[GitHub] eolivelli commented on issue #241: Merge script does not deal well with non-ascii names of reviewers
eolivelli commented on issue #241: Merge script does not deal well with non-ascii names of reviewers URL: https://github.com/apache/bookkeeper/issues/241#issuecomment-315328854 closed by merging #242 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #241: Merge script does not deal well with non-ascii names of reviewers
eolivelli commented on issue #241: Merge script does not deal well with non-ascii names of reviewers URL: https://github.com/apache/bookkeeper/issues/241#issuecomment-315326358 @jiazhai I am sorry the testcase is not usefull, the bug is on reviewers and on on the 'author', I am loking for a good test case This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #241: Merge script does not deal well with non-ascii names of reviewers
eolivelli commented on issue #241: Merge script does not deal well with non-ascii names of reviewers URL: https://github.com/apache/bookkeeper/issues/241#issuecomment-315326061 @jiazhai I am checking your patch. As soon as I am OK I think we can merge without @sijie it is ery trivial This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #241: Merge script does not deal well with non-ascii names of reviewers
eolivelli commented on issue #241: Merge script does not deal well with non-ascii names of reviewers URL: https://github.com/apache/bookkeeper/issues/241#issuecomment-315319819 thank you @jiazhai I think that you can play with #234, that comes from @sigee, without actually pushing it This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
