[GitHub] jiazhai commented on issue #240: ISSUE #239: typo in class name SpeculativeRequestExecutor

2017-07-14 Thread git 
jiazhai commented on issue #240: ISSUE #239: typo in class name 
SpeculativeRequestExecutor
URL: https://github.com/apache/bookkeeper/pull/240#issuecomment-315319050
 
 
   @eolivelli. thanks for the info. @sigee, From my view, your name certainly 
have no error, we will fix the merge script soon.  :)
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jiazhai commented on issue #240: ISSUE #239: typo in class name SpeculativeRequestExecutor

2017-07-13 Thread git 
jiazhai commented on issue #240: ISSUE #239: typo in class name 
SpeculativeRequestExecutor
URL: https://github.com/apache/bookkeeper/pull/240#issuecomment-315026313
 
 
   seems merge script meet this error:
   ```
   (master) python dev/bk-merge-pr.py
   git rev-parse --abbrev-ref HEAD
   Which pull request would you like to merge? (e.g. 34): 240
   Traceback (most recent call last):
 File "dev/bk-merge-pr.py", line 555, in 
   main()
 File "dev/bk-merge-pr.py", line 466, in main
   pr_reviewers = get_reviewers(pr_num)
 File "dev/bk-merge-pr.py", line 450, in get_reviewers
   reviewers_emails.append('{0} <{1}>'.format(username, useremail))
   UnicodeEncodeError: 'ascii' codec can't encode character u'\xe1' in position 
1: ordinal not in range(128)
   ```
   will use merge button, and fix this issue later.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jiazhai commented on issue #240: ISSUE #239: typo in class name SpeculativeRequestExecutor

2017-07-13 Thread git 
jiazhai commented on issue #240: ISSUE #239: typo in class name 
SpeculativeRequestExecutor
URL: https://github.com/apache/bookkeeper/pull/240#issuecomment-315026313
 
 
   seems merge script meet this error:
   ```
   (master) python dev/bk-merge-pr.py
   git rev-parse --abbrev-ref HEAD
   Which pull request would you like to merge? (e.g. 34): 240
   Traceback (most recent call last):
 File "dev/bk-merge-pr.py", line 555, in 
   main()
 File "dev/bk-merge-pr.py", line 466, in main
   pr_reviewers = get_reviewers(pr_num)
 File "dev/bk-merge-pr.py", line 450, in get_reviewers
   reviewers_emails.append('{0} <{1}>'.format(username, useremail))
   UnicodeEncodeError: 'ascii' codec can't encode character u'\xe1' in position 
1: ordinal not in range(128)
   ```
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services