Re: Force to use linux/amd64 to build release
+1 On Mon, Aug 28, 2023 at 9:50 PM Hang Chen wrote: > +1 > > The BookKeeper 4.16.2 is released based on ARM platform and the direct > IO can't be enabled in 4.16.2. > > Best, > Hang > > Enrico Olivelli 于2023年8月28日周一 16:46写道： > > > > +1 > > > > Thanks > > We should cut a new release as soon as possible > > > > Enrico > > > > Il Lun 28 Ago 2023, 10:34 Yong Zhang ha > > scritto: > > > > > Hi everyone, > > > > > > When releasing the 4.16.2, I did the release with an M1 macbook pro. > > > That makes the native io lib compile and publish with the arm platform. > > > So some users get the wrong lib when running the bookie with native io. > > > https://github.com/apache/bookkeeper/issues/4043 > > > > > > And the `NATIVE_IO.posix_fadvise(fd, offset, len, > POSIX_FADV_DONTNEED);` > > > also affected because the lib was built for arm. > > > > > > > https://github.com/apache/bookkeeper/blob/ba3127447630315c97594822b1510ecd509f7671/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/PageCacheUtil.java#L97 > > > > > > I made a change on the release Dockerfile to force the image to use the > > > linux/amd64 platform, we can ensure the lib is compiled on the amd64. > > > https://github.com/apache/bookkeeper/pull/4060 > > > > > > Please help to review that PR. Once it merged, I would like to be a > > > volunteer to > > > release the 4.16.3 to fix the lib. > > > > > > Thanks, > > > Yong > > > >
Re: Force to use linux/amd64 to build release
+1 The BookKeeper 4.16.2 is released based on ARM platform and the direct IO can't be enabled in 4.16.2. Best, Hang Enrico Olivelli 于2023年8月28日周一 16:46写道： > > +1 > > Thanks > We should cut a new release as soon as possible > > Enrico > > Il Lun 28 Ago 2023, 10:34 Yong Zhang ha > scritto: > > > Hi everyone, > > > > When releasing the 4.16.2, I did the release with an M1 macbook pro. > > That makes the native io lib compile and publish with the arm platform. > > So some users get the wrong lib when running the bookie with native io. > > https://github.com/apache/bookkeeper/issues/4043 > > > > And the `NATIVE_IO.posix_fadvise(fd, offset, len, POSIX_FADV_DONTNEED);` > > also affected because the lib was built for arm. > > > > https://github.com/apache/bookkeeper/blob/ba3127447630315c97594822b1510ecd509f7671/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/PageCacheUtil.java#L97 > > > > I made a change on the release Dockerfile to force the image to use the > > linux/amd64 platform, we can ensure the lib is compiled on the amd64. > > https://github.com/apache/bookkeeper/pull/4060 > > > > Please help to review that PR. Once it merged, I would like to be a > > volunteer to > > release the 4.16.3 to fix the lib. > > > > Thanks, > > Yong > >
Re: Force to use linux/amd64 to build release
+1 Thanks We should cut a new release as soon as possible Enrico Il Lun 28 Ago 2023, 10:34 Yong Zhang ha scritto: > Hi everyone, > > When releasing the 4.16.2, I did the release with an M1 macbook pro. > That makes the native io lib compile and publish with the arm platform. > So some users get the wrong lib when running the bookie with native io. > https://github.com/apache/bookkeeper/issues/4043 > > And the `NATIVE_IO.posix_fadvise(fd, offset, len, POSIX_FADV_DONTNEED);` > also affected because the lib was built for arm. > > https://github.com/apache/bookkeeper/blob/ba3127447630315c97594822b1510ecd509f7671/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/PageCacheUtil.java#L97 > > I made a change on the release Dockerfile to force the image to use the > linux/amd64 platform, we can ensure the lib is compiled on the amd64. > https://github.com/apache/bookkeeper/pull/4060 > > Please help to review that PR. Once it merged, I would like to be a > volunteer to > release the 4.16.3 to fix the lib. > > Thanks, > Yong >
Force to use linux/amd64 to build release
Hi everyone, When releasing the 4.16.2, I did the release with an M1 macbook pro. That makes the native io lib compile and publish with the arm platform. So some users get the wrong lib when running the bookie with native io. https://github.com/apache/bookkeeper/issues/4043 And the `NATIVE_IO.posix_fadvise(fd, offset, len, POSIX_FADV_DONTNEED);` also affected because the lib was built for arm. https://github.com/apache/bookkeeper/blob/ba3127447630315c97594822b1510ecd509f7671/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/PageCacheUtil.java#L97 I made a change on the release Dockerfile to force the image to use the linux/amd64 platform, we can ensure the lib is compiled on the amd64. https://github.com/apache/bookkeeper/pull/4060 Please help to review that PR. Once it merged, I would like to be a volunteer to release the 4.16.3 to fix the lib. Thanks, Yong
