Re: [VOTE] Release 4.15.1, release candidate #3
The vote is now closed and the release was approved with 5 +1s(3 binding and 2 non-binding); Binding votes: * Enrico Olivelli * Andrey Yegorov * Jia Zhai Non-Binding votes: * Hang Chen * steven lu Thank you all guys for voting! On Wed, 31 Aug 2022 at 11:56, Yong Zhang wrote: > > We'd better keep the tag name sync with previous one, using > `release-4.15.1` instead of `v4.15.1 > > We will do that in the finalize steps. > FYI > https://bookkeeper.apache.org/community/release-guide#finalize-the-release > > On Wed, 31 Aug 2022 at 11:43, Hang Chen wrote: > >> Hi Yong, thanks for your great work! >> >> +1 (non-binding) >> >> Verified the following list. >> - Verified the license and checksum >> - Build from the source code with JDK17 >> - Run bin/bkperf to check journal writing >> - Integrate with Pulsar branch-2.11 >> - build from the source code with BookKeeper 4.15.1 dependency >> - start a standalone cluster and run pulsar perf produce and consume. >> >> We'd better keep the tag name sync with previous one, using >> `release-4.15.1` instead of `v4.15.1` >> >> Thanks, >> Hang >> >> steven lu 于2022年8月31日周三 11:33写道： >> > >> > +1 (binding) >> > deployed and verified in our own test environment, no problems were >> found >> > >> > thank you ! >> > >> > Yong Zhang 于2022年8月24日周三 10:41写道： >> > >> > > Hi everyone, >> > > Please review and vote on the release candidate #1 for the version >> 4.15.1, >> > > as follows: >> > > [ ] +1, Approve the release >> > > [ ] -1, Do not approve the release (please provide specific comments) >> > > >> > > The complete staging area is available for your review, which >> includes: >> > > * Release notes [1] >> > > * The official Apache source and binary distributions to be deployed >> to >> > > dist.apache.org [2] >> > > * All artifacts to be deployed to the Maven Central Repository [3] >> > > * Source code tag "v4.15.1-rc3" [4] with git sha [5] >> > > >> > > BookKeeper's KEYS file contains PGP keys we used to sign this release: >> > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS >> > > >> > > Please download these packages and review this release candidate: >> > > >> > > - Review release notes >> > > - Download the source package (verify shasum, and asc) and follow the >> > > instructions to build and run the bookkeeper service. >> > > - Download the binary package (verify shasum, and asc) and follow the >> > > instructions to run the bookkeeper service. >> > > - Review maven repo, release tag, licenses, and any other things you >> think >> > > it is important to a release. >> > > >> > > The vote will be open for at least 72 hours. It is adopted by majority >> > > approval, with at least 3 PMC affirmative votes. >> > > >> > > Thanks, >> > > Release Manager >> > > >> > > [1] >> > > >> > > >> https://github.com/apache/bookkeeper/pull/3440/files#diff-d361215d5d5abaa96ac3362e70a1d2f80f92d369a59c866e1976ff41ec435f53 >> > > [2] >> > > >> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.15.1-rc3/ >> > > [3] >> > > >> https://repository.apache.org/content/repositories/orgapachebookkeeper-1072 >> > > [4] https://github.com/apache/bookkeeper/releases/tag/v4.15.1-rc3 >> > > [5] 1f930273aa329c9b04a19f27a11417624bc02954 >> > > >> >
Re: [VOTE] Release 4.15.1, release candidate #3
> We'd better keep the tag name sync with previous one, using `release-4.15.1` instead of `v4.15.1 We will do that in the finalize steps. FYI https://bookkeeper.apache.org/community/release-guide#finalize-the-release On Wed, 31 Aug 2022 at 11:43, Hang Chen wrote: > Hi Yong, thanks for your great work! > > +1 (non-binding) > > Verified the following list. > - Verified the license and checksum > - Build from the source code with JDK17 > - Run bin/bkperf to check journal writing > - Integrate with Pulsar branch-2.11 > - build from the source code with BookKeeper 4.15.1 dependency > - start a standalone cluster and run pulsar perf produce and consume. > > We'd better keep the tag name sync with previous one, using > `release-4.15.1` instead of `v4.15.1` > > Thanks, > Hang > > steven lu 于2022年8月31日周三 11:33写道： > > > > +1 (binding) > > deployed and verified in our own test environment, no problems were found > > > > thank you ! > > > > Yong Zhang 于2022年8月24日周三 10:41写道： > > > > > Hi everyone, > > > Please review and vote on the release candidate #1 for the version > 4.15.1, > > > as follows: > > > [ ] +1, Approve the release > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > The complete staging area is available for your review, which includes: > > > * Release notes [1] > > > * The official Apache source and binary distributions to be deployed to > > > dist.apache.org [2] > > > * All artifacts to be deployed to the Maven Central Repository [3] > > > * Source code tag "v4.15.1-rc3" [4] with git sha [5] > > > > > > BookKeeper's KEYS file contains PGP keys we used to sign this release: > > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > > > Please download these packages and review this release candidate: > > > > > > - Review release notes > > > - Download the source package (verify shasum, and asc) and follow the > > > instructions to build and run the bookkeeper service. > > > - Download the binary package (verify shasum, and asc) and follow the > > > instructions to run the bookkeeper service. > > > - Review maven repo, release tag, licenses, and any other things you > think > > > it is important to a release. > > > > > > The vote will be open for at least 72 hours. It is adopted by majority > > > approval, with at least 3 PMC affirmative votes. > > > > > > Thanks, > > > Release Manager > > > > > > [1] > > > > > > > https://github.com/apache/bookkeeper/pull/3440/files#diff-d361215d5d5abaa96ac3362e70a1d2f80f92d369a59c866e1976ff41ec435f53 > > > [2] > > > > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.15.1-rc3/ > > > [3] > > > > https://repository.apache.org/content/repositories/orgapachebookkeeper-1072 > > > [4] https://github.com/apache/bookkeeper/releases/tag/v4.15.1-rc3 > > > [5] 1f930273aa329c9b04a19f27a11417624bc02954 > > > >
Re: [VOTE] Release 4.15.1, release candidate #3
+1 (binding) - verified packages checksum and signatures, they look good. - the source package build and test all run successfully. - in both binary packages(server & all), 'bin/bookkeeper standalone' and 'bin/bookkeeper shell bookiesanity' runs well. On Wed, Aug 31, 2022 at 11:43 AM Hang Chen wrote: > Hi Yong, thanks for your great work! > > +1 (non-binding) > > Verified the following list. > - Verified the license and checksum > - Build from the source code with JDK17 > - Run bin/bkperf to check journal writing > - Integrate with Pulsar branch-2.11 > - build from the source code with BookKeeper 4.15.1 dependency > - start a standalone cluster and run pulsar perf produce and consume. > > We'd better keep the tag name sync with previous one, using > `release-4.15.1` instead of `v4.15.1` > > Thanks, > Hang > > steven lu 于2022年8月31日周三 11:33写道： > > > > +1 (binding) > > deployed and verified in our own test environment, no problems were found > > > > thank you ! > > > > Yong Zhang 于2022年8月24日周三 10:41写道： > > > > > Hi everyone, > > > Please review and vote on the release candidate #1 for the version > 4.15.1, > > > as follows: > > > [ ] +1, Approve the release > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > The complete staging area is available for your review, which includes: > > > * Release notes [1] > > > * The official Apache source and binary distributions to be deployed to > > > dist.apache.org [2] > > > * All artifacts to be deployed to the Maven Central Repository [3] > > > * Source code tag "v4.15.1-rc3" [4] with git sha [5] > > > > > > BookKeeper's KEYS file contains PGP keys we used to sign this release: > > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > > > Please download these packages and review this release candidate: > > > > > > - Review release notes > > > - Download the source package (verify shasum, and asc) and follow the > > > instructions to build and run the bookkeeper service. > > > - Download the binary package (verify shasum, and asc) and follow the > > > instructions to run the bookkeeper service. > > > - Review maven repo, release tag, licenses, and any other things you > think > > > it is important to a release. > > > > > > The vote will be open for at least 72 hours. It is adopted by majority > > > approval, with at least 3 PMC affirmative votes. > > > > > > Thanks, > > > Release Manager > > > > > > [1] > > > > > > > https://github.com/apache/bookkeeper/pull/3440/files#diff-d361215d5d5abaa96ac3362e70a1d2f80f92d369a59c866e1976ff41ec435f53 > > > [2] > > > > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.15.1-rc3/ > > > [3] > > > > https://repository.apache.org/content/repositories/orgapachebookkeeper-1072 > > > [4] https://github.com/apache/bookkeeper/releases/tag/v4.15.1-rc3 > > > [5] 1f930273aa329c9b04a19f27a11417624bc02954 > > > >
Re: [VOTE] Release 4.15.1, release candidate #3
Hi Yong, thanks for your great work! +1 (non-binding) Verified the following list. - Verified the license and checksum - Build from the source code with JDK17 - Run bin/bkperf to check journal writing - Integrate with Pulsar branch-2.11 - build from the source code with BookKeeper 4.15.1 dependency - start a standalone cluster and run pulsar perf produce and consume. We'd better keep the tag name sync with previous one, using `release-4.15.1` instead of `v4.15.1` Thanks, Hang steven lu 于2022年8月31日周三 11:33写道： > > +1 (binding) > deployed and verified in our own test environment, no problems were found > > thank you ! > > Yong Zhang 于2022年8月24日周三 10:41写道： > > > Hi everyone, > > Please review and vote on the release candidate #1 for the version 4.15.1, > > as follows: > > [ ] +1, Approve the release > > [ ] -1, Do not approve the release (please provide specific comments) > > > > The complete staging area is available for your review, which includes: > > * Release notes [1] > > * The official Apache source and binary distributions to be deployed to > > dist.apache.org [2] > > * All artifacts to be deployed to the Maven Central Repository [3] > > * Source code tag "v4.15.1-rc3" [4] with git sha [5] > > > > BookKeeper's KEYS file contains PGP keys we used to sign this release: > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > Please download these packages and review this release candidate: > > > > - Review release notes > > - Download the source package (verify shasum, and asc) and follow the > > instructions to build and run the bookkeeper service. > > - Download the binary package (verify shasum, and asc) and follow the > > instructions to run the bookkeeper service. > > - Review maven repo, release tag, licenses, and any other things you think > > it is important to a release. > > > > The vote will be open for at least 72 hours. It is adopted by majority > > approval, with at least 3 PMC affirmative votes. > > > > Thanks, > > Release Manager > > > > [1] > > > > https://github.com/apache/bookkeeper/pull/3440/files#diff-d361215d5d5abaa96ac3362e70a1d2f80f92d369a59c866e1976ff41ec435f53 > > [2] > > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.15.1-rc3/ > > [3] > > https://repository.apache.org/content/repositories/orgapachebookkeeper-1072 > > [4] https://github.com/apache/bookkeeper/releases/tag/v4.15.1-rc3 > > [5] 1f930273aa329c9b04a19f27a11417624bc02954 > >
Re: [VOTE] Release 4.15.1, release candidate #3
+1 (binding) deployed and verified in our own test environment, no problems were found thank you ! Yong Zhang 于2022年8月24日周三 10:41写道： > Hi everyone, > Please review and vote on the release candidate #1 for the version 4.15.1, > as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide specific comments) > > The complete staging area is available for your review, which includes: > * Release notes [1] > * The official Apache source and binary distributions to be deployed to > dist.apache.org [2] > * All artifacts to be deployed to the Maven Central Repository [3] > * Source code tag "v4.15.1-rc3" [4] with git sha [5] > > BookKeeper's KEYS file contains PGP keys we used to sign this release: > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > Please download these packages and review this release candidate: > > - Review release notes > - Download the source package (verify shasum, and asc) and follow the > instructions to build and run the bookkeeper service. > - Download the binary package (verify shasum, and asc) and follow the > instructions to run the bookkeeper service. > - Review maven repo, release tag, licenses, and any other things you think > it is important to a release. > > The vote will be open for at least 72 hours. It is adopted by majority > approval, with at least 3 PMC affirmative votes. > > Thanks, > Release Manager > > [1] > > https://github.com/apache/bookkeeper/pull/3440/files#diff-d361215d5d5abaa96ac3362e70a1d2f80f92d369a59c866e1976ff41ec435f53 > [2] > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.15.1-rc3/ > [3] > https://repository.apache.org/content/repositories/orgapachebookkeeper-1072 > [4] https://github.com/apache/bookkeeper/releases/tag/v4.15.1-rc3 > [5] 1f930273aa329c9b04a19f27a11417624bc02954 >
Re: [VOTE] Release 4.15.1, release candidate #3
Thank you for voting! --- > Why are there no such fixes for cherry pick indexDirs, so there will be problems when indexDirs are specified independently. For the function fixes of indexDirs, please refer to https://github.com/apache/bookkeeper/issues/3419 Look like that is a new feature and we don't cherry-pick features into a patch release usually. It will be released with 4.16.0. Thanks Yong On Wed, 31 Aug 2022 at 10:28, steven lu wrote: > hello,Yang Yong > Why are there no such fixes for cherry pick indexDirs, so there will be > problems when indexDirs are specified independently. For the function fixes > of indexDirs, please refer to > https://github.com/apache/bookkeeper/issues/3419 > > Yong Zhang 于2022年8月24日周三 10:41写道： > > > Hi everyone, > > Please review and vote on the release candidate #1 for the version > 4.15.1, > > as follows: > > [ ] +1, Approve the release > > [ ] -1, Do not approve the release (please provide specific comments) > > > > The complete staging area is available for your review, which includes: > > * Release notes [1] > > * The official Apache source and binary distributions to be deployed to > > dist.apache.org [2] > > * All artifacts to be deployed to the Maven Central Repository [3] > > * Source code tag "v4.15.1-rc3" [4] with git sha [5] > > > > BookKeeper's KEYS file contains PGP keys we used to sign this release: > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > Please download these packages and review this release candidate: > > > > - Review release notes > > - Download the source package (verify shasum, and asc) and follow the > > instructions to build and run the bookkeeper service. > > - Download the binary package (verify shasum, and asc) and follow the > > instructions to run the bookkeeper service. > > - Review maven repo, release tag, licenses, and any other things you > think > > it is important to a release. > > > > The vote will be open for at least 72 hours. It is adopted by majority > > approval, with at least 3 PMC affirmative votes. > > > > Thanks, > > Release Manager > > > > [1] > > > > > https://github.com/apache/bookkeeper/pull/3440/files#diff-d361215d5d5abaa96ac3362e70a1d2f80f92d369a59c866e1976ff41ec435f53 > > [2] > > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.15.1-rc3/ > > [3] > > > https://repository.apache.org/content/repositories/orgapachebookkeeper-1072 > > [4] https://github.com/apache/bookkeeper/releases/tag/v4.15.1-rc3 > > [5] 1f930273aa329c9b04a19f27a11417624bc02954 > > >
Re: [VOTE] Release 4.15.1, release candidate #3
hello,Yang Yong Why are there no such fixes for cherry pick indexDirs, so there will be problems when indexDirs are specified independently. For the function fixes of indexDirs, please refer to https://github.com/apache/bookkeeper/issues/3419 Yong Zhang 于2022年8月24日周三 10:41写道： > Hi everyone, > Please review and vote on the release candidate #1 for the version 4.15.1, > as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide specific comments) > > The complete staging area is available for your review, which includes: > * Release notes [1] > * The official Apache source and binary distributions to be deployed to > dist.apache.org [2] > * All artifacts to be deployed to the Maven Central Repository [3] > * Source code tag "v4.15.1-rc3" [4] with git sha [5] > > BookKeeper's KEYS file contains PGP keys we used to sign this release: > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > Please download these packages and review this release candidate: > > - Review release notes > - Download the source package (verify shasum, and asc) and follow the > instructions to build and run the bookkeeper service. > - Download the binary package (verify shasum, and asc) and follow the > instructions to run the bookkeeper service. > - Review maven repo, release tag, licenses, and any other things you think > it is important to a release. > > The vote will be open for at least 72 hours. It is adopted by majority > approval, with at least 3 PMC affirmative votes. > > Thanks, > Release Manager > > [1] > > https://github.com/apache/bookkeeper/pull/3440/files#diff-d361215d5d5abaa96ac3362e70a1d2f80f92d369a59c866e1976ff41ec435f53 > [2] > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.15.1-rc3/ > [3] > https://repository.apache.org/content/repositories/orgapachebookkeeper-1072 > [4] https://github.com/apache/bookkeeper/releases/tag/v4.15.1-rc3 > [5] 1f930273aa329c9b04a19f27a11417624bc02954 >
Re: [VOTE] Release 4.15.1, release candidate #3
+1 (binding) Smoke test with localbookie passed. Build from packaged sources succeeds, some test failed but they look like known flakes on CI I left a couple of comments on the release notes, the rest looks good. Thank you! On Mon, Aug 29, 2022 at 7:33 AM Enrico Olivelli wrote: > +1 (binding) > All tests passed > Smoke tests with localbookie passed > GPG signatures are good > > thank you ! > > Enrico > > Il giorno sab 27 ago 2022 alle ore 07:31 steven lu > ha scritto: > > > > Great work! > > I’m verifying this > > > > Yong Zhang 于2022年8月24日周三 10:41写道： > > > > > Hi everyone, > > > Please review and vote on the release candidate #1 for the version > 4.15.1, > > > as follows: > > > [ ] +1, Approve the release > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > The complete staging area is available for your review, which includes: > > > * Release notes [1] > > > * The official Apache source and binary distributions to be deployed to > > > dist.apache.org [2] > > > * All artifacts to be deployed to the Maven Central Repository [3] > > > * Source code tag "v4.15.1-rc3" [4] with git sha [5] > > > > > > BookKeeper's KEYS file contains PGP keys we used to sign this release: > > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > > > Please download these packages and review this release candidate: > > > > > > - Review release notes > > > - Download the source package (verify shasum, and asc) and follow the > > > instructions to build and run the bookkeeper service. > > > - Download the binary package (verify shasum, and asc) and follow the > > > instructions to run the bookkeeper service. > > > - Review maven repo, release tag, licenses, and any other things you > think > > > it is important to a release. > > > > > > The vote will be open for at least 72 hours. It is adopted by majority > > > approval, with at least 3 PMC affirmative votes. > > > > > > Thanks, > > > Release Manager > > > > > > [1] > > > > > > > https://github.com/apache/bookkeeper/pull/3440/files#diff-d361215d5d5abaa96ac3362e70a1d2f80f92d369a59c866e1976ff41ec435f53 > > > [2] > > > > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.15.1-rc3/ > > > [3] > > > > https://repository.apache.org/content/repositories/orgapachebookkeeper-1072 > > > [4] https://github.com/apache/bookkeeper/releases/tag/v4.15.1-rc3 > > > [5] 1f930273aa329c9b04a19f27a11417624bc02954 > > > > -- Andrey Yegorov
Re: [VOTE] Release 4.15.1, release candidate #3
+1 (binding) All tests passed Smoke tests with localbookie passed GPG signatures are good thank you ! Enrico Il giorno sab 27 ago 2022 alle ore 07:31 steven lu ha scritto: > > Great work! > I’m verifying this > > Yong Zhang 于2022年8月24日周三 10:41写道： > > > Hi everyone, > > Please review and vote on the release candidate #1 for the version 4.15.1, > > as follows: > > [ ] +1, Approve the release > > [ ] -1, Do not approve the release (please provide specific comments) > > > > The complete staging area is available for your review, which includes: > > * Release notes [1] > > * The official Apache source and binary distributions to be deployed to > > dist.apache.org [2] > > * All artifacts to be deployed to the Maven Central Repository [3] > > * Source code tag "v4.15.1-rc3" [4] with git sha [5] > > > > BookKeeper's KEYS file contains PGP keys we used to sign this release: > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > Please download these packages and review this release candidate: > > > > - Review release notes > > - Download the source package (verify shasum, and asc) and follow the > > instructions to build and run the bookkeeper service. > > - Download the binary package (verify shasum, and asc) and follow the > > instructions to run the bookkeeper service. > > - Review maven repo, release tag, licenses, and any other things you think > > it is important to a release. > > > > The vote will be open for at least 72 hours. It is adopted by majority > > approval, with at least 3 PMC affirmative votes. > > > > Thanks, > > Release Manager > > > > [1] > > > > https://github.com/apache/bookkeeper/pull/3440/files#diff-d361215d5d5abaa96ac3362e70a1d2f80f92d369a59c866e1976ff41ec435f53 > > [2] > > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.15.1-rc3/ > > [3] > > https://repository.apache.org/content/repositories/orgapachebookkeeper-1072 > > [4] https://github.com/apache/bookkeeper/releases/tag/v4.15.1-rc3 > > [5] 1f930273aa329c9b04a19f27a11417624bc02954 > >
Re: [VOTE] Release 4.15.1, release candidate #3
Great work! I’m verifying this Yong Zhang 于2022年8月24日周三 10:41写道： > Hi everyone, > Please review and vote on the release candidate #1 for the version 4.15.1, > as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide specific comments) > > The complete staging area is available for your review, which includes: > * Release notes [1] > * The official Apache source and binary distributions to be deployed to > dist.apache.org [2] > * All artifacts to be deployed to the Maven Central Repository [3] > * Source code tag "v4.15.1-rc3" [4] with git sha [5] > > BookKeeper's KEYS file contains PGP keys we used to sign this release: > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > Please download these packages and review this release candidate: > > - Review release notes > - Download the source package (verify shasum, and asc) and follow the > instructions to build and run the bookkeeper service. > - Download the binary package (verify shasum, and asc) and follow the > instructions to run the bookkeeper service. > - Review maven repo, release tag, licenses, and any other things you think > it is important to a release. > > The vote will be open for at least 72 hours. It is adopted by majority > approval, with at least 3 PMC affirmative votes. > > Thanks, > Release Manager > > [1] > > https://github.com/apache/bookkeeper/pull/3440/files#diff-d361215d5d5abaa96ac3362e70a1d2f80f92d369a59c866e1976ff41ec435f53 > [2] > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.15.1-rc3/ > [3] > https://repository.apache.org/content/repositories/orgapachebookkeeper-1072 > [4] https://github.com/apache/bookkeeper/releases/tag/v4.15.1-rc3 > [5] 1f930273aa329c9b04a19f27a11417624bc02954 >
