Re: BP-54: Repaired the ledger fragment which ensemble not adhere placement policy.

2022-08-03 Thread steven lu 
I re-read the code again, look good to me
At the same time, please Enrico review the code, thank you

Yan Zhao  于2022年8月2日周二 13:30写道：

> Could you describe detail.
>
> On 2022/08/01 17:00:47 steven lu wrote:
> > I feel that the code is not the same as the discussion:
> > https://github.com/apache/bookkeeper/pull/3359
>

Re: BP-54: Repaired the ledger fragment which ensemble not adhere placement policy.

2022-08-01 Thread Yan Zhao 
Could you describe detail.

On 2022/08/01 17:00:47 steven lu wrote:
> I feel that the code is not the same as the discussion:
> https://github.com/apache/bookkeeper/pull/3359

Re: BP-54: Repaired the ledger fragment which ensemble not adhere placement policy.

2022-08-01 Thread steven lu 
I feel that the code is not the same as the discussion:
https://github.com/apache/bookkeeper/pull/3359

Enrico Olivelli  于2022年7月31日周日 01:55写道：

> Il Ven 29 Lug 2022, 19:24 Yan Zhao  ha scritto:
>
> > You means we define api in EnsemblePlacementPolicy, and use SPI to load
> > special implementation?
> >
>
> This is already configurable.
>
> You are going to add a new method. This new method must be described in the
> BP
>
> Enrico
>
>
> > On 2022/07/29 15:10:05 Enrico Olivelli wrote:
> > > I support this feature.
> > >
> > > We should design the changes to the APIs.
> > > We need to change EnsemblePlacementPolicy, that is a pluggable API:
> > > users can provide. their own implementation
> >
>

Re: BP-54: Repaired the ledger fragment which ensemble not adhere placement policy.

2022-07-30 Thread Enrico Olivelli 
Il Ven 29 Lug 2022, 19:24 Yan Zhao  ha scritto:

> You means we define api in EnsemblePlacementPolicy, and use SPI to load
> special implementation?
>

This is already configurable.

You are going to add a new method. This new method must be described in the
BP

Enrico


> On 2022/07/29 15:10:05 Enrico Olivelli wrote:
> > I support this feature.
> >
> > We should design the changes to the APIs.
> > We need to change EnsemblePlacementPolicy, that is a pluggable API:
> > users can provide. their own implementation
>

Re: BP-54: Repaired the ledger fragment which ensemble not adhere placement policy.

2022-07-29 Thread Yan Zhao 
You means we define api in EnsemblePlacementPolicy, and use SPI to load special 
implementation?
 
On 2022/07/29 15:10:05 Enrico Olivelli wrote:
> I support this feature.
> 
> We should design the changes to the APIs.
> We need to change EnsemblePlacementPolicy, that is a pluggable API:
> users can provide. their own implementation

Re: BP-54: Repaired the ledger fragment which ensemble not adhere placement policy.

2022-07-29 Thread Enrico Olivelli 
I support this feature.

We should design the changes to the APIs.
We need to change EnsemblePlacementPolicy, that is a pluggable API:
users can provide. their own implementation

please add the design decisions you want to make


Thanks

Enrico


Il giorno ven 29 lug 2022 alle ore 15:31 Yan Zhao
 ha scritto:
>
> @Enrico

Re: BP-54: Repaired the ledger fragment which ensemble not adhere placement policy.

2022-07-29 Thread Yan Zhao 
@Enrico