Re: Last issues before cutting 4.10

[Jia Zhai]

Thanks Enrico,
It is all clean now.

Best Regards.


Jia Zhai

Beijing, China

Mobile: +86 15810491983




On Tue, Oct 29, 2019 at 10:43 PM Enrico Olivelli 
wrote:

> Thank you Jia,
> so we have only 1 pending issue targeted 4.10
> https://github.com/apache/bookkeeper/pull/2116 minorCompactionInterval
> should be greater than gcWaitTime
>
> we are waiting for CI
>
> I would like to cut the release branch as soon as we merge that change
>
> Enrico
>
> Il giorno mar 29 ott 2019 alle ore 14:53 Jia Zhai  ha
> scritto:
>
> > Hi,
> > Thanks for taking care of it. I have merged some of 4.10 PRs,
> > And also move some features tasks into 4.11.  If there were any mistaken,
> > please help correct them:
> https://github.com/apache/bookkeeper/milestone/7.
> >
> > Best Regards.
> >
> >
> > Jia Zhai
> >
> > Beijing, China
> >
> > Mobile: +86 15810491983
> >
> >
> >
> >
> > On Sun, Oct 27, 2019 at 6:21 AM Enrico Olivelli 
> > wrote:
> >
> > > Hi,
> > > we still have a lot of issues on 4.10
> > > https://github.com/apache/bookkeeper/milestone/6
> > >
> > > Can you please help me cleaning up ?
> > >
> > > It looks that we have to blocker for cutting a release
> > >
> > > Enrico
> > >
> > > Il giorno gio 17 ott 2019 alle ore 11:43 Enrico Olivelli <
> > > eolive...@gmail.com> ha scritto:
> > >
> > > > I was busy and as you noticed I did not have time to prepare the rc.
> > > > I will do it as soon as possible
> > > >
> > > >
> > > > Enrico
> > > >
> > > > Il ven 11 ott 2019, 16:24 Enrico Olivelli  ha
> > > > scritto:
> > > >
> > > >> Hi all,
> > > >> all is ready from my point of view.
> > > >> I will cut the release candidate during this weekend.
> > > >>
> > > >> Please chime in in case you see blocker issues on the release as
> soon
> > as
> > > >> possible
> > > >>
> > > >> Regards
> > > >> Enrico
> > > >>
> > > >> Il giorno lun 7 ott 2019 alle ore 07:24 Karan Mehta
> > > >>  ha scritto:
> > > >>
> > > >>> There you go, Enrico,
> https://github.com/apache/bookkeeper/pull/2175
> > > >>>
> > > >>> I am unable to add any reviewers unfortunately. Please review.
> > > >>>
> > > >>
> > >
> >
>

Re: Last issues before cutting 4.10

[Enrico Olivelli]

Thank you Jia,
so we have only 1 pending issue targeted 4.10
https://github.com/apache/bookkeeper/pull/2116 minorCompactionInterval
should be greater than gcWaitTime

we are waiting for CI

I would like to cut the release branch as soon as we merge that change

Enrico

Il giorno mar 29 ott 2019 alle ore 14:53 Jia Zhai  ha
scritto:

> Hi,
> Thanks for taking care of it. I have merged some of 4.10 PRs,
> And also move some features tasks into 4.11.  If there were any mistaken,
> please help correct them:https://github.com/apache/bookkeeper/milestone/7.
>
> Best Regards.
>
>
> Jia Zhai
>
> Beijing, China
>
> Mobile: +86 15810491983
>
>
>
>
> On Sun, Oct 27, 2019 at 6:21 AM Enrico Olivelli 
> wrote:
>
> > Hi,
> > we still have a lot of issues on 4.10
> > https://github.com/apache/bookkeeper/milestone/6
> >
> > Can you please help me cleaning up ?
> >
> > It looks that we have to blocker for cutting a release
> >
> > Enrico
> >
> > Il giorno gio 17 ott 2019 alle ore 11:43 Enrico Olivelli <
> > eolive...@gmail.com> ha scritto:
> >
> > > I was busy and as you noticed I did not have time to prepare the rc.
> > > I will do it as soon as possible
> > >
> > >
> > > Enrico
> > >
> > > Il ven 11 ott 2019, 16:24 Enrico Olivelli  ha
> > > scritto:
> > >
> > >> Hi all,
> > >> all is ready from my point of view.
> > >> I will cut the release candidate during this weekend.
> > >>
> > >> Please chime in in case you see blocker issues on the release as soon
> as
> > >> possible
> > >>
> > >> Regards
> > >> Enrico
> > >>
> > >> Il giorno lun 7 ott 2019 alle ore 07:24 Karan Mehta
> > >>  ha scritto:
> > >>
> > >>> There you go, Enrico, https://github.com/apache/bookkeeper/pull/2175
> > >>>
> > >>> I am unable to add any reviewers unfortunately. Please review.
> > >>>
> > >>
> >
>

Re: Last issues before cutting 4.10

[Jia Zhai]

Hi,
Thanks for taking care of it. I have merged some of 4.10 PRs,
And also move some features tasks into 4.11.  If there were any mistaken,
please help correct them:https://github.com/apache/bookkeeper/milestone/7.

Best Regards.


Jia Zhai

Beijing, China

Mobile: +86 15810491983




On Sun, Oct 27, 2019 at 6:21 AM Enrico Olivelli  wrote:

> Hi,
> we still have a lot of issues on 4.10
> https://github.com/apache/bookkeeper/milestone/6
>
> Can you please help me cleaning up ?
>
> It looks that we have to blocker for cutting a release
>
> Enrico
>
> Il giorno gio 17 ott 2019 alle ore 11:43 Enrico Olivelli <
> eolive...@gmail.com> ha scritto:
>
> > I was busy and as you noticed I did not have time to prepare the rc.
> > I will do it as soon as possible
> >
> >
> > Enrico
> >
> > Il ven 11 ott 2019, 16:24 Enrico Olivelli  ha
> > scritto:
> >
> >> Hi all,
> >> all is ready from my point of view.
> >> I will cut the release candidate during this weekend.
> >>
> >> Please chime in in case you see blocker issues on the release as soon as
> >> possible
> >>
> >> Regards
> >> Enrico
> >>
> >> Il giorno lun 7 ott 2019 alle ore 07:24 Karan Mehta
> >>  ha scritto:
> >>
> >>> There you go, Enrico, https://github.com/apache/bookkeeper/pull/2175
> >>>
> >>> I am unable to add any reviewers unfortunately. Please review.
> >>>
> >>
>

Re: Last issues before cutting 4.10

[Enrico Olivelli]

Hi,
we still have a lot of issues on 4.10
https://github.com/apache/bookkeeper/milestone/6

Can you please help me cleaning up ?

It looks that we have to blocker for cutting a release

Enrico

Il giorno gio 17 ott 2019 alle ore 11:43 Enrico Olivelli <
eolive...@gmail.com> ha scritto:

> I was busy and as you noticed I did not have time to prepare the rc.
> I will do it as soon as possible
>
>
> Enrico
>
> Il ven 11 ott 2019, 16:24 Enrico Olivelli  ha
> scritto:
>
>> Hi all,
>> all is ready from my point of view.
>> I will cut the release candidate during this weekend.
>>
>> Please chime in in case you see blocker issues on the release as soon as
>> possible
>>
>> Regards
>> Enrico
>>
>> Il giorno lun 7 ott 2019 alle ore 07:24 Karan Mehta
>>  ha scritto:
>>
>>> There you go, Enrico, https://github.com/apache/bookkeeper/pull/2175
>>>
>>> I am unable to add any reviewers unfortunately. Please review.
>>>
>>

Re: Last issues before cutting 4.10

[Enrico Olivelli]

I was busy and as you noticed I did not have time to prepare the rc.
I will do it as soon as possible


Enrico

Il ven 11 ott 2019, 16:24 Enrico Olivelli  ha scritto:

> Hi all,
> all is ready from my point of view.
> I will cut the release candidate during this weekend.
>
> Please chime in in case you see blocker issues on the release as soon as
> possible
>
> Regards
> Enrico
>
> Il giorno lun 7 ott 2019 alle ore 07:24 Karan Mehta
>  ha scritto:
>
>> There you go, Enrico, https://github.com/apache/bookkeeper/pull/2175
>>
>> I am unable to add any reviewers unfortunately. Please review.
>>
>

Re: Last issues before cutting 4.10

[Enrico Olivelli]

Hi all,
all is ready from my point of view.
I will cut the release candidate during this weekend.

Please chime in in case you see blocker issues on the release as soon as
possible

Regards
Enrico

Il giorno lun 7 ott 2019 alle ore 07:24 Karan Mehta
 ha scritto:

> There you go, Enrico, https://github.com/apache/bookkeeper/pull/2175
>
> I am unable to add any reviewers unfortunately. Please review.
>

Re: Last issues before cutting 4.10

[Karan Mehta]

There you go, Enrico, https://github.com/apache/bookkeeper/pull/2175

I am unable to add any reviewers unfortunately. Please review.

Re: Last issues before cutting 4.10

[Enrico Olivelli]

Il sab 5 ott 2019, 03:22 Karan Mehta  ha
scritto:

> @Enrico, Happy to take that up. Where do we do that?
>
> 1. Inside the code, before every public addEntry method
>

Here

> 2. Your release notes PR
>
I will take care of this part

> 3. Anything else?
>

No

Thanks
Enrico

>
> On Thu, Oct 3, 2019 at 10:36 PM Enrico Olivelli 
> wrote:
>
> > Il gio 3 ott 2019, 23:52 Karan Mehta  ha
> > scritto:
> >
> > > I see that you concluded on this issue
> > >  with comment here
> > > <
> https://github.com/apache/bookkeeper/issues/2138#issuecomment-522099668
> > >,
> > > however have we actually added any Javadoc for it?
> > >
> >
> > Good catch Karan
> >
> >
> > Can you please send a PR?
> >
> >
> > Enrico
> >
> > >
> > >
> > > On Wed, Oct 2, 2019 at 1:09 AM Enrico Olivelli 
> > > wrote:
> > >
> > > > Hi,
> > > > I see there is only one pending PR worth to commit before cutting
> 4.10
> > > >
> > > > It is from Charan
> > > > https://github.com/apache/bookkeeper/pull/2166
> > > >
> > > > I have already approved it, but I feel we need another eye on it.
> > > >
> > > > Just to make it clear, we have some old version of Netty and
> ZooKeeper
> > on
> > > > current master, and there are pending CVEs over those libraries.
> > > >
> > > > We are close to the release, and some time ago, on Slack, Sijie and I
> > > told
> > > > that is it better to upgrade libraries only after starting the cycle
> > for
> > > > 4.11.
> > > > I prefer to not upgrade those libraries now, and leave the change to
> > the
> > > > next release.
> > > >
> > > > On my products/projects I am already using latest and greatest Netty
> > and
> > > > ZooKeeper (and on JDK11,12,13) without issues.
> > > >
> > > >
> > > > Best regards
> > > > Enrico
> > > >
> > >
> > >
> > > --
> > > Karan Mehta
> > >
> > > 
> > >
> >
>
>
> --
> Karan Mehta
>
> 
>

Re: Last issues before cutting 4.10

[Karan Mehta]

@Enrico, Happy to take that up. Where do we do that?

1. Inside the code, before every public addEntry method
2. Your release notes PR
3. Anything else?

On Thu, Oct 3, 2019 at 10:36 PM Enrico Olivelli  wrote:

> Il gio 3 ott 2019, 23:52 Karan Mehta  ha
> scritto:
>
> > I see that you concluded on this issue
> >  with comment here
> >  >,
> > however have we actually added any Javadoc for it?
> >
>
> Good catch Karan
>
>
> Can you please send a PR?
>
>
> Enrico
>
> >
> >
> > On Wed, Oct 2, 2019 at 1:09 AM Enrico Olivelli 
> > wrote:
> >
> > > Hi,
> > > I see there is only one pending PR worth to commit before cutting 4.10
> > >
> > > It is from Charan
> > > https://github.com/apache/bookkeeper/pull/2166
> > >
> > > I have already approved it, but I feel we need another eye on it.
> > >
> > > Just to make it clear, we have some old version of Netty and ZooKeeper
> on
> > > current master, and there are pending CVEs over those libraries.
> > >
> > > We are close to the release, and some time ago, on Slack, Sijie and I
> > told
> > > that is it better to upgrade libraries only after starting the cycle
> for
> > > 4.11.
> > > I prefer to not upgrade those libraries now, and leave the change to
> the
> > > next release.
> > >
> > > On my products/projects I am already using latest and greatest Netty
> and
> > > ZooKeeper (and on JDK11,12,13) without issues.
> > >
> > >
> > > Best regards
> > > Enrico
> > >
> >
> >
> > --
> > Karan Mehta
> >
> > 
> >
>


-- 
Karan Mehta

Re: Last issues before cutting 4.10

[Enrico Olivelli]

Il gio 3 ott 2019, 23:52 Karan Mehta  ha
scritto:

> I see that you concluded on this issue
>  with comment here
> ,
> however have we actually added any Javadoc for it?
>

Good catch Karan


Can you please send a PR?


Enrico

>
>
> On Wed, Oct 2, 2019 at 1:09 AM Enrico Olivelli 
> wrote:
>
> > Hi,
> > I see there is only one pending PR worth to commit before cutting 4.10
> >
> > It is from Charan
> > https://github.com/apache/bookkeeper/pull/2166
> >
> > I have already approved it, but I feel we need another eye on it.
> >
> > Just to make it clear, we have some old version of Netty and ZooKeeper on
> > current master, and there are pending CVEs over those libraries.
> >
> > We are close to the release, and some time ago, on Slack, Sijie and I
> told
> > that is it better to upgrade libraries only after starting the cycle for
> > 4.11.
> > I prefer to not upgrade those libraries now, and leave the change to the
> > next release.
> >
> > On my products/projects I am already using latest and greatest Netty and
> > ZooKeeper (and on JDK11,12,13) without issues.
> >
> >
> > Best regards
> > Enrico
> >
>
>
> --
> Karan Mehta
>
> 
>

Re: Last issues before cutting 4.10

[Karan Mehta]

I see that you concluded on this issue
 with comment here
,
however have we actually added any Javadoc for it?


On Wed, Oct 2, 2019 at 1:09 AM Enrico Olivelli  wrote:

> Hi,
> I see there is only one pending PR worth to commit before cutting 4.10
>
> It is from Charan
> https://github.com/apache/bookkeeper/pull/2166
>
> I have already approved it, but I feel we need another eye on it.
>
> Just to make it clear, we have some old version of Netty and ZooKeeper on
> current master, and there are pending CVEs over those libraries.
>
> We are close to the release, and some time ago, on Slack, Sijie and I told
> that is it better to upgrade libraries only after starting the cycle for
> 4.11.
> I prefer to not upgrade those libraries now, and leave the change to the
> next release.
>
> On my products/projects I am already using latest and greatest Netty and
> ZooKeeper (and on JDK11,12,13) without issues.
>
>
> Best regards
> Enrico
>


-- 
Karan Mehta