Re: brooklyn br cli + go lang required for build

[Aled Sage]

Hi Aleksandr,

It's in the root's pom.xml: if you use -Dno-go-client then it disables 
the profile that adds the brooklyn-client module to those being built by 
maven.





go-client


!no-go-client



brooklyn-client



Aled


On 11/03/2016 03:09, Aleksandr Vasilev wrote:

Hi Alex,

I'm interested in the implementation details of "-Dno-go-client" option as
I'd like to implement the same thing for RPM packaging as per your advice.
I searched through Brooklyn uber project but only found readme articles and
links to golang website.

Best Regards,

Aleksandr Vasilev
DevOps Engineer | Cloudsoft Corporation

On 10 March 2016 at 05:10, Alex Heneveld 
wrote:


This is to announce that the Brooklyn Client Command Line Interface tool

has been

added to the Apache Brooklyn "brooklyn-client" repository [1].

This is excellent!  Great work Robert, Geoff, and David.

I've already switched to using the CLI for many things, from deploying to
looking up details.  The fun will really start when we're embedding this in
scripts and using `jq` on the output.

You may have seen lots of commits across projects just now:  the CLI is
now built and bundled as part of the dist.  This means you need Go 1.6
installed.  Or you can use `-Dno-go-client` if building in the uber.  (See
the README at [1].)

Now we just need to release 0.9.0.

Best
Alex

[1]  https://github.com/apache/brooklyn


On 09/03/2016 12:35, Geoff Macartney wrote:


This is to announce that the Brooklyn Client Command Line Interface tool
has been added to the Apache Brooklyn "brooklyn-client" repository [1].

This is a lightweight, standalone command line client for Apache
Brooklyn, written in Go.  The intention is to provide the same control over
Brooklyn that until now has only been possible via the graphical UI, but at
the command line. So not only can Brooklyn now be used without requiring a
web browser, but it also allows power users and devops teams to automate
Brooklyn with shell scripts.

The tool name is "br".  Just to give a couple of quick examples, you
could deploy a blueprint with

$ br deploy webapp.yaml

You can then check the progress of the installation by querying the
application you just deployed:

$ br application WebCluster
Id:  lmOcZbsT
Name:WebCluster
Status:  RUNNING
ServiceUp:   true
... etc.

(or just "br app").

The tool also lets you examine the status of individual entities in the
application, check sensor values and policy configuration, examine the
activity history, and even invoke effectors.

The documentation for Brooklyn will be updated with guides for the CLI,
and you can already read the current snapshot documentation [2].

It is worth noting that the tool is still under development, and, while
it has broad coverage of Brooklyn functionality at present, there are still
things to do.

If you are interested in seeing a demo of the CLI in action, you might
want to look at a blog post I wrote recently [3].  This is actually on a
different topic (Brooklyn Salt integration) but does show the CLI in action.

Thanks to Cloudsoft for contributing this to Apache Brooklyn.

Regards
Geoff Macartney

[1] https://github.com/apache/brooklyn-client
[2] https://brooklyn.apache.org/v/0.9.0-SNAPSHOT/ops/cli/index.html
[3]
http://www.cloudsoftcorp.com/blog/2016/03/salt-support-in-apache-brooklyn/


Gnu PGP key - http://is.gd/uI

Re: brooklyn br cli + go lang required for build

[Aleksandr Vasilev]

Hi Alex,

I'm interested in the implementation details of "-Dno-go-client" option as
I'd like to implement the same thing for RPM packaging as per your advice.
I searched through Brooklyn uber project but only found readme articles and
links to golang website.

Best Regards,

Aleksandr Vasilev
DevOps Engineer | Cloudsoft Corporation

On 10 March 2016 at 05:10, Alex Heneveld 
wrote:

>
> > This is to announce that the Brooklyn Client Command Line Interface tool
> has been
> > added to the Apache Brooklyn "brooklyn-client" repository [1].
>
> This is excellent!  Great work Robert, Geoff, and David.
>
> I've already switched to using the CLI for many things, from deploying to
> looking up details.  The fun will really start when we're embedding this in
> scripts and using `jq` on the output.
>
> You may have seen lots of commits across projects just now:  the CLI is
> now built and bundled as part of the dist.  This means you need Go 1.6
> installed.  Or you can use `-Dno-go-client` if building in the uber.  (See
> the README at [1].)
>
> Now we just need to release 0.9.0.
>
> Best
> Alex
>
> [1]  https://github.com/apache/brooklyn
>
>
> On 09/03/2016 12:35, Geoff Macartney wrote:
>
>> This is to announce that the Brooklyn Client Command Line Interface tool
>> has been added to the Apache Brooklyn "brooklyn-client" repository [1].
>>
>> This is a lightweight, standalone command line client for Apache
>> Brooklyn, written in Go.  The intention is to provide the same control over
>> Brooklyn that until now has only been possible via the graphical UI, but at
>> the command line. So not only can Brooklyn now be used without requiring a
>> web browser, but it also allows power users and devops teams to automate
>> Brooklyn with shell scripts.
>>
>> The tool name is "br".  Just to give a couple of quick examples, you
>> could deploy a blueprint with
>>
>> $ br deploy webapp.yaml
>>
>> You can then check the progress of the installation by querying the
>> application you just deployed:
>>
>> $ br application WebCluster
>> Id:  lmOcZbsT
>> Name:WebCluster
>> Status:  RUNNING
>> ServiceUp:   true
>> ... etc.
>>
>> (or just "br app").
>>
>> The tool also lets you examine the status of individual entities in the
>> application, check sensor values and policy configuration, examine the
>> activity history, and even invoke effectors.
>>
>> The documentation for Brooklyn will be updated with guides for the CLI,
>> and you can already read the current snapshot documentation [2].
>>
>> It is worth noting that the tool is still under development, and, while
>> it has broad coverage of Brooklyn functionality at present, there are still
>> things to do.
>>
>> If you are interested in seeing a demo of the CLI in action, you might
>> want to look at a blog post I wrote recently [3].  This is actually on a
>> different topic (Brooklyn Salt integration) but does show the CLI in action.
>>
>> Thanks to Cloudsoft for contributing this to Apache Brooklyn.
>>
>> Regards
>> Geoff Macartney
>>
>> [1] https://github.com/apache/brooklyn-client
>> [2] https://brooklyn.apache.org/v/0.9.0-SNAPSHOT/ops/cli/index.html
>> [3]
>> http://www.cloudsoftcorp.com/blog/2016/03/salt-support-in-apache-brooklyn/
>>
>> 
>> Gnu PGP key - http://is.gd/uI
>>
>>
>>
>>
>

[GitHub] brooklyn-dist pull request: AnsibleEntity was missing from 'all' p...

[geomacy]

GitHub user geomacy opened a pull request:

https://github.com/apache/brooklyn-dist/pull/16

AnsibleEntity was missing from 'all' pom.xml

 so could not deploy ansible entities.

This permits blueprints with AnsibleEntity to deploy.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/geomacy/brooklyn-dist 
ansible-missing-from-all-pom

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-dist/pull/16.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #16


commit 43bc853e2e8e995da7d23f314d237ab8c5c88b7c
Author: Geoff Macartney 
Date:   2016-03-10T23:08:41Z

AnsibleEntity was missing from 'all' pom.xml so could not deploy ansible 
entities.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-library pull request: Adding prepare method

[grkvlt]

Github user grkvlt commented on the pull request:

https://github.com/apache/brooklyn-library/pull/14#issuecomment-195064652
  
@ahgittin thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-docs pull request: Update maven-build.md with RPM notes.

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-docs/pull/27


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-docs pull request: Update maven-build.md with RPM notes.

[aledsage]

Github user aledsage commented on the pull request:

https://github.com/apache/brooklyn-docs/pull/27#issuecomment-195050325
  
LGTM; I'll add a few more pointers that I needed as well after merging.

For the record, this is needed after we merge 
https://github.com/apache/brooklyn-dist/pull/13


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request: [OSGI] brooklyn.properties & CAMP pl...

[neykov]

Github user neykov commented on the pull request:

https://github.com/apache/brooklyn-server/pull/52#issuecomment-194962725
  
Decided to stop troubleshooting before investing too much time - at the 
point where I figured out it's not really required for everything to work. But 
agree it needs to be addressed sooner or later.

Re missing items:
  * locations - due to service loader
  * catalog - there's something more going on there, will troubleshoot once 
this + the service loader fix lands. It's  a non-critical problem - brooklyn 
still can be used without it, so better address the immediate problems first.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...

[neykov]

Github user neykov commented on the pull request:

https://github.com/apache/brooklyn-dist/pull/13#issuecomment-194945382
  
For the record, installed rpm with brew (version rpm (RPM) 5.4.15) and the 
build was successful.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request: SoftLayer VLAN customizer

[ahgittin]

Github user ahgittin commented on the pull request:

https://github.com/apache/brooklyn-server/pull/53#issuecomment-194941293
  
completed.  good start but some things need addressed i think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request: SoftLayer VLAN customizer

[ahgittin]

Github user ahgittin commented on the pull request:

https://github.com/apache/brooklyn-server/pull/53#issuecomment-194941194
  
also can you update the `more-clouds.md` doc to describe this for softlayer?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request: SoftLayer VLAN customizer

[ahgittin]

Github user ahgittin commented on the pull request:

https://github.com/apache/brooklyn-server/pull/53#issuecomment-194940813
  
static caches are bad!  :)  the right impl i think would be to search 
through known locations to look for locations with scope and store the vlan 
id's on that.  that would also allow us to resize to 0 then back out, and we'll 
get a new vlan id.  however that may be hard.

could we note that preferred implementation as a comment in the code?

however a more important problem is that the static cache prevents the vlan 
id's to be persisted.  if we restart brooklyn then scale out we will acquire a 
new vlan id with this code.  :(  i think that does need to be fixed.

it could be fixed by switching away from the cache.  however a simpler fix 
could be that the first thread which acquires the semaphore before exiting 
(without setting a vlan id) first does a query of machines in SL.  if there are 
some already there we just take their vlan id info and cache that.  it won't be 
perfect because vlan id *could* change if we rebooted brooklyn and the list of 
vm's from SL came back in a different order but i think we could live with 
that.  also it means that we are able to provision in parallel much more often, 
if there are any machines in SL, and machines in different apps will also go on 
to the same vlan (not needed but nice).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...

[neykov]

Github user neykov commented on the pull request:

https://github.com/apache/brooklyn-dist/pull/13#issuecomment-194940751
  
@alrick87 The repo looks alright to me, it should upload to apache's repos 
by default.
If you need a different repo to upload to see how the [release 
script](https://github.com/cloudsoft/amp/blob/master/dist/scripts/release-make.sh#L271)
 overrides it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...

[alrick87]

Github user alrick87 commented on the pull request:

https://github.com/apache/brooklyn-dist/pull/13#issuecomment-194937585
  
@neykov I changed the goal from rpm to attached-rpm and it seems to choose 
the wrong artifactory server:
```
[ERROR] Failed to execute goal on project brooklyn-packaging: Could not 
resolve dependencies for project 
org.apache.brooklyn:brooklyn-packaging:pom:0.9.0-SNAPSHOT: Could not transfer 
artifact org.apache.brooklyn:brooklyn-policy:jar:0.9.0-20160310.013017-161 
from/to apache.snapshots (http://repository.apache.org/snapshots): GET request 
of: 
org/apache/brooklyn/brooklyn-policy/0.9.0-SNAPSHOT/brooklyn-policy-0.9.0-20160310.013017-161.jar
 from apache.snapshots failed: Premature end of Content-Length delimited 
message body (expected: 194881; received: 48841 -> [Help 1]
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request: SoftLayer VLAN customizer

[ahgittin]

Github user ahgittin commented on the pull request:

https://github.com/apache/brooklyn-server/pull/53#issuecomment-194936727
  
good start, but i think the acquisition logic is too brittle.

if a machine fails or is cancelled or it somehow doesn't go through the 
`customize(..., Location)` method the lock is kept forever.  i'd suggest:

* in the `synchronized` block, before acquiring the semaphore, check 
whether anyone has owned it for more than 30m, if so, forcibly eject them (we 
have a class `SemaphoreWithOwners` which could be extended to include timestamp 
of when owning threads were issued it to achieve this)

* if it's easy to check for creation failure we should `release` if we were 
the owner (or simply if there are no permits available)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request: SoftLayer VLAN customizer

[ahgittin]

Github user ahgittin commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/53#discussion_r55705953
  
--- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/softlayer/SoftLayerSameVlanLocationCustomizer.java
 ---
@@ -0,0 +1,192 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.brooklyn.location.jclouds.softlayer;
+
+import java.util.concurrent.Semaphore;
+import java.util.concurrent.TimeUnit;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.cache.Cache;
+import com.google.common.cache.CacheBuilder;
+
+import org.jclouds.compute.ComputeService;
+import org.jclouds.compute.options.TemplateOptions;
+import org.jclouds.softlayer.SoftLayerApi;
+import org.jclouds.softlayer.compute.options.SoftLayerTemplateOptions;
+import org.jclouds.softlayer.domain.VirtualGuest;
+import org.jclouds.softlayer.features.VirtualGuestApi;
+import org.jclouds.softlayer.reference.SoftLayerConstants;
+
+import org.apache.brooklyn.api.entity.Entity;
+import org.apache.brooklyn.config.ConfigKey;
+import org.apache.brooklyn.core.config.ConfigKeys;
+import org.apache.brooklyn.core.location.LocationConfigKeys;
+import org.apache.brooklyn.location.jclouds.BasicJcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsMachineLocation;
+import org.apache.brooklyn.util.core.task.Tasks;
+import org.apache.brooklyn.util.javalang.Threads;
+import org.apache.brooklyn.util.text.Strings;
+import org.apache.brooklyn.util.time.Duration;
+
+/**
+ * Configures SoftLayer provisioned VMs with the same VLAN ids across an 
application.
+ */
+public class SoftLayerSameVlanLocationCustomizer extends 
BasicJcloudsLocationCustomizer {
+
+private static final Logger LOG = 
LoggerFactory.getLogger(SoftLayerSameVlanLocationCustomizer.class);
+
+public static final ConfigKey SCOPE_UID = 
ConfigKeys.newStringConfigKey("softlayer.vlan.scopeUid",
+"The unique identifier for a Softlayer location scope that 
will have VMs created in the same VLAN");
+
+public static final ConfigKey SCOPE_TIMEOUT = 
ConfigKeys.newDurationConfigKey("softlayer.vlan.timeout",
+"The length of time to wait for a Softlayer VLAN ID", 
Duration.minutes(10));
+
+/** Caches the semaphore object for locking access to the scope. */
+private static final Cache semaphoreCache = 
CacheBuilder.newBuilder().build();
+
+/** Caches the public VLAN id that should be shared between all 
entities in the same scope. */
+private static final Cache publicVlanIdCache = 
CacheBuilder.newBuilder().build();
+
+/** Caches the private VLAN id that should be shared between all 
entities in the same scope. */
+private static final Cache privateVlanIdCache = 
CacheBuilder.newBuilder().build();
+
+/**
+ * Used to obtain the VLANs being used by the first created {@link 
JcloudsMachineLocation}.
+ */
+@Override
+public void customize(JcloudsLocation location, ComputeService 
computeService, JcloudsMachineLocation machine) {
+String provider = location.getProvider();
+if 
(!(provider.equals(SoftLayerConstants.SOFTLAYER_PROVIDER_NAME))) {
+String message = String.format("Invalid location provider: 
%s", provider);
+LOG.warn(message);
+throw new IllegalArgumentException(message);
+}
+
+Semaphore semaphore = null;
+String scopeUid = getScopeUid(location);
+
+synchronized (SoftLayerSameVlanLocationCustomizer.class) {
+semaphore = semaphoreCache.getIfPresent(scopeUid);
+if (semaphore == null) {
+throw new IllegalStateException("No semaphore 

[GitHub] brooklyn-server pull request: SoftLayer VLAN customizer

[ahgittin]

Github user ahgittin commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/53#discussion_r55705608
  
--- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/softlayer/SoftLayerSameVlanLocationCustomizer.java
 ---
@@ -0,0 +1,192 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.brooklyn.location.jclouds.softlayer;
+
+import java.util.concurrent.Semaphore;
+import java.util.concurrent.TimeUnit;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.cache.Cache;
+import com.google.common.cache.CacheBuilder;
+
+import org.jclouds.compute.ComputeService;
+import org.jclouds.compute.options.TemplateOptions;
+import org.jclouds.softlayer.SoftLayerApi;
+import org.jclouds.softlayer.compute.options.SoftLayerTemplateOptions;
+import org.jclouds.softlayer.domain.VirtualGuest;
+import org.jclouds.softlayer.features.VirtualGuestApi;
+import org.jclouds.softlayer.reference.SoftLayerConstants;
+
+import org.apache.brooklyn.api.entity.Entity;
+import org.apache.brooklyn.config.ConfigKey;
+import org.apache.brooklyn.core.config.ConfigKeys;
+import org.apache.brooklyn.core.location.LocationConfigKeys;
+import org.apache.brooklyn.location.jclouds.BasicJcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsMachineLocation;
+import org.apache.brooklyn.util.core.task.Tasks;
+import org.apache.brooklyn.util.javalang.Threads;
+import org.apache.brooklyn.util.text.Strings;
+import org.apache.brooklyn.util.time.Duration;
+
+/**
+ * Configures SoftLayer provisioned VMs with the same VLAN ids across an 
application.
+ */
+public class SoftLayerSameVlanLocationCustomizer extends 
BasicJcloudsLocationCustomizer {
+
+private static final Logger LOG = 
LoggerFactory.getLogger(SoftLayerSameVlanLocationCustomizer.class);
+
+public static final ConfigKey SCOPE_UID = 
ConfigKeys.newStringConfigKey("softlayer.vlan.scopeUid",
+"The unique identifier for a Softlayer location scope that 
will have VMs created in the same VLAN");
+
+public static final ConfigKey SCOPE_TIMEOUT = 
ConfigKeys.newDurationConfigKey("softlayer.vlan.timeout",
+"The length of time to wait for a Softlayer VLAN ID", 
Duration.minutes(10));
+
+/** Caches the semaphore object for locking access to the scope. */
+private static final Cache semaphoreCache = 
CacheBuilder.newBuilder().build();
+
+/** Caches the public VLAN id that should be shared between all 
entities in the same scope. */
+private static final Cache publicVlanIdCache = 
CacheBuilder.newBuilder().build();
+
+/** Caches the private VLAN id that should be shared between all 
entities in the same scope. */
+private static final Cache privateVlanIdCache = 
CacheBuilder.newBuilder().build();
+
+/**
+ * Used to obtain the VLANs being used by the first created {@link 
JcloudsMachineLocation}.
+ */
+@Override
+public void customize(JcloudsLocation location, ComputeService 
computeService, JcloudsMachineLocation machine) {
+String provider = location.getProvider();
+if 
(!(provider.equals(SoftLayerConstants.SOFTLAYER_PROVIDER_NAME))) {
+String message = String.format("Invalid location provider: 
%s", provider);
+LOG.warn(message);
+throw new IllegalArgumentException(message);
+}
+
+Semaphore semaphore = null;
+String scopeUid = getScopeUid(location);
+
+synchronized (SoftLayerSameVlanLocationCustomizer.class) {
+semaphore = semaphoreCache.getIfPresent(scopeUid);
+if (semaphore == null) {
+throw new IllegalStateException("No semaphore 

[jira] [Created] (BROOKLYN-235) $brooklyn:sensor ref to class name fails when class in catalog's OSGi bundle

[Aled Sage (JIRA)]

Aled Sage created BROOKLYN-235:
--

 Summary: $brooklyn:sensor ref to class name fails when class in 
catalog's OSGi bundle
 Key: BROOKLYN-235
 URL: https://issues.apache.org/jira/browse/BROOKLYN-235
 Project: Brooklyn
  Issue Type: Bug
Reporter: Aled Sage


With Brooklyn 0.9.0-SNAPSHOT...

A customer has recently moved from using jars in ./lib/dropins to OSGi bundles, 
referenced in the catalog metadata.

However, some of their existing catalog items fail. Below is a simplified 
version.

{noformat}
brooklyn.catalog:
  id: MySample
  brooklyn.libraries:
  - https://acme.com/path/to/mysample.jar
  item:
services:
- type: com.acme.MySample
  brooklyn.config:
port: $brooklyn:sensor("com.acme.MySample", "sample.port")
{noformat}

This gives a {{ClassNotFoundException}} coming for the use of 
{{$brooklyn:sensor("com.acme.MySample", "sample.port")}}.

The same blueprint (without the {{brooklyn.libraries}} section worked when the 
jar was instead in the dropins dir.

---
The problem (I believe) is that it tries to interpret the sensor while 
initially parsing the YAML, before the catalog entry has been created, and the 
OSGi bundle has been loaded. It thus can't find the given class.

If you change the example above to just {{$brooklyn:sensor("sample.port")}} 
then it works.

To ensure the first example does not fail, I see a few options:

1. When parsing the yaml, don't fail if the class for the sensor is not found - 
let it be a runtime error instead.
2. Do something overly complicated (!) like a two-phase validation: an initial 
light validation of the YAML; then load the OSGi bundle; then check if this 
sensor exists; but if it doesn't then roll everything back.

Option (2) sounds far too complicated. Should we do option (1), or are there 
better ways to fix this?

---
As a (slightly related) aside, I had a conversation with another Brooklyn 
developer recently about how the semantics of 
{{$brooklyn:sensor("sample.port")}} is not intuitive. It first looks for the 
statically defined sensor on "this" entity (i.e. the entity type that it is 
defined within). But if that sensor does not exist it will just create a new 
sensor definition with the given name (of type {{Object}}, and no metadata like 
descriptions etc). This means you can use this approach to refer to a named 
sensor on another type of entity. It will just work (as long as you don't 
expect fancy type coercions).

Should we just better document that? Or is there a cleaner way to represent it 
in YAML?




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] brooklyn-docs pull request: Update/improve docs for java entities

[aledsage]

Github user aledsage commented on the pull request:

https://github.com/apache/brooklyn-docs/pull/24#issuecomment-194837753
  
Thanks @drigodwin - I've incorporated your comments. Merging now. (but 
please do let me know if there's anything else you come across to be fixed).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...

[ahgittin]

Github user ahgittin commented on the pull request:

https://github.com/apache/brooklyn-dist/pull/13#issuecomment-194837460
  
meant to say, if we prefer to flip it so that `just-java` is the default 
that's not hard.  but i think safety first.

someone doing java should probably just dive in to `brooklyn-server` and 
build that.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...

[ahgittin]

Github user ahgittin commented on the pull request:

https://github.com/apache/brooklyn-dist/pull/13#issuecomment-194837203
  
this is a good question.  we hesitated before requiring `go`, in the end we 
tentatively concluded:

* the default build *does* build everything
* a maven property allows some parts easily to be skipped, e.g. 
`-Dno-go-client` (see in uber's `pom`)
* if you're missing a requirement we show a nice error message (see in 
brooklyn-client `release/build.sh`) explaining
  * how to fix
  * how to skip

@alrick87 if you `grep -r no-go-client` you should find all the references 
to
* go being required
* being able to skip it

suggest we do the same for docker images, rpm/deb, eventually npm, anything 
which isn't pure java.

if we start to have a lot then it might be easier to introduce a 
`just-java` property which also disables the non-portable build items and 
simply document that in the "quick build" instructions, with a reference from 
there to the `maven-build` docs where we detail the properties.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

brooklyn br cli + go lang required for build

[Alex Heneveld]

> This is to announce that the Brooklyn Client Command Line Interface 
tool has been

> added to the Apache Brooklyn "brooklyn-client" repository [1].

This is excellent!  Great work Robert, Geoff, and David.

I've already switched to using the CLI for many things, from deploying 
to looking up details.  The fun will really start when we're embedding 
this in scripts and using `jq` on the output.


You may have seen lots of commits across projects just now:  the CLI is 
now built and bundled as part of the dist.  This means you need Go 1.6 
installed.  Or you can use `-Dno-go-client` if building in the uber.  
(See the README at [1].)


Now we just need to release 0.9.0.

Best
Alex

[1]  https://github.com/apache/brooklyn


On 09/03/2016 12:35, Geoff Macartney wrote:

This is to announce that the Brooklyn Client Command Line Interface tool has been added 
to the Apache Brooklyn "brooklyn-client" repository [1].

This is a lightweight, standalone command line client for Apache Brooklyn, 
written in Go.  The intention is to provide the same control over Brooklyn that 
until now has only been possible via the graphical UI, but at the command line. 
So not only can Brooklyn now be used without requiring a web browser, but it 
also allows power users and devops teams to automate Brooklyn with shell 
scripts.

The tool name is "br".  Just to give a couple of quick examples, you could 
deploy a blueprint with

$ br deploy webapp.yaml

You can then check the progress of the installation by querying the application 
you just deployed:

$ br application WebCluster
Id:  lmOcZbsT
Name:WebCluster
Status:  RUNNING
ServiceUp:   true
... etc.

(or just "br app").

The tool also lets you examine the status of individual entities in the 
application, check sensor values and policy configuration, examine the activity 
history, and even invoke effectors.

The documentation for Brooklyn will be updated with guides for the CLI, and you 
can already read the current snapshot documentation [2].

It is worth noting that the tool is still under development, and, while it has 
broad coverage of Brooklyn functionality at present, there are still things to 
do.

If you are interested in seeing a demo of the CLI in action, you might want to 
look at a blog post I wrote recently [3].  This is actually on a different 
topic (Brooklyn Salt integration) but does show the CLI in action.

Thanks to Cloudsoft for contributing this to Apache Brooklyn.

Regards
Geoff Macartney

[1] https://github.com/apache/brooklyn-client
[2] https://brooklyn.apache.org/v/0.9.0-SNAPSHOT/ops/cli/index.html
[3] http://www.cloudsoftcorp.com/blog/2016/03/salt-support-in-apache-brooklyn/


Gnu PGP key - http://is.gd/uI

[GitHub] brooklyn-docs pull request: document go requirement and exclusion

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-docs/pull/26


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-client pull request: Add -Pno-go-client profile

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-client/pull/4


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn pull request: Add brooklyn-client (the client CLI) to the...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn/pull/5


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn pull request: add the go CLI

[ahgittin]

Github user ahgittin commented on a diff in the pull request:

https://github.com/apache/brooklyn/pull/6#discussion_r55672675
  
--- Diff: pom.xml ---
@@ -76,7 +76,34 @@
 brooklyn-ui
 brooklyn-server
 brooklyn-library
-brooklyn-dist
 
 
+
+
+
+go-client
+
+
+!no-go-client
+
+
+
+brooklyn-client
+
+
+
+
+dist
+
+
+!no-dist
+
+
+
+brooklyn-dist
+
+
+
+
--- End diff --

yep


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn pull request: add the go CLI

[geomacy]

Github user geomacy commented on a diff in the pull request:

https://github.com/apache/brooklyn/pull/6#discussion_r55672623
  
--- Diff: pom.xml ---
@@ -76,7 +76,34 @@
 brooklyn-ui
 brooklyn-server
 brooklyn-library
-brooklyn-dist
 
 
+
+
+
+go-client
+
+
+!no-go-client
+
+
+
+brooklyn-client
+
+
+
+
+dist
+
+
+!no-dist
+
+
+
+brooklyn-dist
+
+
+
+
--- End diff --

p.s. just to confirm, I take it that this automatically includes BOTH 
client and dist if no property is specified, i.e. both profiles are executed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: revised go cli exclusion, and tweaked ...

[ahgittin]

Github user ahgittin commented on the pull request:

https://github.com/apache/brooklyn-dist/pull/15#issuecomment-194819735
  
good spot, removed it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-client pull request: standardise how licenses are used, a...

[geomacy]

Github user geomacy commented on the pull request:

https://github.com/apache/brooklyn-client/pull/5#issuecomment-194816076
  
:+1: lgtm


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-docs pull request: document go requirement and exclusion

[geomacy]

Github user geomacy commented on the pull request:

https://github.com/apache/brooklyn-docs/pull/26#issuecomment-194815689
  
:+1: lgtm


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: revised go cli exclusion, and tweaked ...

[ahgittin]

GitHub user ahgittin opened a pull request:

https://github.com/apache/brooklyn-dist/pull/15

revised go cli exclusion, and tweaked license generation



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ahgittin/brooklyn-dist go-cli

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-dist/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15


commit 5bc7080a42536d2ce6a109729aaacfe2952796dc
Author: Geoff Macartney 
Date:   2016-02-19T16:22:10Z

Add brooklyn-client-cli as a dependency.

This will mean that the build includes the archive for the client CLI
in lib/brooklyn, e.g.

lib/brooklyn/org.apache.brooklyn-brooklyn-client-cli-0.9.0-SNAPSHOT-bin.zip

commit fb30a9cbbbdaa7dc27378f27352ba96f58b3f1fa
Author: Geoff Macartney 
Date:   2016-02-23T14:57:42Z

Include brooklyn-client-cli artifacts

commit f7e8eddc24835f197782ecddfbc1c13f21820851
Author: Geoff Macartney 
Date:   2016-02-24T21:06:42Z

Fix paths in projects-with-custom-licenses

commit 7d55d53318bd97357b57a4132ebc2a5b7e3602ac
Author: Geoff Macartney 
Date:   2016-02-25T16:20:58Z

Start of work to add license files for CLI, NOT WORKING YET.

commit 1bf00c1e9405747ffe5b1543d8e62ca8b3fa6774
Author: Geoff Macartney 
Date:   2016-02-26T12:17:16Z

Updates for license for brooklyn-client, now working.

commit 98389cda4c25099f17b3eb7b9f8b232131996907
Author: Geoff Macartney 
Date:   2016-03-09T21:17:10Z

Add no-go-client profile to avoid including brooklyn-client artifacts.

commit d534b9563ad0d0e5052841c47835fb53a4de0eec
Author: Alex Heneveld 
Date:   2016-03-10T09:37:33Z

This closes #14

commit 3d801c6b2fc474f994d411d97b6074f9dd47a801
Author: Alex Heneveld 
Date:   2016-03-10T10:07:39Z

write cli binaries to a directory without the version name

commit b213524c3f94bea472da698990bc55a84be37d7c
Author: Alex Heneveld 
Date:   2016-03-10T10:38:01Z

switch go-client profile to be activated based on property

commit c056640e106660f482ed06d15d2f1c0d98fdd4df
Author: Alex Heneveld 
Date:   2016-03-10T10:45:07Z

update how go client cli licenses generated

point at new location of license files, tweak scripts to support that, use 
embedded notices like other projects, and add text of referenced licenses




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-client pull request: standardise how licenses are used, a...

[ahgittin]

GitHub user ahgittin opened a pull request:

https://github.com/apache/brooklyn-client/pull/5

standardise how licenses are used, and let uber exclude us rather than us 
pretend to build



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ahgittin/brooklyn-client go-cli

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-client/pull/5.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5


commit 6e868db0e9de64c8fe389db38df798d1586b919c
Author: Geoff Macartney 
Date:   2016-03-09T20:47:18Z

Add -Pno-go-client profile to permit skipping of build for users without Go.

commit d9b2079087bedaf755810172664e7455c81924e7
Author: Alex Heneveld 
Date:   2016-03-10T10:23:02Z

This closes #4

commit e9259bf171401e56adb5585efd3e65310d85a8de
Author: Alex Heneveld 
Date:   2016-03-10T10:42:28Z

project now excluded in maven build by a property, in the uber pom rather 
than here

commit 284627aee5ef55a9ebcb0dd0f31b26081330f6d3
Author: Alex Heneveld 
Date:   2016-03-10T10:45:35Z

move license and assembly files to "release" folder, removing src/

having a dir called `src` when the source code mostly lives in a different 
dir felt wrong

commit 553ad8b301e9213713d255c43c90558374c41f2d
Author: Alex Heneveld 
Date:   2016-03-10T10:55:56Z

simplify the README bundled with the binaries

commit 6fc8a1ee098fa5a4cd7d8fe726dcc7354abaf15a
Author: Alex Heneveld 
Date:   2016-03-10T11:46:09Z

update how go client cli licenses generated

use new location of license files, embedded notices like other projects, 
and add text of referenced licenses




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-docs pull request: Updated page structure & locations

[aledsage]

Github user aledsage commented on a diff in the pull request:

https://github.com/apache/brooklyn-docs/pull/20#discussion_r55659854
  
--- Diff: guide/ops/locations/byon.md ---
@@ -0,0 +1,74 @@
+---
+section: BYON
+section_position: 4
+section_type: inline
+---
+
+### BYON
+
+"Bring-your-own-nodes" mode is useful in production, where machines have 
been provisioned by someone else,
+and during testing, to cut down provisioning time.
+
+Your nodes must meet the following prerequisites:
+
+- A suitable OS must have been installed on all nodes
+- The node must be running sshd (or similar)
+- the brooklyn user must be able to ssh to each node as root or as a user 
with passwordless sudo permission. (For more information on SSH keys, see 
[here](ssh-keys.html).) 
--- End diff --

Also supports windows, with WinRM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-docs pull request: Updated page structure & locations

[aledsage]

Github user aledsage commented on a diff in the pull request:

https://github.com/apache/brooklyn-docs/pull/20#discussion_r55659298
  
--- Diff: _plugins/page_structure.rb ---
@@ -0,0 +1,220 @@
+#
+# Adds a liquid tag to build a page on the contents of the folder it's in
+# 
+# Pulls in files in the format _.md in the order of version 
number. Ignores files not in this format.
+#
+
+require 'rubygems'
+require 'yaml'
+require "kramdown"
+
+module PageStructureUtils
+  
+  class ChildPage
+def initialize(yaml, content)
+  @yaml=yaml
+  @content=content
+end
+attr_accessor :yaml
+attr_accessor :content
+def to_s # called with print / puts
+  "YAML : #{@yaml}" #, Content : #{@content}"
+end
+
+##
+# Sort a list of children by their YAML containing section positions. 
Do this with Gem:Version
+#
+#
+def self.sortBySectionPositions(yaml)
+  
+  $major = "1"
+  $minor = 1
+  # first check all the child pages are numbered, if not, number them 
in the order they are
+  yaml.each do |i|
+if i.yaml['section_position'] == nil
+  i.yaml['section_position'] = $major+"."+$minor.to_s
+  $minor += 1
+else
+  # Store any major, start incrementing minor
+  $major = i.yaml['section_position'].to_s
+  $minor = 1
+end
+  end
+  
+  # return the comparison between the versions
+  yaml.sort{ |x,y| Gem::Version.new(x.yaml['section_position'].to_s) 
<=> Gem::Version.new(y.yaml['section_position'].to_s) }
+end
+##
+# This goes through the hash looking for the keys for the different 
types of children
+#
+def self.getDefiningParameterFromHash(hash)
+  param_name = hash['path']
+  param_name = (param_name == nil ? hash['link'] : param_name)
+   (param_name == nil ? hash['section'] : param_name)
+end
+##
+# Sorts a list of yaml children, if there's no numbering, use the YAML 
order to create a numbering
+# NOTE: doesn't alter the returned object as that seemed to break 
things downstream
+#
+def self.sortYAMLSectionPositions(yaml)
+  position = Hash.new
+  $major = "1"
+  $minor = 1
+  # go through and generate a position for each
+  yaml.each do |i|
+if i.instance_of? String
+  position[i] = $major+"."+$minor.to_s
+  $minor += 1
+else
+  # get the key for this type of child
+  defining_param = getDefiningParameterFromHash(i)
+  if i['section_position'] == nil
+position[defining_param] = $major+"."+$minor.to_s
+$minor += 1
+  else
+# Store any major, start incrementing minor
+position[defining_param] = i['section_position'].to_s
+$major = i['section_position'].to_s
+$minor = 1
+  end
+end
+  end
+  # sort on the position (NB: sort! for in-place sorting)
+  yaml.sort!{ |x,y| 
+$pos_x = nil
+$pos_y = nil
+if x.instance_of? String
+  $pos_x = position[x]
+else
+  defining_param = getDefiningParameterFromHash(x)
+  $pos_x = position[defining_param]
+end
+if y.instance_of? String
+  $pos_y = position[y]
+else
+  defining_param = getDefiningParameterFromHash(y)
+  $pos_y = position[defining_param]
+end
+Gem::Version.new($pos_x.to_s) <=> 
Gem::Version.new($pos_y.to_s) 
+}
+end
+
+##
+# This function looks at all the *.md files at the YAML in the headers 
and produces a list of children ordered by section_position
+#
+#
+def self.parseChildYAMLFromParent(page)
+  # get the base directory of the current file
+  $baseFile = Dir.pwd+page['dir']
+  # list all of the files in that directory
+  $listings = Dir[$baseFile+"/*.md"]
+  $allPages = []
+
+  for $listing in $listings
+
+# read the file
+$fileContent = IO.read($listing)
+# try and split of any YAML
+$partitionedFileContent = $fileContent.split('---');
+# if there's potentially partitioned YAML try and parse it
+if $partitionedFileContent.size > 2
+  # try and parse the YAML
+  yamlContent = 

[GitHub] brooklyn-docs pull request: Updated page structure & locations

[aledsage]

Github user aledsage commented on a diff in the pull request:

https://github.com/apache/brooklyn-docs/pull/20#discussion_r55659068
  
--- Diff: _plugins/page_structure.rb ---
@@ -0,0 +1,220 @@
+#
+# Adds a liquid tag to build a page on the contents of the folder it's in
+# 
+# Pulls in files in the format _.md in the order of version 
number. Ignores files not in this format.
+#
+
+require 'rubygems'
+require 'yaml'
+require "kramdown"
+
+module PageStructureUtils
+  
+  class ChildPage
+def initialize(yaml, content)
+  @yaml=yaml
+  @content=content
+end
+attr_accessor :yaml
+attr_accessor :content
+def to_s # called with print / puts
+  "YAML : #{@yaml}" #, Content : #{@content}"
+end
+
+##
+# Sort a list of children by their YAML containing section positions. 
Do this with Gem:Version
+#
+#
+def self.sortBySectionPositions(yaml)
+  
+  $major = "1"
+  $minor = 1
+  # first check all the child pages are numbered, if not, number them 
in the order they are
+  yaml.each do |i|
+if i.yaml['section_position'] == nil
+  i.yaml['section_position'] = $major+"."+$minor.to_s
+  $minor += 1
+else
+  # Store any major, start incrementing minor
+  $major = i.yaml['section_position'].to_s
+  $minor = 1
+end
+  end
+  
+  # return the comparison between the versions
+  yaml.sort{ |x,y| Gem::Version.new(x.yaml['section_position'].to_s) 
<=> Gem::Version.new(y.yaml['section_position'].to_s) }
+end
+##
--- End diff --

Very minor: would prefer a blank link between previous def and the 
following TomDoc section.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-client pull request: Add -Pno-go-client profile

[ahgittin]

Github user ahgittin commented on the pull request:

https://github.com/apache/brooklyn-client/pull/4#issuecomment-194775338
  
we still have the problem that `activeByDefault` will not be activated if a 
different profile is specified explicitly, i.e. if we say `-PIntegration` we 
would skip the go client build!

personally i prefer something explicit in the code.  poking around i think 
properties are definitely the way to do.  will work on update (but @neykov 
@geomacy if you think otherwise do say!)

also `!` has to be escaped on shells which is tedious


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request: [OSGi] Streamline ManagementContext ...

[neykov]

GitHub user neykov opened a pull request:

https://github.com/apache/brooklyn-server/pull/55

[OSGi] Streamline ManagementContext injection in REST resources

Makes `ManagementContextProvider` the single source of `ManagementContext` 
in REST code, abstracting away the different methods for accessing it.

Discussed in https://github.com/apache/brooklyn-server/pull/34
Depends on #41 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/neykov/brooklyn-server osgi/mgmt-injection

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-server/pull/55.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #55


commit 1bd54e8e86844cf94093a064655c8bb705b7a7db
Author: Svetoslav Neykov 
Date:   2016-02-18T13:02:29Z

JAAS LoginModule delegating to Brooklyn's SecurityProviders

An implementation of a JAAS LoginModule, delegating to the SecurityProvider 
configured in brooklyn.properties. Used as the authentication mechanism for the 
REST API when running in Karaf.
Currently configured as a separate realm, used only for web.

commit 8043106811135c57e5cd213000c54da850003e59
Author: Svetoslav Neykov 
Date:   2016-02-28T13:03:29Z

[BROOKLYN-183] Configure Jetty to use JAAS authentication

* Implement an OSGi fragment so PAX-WEB code can load Jetty classes 
dynamically
* Default jetty.xml for karaf, registering the BrooklynLoginModule JAAS 
implementation
* Register JaasLoginService programatically in classical launcher
* Add support for roles in BrooklynLoginModule
* Register a default jaas.conf for classical launcher if one not already 
registered externally
* Configure Karaf Jetty to listen on port 8081

commit f552f4acd5a484ae52b9437e92b435609d78aa01
Author: Svetoslav Neykov 
Date:   2016-02-28T13:36:24Z

[BROOKLYN-183] Merge HaMasterCheckFilter (servlet) with 
HaHotCheckResourceFilter (JAX-RS)

Move over missing functionality and deprecate HaMasterCheckFilter.

commit cd3a06f0426dbac9b010dec723ab63b9c4a61cb4
Author: Svetoslav Neykov 
Date:   2016-02-28T13:39:58Z

[BROOKLYN-183] ManagementContextProvider support in web.xml files

Support adding the provider in web.xml files. If no management context 
passed in the constructor look for it in the servlet context.

commit 194e9250c903c3b51593c699bdf51a6b9f53f06a
Author: Svetoslav Neykov 
Date:   2016-02-28T13:48:13Z

[BROOKLYN-183] Split servlet filter BrooklynPropertiesSecurityFilter into 
various JAX-RS parts

* LogoutApi & LogoutResource
* RequestTaggingRsFilter - still need a servlet version of it because of 
the LoggingFilter, so get the tag from the request if one is present, generate 
otherwise
* EntitlementContextFilter - initialise thread request entitlements
* Support identical functionality in Jersey
* Deprecate BrooklynPropertiesSecurityFilter

commit a0f610d8360fbb706a01e5a112b605c6d5bb86ce
Author: Svetoslav Neykov 
Date:   2016-02-28T13:49:51Z

[BROOKLYN-183] Deprecate setting a security filter in the launcher

Instead add a new property skipSecurity corresponding to the 
"--noConsoleSecurity" cli option.

commit 5e0939a9ee81c02f760156344b563cd45b7fab95
Author: Svetoslav Neykov 
Date:   2016-03-07T10:59:27Z

Mark resources as testing

commit 7c2a9064ff1ab8b1835a6d106e4ad57eddcc6f0d
Author: Svetoslav Neykov 
Date:   2016-03-07T13:10:10Z

Fix failing tests because of auth request

Explicitly disable web server authentication for tests that don't need it.

commit 7499d9ef282a26a5c5ff437269fc877ccec434b5
Author: Svetoslav Neykov 
Date:   2016-03-07T14:02:06Z

Fix for logout logic - break reauth loop

commit 72b0cd721bf4b10678a0bf2df6235df157d6d8a9
Author: Svetoslav Neykov 
Date:   2016-03-07T14:02:06Z

Streamline ManagementContext injection in REST resources




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-docs pull request: Cli doc updates

[drigodwin]

Github user drigodwin commented on a diff in the pull request:

https://github.com/apache/brooklyn-docs/pull/25#discussion_r55657979
  
--- Diff: guide/start/running.md ---
@@ -133,9 +134,9 @@ INFO  Started Brooklyn console at 
http://127.0.0.1:8081/, running classpath://br
 
 By default it can be accessed by opening 
[127.0.0.1:8081](http://127.0.0.1:8081){:target="_blank"} in your web browser. 
 
-The rest of this getting started guide uses the Apache Brooklyn command 
line interface (CLI). To use this, download and install the tool as described 
on the [CLI GitHub 
page](https://github.com/brooklyncentral/brooklyn-cli){:target="_blank"}.
+The rest of this getting started guide uses the Apache Brooklyn command 
line interface (CLI) tool, `br`. 
+This tool is distributed along with Apache Brooklyn. See details on the 
[Client CLI Reference](../../ops/cli/) page. 
--- End diff --

I think URL is incorrect


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: CI builds?

[Svetoslav Neykov]

Hi Yavor,

I can help you with that. Let's discuss in PM.

Svet.


> On 10.03.2016 г., at 12:04, Yavor Yanchev  wrote:
> 
> Hi All,
> 
> We have the required patches merged and successfully running build jobs on 
> the internal jenkins server. They are ready to be migrated/created on 
> builds.apache.org.
> I'm looking for persons with committer rights to do so, because I don't have 
> account with such privileges.
> 
> Regards,
> Yavor
> 
> On 03/09/2016 11:57 AM, Yavor Yanchev wrote:
>> Hi Richard,
>> 
>> There are prepared build jobs on the internal jenkins.
>> There were problems building the brooklyn-ui as part of the new repo 
>> structure.
>> We have to get two PRs [1] reviewed/merged, before brooklyn-ui and 
>> brooklyn-server can be build successfully as separate projects.
>> 
>> Regards,
>> Yavor
>> 
>> [1] https://github.com/apache/brooklyn-ui/pull/9
>> https://github.com/apache/brooklyn-server/pull/51
>> 
>> On 03/08/2016 03:13 PM, Richard Downer wrote:
>>> All,
>>> 
>>> Apologies I've not been keeping up with this. What's the status of our
>>> CI builds on builds.apache.org?
>>> 
>>> - Are they appropriate for the new repo layout?
>>> - Are they working properly?
>>> - Are PRs also being built?
>>> - Any other issues?
>>> 
>>> I believe there has been some activity but I've not seen it discussed
>>> much on the list. Are we where we want to be?
>>> 
>>> (Note that I'm talking about the setup of the CI builds, not about
>>> whether they are passing or not - start a separate thread if you want
>>> to discuss bugs causing CI failures.)
>>> 
>>> Cheers
>>> Richard.
>> 
>> 
> 
> 

[GitHub] brooklyn-client pull request: Add -Pno-go-client profile

[ahgittin]

Github user ahgittin commented on the pull request:

https://github.com/apache/brooklyn-client/pull/4#issuecomment-194768427
  
thx @neykov i think you are right what i propose wouldn't work anyway, the 
profile modules list would be additive so making it empty would have no effect 
not skip the module.  we need `if profile not set` which i don't yet see how to 
do.

maybe properties are the way to go.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-docs pull request: Cli doc updates

[ahgittin]

Github user ahgittin commented on the pull request:

https://github.com/apache/brooklyn-docs/pull/25#issuecomment-194764886
  
i will tweak dist and docs so that:

* it puts binaries in `bin/brooklyn-client-cli/` (unversioned dir)
* we only list the binaries we care about

then merge

will then do a follow-up which adjusts how the client build and files are 
excluded, as discussed at https://github.com/apache/brooklyn-dist/pull/14


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-docs pull request: Cli doc updates

[geomacy]

Github user geomacy commented on a diff in the pull request:

https://github.com/apache/brooklyn-docs/pull/25#discussion_r55656347
  
--- Diff: guide/ops/cli/index.md ---
@@ -6,7 +6,25 @@ children:
 - cli-usage-guide.md
 ---
 
-{% include list-children.html %}
 
-**NOTE:** These documents are for using the Brooklyn Client CLI to access 
a running Brooklyn Server.  For 
+**NOTE:** These documents are for using the Brooklyn Client CLI tool to 
access a running Brooklyn Server.  For
 information on starting on a Brooklyn Server, refer to [Server CLI 
Reference](../server-cli-reference.html).
+
+## Obtaining the CLI tool
+
+The CLI tool, `br`,  is included in the Apache Brooklyn distribution, in 
bin/brooklyn-client-cli-0.9.0-SNAPSHOT.
+The tool is an executable binary (written in Go), and is distributed in a 
number of builds for a variety of platforms
+and architectures, each build in its own subdirectory:
+
+darwin.386freebsd.386linux.386netbsd.386 openbsd.386   
 windows.386
+darwin.amd64  freebsd.amd64  linux.amd64  netbsd.amd64   openbsd.amd64 
 windows.amd64
--- End diff --

@robertgmoss I will have a look at how to get round that $HOME problem, 
maybe use %USERPROFILE% instead(?)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-client pull request: Add -Pno-go-client profile

[neykov]

Github user neykov commented on the pull request:

https://github.com/apache/brooklyn-client/pull/4#issuecomment-194759161
  
A wrapper module doesn't bring much to the table, makes the build more 
complex I think. You'd need the same workarounds elsewhere to depend on the 
artifact and to activate the profile for the modules.

The important thing is that we don't generate an empty zip file. Whether 
there's a pom file uploaded to artifactory doesn't really matter (for the 
client module).

Also keep in mind we'd need the same workarounds for the rpm build.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-client pull request: Add -Pno-go-client profile

[geomacy]

Github user geomacy commented on the pull request:

https://github.com/apache/brooklyn-client/pull/4#issuecomment-194756045
  
I guess something like that might be made to work but I'd have to try it 
out.  At the same time the solution needs to include both avoiding the Go 
client build and also avoiding any attempt to package the artifacts if you know 
you didn't build it, so brooklyn-dist will also need to be aware of the profile 
(or whatever solution is chosen), as attempted in 
https://github.com/apache/brooklyn-dist/pull/14.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: Include brooklyn-client-cli

[ahgittin]

Github user ahgittin commented on a diff in the pull request:

https://github.com/apache/brooklyn-dist/pull/14#discussion_r55653884
  
--- Diff: dist/licensing/extras-files ---
@@ -1 +1 @@

-../../brooklyn-ui/src/main/license/source-inclusions.yaml:../../brooklyn-server/server-cli/src/main/license/source-inclusions.yaml

+../../brooklyn-ui/src/main/license/source-inclusions.yaml:../../brooklyn-server/server-cli/src/main/license/source-inclusions.yaml:../../brooklyn-client/src/main/license/source-inclusions.yaml
--- End diff --

(not part of this PR but it feels wrong to follow the `/src/main/` 
structure for a go project and easy to change to put this info into `build/`)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-docs pull request: Cli doc updates

[ahgittin]

Github user ahgittin commented on a diff in the pull request:

https://github.com/apache/brooklyn-docs/pull/25#discussion_r55653462
  
--- Diff: guide/ops/cli/index.md ---
@@ -6,7 +6,25 @@ children:
 - cli-usage-guide.md
 ---
 
-{% include list-children.html %}
 
-**NOTE:** These documents are for using the Brooklyn Client CLI to access 
a running Brooklyn Server.  For 
+**NOTE:** These documents are for using the Brooklyn Client CLI tool to 
access a running Brooklyn Server.  For
 information on starting on a Brooklyn Server, refer to [Server CLI 
Reference](../server-cli-reference.html).
+
+## Obtaining the CLI tool
+
+The CLI tool, `br`,  is included in the Apache Brooklyn distribution, in 
bin/brooklyn-client-cli-0.9.0-SNAPSHOT.
--- End diff --

we need `` on the previous line


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-client pull request: Add -Pno-go-client profile

[ahgittin]

Github user ahgittin commented on the pull request:

https://github.com/apache/brooklyn-client/pull/4#issuecomment-194752153
  
this is a complex way to exclude the client, and roundabout it feels as it 
suggests the module is built it just defines a no-op build.  also with maven 
(as you've discovered with the `activation` logic) inverting a profile is 
convoluted and prone to errors.

do you think it would be better to exclude the module altogether if the 
profile is set?

unfortunately to do this in the uber pom it seems there is no way to avoid 
listing the modules twice, once with `brooklyn-client` and once without.  maybe 
the least messy way would be to create a new pom in 
`brooklyn-client/pom-wrapper/` which has a default `` list pointing at 
the parent but if `no-go-client` profile is set the `` list would be 
empty.  wdyt? /cc @aledsage @rdowner @neykov 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-docs pull request: Cli doc updates

[neykov]

Github user neykov commented on a diff in the pull request:

https://github.com/apache/brooklyn-docs/pull/25#discussion_r55652315
  
--- Diff: guide/ops/cli/index.md ---
@@ -6,7 +6,25 @@ children:
 - cli-usage-guide.md
 ---
 
-{% include list-children.html %}
 
-**NOTE:** These documents are for using the Brooklyn Client CLI to access 
a running Brooklyn Server.  For 
+**NOTE:** These documents are for using the Brooklyn Client CLI tool to 
access a running Brooklyn Server.  For
 information on starting on a Brooklyn Server, refer to [Server CLI 
Reference](../server-cli-reference.html).
+
+## Obtaining the CLI tool
+
+The CLI tool, `br`,  is included in the Apache Brooklyn distribution, in 
bin/brooklyn-client-cli-0.9.0-SNAPSHOT.
+The tool is an executable binary (written in Go), and is distributed in a 
number of builds for a variety of platforms
+and architectures, each build in its own subdirectory:
+
+darwin.386freebsd.386linux.386netbsd.386 openbsd.386   
 windows.386
+darwin.amd64  freebsd.amd64  linux.amd64  netbsd.amd64   openbsd.amd64 
 windows.amd64
--- End diff --

re windows - the executable doesn't have an `.exe` extension.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...

[neykov]

Github user neykov commented on the pull request:

https://github.com/apache/brooklyn-dist/pull/13#issuecomment-194748385
  
If we are adding `rpm` to the build requirements how will this affect 
windows builds? Do we really want to require rpm executable on the windows path?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...

[aledsage]

Github user aledsage commented on the pull request:

https://github.com/apache/brooklyn-dist/pull/13#issuecomment-194747517
  
@alrick87 @neykov for a local build, the RPM was created in 
`brooklyn-dist/packaging/target/rpm/apache-brooklyn/RPMS/i386/apache-brooklyn-0.9.0-SNAPSHOT20160309232115.i386.rpm`.

However, when I tried pushing to artifactory then this wasn't included. Any 
ideas?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...

[aledsage]

Github user aledsage commented on the pull request:

https://github.com/apache/brooklyn-dist/pull/13#issuecomment-194747210
  
Can you also update the instructions at 
http://brooklyn.apache.org/v/0.9.0-SNAPSHOT/dev/env/maven-build.html (or a 
similar page - i.e. to 
https://github.com/apache/brooklyn-docs/blob/master/guide/dev/env/maven-build.md)
 to say about the need for `rpm` on the path, and how to get it. For me, I had 
to follow the instructions at 
http://stackoverflow.com/questions/25277878/make-rpm-maven-plugin-work-on-mac-osmavericks/29723957#29723957
 to get the normal build to pass on OS X. i.e. `sudo port install rpm`, and 
adding `%_tmppath   /tmp` to the file `$HOME/.rpmmacros`. Use of `brew` 
didn't work for me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-docs pull request: Cli doc updates

[robertgmoss]

Github user robertgmoss commented on a diff in the pull request:

https://github.com/apache/brooklyn-docs/pull/25#discussion_r55651252
  
--- Diff: guide/ops/cli/index.md ---
@@ -6,7 +6,25 @@ children:
 - cli-usage-guide.md
 ---
 
-{% include list-children.html %}
 
-**NOTE:** These documents are for using the Brooklyn Client CLI to access 
a running Brooklyn Server.  For 
+**NOTE:** These documents are for using the Brooklyn Client CLI tool to 
access a running Brooklyn Server.  For
 information on starting on a Brooklyn Server, refer to [Server CLI 
Reference](../server-cli-reference.html).
+
+## Obtaining the CLI tool
+
+The CLI tool, `br`,  is included in the Apache Brooklyn distribution, in 
bin/brooklyn-client-cli-0.9.0-SNAPSHOT.
+The tool is an executable binary (written in Go), and is distributed in a 
number of builds for a variety of platforms
+and architectures, each build in its own subdirectory:
+
+darwin.386freebsd.386linux.386netbsd.386 openbsd.386   
 windows.386
+darwin.amd64  freebsd.amd64  linux.amd64  netbsd.amd64   openbsd.amd64 
 windows.amd64
--- End diff --

BTW @ahgittin @geomacy I missed this before: I'm pretty sure the windows 
version won't work properly since it relies on putting a file in the $HOME 
directory for login.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-docs pull request: Cli doc updates

[ahgittin]

Github user ahgittin commented on a diff in the pull request:

https://github.com/apache/brooklyn-docs/pull/25#discussion_r55650931
  
--- Diff: guide/ops/cli/index.md ---
@@ -6,7 +6,25 @@ children:
 - cli-usage-guide.md
 ---
 
-{% include list-children.html %}
 
-**NOTE:** These documents are for using the Brooklyn Client CLI to access 
a running Brooklyn Server.  For 
+**NOTE:** These documents are for using the Brooklyn Client CLI tool to 
access a running Brooklyn Server.  For
 information on starting on a Brooklyn Server, refer to [Server CLI 
Reference](../server-cli-reference.html).
+
+## Obtaining the CLI tool
+
+The CLI tool, `br`,  is included in the Apache Brooklyn distribution, in 
bin/brooklyn-client-cli-0.9.0-SNAPSHOT.
+The tool is an executable binary (written in Go), and is distributed in a 
number of builds for a variety of platforms
+and architectures, each build in its own subdirectory:
+
+darwin.386freebsd.386linux.386netbsd.386 openbsd.386   
 windows.386
+darwin.amd64  freebsd.amd64  linux.amd64  netbsd.amd64   openbsd.amd64 
 windows.amd64
--- End diff --

would it be (a) easy and (b) sensible just to do:

* darwin.amd64 (Mac)
* linux.{386,amd64}
* windows.{386,amd64}

i don't think we've ever discussed tested or had a request for the others.  
might improve build time by 1m+ ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-client pull request: Optional build - check if go executa...

[ahgittin]

Github user ahgittin commented on the pull request:

https://github.com/apache/brooklyn-client/pull/2#issuecomment-194741336
  
@neykov sorry I missed this!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---