[GitHub] brooklyn-server issue #949: Improve JcloudsWinrmingLiveTest coverage

2018-02-26 Thread sjcorbett 
Github user sjcorbett commented on the issue:

https://github.com/apache/brooklyn-server/pull/949
  
@andreaturli looks good. I've left two minor comments that needn't stop 
this being merged if you wish.


---

[GitHub] brooklyn-server pull request #949: Improve JcloudsWinrmingLiveTest coverage

2018-02-26 Thread sjcorbett 
Github user sjcorbett commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/949#discussion_r170685601
  
--- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/DefaultConnectivityResolver.java
 ---
@@ -212,8 +217,10 @@ public ManagementAddressResolveResult resolve(
 }
 
 if (hapChoice == null) {
-throw new IllegalStateException("jclouds did not return any IP 
addresses matching " + getNetworkMode() + " in " + location);
+LOG.error("None of the addresses of node {} are reachable in 
mode {}", new Object[]{node, getNetworkMode()});
+throw new IllegalStateException("Could not find any reachable 
address for node: " + node + " in mode: " + getNetworkMode());
--- End diff --

Strictly speaking Brooklyn didn't look for a "reachable" address if 
ConnectivityResolverOptions.pollForReachableAddresses was false. How about 
"Could not determine management address for node..."?


---

[GitHub] brooklyn-server pull request #949: Improve JcloudsWinrmingLiveTest coverage

2018-02-26 Thread sjcorbett 
Github user sjcorbett commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/949#discussion_r170685134
  
--- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/DefaultConnectivityResolver.java
 ---
@@ -181,24 +183,27 @@ public ManagementAddressResolveResult resolve(
 LoginCredentials credChoice = null;
 
 final Iterable managementCandidates = 
getManagementCandidates(location, node, config, options);
-final Iterable credentialCandidates = 
getCredentialCandidates(location, node, options, config);
-
-// Try each pair of address and credential until one succeeds.
-if (shouldCheckCredentials() && 
options.pollForReachableAddresses()) {
-for (HostAndPort hap : managementCandidates) {
-for (LoginCredentials cred : credentialCandidates) {
-LOG.trace("Testing host={} with credential={}", hap, 
cred);
-if (checkCredential(location, hap, cred, config, 
options.isWindows())) {
-hapChoice = hap;
-credChoice = cred;
-break;
+Iterable credentialCandidates = 
Lists.newArrayList();
--- End diff --

You could use `Collections.emptyList()` or `ImmutableList.of()` here to 
save the redundant creation of an object. You could also assign it in an `else` 
block for the list so its use is a little clearer.


---

[jira] [Commented] (BROOKLYN-584) Support jclouds ContextLinking

2018-02-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BROOKLYN-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376917#comment-16376917
 ] 

ASF GitHub Bot commented on BROOKLYN-584:
-

Github user geomacy commented on the issue:

https://github.com/apache/brooklyn-server/pull/952
  
@andreaturli @duncangrant  I agree it shouldn't be part of this PR, just 
think it's worth documenting 


> Support jclouds ContextLinking
> --
>
> Key: BROOKLYN-584
> URL: https://issues.apache.org/jira/browse/BROOKLYN-584
> Project: Brooklyn
>  Issue Type: Improvement
>Reporter: Andrea Turli
>Priority: Major
> Fix For: 1.0.0
>
>
> * Some cloud providers like OpenStack require to link a jclouds context to 
> another context (i.e. Neutron to Nova). jclouds already supports that and 
> brooklyn could add it
>  * in addition add support for user-defined Guice modules would be useful



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] brooklyn-server issue #952: [BROOKLYN-584] Add support for recent jclouds's ...

2018-02-26 Thread geomacy 
Github user geomacy commented on the issue:

https://github.com/apache/brooklyn-server/pull/952
  
@andreaturli @duncangrant  I agree it shouldn't be part of this PR, just 
think it's worth documenting 


---

[GitHub] brooklyn-server issue #949: Improve JcloudsWinrmingLiveTest coverage

2018-02-26 Thread andreaturli 
Github user andreaturli commented on the issue:

https://github.com/apache/brooklyn-server/pull/949
  
@sjcorbett is it ok for you now?


---

[GitHub] brooklyn-docs issue #245: improve OpenStack documentation

2018-02-26 Thread andreaturli 
Github user andreaturli commented on the issue:

https://github.com/apache/brooklyn-docs/pull/245
  
merging now, thanks @duncangrant 


---

[GitHub] brooklyn-docs issue #245: improve OpenStack documentation

2018-02-26 Thread andreaturli 
Github user andreaturli commented on the issue:

https://github.com/apache/brooklyn-docs/pull/245
  
merged at 
[master](https://git-wip-us.apache.org/repos/asf?p=brooklyn-docs.git;a=commit;h=2f2ed97c4fc68a086723c965077ce54204b4ecba)


---

[GitHub] brooklyn-docs pull request #245: improve OpenStack documentation

2018-02-26 Thread duncangrant 
Github user duncangrant commented on a diff in the pull request:

https://github.com/apache/brooklyn-docs/pull/245#discussion_r170577533
  
--- Diff: guide/locations/_openstack.md ---
@@ -1,23 +1,69 @@
 ## OpenStack
 
-### Apache jclouds
 
-Support for OpenStack is provided by Apache jclouds. For more information, 
see their guide
-[here](https://jclouds.apache.org/guides/openstack/).
+Brooklyn requires the following API to deploy application onto an 
OpenStack-based provider
--- End diff --

deploy an application


---

[GitHub] brooklyn-docs pull request #245: improve OpenStack documentation

2018-02-26 Thread andreaturli 
GitHub user andreaturli opened a pull request:

https://github.com/apache/brooklyn-docs/pull/245

improve OpenStack documentation

- describes how to link Neutron to Nova



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andreaturli/brooklyn-docs 
feature/openstack-context-linking

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-docs/pull/245.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #245


commit d6494656c25095dfe3d5734e23372157323149f8
Author: andreaturli 
Date:   2018-02-26T11:44:37Z

improve OpenStack documentation

- describes how to link Neutron to Nova




---

[GitHub] brooklyn-server pull request #952: [BROOKLYN-584] Add support for recent jcl...

2018-02-26 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-server/pull/952


---

[jira] [Commented] (BROOKLYN-584) Support jclouds ContextLinking

2018-02-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BROOKLYN-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376683#comment-16376683
 ] 

ASF GitHub Bot commented on BROOKLYN-584:
-

Github user duncangrant commented on the issue:

https://github.com/apache/brooklyn-server/pull/952
  
@andreaturli No - shouldn't be part of this PR.  I just wrote the comment 
as a reminder.


> Support jclouds ContextLinking
> --
>
> Key: BROOKLYN-584
> URL: https://issues.apache.org/jira/browse/BROOKLYN-584
> Project: Brooklyn
>  Issue Type: Improvement
>Reporter: Andrea Turli
>Priority: Major
> Fix For: 1.0.0
>
>
> * Some cloud providers like OpenStack require to link a jclouds context to 
> another context (i.e. Neutron to Nova). jclouds already supports that and 
> brooklyn could add it
>  * in addition add support for user-defined Guice modules would be useful



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] brooklyn-server issue #952: [BROOKLYN-584] Add support for recent jclouds's ...

2018-02-26 Thread duncangrant 
Github user duncangrant commented on the issue:

https://github.com/apache/brooklyn-server/pull/952
  
@andreaturli No - shouldn't be part of this PR.  I just wrote the comment 
as a reminder.


---

[jira] [Commented] (BROOKLYN-584) Support jclouds ContextLinking

2018-02-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BROOKLYN-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376684#comment-16376684
 ] 

ASF GitHub Bot commented on BROOKLYN-584:
-

Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-server/pull/952


> Support jclouds ContextLinking
> --
>
> Key: BROOKLYN-584
> URL: https://issues.apache.org/jira/browse/BROOKLYN-584
> Project: Brooklyn
>  Issue Type: Improvement
>Reporter: Andrea Turli
>Priority: Major
> Fix For: 1.0.0
>
>
> * Some cloud providers like OpenStack require to link a jclouds context to 
> another context (i.e. Neutron to Nova). jclouds already supports that and 
> brooklyn could add it
>  * in addition add support for user-defined Guice modules would be useful



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (BROOKLYN-584) Support jclouds ContextLinking

2018-02-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BROOKLYN-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376673#comment-16376673
 ] 

ASF GitHub Bot commented on BROOKLYN-584:
-

Github user andreaturli commented on the issue:

https://github.com/apache/brooklyn-server/pull/952
  
thanks @duncangrant and @geomacy 

Do you guys think the docs should be part of the same PR?


> Support jclouds ContextLinking
> --
>
> Key: BROOKLYN-584
> URL: https://issues.apache.org/jira/browse/BROOKLYN-584
> Project: Brooklyn
>  Issue Type: Improvement
>Reporter: Andrea Turli
>Priority: Major
> Fix For: 1.0.0
>
>
> * Some cloud providers like OpenStack require to link a jclouds context to 
> another context (i.e. Neutron to Nova). jclouds already supports that and 
> brooklyn could add it
>  * in addition add support for user-defined Guice modules would be useful



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] brooklyn-server issue #952: [BROOKLYN-584] Add support for recent jclouds's ...

2018-02-26 Thread andreaturli 
Github user andreaturli commented on the issue:

https://github.com/apache/brooklyn-server/pull/952
  
thanks @duncangrant and @geomacy 

Do you guys think the docs should be part of the same PR?


---

[jira] [Commented] (BROOKLYN-584) Support jclouds ContextLinking

2018-02-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BROOKLYN-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376660#comment-16376660
 ] 

ASF GitHub Bot commented on BROOKLYN-584:
-

Github user duncangrant commented on the issue:

https://github.com/apache/brooklyn-server/pull/952
  
@andreaturli Might be worth adding a docs change to 
https://brooklyn.apache.org/v/latest/locations/index.html#openstack?


> Support jclouds ContextLinking
> --
>
> Key: BROOKLYN-584
> URL: https://issues.apache.org/jira/browse/BROOKLYN-584
> Project: Brooklyn
>  Issue Type: Improvement
>Reporter: Andrea Turli
>Priority: Major
> Fix For: 1.0.0
>
>
> * Some cloud providers like OpenStack require to link a jclouds context to 
> another context (i.e. Neutron to Nova). jclouds already supports that and 
> brooklyn could add it
>  * in addition add support for user-defined Guice modules would be useful



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] brooklyn-server issue #952: [BROOKLYN-584] Add support for recent jclouds's ...

2018-02-26 Thread duncangrant 
Github user duncangrant commented on the issue:

https://github.com/apache/brooklyn-server/pull/952
  
@andreaturli Might be worth adding a docs change to 
https://brooklyn.apache.org/v/latest/locations/index.html#openstack?


---

[GitHub] brooklyn-server issue #673: [WIP] [JCLOUDS 2.1.0] Upgrade to jclouds 2.1

2018-02-26 Thread geomacy 
Github user geomacy commented on the issue:

https://github.com/apache/brooklyn-server/pull/673
  
hi @neykov I think this can be retired now as superseded by 
https://github.com/apache/brooklyn-server/pull/950.  Andrea cross checked 
against this one before his was merged. 


---

[GitHub] brooklyn-server pull request #951: Support iteration of hashes in templates

2018-02-26 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-server/pull/951


---