[GitHub] [brooklyn-docs] asfgit merged pull request #379: Workflow - update-children and more

[via GitHub]

asfgit merged PR #379:
URL: https://github.com/apache/brooklyn-docs/pull/379


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Build failed in Jenkins: Brooklyn » Brooklyn - UI module » master #266

[Apache Jenkins Server]

See 


Changes:


--
Push event to branch master
Connecting to https://api.github.com using This is to connect to Brooklyn repos 
on GitHub
Obtained Jenkinsfile from 64e4cdc11638030452f34c63204ae3b78016c203
[Pipeline] Start of Pipeline
[Pipeline] node
Running on builds23 in /home/jenkins/workspace/Brooklyn_brooklyn-ui_master
[Pipeline] {
[Pipeline] catchError
[Pipeline] {
[Pipeline] withEnv
[Pipeline] {
[Pipeline] stage
[Pipeline] { (Clone repository)
[Pipeline] checkout
The recommended git tool is: git
using credential Read only (Brooklyn repos)
Fetching changes from the remote Git repository
Fetching without tags
 > git rev-parse --resolve-git-dir 
 > /home/jenkins/workspace/Brooklyn_brooklyn-ui_master/.git # timeout=10
 > git config remote.origin.url https://github.com/apache/brooklyn-ui.git # 
 > timeout=10
Fetching upstream changes from https://github.com/apache/brooklyn-ui.git
 > git --version # timeout=10
 > git --version # 'git version 2.17.1'
using GIT_ASKPASS to set credentials This is to connect to Brooklyn repos on 
GitHub
 > git fetch --no-tags --progress -- https://github.com/apache/brooklyn-ui.git 
 > +refs/heads/master:refs/remotes/origin/master # timeout=10
Checking out Revision 64e4cdc11638030452f34c63204ae3b78016c203 (master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 64e4cdc11638030452f34c63204ae3b78016c203 # timeout=10
Commit message: "remove redundant call to get activities"
 > git rev-list --no-walk 49c2f9db886df17b20c11bab8f8c0b55f3f396bb # timeout=10
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Prepare environment)
[Pipeline] echo
Creating maven cache ...
[Pipeline] sh
+ mkdir -p /home/jenkins/workspace/Brooklyn_brooklyn-ui_master/.m2
[Pipeline] sh
+ docker logout
Removing login credentials for https://index.docker.io/v1/
WARNING: could not erase credentials:
https://index.docker.io/v1/: rename /home/jenkins/.docker/config.json4075010151 
/home/jenkins/.docker/config.json: operation not permitted
[Pipeline] echo
Building docker image for test environment ...
[Pipeline] echo
Using docker tag DOCKER_TAG=jenkins-Brooklyn-brooklyn-ui-master-266
[Pipeline] isUnix
[Pipeline] withEnv
[Pipeline] {
[Pipeline] sh
+ docker build -t brooklyn:jenkins-Brooklyn-brooklyn-ui-master-266 .
#1 [internal] load .dockerignore
#1 transferring context: 2B done
#1 ...

#2 [internal] load build definition from Dockerfile
#2 transferring dockerfile: 1.54kB 0.0s done
#2 DONE 0.4s

#1 [internal] load .dockerignore
#1 DONE 0.5s

#3 [internal] load metadata for docker.io/library/maven:3.5.4-jdk-8
#3 DONE 1.8s

#4 [1/5] FROM 
docker.io/library/maven:3.5.4-jdk-8@sha256:b90230c6c65fa00b3404555ad9d3a131101cef791e5583aab18ac420def7d6bb
#4 resolve 
docker.io/library/maven:3.5.4-jdk-8@sha256:b90230c6c65fa00b3404555ad9d3a131101cef791e5583aab18ac420def7d6bb
#4 resolve 
docker.io/library/maven:3.5.4-jdk-8@sha256:b90230c6c65fa00b3404555ad9d3a131101cef791e5583aab18ac420def7d6bb
 0.4s done
#4 sha256:b90230c6c65fa00b3404555ad9d3a131101cef791e5583aab18ac420def7d6bb 
2.37kB / 2.37kB done
#4 sha256:6a81c4b3372c5303c321e2f43db8afd4b546ec5ec416c96fca148cfed6674aa4 
2.84kB / 2.84kB done
#4 sha256:985f3637ded401ec2ce4c63d39255e8c0797f68ce24cc123065eabf87f7f3da2 
7.83kB / 7.83kB done
#4 DONE 1.7s

#5 [2/5] RUN apt-get update && apt-get install -y git-core libpng-dev 
libjpeg-progs pngquant make automake autoconf libtool 
dpkg pkg-config nasm gcc
#5 2.006 Ign:1 http://security.debian.org/debian-security stretch/updates 
InRelease
#5 2.006 Ign:2 http://deb.debian.org/debian stretch InRelease
#5 2.012 Ign:3 http://deb.debian.org/debian stretch-updates InRelease
#5 2.014 Ign:4 http://security.debian.org/debian-security stretch/updates 
Release
#5 2.017 Ign:5 http://deb.debian.org/debian stretch Release
#5 2.021 Ign:6 http://security.debian.org/debian-security stretch/updates/main 
amd64 Packages
#5 2.023 Ign:7 http://deb.debian.org/debian stretch-updates Release
#5 2.027 Ign:8 http://security.debian.org/debian-security stretch/updates/main 
all Packages
#5 2.033 Ign:6 http://security.debian.org/debian-security stretch/updates/main 
amd64 Packages
#5 2.037 Ign:9 http://deb.debian.org/debian stretch/main amd64 Packages
#5 2.040 Ign:8 http://security.debian.org/debian-security stretch/updates/main 
all Packages
#5 2.048 Ign:6 http://security.debian.org/debian-security stretch/updates/main 
amd64 Packages
#5 2.051 Ign:10 http://deb.debian.org/debian stretch/main all Packages
#5 2.054 Ign:8 http://security.debian.org/debian-security stretch/updates/main 
all Packages
#5 2.057 Ign:11 http://deb.debian.org/debian stretch-updates/main all Packages
#5 2.060 Ign:6 http://security.debian.org/debian-security stretch/updates/main 
amd64 Packages
#5 2.063 Ign:12 http://deb.debian.org/debian stretch-updates/main amd64 Packages
#5 2.067 Ign:

[GitHub] [brooklyn-server] ahgittin commented on pull request #1389: Activities tab rest optimization

[via GitHub]

ahgittin commented on PR #1389:
URL: https://github.com/apache/brooklyn-server/pull/1389#issuecomment-1560901120

   @jcabrerizo You are right, this makes a huge difference, and I agree with 
you it's the correct balance where we do it.
   
   In fact I've extended it a bit, and tidied, in 2d6e8cdc40, as follows:
   
   Use this in a few more places:
   * exclude detail from tasks when doing a recursive/children lookup
   * filter output fields in tasks when detail is excluded
   * filter output fields from children and recursive task requests by default
   * filter output fields for selected sensors (name starts with "internal") 
when doing a batch read of sensors (this affects the workflow cache which 
contains all output)
   * also filter various `content...` fields used by the `http` workflow step
   
   And some tidying/tweaks:
   * change name of methods and params - call it filterOutputFields instead of 
suppressOutput (to me, suppress hints at security)
   * expose the capability on the generic resolver (used for the sensors above)
   * when doing the filter, don't bother if it's short/trivial, and if it's not 
a string include the type for info
   * change implementation of filter to run even if suppress secrets is false
   * (in UI, remove one redundant activities call)
   
   I did a simple test by adding these lines to the `SimpleBlueprintTest` then 
attaching a UI and looking at network size:
   
   ```
   WorkflowYamlTest.addWorkflowTypes(mgmt);
   Application app1 = runTestOnBlueprint("services: [ { type: " + 
WorkflowSoftwareProcess.class.getName() + ", location: localhost } ]");
   WorkflowBasicTest.runWorkflow(app1.getChildren().iterator().next(), 
Strings.lines("steps:",
   "  - ssh aws cloudformation describe-stacks"), "cfn");
   WorkflowBasicTest.runWorkflow(app1.getChildren().iterator().next(), 
Strings.lines("steps:",
   "  - ssh aws cloudformation describe-stacks"), "cfn2");
   WorkflowBasicTest.runWorkflow(app1.getChildren().iterator().next(), 
Strings.lines("steps:",
   "  - ssh aws cloudformation describe-stacks"), "cfn3");
   ```
   
   The impact is huge:
   * 3 med size workflows - call to list - reduced from 126kb to 2kb
   * recursive task call for the above - from 25k to 5k
   * sensor batch read - from 120k to 2k
   * details of 1 workflow - 42kb to access (unchanged)
   
   It doesn't address the huge size of persistence but I will add a section to 
the docs on workflow for that.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [brooklyn-server] asfgit merged pull request #1400: Workflow - foreach, reducing, update-children, and more

[via GitHub]

asfgit merged PR #1400:
URL: https://github.com/apache/brooklyn-server/pull/1400


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [brooklyn-server] asfgit merged pull request #1389: Activities tab rest optimization

[via GitHub]

asfgit merged PR #1389:
URL: https://github.com/apache/brooklyn-server/pull/1389


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [brooklyn-docs] iuliana commented on a diff in pull request #379: Workflow - update-children and more

[via GitHub]

iuliana commented on code in PR #379:
URL: https://github.com/apache/brooklyn-docs/pull/379#discussion_r1203841245


##
guide/blueprints/workflow/nested-workflow.md:
##
@@ -80,6 +119,8 @@ and always allowing 1.
 This might be used for example to upgrade a cluster in situ, leaving the 
larger of 10 instances or half the cluster alone, if possible.  
 If the concurrency expression evaluates to 0, or to a negative number whose 
absolute value is larger than the number of values, the step will fail before 
executing, to ensure that if e.g. "-10" is specified when there are fewer than 
10 items in the target list, the workflow does not run.  (Use "max(1, -10)" to 
allow it to run 1 at a time if there are 10 or fewer.)
 
+Concurrency cannot be specified when `reducing`.

Review Comment:
   @ahgittin  Maybe add a **Note:** in front of this statement



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [brooklyn-server] ahgittin commented on pull request #1400: Workflow - foreach, reducing, update-children, and more

[via GitHub]

ahgittin commented on PR #1400:
URL: https://github.com/apache/brooklyn-server/pull/1400#issuecomment-1560688419

   `update-children` now completed, including recovering on interrupts with 
tests, and a few fixes for workflow/task interruption and resumption
   
   ready for final review and merge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org