[GitHub] brooklyn-server issue #812: use external config in examples
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/812 Good point re examples pointing to master. Will add password in script. But we should probably change links in example to point at specific branches too. ---
[GitHub] brooklyn-server issue #812: use external config in examples
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/812 @m4rkmckenna there is a "file-based exteranl config supplier" you can use for dev (`PropertiesFileExternalConfigSupplier`), and then switch to Vault or whatever when you're ready. But I think that @ahgittin's change here is a separate good addition as it means stock examples can work out-of-the-box without the user having to modify `brooklyn.cfg` to configure things like that, or to add the desired password to some file. --- I agree with @drigodwin's suggestion of giving a default in `visitors-creation-script.sql` so that we don't break other people's examples that might be referencing that file. For Brooklyn 1.0.0 we can remove the default, perhaps first warning people on the mailing list. ---
[GitHub] brooklyn-server issue #812: use external config in examples
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-server/pull/812 Ignore me ... It was never added. But i do think the flow i mentioned above would be incredibly useful ---
[GitHub] brooklyn-server issue #812: use external config in examples
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-server/pull/812 @ahgittin I think @neykov added a file based external config provider for this, That enable users to configure for development and then swap to a "proper" config provider. You could just configure it by default ---
[GitHub] brooklyn-server issue #812: use external config in examples
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/812 note the two other PRs in downstream projects listed above ---
[GitHub] brooklyn-server issue #812: use external config in examples
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/812 OTOH someone using a live deployment might want to use one of the test blueprints. The docs describe how to change the password: https://github.com/apache/brooklyn-docs/pull/209/files#diff-b6c73a383415d543418f8762ce2dbe9eR79 I think that's sufficient. If someone really wants to disable that key we can tell them to include just the first line there (the provider is present, but empty); if that becomes a popular feature request then we add the ability to completely disable. ---
[GitHub] brooklyn-server issue #812: use external config in examples
Github user duncangrant commented on the issue: https://github.com/apache/brooklyn-server/pull/812 Should we make it easier to disable the provider? That way a "live" deployment of amp would prevent it's use. So if a developer forgets to update their yaml to use a real provider it will fail to deploy. ---
