[GitHub] incubator-brooklyn pull request: replaced jython imports with guav...
Github user neykov commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1099#issuecomment-163693129 thanks @johnmccabe --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-brooklyn pull request: replaced jython imports with guav...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/1099 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-brooklyn pull request: replaced jython imports with guav...
Github user johnmccabe commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1099#issuecomment-163662599 Pushed @neykov suggestions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-brooklyn pull request: replaced jython imports with guav...
Github user sjcorbett commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1099#issuecomment-163629680 @johnmccabe Seems to be working: ``` [INFO] There are 1 checkstyle errors. [ERROR] BrooklynFeatureEnablement.java[21:1] (imports) IllegalImport: Import from illegal package - com.google.api.client.repackaged.com.google.common.base.*. ``` The check runs in the `process-classes` phase, after `compile`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-brooklyn pull request: replaced jython imports with guav...
Github user johnmccabe commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1099#issuecomment-163626961 @neykov does that checkstyle ever run? I've included the jython package and added a duff import to a class but I can't seem to get it to fail the build or generate a checkstyle report? ``` ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-brooklyn pull request: replaced jython imports with guav...
Github user neykov commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1099#issuecomment-163612109 Looks great. Worth adding the package to the `IllegalImport` list in `parent/pom.xml` so we get build failures. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-brooklyn pull request: replaced jython imports with guav...
Github user neykov commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1099#discussion_r47224141 --- Diff: usage/camp/pom.xml --- @@ -196,7 +196,6 @@ org.apache.brooklyn.* --- End diff -- You can remove the whole element, no longer needed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-brooklyn pull request: replaced jython imports with guav...
GitHub user johnmccabe opened a pull request: https://github.com/apache/incubator-brooklyn/pull/1099 replaced jython imports with guava equivalents encountered the following apparently unnecessary jython imports while looking at building the proposed split brooklyn-server repo, replaced with guava equivalents. You can merge this pull request into a Git repository by running: $ git pull https://github.com/johnmccabe/incubator-brooklyn fix/incorrect-import Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-brooklyn/pull/1099.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1099 commit 96f10e40a3665cdeedd022bd5435dfc8ebf4e9b9 Author: John McCabe Date: 2015-12-10T12:38:33Z replaced jython imports with guava equivalents --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
