Re: Podling Brpc Report Reminder - June 2020

[tan zhongyi]

https://cwiki.apache.org/confluence/display/INCUBATOR/June2020

hi, kevin & jd & von,
the pod report is almost done,
please review,
thanks.


发件人: "Kevin A. McGrail" 
日期: 2020年5月25日 星期一 上午11:01
收件人: tan zhongyi 
主题: Re: Podling Brpc Report Reminder - June 2020


:-)
On 5/24/2020 10:39 PM, tan zhongyi wrote:
Hi， Kevin，

Thanks for reminder.
I will finish the draft today.


发件人: "Kevin A. McGrail" 
答复: "priv...@brpc.apache.org" 

日期: 2020年5月24日 星期日 下午12:35
收件人: "brpc-priv...@apache.org" 

主题: Fwd: Podling Brpc Report Reminder - June 2020

Hi PMC, please let me know when the draft report is ready so I can review it!  
Hope you are all well,
KAM
--
Kevin A. McGrail
Member, Apache Software Foundation
Chair Emeritus Apache SpamAssassin Project
https://www.linkedin.com/in/kmcgrail - 703.798.0171

-- Forwarded message -
From: mailto:jmcl...@apache.org>>
Date: Sat, May 23, 2020 at 12:53 AM
Subject: Podling Brpc Report Reminder - June 2020
To: mailto:d...@brpc.incubator.apache.org>>


Dear podling,

This email was sent by an automated system on behalf of the Apache
Incubator PMC. It is an initial reminder to give you plenty of time to
prepare your quarterly board report.

The board meeting is scheduled for Wed, 17 June 2020.
The report for your podling will form a part of the Incubator PMC
report. The Incubator PMC requires your report to be submitted 2 weeks
before the board meeting, to allow sufficient time for review and
submission (Wed, June 03).

Please submit your report with sufficient time to allow the Incubator
PMC, and subsequently board members to review and digest. Again, the
very latest you should submit your report is 2 weeks prior to the board
meeting.

Candidate names should not be made public before people are actually
elected, so please do not include the names of potential committers or
PPMC members in your report.

Thanks,

The Apache Incubator PMC

Submitting your Report

--

Your report should contain the following:

*   Your project name
*   A brief description of your project, which assumes no knowledge of
the project or necessarily of its field
*   A list of the three most important issues to address in the move
towards graduation.
*   Any issues that the Incubator PMC or ASF Board might wish/need to be
aware of
*   How has the community developed since the last report
*   How has the project developed since the last report.
*   How does the podling rate their own maturity.

This should be appended to the Incubator Wiki page at:

https://cwiki.apache.org/confluence/display/INCUBATOR/June2020

Note: This is manually populated. You may need to wait a little before
this page is created from a template.

Note: The format of the report has changed to use markdown.

Mentors
---

Mentors should review reports for their project(s) and sign them off on
the Incubator wiki page. Signing off reports shows that you are
following the project - projects that are not signed may raise alarms
for the Incubator PMC.

Incubator PMC

-
To unsubscribe, e-mail: 
dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: 
dev-h...@brpc.apache.org

--

Kevin A. McGrail

kmcgr...@apache.org



Member, Apache Software Foundation

Chair Emeritus Apache SpamAssassin Project

https://www.linkedin.com/in/kmcgrail - 703.798.0171

[GitHub] [incubator-brpc] zyctree opened a new pull request #1134: fix Makefile unittest

[GitBox]

zyctree opened a new pull request #1134:
URL: https://github.com/apache/incubator-brpc/pull/1134


   seems https://github.com/apache/incubator-brpc/pull/1121 failed the unittest



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #1128: fix redis args

[GitBox]

zyearn commented on a change in pull request #1128:
URL: https://github.com/apache/incubator-brpc/pull/1128#discussion_r435827257



##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -189,7 +189,9 @@ ParseResult ParseRedisMessage(butil::IOBuf* source, Socket* 
socket,
 wopt.ignore_eovercrowded = true;
 LOG_IF(WARNING, socket->Write(, ) != 0)
 << "Fail to send redis reply";
-ctx->arena.clear();
+if (err != PARSE_ERROR_NOT_ENOUGH_DATA) {
+ctx->arena.clear();
+}

Review comment:
   好的，先去掉吧。





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org

[GitHub] [incubator-brpc] liumh8 commented on a change in pull request #1128: fix redis args

[GitBox]

liumh8 commented on a change in pull request #1128:
URL: https://github.com/apache/incubator-brpc/pull/1128#discussion_r435774755



##
File path: src/brpc/policy/redis_protocol.cpp
##
@@ -189,7 +189,9 @@ ParseResult ParseRedisMessage(butil::IOBuf* source, Socket* 
socket,
 wopt.ignore_eovercrowded = true;
 LOG_IF(WARNING, socket->Write(, ) != 0)
 << "Fail to send redis reply";
-ctx->arena.clear();
+if (err != PARSE_ERROR_NOT_ENOUGH_DATA) {
+ctx->arena.clear();
+}

Review comment:
   我先把这个修改去掉了，修复这个问题涉及到了之前说的`flush_batch`的问题，你们后续尽快一同修复一下这两个问题吧？这个pull 
request就只针对'\0'和空串的问题。





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org