[GitHub] [incubator-brpc] wasphin commented on issue #742: 树莓派上的编译问题
wasphin commented on issue #742: URL: https://github.com/apache/incubator-brpc/issues/742#issuecomment-655915774 @jamesge 不支持 32 位系统是因为使用了什么 32 位系统中不支持的特性还是只是因为使用场景少而没考虑该问题? 有这方面的什么考虑吗? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] gydong commented on issue #1154: 支持设置tcp_user_timeout
gydong commented on issue #1154: URL: https://github.com/apache/incubator-brpc/issues/1154#issuecomment-655858507 可以开启一下熔断功能，时间就变成可控的了 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] jamesge commented on a change in pull request #1156: fix_share_tls_block
jamesge commented on a change in pull request #1156:
URL: https://github.com/apache/incubator-brpc/pull/1156#discussion_r451671247
##
File path: src/butil/iobuf.cpp
##
@@ -366,9 +366,13 @@ inline IOBuf::Block* share_tls_block() {
}
IOBuf::Block* new_block = NULL;
if (b) {
-new_block = b->portal_next;
-b->dec_ref();
---tls_data.num_blocks;
+new_block = b;
+while (new_block && new_block->full()) {
+IOBuf::Block* const saved_next = new_block->portal_next;
+new_block->dec_ref();
Review comment:
出现new_block->full的场景是什么？可以补充UT么？
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [VOTE] Release Apache brpc(incubating) 0.9.8-rc01
+1 binding. | | lhestz | | lhe...@163.com | 签名由网易邮箱大师定制 On 7/8/2020 18:35，JiashunZhu wrote： +1 binding. I have checked: - DISCLAIMER present - Hashes okay - NOTICE present - No unexpected binary files - Building passed on macos10.15.2 牟盖东 于2020年7月8日周三 下午6:24写道： +1（binding） tan zhongyi 于2020年7月8日周三 下午5:01写道： Hi, guys, 0.9.8-rc01 is ready for vote, here it is. Thanks helei，he made the build. I am pleased to be calling this vote for the release of apache brpc(incubating) 0.9.8-rc01. The source code can be found at: https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/incubator-brpc-0.9.8-rc01.tar.gz The release candidate has been tagged in GitHub as 0.9.8-rc01, available here: https://github.com/apache/incubator-brpc/releases/tag/0.9.8-rc01 The SHA-512 checksum is: 972744e0915b2bf881ad04bae393761170bf91003b44c82dff8ba5306e8081abb5c4108c469a58ac4e4162838a04191fcf681594d89a7d97bbbfa0943cc2f41d which can be found via: https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/incubator-brpc-0.9.8-rc01.tar.gz.sha512 The signature can be found via: https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/incubator-brpc-0.9.8-rc01.tar.gz.asc KEYS file is available here: https://dist.apache.org/repos/dist/dev/incubator/brpc/KEYS [Release Note] * Fix bug that time unit is not listed in grpc timeout options. https://github.com/apache/incubator-brpc/pull/1036 * Fix heap overflow in simple_data_pool https://github.com/apache/incubator-brpc/pull/1056 * Make args of redis protocol be StringPiece https://github.com/apache/incubator-brpc/pull/1128 * Support the length of redis args could be zero https://github.com/apache/incubator-brpc/pull/1128 * Optimize code in timer_thread https://github.com/apache/incubator-brpc/pull/1137/files * Fix a narrowing warning on aarch64 https://github.com/apache/incubator-brpc/commit/87f149c464ea0322a5b59d040bb80e7847f365be * Make pthread_atfork not registered in child process https://github.com/apache/incubator-brpc/commit/2f8fc37d52c2a02ee6f348aaa52c7ded4a4844c3 * Rename LOG_NONE which conflicts with a name in mysql https://github.com/apache/incubator-brpc/commit/e3840c18cdd9e1ff81f8280b96ac14869007a122 * Fix several warnings under MAC https://github.com/apache/incubator-brpc/commit/f8c188a7a5186c2d43a20735ad175a32b39788a3 * Ignore ELIMIT for circuit breaker https://github.com/apache/incubator-brpc/pull/1005 * limit minimum value of max_concurrency for auto_cl https://github.com/apache/incubator-brpc/pull/1003 Please vote on releasing this package as: Apache brpc(incubating) 0.9.8-rc01 This vote will be open until “Tuesday July 14 2020 00:00:00 GMT+0800 (CST)" and passes if a majority of at least three +1 Apache brpc IPMC votes are cast. [ ] +1 Release this package [ ] 0 I don't feel strongly about it, but don't object [ ] -1 Do not release this package because... Checklist for reference: [ ]Are release files in correct location? [ ]Do release files have the word incubating in their name? [ ] Are the digital signature and hashes correct? [ ] Does DISCLAIMER file exist? [ ]Do LICENSE and NOTICE files exists? [ ] Is the LICENSE and NOTICE text correct? [ ] Is the NOTICE year correct? [ ] Un-included software dependencies are not mentioned in LICENSE or NOTICE? [ ] License information is not mentioned in NOTICE? Is there any 3rd party code contained inside the release? If so: [ ] Does the software have a compatible license? [ ] Are all software licenses mentioned in LICENSE? [ ] Is the full text of the licenses (or pointers to it) in LICENSE? Is any of this code Apache licensed? Do they have NOTICE files? If so: [ ]Have relevant parts of those NOTICE files been added to this NOTICE file? [ ]Do all source files have ASF headers? [ ] Do the contents of the release match with what's tagged in version control? [ ] Are there any unexpected binary files in the release? [ ] Can you compile from source? Are the instruction clear? Anyone can participate in testing and voting, not just committers, please feel free to try out the release candidate and provide your votes. Thanks -- Jiashun Zhu
Re: [VOTE] Release Apache brpc(incubating) 0.9.8-rc01
+1 binding. I have checked: - DISCLAIMER present - Hashes okay - NOTICE present - No unexpected binary files - Building passed on macos10.15.2 牟盖东 于2020年7月8日周三 下午6:24写道： > +1（binding） > > tan zhongyi 于2020年7月8日周三 下午5:01写道： > > > Hi, guys, > > > > > > > > 0.9.8-rc01 is ready for vote, here it is. Thanks helei，he made the build. > > > > > > > > I am pleased to be calling this vote for the release of apache > > brpc(incubating) 0.9.8-rc01. > > > > > > > > The source code can be found at: > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/incubator-brpc-0.9.8-rc01.tar.gz > > > > > > > > The release candidate has been tagged in GitHub as 0.9.8-rc01, available > > here: > > > > https://github.com/apache/incubator-brpc/releases/tag/0.9.8-rc01 > > > > > > > > The SHA-512 checksum is: > > > > > > > 972744e0915b2bf881ad04bae393761170bf91003b44c82dff8ba5306e8081abb5c4108c469a58ac4e4162838a04191fcf681594d89a7d97bbbfa0943cc2f41d > > > > > > > > which can be found via: > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/incubator-brpc-0.9.8-rc01.tar.gz.sha512 > > > > > > > > The signature can be found via: > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/incubator-brpc-0.9.8-rc01.tar.gz.asc > > > > > > > > KEYS file is available here: > > > > https://dist.apache.org/repos/dist/dev/incubator/brpc/KEYS > > > > [Release Note] > > * Fix bug that time unit is not listed in grpc timeout options. > > https://github.com/apache/incubator-brpc/pull/1036 > > * Fix heap overflow in simple_data_pool > > https://github.com/apache/incubator-brpc/pull/1056 > > * Make args of redis protocol be StringPiece > > https://github.com/apache/incubator-brpc/pull/1128 > > * Support the length of redis args could be zero > > https://github.com/apache/incubator-brpc/pull/1128 > > * Optimize code in timer_thread > > https://github.com/apache/incubator-brpc/pull/1137/files > > * Fix a narrowing warning on aarch64 > > > > > https://github.com/apache/incubator-brpc/commit/87f149c464ea0322a5b59d040bb80e7847f365be > > * Make pthread_atfork not registered in child process > > > > > https://github.com/apache/incubator-brpc/commit/2f8fc37d52c2a02ee6f348aaa52c7ded4a4844c3 > > * Rename LOG_NONE which conflicts with a name in mysql > > > > > https://github.com/apache/incubator-brpc/commit/e3840c18cdd9e1ff81f8280b96ac14869007a122 > > * Fix several warnings under MAC > > > > > https://github.com/apache/incubator-brpc/commit/f8c188a7a5186c2d43a20735ad175a32b39788a3 > > * Ignore ELIMIT for circuit breaker > > https://github.com/apache/incubator-brpc/pull/1005 > > * limit minimum value of max_concurrency for auto_cl > > https://github.com/apache/incubator-brpc/pull/1003 > > > > > > Please vote on releasing this package as: > > Apache brpc(incubating) 0.9.8-rc01 > > > > This vote will be open until “Tuesday July 14 2020 00:00:00 GMT+0800 > > (CST)" and > > passes if a majority of at least three +1 Apache brpc IPMC votes are > > cast. > > > > [ ] +1 Release this package > > [ ] 0 I don't feel strongly about it, but don't object > > [ ] -1 Do not release this package because... > > > > Checklist for reference: > > [ ]Are release files in correct location? > > [ ]Do release files have the word incubating in their name? > > [ ] Are the digital signature and hashes correct? > > [ ] Does DISCLAIMER file exist? > > [ ]Do LICENSE and NOTICE files exists? > > [ ] Is the LICENSE and NOTICE text correct? > > [ ] Is the NOTICE year correct? > > [ ] Un-included software dependencies are not mentioned in LICENSE or > > NOTICE? > > [ ] License information is not mentioned in NOTICE? > > Is there any 3rd party code contained inside the release? If so: > > [ ] Does the software have a compatible license? > > [ ] Are all software licenses mentioned in LICENSE? > > [ ] Is the full text of the licenses (or pointers to it) in LICENSE? > > Is any of this code Apache licensed? Do they have NOTICE files? If so: > > [ ]Have relevant parts of those NOTICE files been added to this NOTICE > > file? > > [ ]Do all source files have ASF headers? > > [ ] Do the contents of the release match with what's tagged in version > > control? > > [ ] Are there any unexpected binary files in the release? > > [ ] Can you compile from source? Are the instruction clear? > > > > > > Anyone can participate in testing and voting, not just committers, please > > feel free to try out the release candidate and provide your votes. > > > > Thanks > > > > > -- Jiashun Zhu
Re: [VOTE] Release Apache brpc(incubating) 0.9.8-rc01
+1（binding） tan zhongyi 于2020年7月8日周三 下午5:01写道： > Hi, guys, > > > > 0.9.8-rc01 is ready for vote, here it is. Thanks helei，he made the build. > > > > I am pleased to be calling this vote for the release of apache > brpc(incubating) 0.9.8-rc01. > > > > The source code can be found at: > > > https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/incubator-brpc-0.9.8-rc01.tar.gz > > > > The release candidate has been tagged in GitHub as 0.9.8-rc01, available > here: > > https://github.com/apache/incubator-brpc/releases/tag/0.9.8-rc01 > > > > The SHA-512 checksum is: > > > 972744e0915b2bf881ad04bae393761170bf91003b44c82dff8ba5306e8081abb5c4108c469a58ac4e4162838a04191fcf681594d89a7d97bbbfa0943cc2f41d > > > > which can be found via: > > > https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/incubator-brpc-0.9.8-rc01.tar.gz.sha512 > > > > The signature can be found via: > > > https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/incubator-brpc-0.9.8-rc01.tar.gz.asc > > > > KEYS file is available here: > > https://dist.apache.org/repos/dist/dev/incubator/brpc/KEYS > > [Release Note] > * Fix bug that time unit is not listed in grpc timeout options. > https://github.com/apache/incubator-brpc/pull/1036 > * Fix heap overflow in simple_data_pool > https://github.com/apache/incubator-brpc/pull/1056 > * Make args of redis protocol be StringPiece > https://github.com/apache/incubator-brpc/pull/1128 > * Support the length of redis args could be zero > https://github.com/apache/incubator-brpc/pull/1128 > * Optimize code in timer_thread > https://github.com/apache/incubator-brpc/pull/1137/files > * Fix a narrowing warning on aarch64 > > https://github.com/apache/incubator-brpc/commit/87f149c464ea0322a5b59d040bb80e7847f365be > * Make pthread_atfork not registered in child process > > https://github.com/apache/incubator-brpc/commit/2f8fc37d52c2a02ee6f348aaa52c7ded4a4844c3 > * Rename LOG_NONE which conflicts with a name in mysql > > https://github.com/apache/incubator-brpc/commit/e3840c18cdd9e1ff81f8280b96ac14869007a122 > * Fix several warnings under MAC > > https://github.com/apache/incubator-brpc/commit/f8c188a7a5186c2d43a20735ad175a32b39788a3 > * Ignore ELIMIT for circuit breaker > https://github.com/apache/incubator-brpc/pull/1005 > * limit minimum value of max_concurrency for auto_cl > https://github.com/apache/incubator-brpc/pull/1003 > > > Please vote on releasing this package as: > Apache brpc(incubating) 0.9.8-rc01 > > This vote will be open until “Tuesday July 14 2020 00:00:00 GMT+0800 > (CST)" and > passes if a majority of at least three +1 Apache brpc IPMC votes are > cast. > > [ ] +1 Release this package > [ ] 0 I don't feel strongly about it, but don't object > [ ] -1 Do not release this package because... > > Checklist for reference: > [ ]Are release files in correct location? > [ ]Do release files have the word incubating in their name? > [ ] Are the digital signature and hashes correct? > [ ] Does DISCLAIMER file exist? > [ ]Do LICENSE and NOTICE files exists? > [ ] Is the LICENSE and NOTICE text correct? > [ ] Is the NOTICE year correct? > [ ] Un-included software dependencies are not mentioned in LICENSE or > NOTICE? > [ ] License information is not mentioned in NOTICE? > Is there any 3rd party code contained inside the release? If so: > [ ] Does the software have a compatible license? > [ ] Are all software licenses mentioned in LICENSE? > [ ] Is the full text of the licenses (or pointers to it) in LICENSE? > Is any of this code Apache licensed? Do they have NOTICE files? If so: > [ ]Have relevant parts of those NOTICE files been added to this NOTICE > file? > [ ]Do all source files have ASF headers? > [ ] Do the contents of the release match with what's tagged in version > control? > [ ] Are there any unexpected binary files in the release? > [ ] Can you compile from source? Are the instruction clear? > > > Anyone can participate in testing and voting, not just committers, please > feel free to try out the release candidate and provide your votes. > > Thanks > >
[GitHub] [incubator-brpc] zyearn commented on a change in pull request #1156: fix_share_tls_block
zyearn commented on a change in pull request #1156:
URL: https://github.com/apache/incubator-brpc/pull/1156#discussion_r451438135
##
File path: src/butil/iobuf.cpp
##
@@ -366,9 +366,13 @@ inline IOBuf::Block* share_tls_block() {
}
IOBuf::Block* new_block = NULL;
if (b) {
-new_block = b->portal_next;
-b->dec_ref();
---tls_data.num_blocks;
+new_block = b;
+while (new_block && new_block->full()) {
+IOBuf::Block* const saved_next = new_block->portal_next;
+new_block->dec_ref();
Review comment:
Block的构造函数会把ref初始化成1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] lacey1102 opened a new pull request #1157: fix socket conn stat err and memory leak when discard socket
lacey1102 opened a new pull request #1157: URL: https://github.com/apache/incubator-brpc/pull/1157 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[VOTE] Release Apache brpc(incubating) 0.9.8-rc01
Hi, guys, 0.9.8-rc01 is ready for vote, here it is. Thanks helei，he made the build. I am pleased to be calling this vote for the release of apache brpc(incubating) 0.9.8-rc01. The source code can be found at: https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/incubator-brpc-0.9.8-rc01.tar.gz The release candidate has been tagged in GitHub as 0.9.8-rc01, available here: https://github.com/apache/incubator-brpc/releases/tag/0.9.8-rc01 The SHA-512 checksum is: 972744e0915b2bf881ad04bae393761170bf91003b44c82dff8ba5306e8081abb5c4108c469a58ac4e4162838a04191fcf681594d89a7d97bbbfa0943cc2f41d which can be found via: https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/incubator-brpc-0.9.8-rc01.tar.gz.sha512 The signature can be found via: https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/incubator-brpc-0.9.8-rc01.tar.gz.asc KEYS file is available here: https://dist.apache.org/repos/dist/dev/incubator/brpc/KEYS [Release Note] * Fix bug that time unit is not listed in grpc timeout options. https://github.com/apache/incubator-brpc/pull/1036 * Fix heap overflow in simple_data_pool https://github.com/apache/incubator-brpc/pull/1056 * Make args of redis protocol be StringPiece https://github.com/apache/incubator-brpc/pull/1128 * Support the length of redis args could be zero https://github.com/apache/incubator-brpc/pull/1128 * Optimize code in timer_thread https://github.com/apache/incubator-brpc/pull/1137/files * Fix a narrowing warning on aarch64 https://github.com/apache/incubator-brpc/commit/87f149c464ea0322a5b59d040bb80e7847f365be * Make pthread_atfork not registered in child process https://github.com/apache/incubator-brpc/commit/2f8fc37d52c2a02ee6f348aaa52c7ded4a4844c3 * Rename LOG_NONE which conflicts with a name in mysql https://github.com/apache/incubator-brpc/commit/e3840c18cdd9e1ff81f8280b96ac14869007a122 * Fix several warnings under MAC https://github.com/apache/incubator-brpc/commit/f8c188a7a5186c2d43a20735ad175a32b39788a3 * Ignore ELIMIT for circuit breaker https://github.com/apache/incubator-brpc/pull/1005 * limit minimum value of max_concurrency for auto_cl https://github.com/apache/incubator-brpc/pull/1003 Please vote on releasing this package as: Apache brpc(incubating) 0.9.8-rc01 This vote will be open until “Tuesday July 14 2020 00:00:00 GMT+0800 (CST)" and passes if a majority of at least three +1 Apache brpc IPMC votes are cast. [ ] +1 Release this package [ ] 0 I don't feel strongly about it, but don't object [ ] -1 Do not release this package because... Checklist for reference: [ ]Are release files in correct location? [ ]Do release files have the word incubating in their name? [ ] Are the digital signature and hashes correct? [ ] Does DISCLAIMER file exist? [ ]Do LICENSE and NOTICE files exists? [ ] Is the LICENSE and NOTICE text correct? [ ] Is the NOTICE year correct? [ ] Un-included software dependencies are not mentioned in LICENSE or NOTICE? [ ] License information is not mentioned in NOTICE? Is there any 3rd party code contained inside the release? If so: [ ] Does the software have a compatible license? [ ] Are all software licenses mentioned in LICENSE? [ ] Is the full text of the licenses (or pointers to it) in LICENSE? Is any of this code Apache licensed? Do they have NOTICE files? If so: [ ]Have relevant parts of those NOTICE files been added to this NOTICE file? [ ]Do all source files have ASF headers? [ ] Do the contents of the release match with what's tagged in version control? [ ] Are there any unexpected binary files in the release? [ ] Can you compile from source? Are the instruction clear? Anyone can participate in testing and voting, not just committers, please feel free to try out the release candidate and provide your votes. Thanks
[GitHub] [incubator-brpc] gydong commented on a change in pull request #1156: fix_share_tls_block
gydong commented on a change in pull request #1156:
URL: https://github.com/apache/incubator-brpc/pull/1156#discussion_r451384967
##
File path: src/butil/iobuf.cpp
##
@@ -366,9 +366,13 @@ inline IOBuf::Block* share_tls_block() {
}
IOBuf::Block* new_block = NULL;
if (b) {
-new_block = b->portal_next;
-b->dec_ref();
---tls_data.num_blocks;
+new_block = b;
+while (new_block && new_block->full()) {
+IOBuf::Block* const saved_next = new_block->portal_next;
+new_block->dec_ref();
Review comment:
这里为啥引用减1，它对应的inc_ref是哪里了？
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] ming-relax commented on issue #1099: bthread
ming-relax commented on issue #1099: URL: https://github.com/apache/incubator-brpc/issues/1099#issuecomment-655344470 【那个bthread用std::mutex导致死锁的问题】请问这个是什么问题，现有的 issue 上也没有搜到 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
