[GitHub] [incubator-brpc] darionyaphet opened a new pull request #1297: fix ErrorToString
darionyaphet opened a new pull request #1297: URL: https://github.com/apache/incubator-brpc/pull/1297 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Podling Brpc Report Reminder - December 2020
Dear podling, This email was sent by an automated system on behalf of the Apache Incubator PMC. It is an initial reminder to give you plenty of time to prepare your quarterly board report. The board meeting is scheduled for Wed, 16 December 2020. The report for your podling will form a part of the Incubator PMC report. The Incubator PMC requires your report to be submitted 2 weeks before the board meeting, to allow sufficient time for review and submission (Wed, December 02). Please submit your report with sufficient time to allow the Incubator PMC, and subsequently board members to review and digest. Again, the very latest you should submit your report is 2 weeks prior to the board meeting. Candidate names should not be made public before people are actually elected, so please do not include the names of potential committers or PPMC members in your report. Thanks, The Apache Incubator PMC Submitting your Report -- Your report should contain the following: * Your project name * A brief description of your project, which assumes no knowledge of the project or necessarily of its field * A list of the three most important issues to address in the move towards graduation. * Any issues that the Incubator PMC or ASF Board might wish/need to be aware of * How has the community developed since the last report * How has the project developed since the last report. * How does the podling rate their own maturity. This should be appended to the Incubator Wiki page at: https://cwiki.apache.org/confluence/display/INCUBATOR/December2020 Note: This is manually populated. You may need to wait a little before this page is created from a template. Note: The format of the report has changed to use markdown. Mentors --- Mentors should review reports for their project(s) and sign them off on the Incubator wiki page. Signing off reports shows that you are following the project - projects that are not signed may raise alarms for the Incubator PMC. Incubator PMC - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] Tuvie commented on a change in pull request #1002: fix two bugs about rdma
Tuvie commented on a change in pull request #1002:
URL: https://github.com/apache/incubator-brpc/pull/1002#discussion_r532154596
##
File path: src/brpc/server.cpp
##
@@ -1055,16 +1055,16 @@ int Server::StartInternal(const butil::ip_t& ip,
return -1;
}
std::unique_ptr rh;
+butil::EndPoint internal_point = _listen_addr;
+internal_point.port = _options.internal_port;
if (_options.use_rdma) {
-rh.reset(rdma::RdmaCommunicationManager::Listen(_listen_addr));
+rh.reset(rdma::RdmaCommunicationManager::Listen(internal_point));
Review comment:
这是之前的一个bug，会对_listen_addr重复监听。internal_point没有必要启用rdma。新代码我移除了这块。
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[incubator-brpc] branch master updated: Use = as non-json sep; Rename LOG* macros to CLOG*
This is an automated email from the ASF dual-hosted git repository.
jamesge pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git
The following commit(s) were added to refs/heads/master by this push:
new d06e330 Use = as non-json sep; Rename LOG* macros to CLOG*
d06e330 is described below
commit d06e330533dacb44ecf0282dd7cc0b62307fda4f
Author: jamesge
AuthorDate: Sun Nov 29 13:56:35 2020 +0800
Use = as non-json sep; Rename LOG* macros to CLOG*
---
src/brpc/controller.cpp | 2 +-
src/brpc/controller.h | 15 ---
test/brpc_controller_unittest.cpp | 6 +++---
3 files changed, 12 insertions(+), 11 deletions(-)
diff --git a/src/brpc/controller.cpp b/src/brpc/controller.cpp
index e88e3e1..a3c77e0 100644
--- a/src/brpc/controller.cpp
+++ b/src/brpc/controller.cpp
@@ -1509,7 +1509,7 @@ KVMap& Controller::SessionKV() {
#define BRPC_SESSION_END_MSG "Session ends."
#define BRPC_REQ_ID "@rid"
-#define BRPC_KV_SEP ":"
+#define BRPC_KV_SEP "="
void Controller::FlushSessionKV(std::ostream& os) {
if (_session_kv == nullptr || _session_kv->Count() == 0) {
diff --git a/src/brpc/controller.h b/src/brpc/controller.h
index b1689cf..9118633 100755
--- a/src/brpc/controller.h
+++ b/src/brpc/controller.h
@@ -814,12 +814,13 @@ std::ostream& operator<<(std::ostream& os, const
Controller::LogPrefixDummy& p);
} // namespace brpc
-// Print logs appended with @rid which is got from "x-request-id"(set
-// -request_id_header to change) in http header by default
-#define LOGD(cntl) LOG(DEBUG) << (cntl)->LogPrefix()
-#define LOGI(cntl) LOG(INFO) << (cntl)->LogPrefix()
-#define LOGW(cntl) LOG(WARNING) << (cntl)->LogPrefix()
-#define LOGE(cntl) LOG(ERROR) << (cntl)->LogPrefix()
-#define LOGF(cntl) LOG(FATAL) << (cntl)->LogPrefix()
+// Print contextual logs with @rid which is got from "x-request-id"(changable
+// by -request_id_header) in http header by default
+#define CLOGD(cntl) LOG(DEBUG) << (cntl)->LogPrefix()
+#define CLOGI(cntl) LOG(INFO) << (cntl)->LogPrefix()
+#define CLOGW(cntl) LOG(WARNING) << (cntl)->LogPrefix()
+#define CLOGE(cntl) LOG(ERROR) << (cntl)->LogPrefix()
+#define CLOGF(cntl) LOG(FATAL) << (cntl)->LogPrefix()
+#define CVLOG(v, cntl) VLOG(v) << (cntl)->LogPrefix()
#endif // BRPC_CONTROLLER_H
diff --git a/test/brpc_controller_unittest.cpp
b/test/brpc_controller_unittest.cpp
index 9b999b9..0def06d 100644
--- a/test/brpc_controller_unittest.cpp
+++ b/test/brpc_controller_unittest.cpp
@@ -117,14 +117,14 @@ TEST_F(ControllerTest, SessionKV) {
cntl.SessionKV().Set("Cisco", 33.33);
-LOGW(&cntl) << "My WARNING Log";
+CLOGW(&cntl) << "My WARNING Log";
ASSERT_TRUE(endsWith(sink1, "] My WARNING Log")) << sink1;
ASSERT_TRUE(startsWith(sink1, "W")) << sink1;
sink1.clear();
cntl.http_request().SetHeader("x-request-id", "abcdEFG-456");
-LOGE(&cntl) << "My ERROR Log";
-ASSERT_TRUE(endsWith(sink1, "] @rid:abcdEFG-456 My ERROR Log")) <<
sink1;
+CLOGE(&cntl) << "My ERROR Log";
+ASSERT_TRUE(endsWith(sink1, "] @rid=abcdEFG-456 My ERROR Log")) <<
sink1;
ASSERT_TRUE(startsWith(sink1, "E")) << sink1;
sink1.clear();
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
