[GitHub] [incubator-brpc] kungf commented on issue #1086: 使用cmake依赖brpc编译成功，运行报undefined symbol: pthread_mutex_lock
kungf commented on issue #1086: URL: https://github.com/apache/incubator-brpc/issues/1086#issuecomment-736276326 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] Pating commented on issue #1296: brpc rdma异常
Pating commented on issue #1296: URL: https://github.com/apache/incubator-brpc/issues/1296#issuecomment-736151597 > This should be a bug when initialize rdma CQ with incorrect queue index ID. > I will commit a patch for that soon and you can retry. > > Thanks for the feedback. Thansk, look forward to your patch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] Pating removed a comment on issue #1296: brpc rdma异常
Pating removed a comment on issue #1296: URL: https://github.com/apache/incubator-brpc/issues/1296#issuecomment-736151075 > This should be a bug when initialize rdma CQ with incorrect queue index ID. > I will commit a patch for that soon and you can retry. > > Thanks for the feedback. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] Pating closed issue #1296: brpc rdma异常
Pating closed issue #1296: URL: https://github.com/apache/incubator-brpc/issues/1296 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] Pating commented on issue #1296: brpc rdma异常
Pating commented on issue #1296: URL: https://github.com/apache/incubator-brpc/issues/1296#issuecomment-736151075 > This should be a bug when initialize rdma CQ with incorrect queue index ID. > I will commit a patch for that soon and you can retry. > > Thanks for the feedback. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] jamesge merged pull request #1291: make butil::ScopedVector support std::initializer_list
jamesge merged pull request #1291: URL: https://github.com/apache/incubator-brpc/pull/1291 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[incubator-brpc] branch master updated (29ab898 -> 8ff49b3)
This is an automated email from the ASF dual-hosted git repository. jamesge pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git. from 29ab898 Merge pull request #1295 from lrita/l_s new 6d06398 make butil::ScopedVector support initializer_list new cd6fc15 make butil::ScopedVector support initializer_list new 1c02d48 remove #include in scoped_vector.h new 8ff49b3 Merge pull request #1291 from lrita/l_m The 2153 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/butil/memory/scoped_vector.h | 3 +++ test/scoped_vector_unittest.cc | 11 +++ 2 files changed, 14 insertions(+) - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[incubator-brpc] branch master updated (e64eb3c -> 29ab898)
This is an automated email from the ASF dual-hosted git repository. jamesge pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git. from e64eb3c partial fix for profiling under MacOS, symbols are not shown yet(even with llvm-symbolizer) new 1015264 make butil::BasicStringPiece support string split functions-family new 32c05be make butil::BasicStringPiece support string split functions-family new 29ab898 Merge pull request #1295 from lrita/l_s The 2149 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/butil/strings/string_piece.h | 7 +++ src/butil/strings/string_split.cc | 103 -- src/butil/strings/string_split.h | 28 +++ src/butil/strings/string_util.cc | 21 +++- src/butil/strings/string_util.h | 11 +++- test/string_split_unittest.cc | 64 +++ 6 files changed, 218 insertions(+), 16 deletions(-) - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] jamesge merged pull request #1295: make butil::BasicStringPiece support string split functions-family
jamesge merged pull request #1295: URL: https://github.com/apache/incubator-brpc/pull/1295 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[incubator-brpc] branch master updated (9320f1c -> e64eb3c)
This is an automated email from the ASF dual-hosted git repository. jamesge pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git. from 9320f1c Merge pull request #1298 from apache/fix_bazel_on_macos new 61667b2 more accurate assertion new e64eb3c partial fix for profiling under MacOS, symbols are not shown yet(even with llvm-symbolizer) The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/brpc/builtin/hotspots_service.cpp | 7 +-- test/baidu_thread_local_unittest.cpp | 6 +++--- test/brpc_builtin_service_unittest.cpp | 6 +++--- 3 files changed, 11 insertions(+), 8 deletions(-) - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[incubator-brpc] 02/02: partial fix for profiling under MacOS, symbols are not shown yet(even with llvm-symbolizer)
This is an automated email from the ASF dual-hosted git repository.
jamesge pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git
commit e64eb3ce15359263aabf2254379c9130ccff7929
Author: jamesge
AuthorDate: Mon Nov 30 21:33:20 2020 +0800
partial fix for profiling under MacOS, symbols are not shown yet(even with
llvm-symbolizer)
---
src/brpc/builtin/hotspots_service.cpp | 7 +--
test/brpc_builtin_service_unittest.cpp | 6 +++---
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/src/brpc/builtin/hotspots_service.cpp
b/src/brpc/builtin/hotspots_service.cpp
index b4e8fcf..7f23a0b 100644
--- a/src/brpc/builtin/hotspots_service.cpp
+++ b/src/brpc/builtin/hotspots_service.cpp
@@ -376,6 +376,7 @@ static void NotifyWaiters(ProfilingType type, const
Controller* cur_cntl,
}
#if defined(OS_MACOSX)
+static const char* s_pprof_binary_path = nullptr;
static bool check_GOOGLE_PPROF_BINARY_PATH() {
char* str = getenv("GOOGLE_PPROF_BINARY_PATH");
if (str == NULL) {
@@ -385,6 +386,7 @@ static bool check_GOOGLE_PPROF_BINARY_PATH() {
if (fd < 0) {
return false;
}
+s_pprof_binary_path = strdup(str);
return true;
}
@@ -491,13 +493,13 @@ static void DisplayResult(Controller* cntl,
}
cmd_builder << " 2>&1 ";
#elif defined(OS_MACOSX)
-cmd_builder << getenv("GOOGLE_PPROF_BINARY_PATH") << " "
+cmd_builder << s_pprof_binary_path << " "
<< DisplayTypeToPProfArgument(display_type)
<< (show_ccount ? " -contentions " : "");
if (base_name) {
cmd_builder << "-base " << *base_name << ' ';
}
-cmd_builder << prof_name << " 2>&1 ";
+cmd_builder << GetProgramName() << " " << prof_name << " 2>&1 ";
#endif
const std::string cmd = cmd_builder.str();
@@ -517,6 +519,7 @@ static void DisplayResult(Controller* cntl,
errno = 0; // read_command_output may not set errno, clear it to make
sure if
// we see non-zero errno, it's real error.
butil::IOBufBuilder pprof_output;
+RPC_VLOG << "Running cmd=" << cmd;
const int rc = butil::read_command_output(pprof_output, cmd.c_str());
if (rc != 0) {
butil::FilePath pprof_path(pprof_tool);
diff --git a/test/brpc_builtin_service_unittest.cpp
b/test/brpc_builtin_service_unittest.cpp
index d9a24a8..21f6f50 100644
--- a/test/brpc_builtin_service_unittest.cpp
+++ b/test/brpc_builtin_service_unittest.cpp
@@ -663,15 +663,15 @@ TEST_F(BuiltinServiceTest, pprof) {
ClosureChecker done;
brpc::Controller cntl;
service.heap(, NULL, NULL, );
-const int rc = getenv("TCMALLOC_SAMPLE_PARAMETER") ? 0 :
brpc::ENOMETHOD;
-EXPECT_EQ(rc, cntl.ErrorCode());
+const int rc = getenv("TCMALLOC_SAMPLE_PARAMETER") != nullptr ? 0 :
brpc::ENOMETHOD;
+EXPECT_EQ(rc, cntl.ErrorCode()) << cntl.ErrorText();
}
{
ClosureChecker done;
brpc::Controller cntl;
service.growth(, NULL, NULL, );
// linked tcmalloc in UT
-EXPECT_EQ(0, cntl.ErrorCode());
+EXPECT_EQ(0, cntl.ErrorCode()) << cntl.ErrorText();
}
{
ClosureChecker done;
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[incubator-brpc] 01/02: more accurate assertion
This is an automated email from the ASF dual-hosted git repository.
jamesge pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git
commit 61667b29b7d944eae8702c0ddf330c4975894c25
Author: jamesge
AuthorDate: Mon Nov 30 21:32:26 2020 +0800
more accurate assertion
---
test/baidu_thread_local_unittest.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/test/baidu_thread_local_unittest.cpp
b/test/baidu_thread_local_unittest.cpp
index 7ffe0f5..01209b6 100644
--- a/test/baidu_thread_local_unittest.cpp
+++ b/test/baidu_thread_local_unittest.cpp
@@ -166,17 +166,17 @@ void fun2() {
}
void fun3(void* arg) {
-get_oss() << "fun3(" << arg << ")" << std::endl;
+get_oss() << "fun3(" << (uintptr_t)arg << ")" << std::endl;
}
void fun4(void* arg) {
-get_oss() << "fun4(" << arg << ")" << std::endl;
+get_oss() << "fun4(" << (uintptr_t)arg << ")" << std::endl;
}
static void check_result() {
// Don't use gtest function since this function might be invoked when the
main
// thread quits, instances required by gtest functions are likely destroyed.
- assert (get_oss().str() == "fun4(0)\nfun3(0x2)\nfun2\n");
+ assert(get_oss().str() == "fun4(0)\nfun3(2)\nfun2\n");
}
TEST_F(BaiduThreadLocalTest, call_order_and_cancel) {
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[incubator-brpc] branch master updated (31eba30 -> 9320f1c)
This is an automated email from the ASF dual-hosted git repository. zychen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git. from 31eba30 change travis-ci.org to travis-ci.com add 3feb6d0 Fix bazel build in macos add ffbf054 Add zlib as an external dependency new 9320f1c Merge pull request #1298 from apache/fix_bazel_on_macos The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .bazelrc | 3 +++ BUILD| 14 ++-- WORKSPACE| 36 +++ openssl.BUILD| 41 src/brpc/span.h | 2 +- src/bthread/key.cpp | 2 +- src/bthread/task_group.cpp | 2 +- src/butil/find_cstr.cpp | 2 +- src/butil/find_cstr.h| 2 +- test/baidu_thread_local_unittest.cpp | 4 +++- test/bthread_futex_unittest.cpp | 1 + test/file_util_unittest.cc | 4 ++-- zlib.BUILD | 8 +++ 13 files changed, 103 insertions(+), 18 deletions(-) create mode 100644 openssl.BUILD create mode 100644 zlib.BUILD - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] chenzhangyi merged pull request #1298: Fix bazel build in macos
chenzhangyi merged pull request #1298: URL: https://github.com/apache/incubator-brpc/pull/1298 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] chenzhangyi closed issue #1260: Formal Bazel BUILD requests
chenzhangyi closed issue #1260: URL: https://github.com/apache/incubator-brpc/issues/1260 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[incubator-brpc] 01/01: Merge pull request #1298 from apache/fix_bazel_on_macos
This is an automated email from the ASF dual-hosted git repository. zychen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git commit 9320f1c07e8a89f0631d45a402a262207cf728bd Merge: 31eba30 ffbf054 Author: Zhangyi Chen AuthorDate: Mon Nov 30 16:17:53 2020 +0800 Merge pull request #1298 from apache/fix_bazel_on_macos Fix bazel build in macos .bazelrc | 3 +++ BUILD| 14 ++-- WORKSPACE| 36 +++ openssl.BUILD| 41 src/brpc/span.h | 2 +- src/bthread/key.cpp | 2 +- src/bthread/task_group.cpp | 2 +- src/butil/find_cstr.cpp | 2 +- src/butil/find_cstr.h| 2 +- test/baidu_thread_local_unittest.cpp | 4 +++- test/bthread_futex_unittest.cpp | 1 + test/file_util_unittest.cc | 4 ++-- zlib.BUILD | 8 +++ 13 files changed, 103 insertions(+), 18 deletions(-) - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
