Re: Cannot find successful vote for brpc 0.9.6
Ok，I will fire a service ticket to track this 在 2021/11/24 下午6:25，“sebb” 写入: You will need to ask Infra to do this On Wed, 24 Nov 2021 at 03:03, tan zhongyi wrote: > > Just confirmed with the team. > > > > 0.9.6 is our first internal release, but it did not go through the vote process in the general@incubator mail list. > > We want to delete it, but don’t know how to remove it from archive. > > > > Hi, Sebb, > > please help us to remove it from archive, > > Thanks > > > > > > 发件人: "hannk...@163.com" 代表 Juan Pan > 答复: "priv...@brpc.apache.org" > 日期: 2021年11月23日 星期二 下午12:10 > 收件人: "seb...@gmail.com" , Willem Jiang > 抄送: "priv...@brpc.apache.org" > 主题: Re:Fwd: Cannot find successful vote for brpc 0.9.6 > > > > Hello Sebb and Willem, > > > > Thanks for your kind remainder. I talked with our brpc team, and maybe we need to remove this release. > > > > @brpc team, could you double check this issue? > > > > Best wishes, > > Trista > > > > > -- > > Juan Pan(Trista), Twitter: @tristaZero > > > > On 11/20/2021 12:29，Willem Jiang wrote： > > Please take a look at this issue. > BTW, did you have a chance to subscribe the private@incubator.a.o? > > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Tue, Nov 9, 2021 at 7:30 AM sebb wrote: > > > As the subject says: the VOTE thread for 0.9.6 on the dev list does > not appear to have been successful, and I could find no vote on the > general@incubator list, yet the release is available from the > archives: > > https://archive.apache.org/dist/incubator/brpc/0.9.6/ > > Maybe the release needs to be removed? > > There also don't seem to be any announce emails on the brpc dev list, > only general@incubator > > Sebb > > - > To unsubscribe, e-mail: private-unsubscr...@incubator.apache.org > For additional commands, e-mail: private-h...@incubator.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] chenzhangyi commented on a change in pull request #1611: Implement streaming lz4 compession
chenzhangyi commented on a change in pull request #1611:
URL: https://github.com/apache/incubator-brpc/pull/1611#discussion_r756563100
##
File path: src/brpc/policy/lz4_compress.cpp
##
@@ -0,0 +1,141 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include
+
+#include "butil/logging.h"
+#include "butil/third_party/lz4/lz4.h"
+#include "brpc/policy/lz4_compress.h"
+#include "brpc/protocol.h"
+
+
+namespace brpc {
+namespace policy {
+
+bool Lz4Compress(const google::protobuf::Message& res, butil::IOBuf* buf) {
+butil::IOBuf serialized_pb;
+butil::IOBufAsZeroCopyOutputStream wrapper(_pb);
+if (res.SerializeToZeroCopyStream()) {
+return Lz4Compress(serialized_pb, buf);
+}
+LOG(WARNING) << "Fail to serialize input pb";
+return false;
+}
+
+bool Lz4Decompress(const butil::IOBuf& data, google::protobuf::Message* req) {
+butil::IOBuf binary_pb;
+if (Lz4Decompress(data, _pb)) {
+return ParsePbFromIOBuf(req, binary_pb);
+}
+LOG(WARNING) << "Fail to lz4 decompress, size=" << data.size();
+return false;
+}
+
+bool Lz4Compress(const butil::IOBuf& in, butil::IOBuf* out) {
+size_t ref_cnt = in.backing_block_num();
+LZ4_stream_t* lz4_stream = LZ4_createStream();
+butil::IOBuf block_buf;
+std::vector block_metas;
Review comment:
不要用size_t, 这个跨架构大小不是确定的。 这里得用int32或者int16.
##
File path: src/butil/third_party/lz4/lz4.c
##
@@ -0,0 +1,2495 @@
+/*
Review comment:
需要更新下LICENSE
##
File path: src/brpc/policy/lz4_compress.cpp
##
@@ -0,0 +1,141 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include
+
+#include "butil/logging.h"
+#include "butil/third_party/lz4/lz4.h"
+#include "brpc/policy/lz4_compress.h"
+#include "brpc/protocol.h"
+
+
+namespace brpc {
+namespace policy {
+
+bool Lz4Compress(const google::protobuf::Message& res, butil::IOBuf* buf) {
+butil::IOBuf serialized_pb;
+butil::IOBufAsZeroCopyOutputStream wrapper(_pb);
+if (res.SerializeToZeroCopyStream()) {
+return Lz4Compress(serialized_pb, buf);
+}
+LOG(WARNING) << "Fail to serialize input pb";
+return false;
+}
+
+bool Lz4Decompress(const butil::IOBuf& data, google::protobuf::Message* req) {
+butil::IOBuf binary_pb;
+if (Lz4Decompress(data, _pb)) {
+return ParsePbFromIOBuf(req, binary_pb);
+}
+LOG(WARNING) << "Fail to lz4 decompress, size=" << data.size();
+return false;
+}
+
+bool Lz4Compress(const butil::IOBuf& in, butil::IOBuf* out) {
+size_t ref_cnt = in.backing_block_num();
+LZ4_stream_t* lz4_stream = LZ4_createStream();
+butil::IOBuf block_buf;
+std::vector block_metas;
+for (size_t i = 0; i < ref_cnt; ++i) {
+butil::StringPiece block_view = in.backing_block(i);
+size_t src_block_size = block_view.size();
+size_t dst_block_bound = LZ4_compressBound(src_block_size);
+char* dst = new char[dst_block_bound];
+size_t dst_block_size =
+LZ4_compress_fast_continue(lz4_stream, block_view.data(), dst,
+ src_block_size, dst_block_bound, 1);
+block_buf.append_user_data(reinterpret_cast(dst),
dst_block_size,
+ [](void *d) {
+ char *nd = reinterpret_cast(d);
+ delete[] nd;
+ });
+
[GitHub] [incubator-brpc] emmettwu commented on pull request #1611: Implement streaming lz4 compession
emmettwu commented on pull request #1611: URL: https://github.com/apache/incubator-brpc/pull/1611#issuecomment-978815237 本地Makefile编译没问题，travis-ci编译不过。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] emmettwu closed pull request #1611: Implement streaming lz4 compession
emmettwu closed pull request #1611: URL: https://github.com/apache/incubator-brpc/pull/1611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] nwuking opened a new issue #1614: 使用bthread_mutex_t,unique_lock，出现死锁
nwuking opened a new issue #1614: URL: https://github.com/apache/incubator-brpc/issues/1614 **Describe the bug (描述bug)** 两个线程通信，unique_lock lock后，bthread::ConditionVariable _cond wait()的时候，就锁住了，另一个线程也获取不到lock。 有时候出现 ，deadlock 那个提示出现了 我的逻辑是没问题的，自己封装了一个，没出现问题 **To Reproduce (复现方法)** **Expected behavior (期望行为)** **Versions (各种版本)** OS: Compiler: brpc: protobuf: **Additional context/screenshots (更多上下文/截图)** 注释掉的是brpc的代码   -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: Cannot find successful vote for brpc 0.9.6
You will need to ask Infra to do this On Wed, 24 Nov 2021 at 03:03, tan zhongyi wrote: > > Just confirmed with the team. > > > > 0.9.6 is our first internal release, but it did not go through the vote > process in the general@incubator mail list. > > We want to delete it, but don’t know how to remove it from archive. > > > > Hi, Sebb, > > please help us to remove it from archive, > > Thanks > > > > > > 发件人: "hannk...@163.com" 代表 Juan Pan > 答复: "priv...@brpc.apache.org" > 日期: 2021年11月23日 星期二 下午12:10 > 收件人: "seb...@gmail.com" , Willem Jiang > > 抄送: "priv...@brpc.apache.org" > 主题: Re:Fwd: Cannot find successful vote for brpc 0.9.6 > > > > Hello Sebb and Willem, > > > > Thanks for your kind remainder. I talked with our brpc team, and maybe we > need to remove this release. > > > > @brpc team, could you double check this issue? > > > > Best wishes, > > Trista > > > > > -- > > Juan Pan(Trista), Twitter: @tristaZero > > > > On 11/20/2021 12:29，Willem Jiang wrote： > > Please take a look at this issue. > BTW, did you have a chance to subscribe the private@incubator.a.o? > > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Tue, Nov 9, 2021 at 7:30 AM sebb wrote: > > > As the subject says: the VOTE thread for 0.9.6 on the dev list does > not appear to have been successful, and I could find no vote on the > general@incubator list, yet the release is available from the > archives: > > https://archive.apache.org/dist/incubator/brpc/0.9.6/ > > Maybe the release needs to be removed? > > There also don't seem to be any announce emails on the brpc dev list, > only general@incubator > > Sebb > > - > To unsubscribe, e-mail: private-unsubscr...@incubator.apache.org > For additional commands, e-mail: private-h...@incubator.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] steven-66 opened a new pull request #1612: Create bvar_c++.md under docs/en
steven-66 opened a new pull request #1612: URL: https://github.com/apache/incubator-brpc/pull/1612 add english version of bvar_c++.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
