[GitHub] [incubator-brpc] chenBright commented on pull request #1814: fix ssl state exception coredump
chenBright commented on PR #1814: URL: https://github.com/apache/incubator-brpc/pull/1814#issuecomment-1169601480 @zyearn 还有什么问题吗？大概什么时候能合呢？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] chenBright commented on pull request #1818: fix hostname2ip fails when aux_buf is not long enough
chenBright commented on PR #1818: URL: https://github.com/apache/incubator-brpc/pull/1818#issuecomment-1169600910 @serverglen 修改了头文件顺序就coredump了？这个要怎么debug呢？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] jamesge commented on issue #1824: Makefile 中 指定 -D_GLIBCXX_USE_CXX11_ABI=0 这个参数无效的问题
jamesge commented on issue #1824: URL: https://github.com/apache/incubator-brpc/issues/1824#issuecomment-1169438385 protoc-gen-mcpack的编译没有加上CXXFLAGS，你更新到master HEAD再试试 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[incubator-brpc] branch master updated: add CXXFLAGS in compiling protoc-gen-mcpack
This is an automated email from the ASF dual-hosted git repository.
jamesge pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git
The following commit(s) were added to refs/heads/master by this push:
new d7be1d9c add CXXFLAGS in compiling protoc-gen-mcpack
d7be1d9c is described below
commit d7be1d9cf90687c687c778e522fa9da79b7824ee
Author: jamesge
AuthorDate: Wed Jun 29 09:27:35 2022 +0800
add CXXFLAGS in compiling protoc-gen-mcpack
---
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index e2e1a6b2..3d5978d4 100644
--- a/Makefile
+++ b/Makefile
@@ -241,9 +241,9 @@ clean_debug:
protoc-gen-mcpack: src/idl_options.pb.cc src/mcpack2pb/generator.o libbrpc.a
@echo "> Linking $@"
ifeq ($(SYSTEM),Linux)
- $(CXX) -o $@ $(HDRPATHS) $(LIBPATHS) -std=c++0x -Xlinker "-(" $^
-Wl,-Bstatic $(STATIC_LINKINGS) -Wl,-Bdynamic -Xlinker "-)" $(DYNAMIC_LINKINGS)
+ $(CXX) -o $@ $(CXXFLAGS) $(HDRPATHS) $(LIBPATHS) -std=c++0x -Xlinker
"-(" $^ -Wl,-Bstatic $(STATIC_LINKINGS) -Wl,-Bdynamic -Xlinker "-)"
$(DYNAMIC_LINKINGS)
else ifeq ($(SYSTEM),Darwin)
- $(CXX) -o $@ $(HDRPATHS) $(LIBPATHS) -std=c++0x $^ $(STATIC_LINKINGS)
$(DYNAMIC_LINKINGS)
+ $(CXX) -o $@ $(CXXFLAGS) $(HDRPATHS) $(LIBPATHS) -std=c++0x $^
$(STATIC_LINKINGS) $(DYNAMIC_LINKINGS)
endif
# force generation of pb headers before compiling to avoid fail-to-import
issues in compiling pb.cc
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] zengkui opened a new issue, #1824: Makefile 中 指定 -D_GLIBCXX_USE_CXX11_ABI=0 这个参数无效的问题
zengkui opened a new issue, #1824:
URL: https://github.com/apache/incubator-brpc/issues/1824
**Describe the bug (描述bug)**
在Makefile中指定了 -D_GLIBCXX_USE_CXX11_ABI=0 发现整个brpc的库都正常生成了，编译命令中显示
-D_GLIBCXX_USE_CXX11_ABI=0 这参数也是正常，但是最后在编译生成 protoc-gen-mcpack
这个目标的时候发现这个参数没有带上。 如下：
```shell
g++ -o protoc-gen-mcpack -I./src -Ithirdparty/gflags/gflags-2.2.2/include/
-Ithirdparty/leveldb/leveldb-1.12.0-12.alios7.x86_64/include/
-Ithirdparty/openssl/openssl_1.0.1_el7_4.9.2/include/
-Ithirdparty/protobuf-3.6.1/include/ -Ithirdparty/glog/glog-0.6.0/include/
-Lthirdparty/gflags/gflags-2.2.2/lib64
-Lthirdparty/leveldb/leveldb-1.12.0-12.alios7.x86_64/lib64
-Lthirdparty/openssl/openssl_1.0.1_el7_4.9.2/lib64
-Lthirdparty/protobuf-3.6.1/lib64 -Lthirdparty/glog/glog-0.6.0/lib64 -std=c++0x
-Xlinker "-(" src/idl_options.pb.cc src/mcpack2pb/generator.o libbrpc.a
-Wl,-Bstatic -lgflags -lprotobuf -lleveldb -lprotoc -lglog -Wl,-Bdynamic
-Xlinker "-)" -lpthread -lssl -lcrypto -ldl -lz -lrt
```
报错信息如下：
```shell
/tmp/ccWAA0uM.o: In function
`protobuf_idl_5foptions_2eproto::protobuf_AssignDescriptors()':
idl_options.pb.cc:(.text+0x6b): undefined reference to
`google::protobuf::internal::AssignDescriptors(std::__cxx11::basic_string, std::allocator > const&,
google::protobuf::internal::MigrationSchema const*, google::protobuf::Message
const* const*, unsigned int const*, google::protobuf::Metadata*,
google::protobuf::EnumDescriptor const**, google::protobuf::ServiceDescriptor
const**)'
/tmp/ccWAA0uM.o: In function
`protobuf_idl_5foptions_2eproto::AddDescriptorsImpl()':
idl_options.pb.cc:(.text+0x10e): undefined reference to
`google::protobuf::MessageFactory::InternalRegisterGeneratedFile(char const*,
void (*)(std::__cxx11::basic_string,
std::allocator > const&))'
```
手工添加上-D_GLIBCXX_USE_CXX11_ABI=0 在命令行单独执行这个命令是ok的，如下：
```shell
g++ -o protoc-gen-mcpack -D_GLIBCXX_USE_CXX11_ABI=0 -I./src
-Ithirdparty/gflags/gflags-2.2.2/include/
-Ithirdparty/leveldb/leveldb-1.12.0-12.alios7.x86_64/include/
-Ithirdparty/openssl/openssl_1.0.1_el7_4.9.2/include/
-Ithirdparty/protobuf-3.6.1/include/ -Ithirdparty/glog/glog-0.6.0/include/
-Lthirdparty/gflags/gflags-2.2.2/lib64
-Lthirdparty/leveldb/leveldb-1.12.0-12.alios7.x86_64/lib64
-Lthirdparty/openssl/openssl_1.0.1_el7_4.9.2/lib64
-Lthirdparty/protobuf-3.6.1/lib64 -Lthirdparty/glog/glog-0.6.0/lib64 -std=c++0x
-Xlinker "-(" src/idl_options.pb.cc src/mcpack2pb/generator.o libbrpc.a
-Wl,-Bstatic -lgflags -lprotobuf -lleveldb -lprotoc -lglog -Wl,-Bdynamic
-Xlinker "-)" -lpthread -lssl -lcrypto -ldl -lz -lrt
```
**To Reproduce (复现方法)**
**Expected behavior (期望行为)**
**Versions (各种版本)**
OS:
Compiler: gcc 8.3.1
brpc: master
protobuf: 3.6.1
**Additional context/screenshots (更多上下文/截图)**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] byrnexu opened a new issue, #1823: 如果传递的都是c的结构体数据，用那种rpc协议？
byrnexu opened a new issue, #1823: URL: https://github.com/apache/incubator-brpc/issues/1823 对性能要求比较高，streaming_rpc么 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
