[GitHub] [incubator-brpc] Tuvie commented on a diff in pull request #1836: enable brpc use rdma
Tuvie commented on code in PR #1836:
URL: https://github.com/apache/incubator-brpc/pull/1836#discussion_r936256208
##
src/brpc/socket.cpp:
##
@@ -626,6 +630,23 @@ int Socket::Create(const SocketOptions& options, SocketId*
id) {
m->_ssl_state = (options.initial_ssl_ctx == NULL ? SSL_OFF : SSL_UNKNOWN);
m->_ssl_session = NULL;
m->_ssl_ctx = options.initial_ssl_ctx;
+#if BRPC_WITH_RDMA
+if (options.use_rdma) {
+m->_rdma_ep = new (std::nothrow)rdma::RdmaEndpoint(m);
+if (!m->_rdma_ep) {
+const int saved_errno = errno;
+PLOG(ERROR) << "Fail to create RdmaEndpoint";
+m->SetFailed(saved_errno, "Fail to create RdmaEndpoint: %s",
+ berror(saved_errno));
+return -1;
+}
+m->_rdma_state = RDMA_UNKNOWN;
+} else {
+delete m->_rdma_ep;
Review Comment:
已修改
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] Tuvie commented on a diff in pull request #1836: enable brpc use rdma
Tuvie commented on code in PR #1836:
URL: https://github.com/apache/incubator-brpc/pull/1836#discussion_r936256078
##
src/brpc/channel.cpp:
##
@@ -149,6 +169,16 @@ int Channel::InitChannelOptions(const ChannelOptions*
options) {
LOG(ERROR) << "Channel does not support the protocol";
return -1;
}
+
+#if BRPC_WITH_RDMA
Review Comment:
已调整为报错
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] Tuvie commented on a diff in pull request #1836: enable brpc use rdma
Tuvie commented on code in PR #1836: URL: https://github.com/apache/incubator-brpc/pull/1836#discussion_r936255855 ## CMakeLists.txt: ## @@ -68,6 +69,12 @@ if(WITH_THRIFT) set(THRIFT_LIB "thrift") endif() +set(WITH_RDMA_VAL "0") +if(WITH_RDMA) +set(WITH_RDMA_VAL "1") +set(BRPC_WITH_RDMA 1) Review Comment: 应该是没用的，我删掉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] CalvinKirs opened a new pull request, #1872: Set protected branches and limit merge methods
CalvinKirs opened a new pull request, #1872: URL: https://github.com/apache/incubator-brpc/pull/1872 In most cases, we only need Squash merge and disable other merge methods to avoid loss of Git record coverage due to inadvertent operations.(such as #1817) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] helloqingbing closed issue #1793: brpc server启动get_value core了
helloqingbing closed issue #1793: brpc server启动get_value core了 URL: https://github.com/apache/incubator-brpc/issues/1793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: Minutes of communication between brpc and China Mobile rpc team
Cool. We have a new partner. Best Regards, serverglen Weibing Wang 于2022年8月3日周三 10:15写道： > > Background: China Mobile uses brpc for cloud storage, hoping to > further improve performance, including the adoption of rdma. > Conclusion: > 1. In the future, brpc will no longer maintain a separate rdma branch. > We plan to merge the latest rdma code inside Baidu into the master > branch. PR: https://github.com/apache/incubator-brpc/pull/1836 > 2. China Mobile will cooperate with the community based on the new > rdma PR, and feedback their problems or improvement of the code > > Best Regards > Weibing > > - > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > For additional commands, e-mail: dev-h...@brpc.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: Minutes of communication between brpc and China Mobile rpc team
great to see it. On 2022/08/03 02:15:43 Weibing Wang wrote: > Background: China Mobile uses brpc for cloud storage, hoping to > further improve performance, including the adoption of rdma. > Conclusion: > 1. In the future, brpc will no longer maintain a separate rdma branch. > We plan to merge the latest rdma code inside Baidu into the master > branch. PR: https://github.com/apache/incubator-brpc/pull/1836 > 2. China Mobile will cooperate with the community based on the new > rdma PR, and feedback their problems or improvement of the code > > Best Regards > Weibing > > - > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > For additional commands, e-mail: dev-h...@brpc.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: about apachecon asia 2022 rpc forum
The playback video will be uploaded to Bilibili within a month. Best Regards, Weibing On Wed, Aug 3, 2022 at 10:01 AM Wang Xiaofeng wrote: > > Hi, > > Congratulations. > > BTW, I have missed some of the talks, is there any playback? > > On 2022/08/03 01:46:58 Jerry Tan wrote: > > Hi， guys, > > nice to announce that > > we have finished apachecon asia 2022 rpc forum. > > > > this time, we organized one separate forum focused on RPC framework, > > and we work together with Apache Dubbo guys. > > Wang Weibing is the co-chair. > > there were 12 sessions altogether. > > > > see it > > https://apachecon.com/acasia2022/tracks/rpc.html > > > > cheers. > > > > - > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > For additional commands, e-mail: dev-h...@brpc.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [ANNOUNCE] Apache brpc 1.2.0 released
I am very honored to release brpc 1.2.0 version, also thanks community for support. Best Regards, serverglen Jerry Tan 于2022年8月3日周三 09:52写道： > > I am very glad to see it. > Good job, Liushuai. > > On 2022/07/29 06:10:54 Shuai Liu wrote: > > Hi all, > > > > The Apache brpc (Incubating) community is glad to announce the new release > > of Apache brpc (Incubating) 1.2.0. > > > > brpc is an industrial-grade RPC framework with extremely high performance, > > and it supports multiple protocols, full rpc features, and has many > > convenient tools. > > > > Brief notes of this release: > > - Support apple silicon > > - Add butex_wake_all support nosignal flag > > - Add an option to allow serialize/deserialize to/from a json array > > - Fix rpc_press can't send request equably > > - Fix thrift protocol exception > > - Other Improvements, bug fixes and document updates > > > > More details regarding Apache brpc can be found at: > > http://brpc.apache.org/ > > > > The release is available for download at: > > https://brpc.apache.org/docs/downloadbrpc/ > > > > The release notes can be found here: > > https://github.com/apache/incubator-brpc/releases/tag/1.2.0 > > > > Website: http://brpc.apache.org/ > > > > brpc(Incubating) Resources: > > - Issue: https://github.com/apache/incubator-brpc/issues/ > > - Mailing list: dev@brpc.apache.org > > - Documents: https://brpc.apache.org/docs/ > > > > We would like to thank all contributors of the Apache brpc community and > > Incubating community who made this release possible! > > > > > > Best Regards, > > Apache brpc (Incubating) community > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > > For additional commands, e-mail: dev-h...@brpc.apache.org > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > For additional commands, e-mail: dev-h...@brpc.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Minutes of communication between brpc and China Mobile rpc team
Background: China Mobile uses brpc for cloud storage, hoping to further improve performance, including the adoption of rdma. Conclusion: 1. In the future, brpc will no longer maintain a separate rdma branch. We plan to merge the latest rdma code inside Baidu into the master branch. PR: https://github.com/apache/incubator-brpc/pull/1836 2. China Mobile will cooperate with the community based on the new rdma PR, and feedback their problems or improvement of the code Best Regards Weibing - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: about apachecon asia 2022 rpc forum
Hi, Congratulations. BTW, I have missed some of the talks, is there any playback? On 2022/08/03 01:46:58 Jerry Tan wrote: > Hi， guys, > nice to announce that > we have finished apachecon asia 2022 rpc forum. > > this time, we organized one separate forum focused on RPC framework, > and we work together with Apache Dubbo guys. > Wang Weibing is the co-chair. > there were 12 sessions altogether. > > see it > https://apachecon.com/acasia2022/tracks/rpc.html > > cheers. > - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [ANNOUNCE] Apache brpc 1.2.0 released
I am very glad to see it. Good job, Liushuai. On 2022/07/29 06:10:54 Shuai Liu wrote: > Hi all, > > The Apache brpc (Incubating) community is glad to announce the new release > of Apache brpc (Incubating) 1.2.0. > > brpc is an industrial-grade RPC framework with extremely high performance, > and it supports multiple protocols, full rpc features, and has many > convenient tools. > > Brief notes of this release: > - Support apple silicon > - Add butex_wake_all support nosignal flag > - Add an option to allow serialize/deserialize to/from a json array > - Fix rpc_press can't send request equably > - Fix thrift protocol exception > - Other Improvements, bug fixes and document updates > > More details regarding Apache brpc can be found at: > http://brpc.apache.org/ > > The release is available for download at: > https://brpc.apache.org/docs/downloadbrpc/ > > The release notes can be found here: > https://github.com/apache/incubator-brpc/releases/tag/1.2.0 > > Website: http://brpc.apache.org/ > > brpc(Incubating) Resources: > - Issue: https://github.com/apache/incubator-brpc/issues/ > - Mailing list: dev@brpc.apache.org > - Documents: https://brpc.apache.org/docs/ > > We would like to thank all contributors of the Apache brpc community and > Incubating community who made this release possible! > > > Best Regards, > Apache brpc (Incubating) community > > - > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > For additional commands, e-mail: dev-h...@brpc.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
about apachecon asia 2022 rpc forum
Hi， guys, nice to announce that we have finished apachecon asia 2022 rpc forum. this time, we organized one separate forum focused on RPC framework, and we work together with Apache Dubbo guys. Wang Weibing is the co-chair. there were 12 sessions altogether. see it https://apachecon.com/acasia2022/tracks/rpc.html cheers.
[GitHub] [incubator-brpc] zyearn commented on a diff in pull request #1857: Fix cmake Build in MacOS
zyearn commented on code in PR #1857:
URL: https://github.com/apache/incubator-brpc/pull/1857#discussion_r935954483
##
cmake/brpc.pc.in:
##
@@ -23,4 +23,4 @@ Description: An industrial-grade RPC framework used
throughout Baidu, with 1,000
Version: @BRPC_VERSION@
Cflags: -I${includedir}
Libs: -L${libdir}/ -lbrpc
-Libs.private: @BRPC_PRIVATE_LIBS@
+Libs.private: @DYNAMIC_LIB@
Review Comment:
这边我暂时先不动了，这里有一些冗余libs要清理，之后的PR再解决好了。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] zyearn closed pull request #1857: Fix cmake Build in MacOS
zyearn closed pull request #1857: Fix cmake Build in MacOS URL: https://github.com/apache/incubator-brpc/pull/1857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] 52coder opened a new issue, #1870: 使用example中的例子验证熔断
52coder opened a new issue, #1870: URL: https://github.com/apache/incubator-brpc/issues/1870 **Describe the bug (描述bug)** 基于example中的例子验证可选熔断(根据失败率） 原始代码：https://github.com/52coder/incubator-brpc/tree/master/example/asynchronous_echo_c%2B%2B client.cpp代码修改点： https://github.com/52coder/incubator-brpc/blob/master/example/asynchronous_echo_c%2B%2B/client.cpp#L65后添加： options.enable_circuit_breaker = true; L30行修改为rr : DEFINE_string(load_balancer, "rr", "The algorithm for load balancing"); server.cpp中未改动，先编译出来echo_server,然后在https://github.com/52coder/incubator-brpc/blob/master/example/asynchronous_echo_c%2B%2B/server.cpp#L63前面增加如下代码： cntl->SetFailed(brpc::EREQUEST, "Fail to parse request");然后编译出二进制echo_server_fail 这里的想法是先构造一个100%失败的server触发熔断。 **To Reproduce (复现方法)** 验证方法，三个终端下分别执行 ./echo_server --port=8001 ./echo_server --port=8002 ./echo_server_fail --port=8003 client端运行： ./echo_client --server="list://192.168.49.1:8001,192.168.49.1:8002,192.168.49.1:8003" **Expected behavior (期望行为)** 期望行为是由于client端开启了熔断，其中一个server一直返回失败，所以应该会触发熔断才对，实际结果是跑了一晚上，一直出错的那个server并未摘除 ` I0803 00:26:21.137101 1872894 client.cpp:45] Received response from 192.168.49.1:8002: hello world (attached=bar) latency=603us I0803 00:26:22.137842 1872886 client.cpp:45] Received response from 192.168.49.1:8003: hello world (attached=bar) latency=734us W0803 00:26:23.138861 1872894 client.cpp:42] Fail to send EchoRequest, [E1003][127.0.1.1:8001][E1003]Fail to parse request I0803 00:26:24.139042 1872886 client.cpp:45] Received response from 192.168.49.1:8002: hello world (attached=bar) latency=590us I0803 00:26:25.139412 1872894 client.cpp:45] Received response from 192.168.49.1:8003: hello world (attached=bar) latency=639us W0803 00:26:26.140028 1872886 client.cpp:42] Fail to send EchoRequest, [E1003][127.0.1.1:8001][E1003]Fail to parse request I0803 00:26:27.140468 1872894 client.cpp:45] Received response from 192.168.49.1:8002: hello world (attached=bar) latency=733us I0803 00:26:28.141491 1872886 client.cpp:45] Received response from 192.168.49.1:8003: hello world (attached=bar) latency=739us W0803 00:26:29.142124 1872894 client.cpp:42] Fail to send EchoRequest, [E1003][127.0.1.1:8001][E1003]Fail to parse request I0803 00:26:30.142181 1872886 client.cpp:45] Received response from 192.168.49.1:8002: hello world (attached=bar) latency=484us I0803 00:26:31.142817 1872894 client.cpp:45] Received response from 192.168.49.1:8003: hello world (attached=bar) latency=737us W0803 00:26:32.143875 1872886 client.cpp:42] Fail to send EchoRequest, [E1003][127.0.1.1:8001][E1003]Fail to parse request I0803 00:26:33.144834 1872894 client.cpp:45] Received response from 192.168.49.1:8002: hello world (attached=bar) latency=748us I0803 00:26:34.145134 1872886 client.cpp:45] Received response from 192.168.49.1:8003: hello world (attached=bar) latency=676us W0803 00:26:35.145437 1872894 client.cpp:42] Fail to send EchoRequest, [E1003][127.0.1.1:8001][E1003]Fail to parse request I0803 00:26:36.145931 1872886 client.cpp:45] Received response from 192.168.49.1:8002: hello world (attached=bar) latency=739us ` **Versions (各种版本)** OS: Compiler: brpc: protobuf: **Additional context/screenshots (更多上下文/截图)** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] FancyJan opened a new issue, #1869: 如何判断设置的event_dispatcher_num是否够用
FancyJan opened a new issue, #1869: URL: https://github.com/apache/incubator-brpc/issues/1869 如题 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on a diff in pull request #1836: enable brpc use rdma
wwbmmm commented on code in PR #1836:
URL: https://github.com/apache/incubator-brpc/pull/1836#discussion_r935263314
##
src/brpc/channel.cpp:
##
@@ -149,6 +169,16 @@ int Channel::InitChannelOptions(const ChannelOptions*
options) {
LOG(ERROR) << "Channel does not support the protocol";
return -1;
}
+
+#if BRPC_WITH_RDMA
Review Comment:
没有BRPC_WITH_RDMA宏的时候，如果用户设置options里的use_rdma，是不是应该报错
##
CMakeLists.txt:
##
@@ -68,6 +69,12 @@ if(WITH_THRIFT)
set(THRIFT_LIB "thrift")
endif()
+set(WITH_RDMA_VAL "0")
+if(WITH_RDMA)
+set(WITH_RDMA_VAL "1")
+set(BRPC_WITH_RDMA 1)
Review Comment:
这个有用到吗
##
src/brpc/socket.cpp:
##
@@ -626,6 +630,23 @@ int Socket::Create(const SocketOptions& options, SocketId*
id) {
m->_ssl_state = (options.initial_ssl_ctx == NULL ? SSL_OFF : SSL_UNKNOWN);
m->_ssl_session = NULL;
m->_ssl_ctx = options.initial_ssl_ctx;
+#if BRPC_WITH_RDMA
+if (options.use_rdma) {
+m->_rdma_ep = new (std::nothrow)rdma::RdmaEndpoint(m);
+if (!m->_rdma_ep) {
+const int saved_errno = errno;
+PLOG(ERROR) << "Fail to create RdmaEndpoint";
+m->SetFailed(saved_errno, "Fail to create RdmaEndpoint: %s",
+ berror(saved_errno));
+return -1;
+}
+m->_rdma_state = RDMA_UNKNOWN;
+} else {
+delete m->_rdma_ep;
Review Comment:
同厂内评论，确保这里一定是NULL
##
src/brpc/input_messenger.cpp:
##
@@ -85,6 +86,15 @@ ParseResult InputMessenger::CutInputMessage(
<< " bytes, the connection will be closed."
" Set max_body_size to allow bigger messages";
return result;
+} else {
+if (m->_read_buf.size() >= 4) {
+char data[4];
Review Comment:
缩进有问题
##
src/brpc/input_messenger.cpp:
##
@@ -85,6 +86,15 @@ ParseResult InputMessenger::CutInputMessage(
<< " bytes, the connection will be closed."
" Set max_body_size to allow bigger messages";
return result;
+} else {
+if (m->_read_buf.size() >= 4) {
+char data[4];
+m->_read_buf.copy_to_cstr(data, 4);
+if (strncmp(data, "RDMA", 4) == 0 && m->_rdma_state ==
Socket::RDMA_OFF) {
Review Comment:
这个 4 能否定义成常量
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] 52coder commented on issue #1855: brpc默认熔断ChannelOptions.timeout_ms < ChannelOptions.connect_timeout_ms时熔断生效
52coder commented on issue #1855: URL: https://github.com/apache/incubator-brpc/issues/1855#issuecomment-1202188766 @wwbmmm @cdjingit 大概看了下代码，Controller::Call::OnComplete>FeedbackCircuitBreaker,再往前分析谁调用OnComplete有点多，业务要设置哪个错误码才会触发失败率熔断呢？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] 52coder commented on issue #1855: brpc默认熔断ChannelOptions.timeout_ms < ChannelOptions.connect_timeout_ms时熔断生效
52coder commented on issue #1855: URL: https://github.com/apache/incubator-brpc/issues/1855#issuecomment-1202171840 @wwbmmm 感谢，使用国外一台服务器验证这个连接超时成功，请教下，server端返回失败，就是设置cntl->SetFailed(xxx,"failed");然后brpc会自动根据失败率熔断吗？上午以为修改后验证没问题，刚看了下，发现还是不行。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] dandyhuang opened a new pull request, #1868: Fix(h2 protocol): ProcessHttpRequest
dandyhuang opened a new pull request, #1868: URL: https://github.com/apache/incubator-brpc/pull/1868 fix: h2 ProcessHttpRequest request_protocol is modified to PROTOCOL_H2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on issue #1822: server侧一次pv支持 cpu 资源统计
wwbmmm commented on issue #1822: URL: https://github.com/apache/incubator-brpc/issues/1822#issuecomment-1202082072 > **Describe alternatives you've considered (描述你想到的折衷方案)** > bthread_attr_t 增加 fn，再切换时支持统计 看了下百度内部现有的bthread_attr_t自定义fn的方式不太满足这里的需求，因为server端bthread是由框架创建而不是由用户创建的，传不了自定义的bthread_attr_t。 因此，这个需求还需要重新开发。如果只是统计bthread的cpu消耗，可以考虑扩展一下bthread::TaskStatistics，加个cpu消耗的统计项，并且在bthread切换时更新该值。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc-website] serverglen closed issue #82: Does `more processes` describe incorrectly?
serverglen closed issue #82: Does `more processes` describe incorrectly? URL: https://github.com/apache/incubator-brpc-website/issues/82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc-website] serverglen commented on issue #82: Does `more processes` describe incorrectly?
serverglen commented on issue #82: URL: https://github.com/apache/incubator-brpc-website/issues/82#issuecomment-1202079479 Thank for your contribution -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc-website] serverglen merged pull request #83: [ISSUE #82] improve doc
serverglen merged PR #83: URL: https://github.com/apache/incubator-brpc-website/pull/83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] feng-y commented on issue #1822: server侧一次pv支持 cpu 资源统计
feng-y commented on issue #1822: URL: https://github.com/apache/incubator-brpc/issues/1822#issuecomment-1202059484 暂时比价难支持路由实例的事情，有办法先统计bthread的耗时么 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
