[incubator-brpc] branch master updated: handle override related warnings
This is an automated email from the ASF dual-hosted git repository.
jamesge pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git
The following commit(s) were added to refs/heads/master by this push:
new ef50cd19 handle override related warnings
ef50cd19 is described below
commit ef50cd193cac4d0ef8c2b5a67e9cf0e2e28ae436
Author: gejun.0
AuthorDate: Thu Aug 25 16:18:34 2022 +0800
handle override related warnings
---
src/brpc/esp_message.h| 18 +-
src/brpc/memcache.h | 42 +-
src/brpc/nshead_message.h | 18 +-
src/brpc/redis.h | 40
src/brpc/serialized_request.h | 22 +++---
src/brpc/thrift_message.h | 20 ++--
6 files changed, 80 insertions(+), 80 deletions(-)
diff --git a/src/brpc/esp_message.h b/src/brpc/esp_message.h
index a17fd917..1c24707b 100644
--- a/src/brpc/esp_message.h
+++ b/src/brpc/esp_message.h
@@ -53,25 +53,25 @@ public:
// implements Message --
-EspMessage* New() const;
+EspMessage* New() const override;
#if GOOGLE_PROTOBUF_VERSION >= 3006000
EspMessage* New(::google::protobuf::Arena* arena) const override;
#endif
-void CopyFrom(const ::google::protobuf::Message& from);
-void MergeFrom(const ::google::protobuf::Message& from);
+void CopyFrom(const ::google::protobuf::Message& from) override;
+void MergeFrom(const ::google::protobuf::Message& from) override;
void CopyFrom(const EspMessage& from);
void MergeFrom(const EspMessage& from);
-void Clear();
-bool IsInitialized() const;
+void Clear() override;
+bool IsInitialized() const override;
int ByteSize() const;
bool MergePartialFromCodedStream(
-::google::protobuf::io::CodedInputStream* input);
+::google::protobuf::io::CodedInputStream* input) override;
void SerializeWithCachedSizes(
-::google::protobuf::io::CodedOutputStream* output) const;
+::google::protobuf::io::CodedOutputStream* output) const override;
::google::protobuf::uint8* SerializeWithCachedSizesToArray(
-::google::protobuf::uint8* output) const;
-int GetCachedSize() const { return ByteSize(); }
+::google::protobuf::uint8* output) const override;
+int GetCachedSize() const override { return ByteSize(); }
protected:
::google::protobuf::Metadata GetMetadata() const override;
diff --git a/src/brpc/memcache.h b/src/brpc/memcache.h
index ab464573..d0aaa542 100644
--- a/src/brpc/memcache.h
+++ b/src/brpc/memcache.h
@@ -89,24 +89,24 @@ public:
const butil::IOBuf& raw_buffer() const { return _buf; }
// Protobuf methods.
-MemcacheRequest* New() const;
+MemcacheRequest* New() const override;
#if GOOGLE_PROTOBUF_VERSION >= 3006000
MemcacheRequest* New(::google::protobuf::Arena* arena) const override;
#endif
-void CopyFrom(const ::google::protobuf::Message& from);
-void MergeFrom(const ::google::protobuf::Message& from);
+void CopyFrom(const ::google::protobuf::Message& from) override;
+void MergeFrom(const ::google::protobuf::Message& from) override;
void CopyFrom(const MemcacheRequest& from);
void MergeFrom(const MemcacheRequest& from);
-void Clear();
-bool IsInitialized() const;
+void Clear() override;
+bool IsInitialized() const override;
int ByteSize() const;
bool MergePartialFromCodedStream(
-::google::protobuf::io::CodedInputStream* input);
+::google::protobuf::io::CodedInputStream* input) override;
void SerializeWithCachedSizes(
-::google::protobuf::io::CodedOutputStream* output) const;
-::google::protobuf::uint8*
SerializeWithCachedSizesToArray(::google::protobuf::uint8* output) const;
-int GetCachedSize() const { return _cached_size_; }
+::google::protobuf::io::CodedOutputStream* output) const override;
+::google::protobuf::uint8*
SerializeWithCachedSizesToArray(::google::protobuf::uint8* output) const
override;
+int GetCachedSize() const override { return _cached_size_; }
static const ::google::protobuf::Descriptor* descriptor();
@@ -124,7 +124,7 @@ private:
void SharedCtor();
void SharedDtor();
-void SetCachedSize(int size) const;
+void SetCachedSize(int size) const override;
int _pipelined_count;
butil::IOBuf _buf;
@@ -202,29 +202,29 @@ public:
// implements Message --
-MemcacheResponse* New() const;
+MemcacheResponse* New() const override;
#if GOOGLE_PROTOBUF_VERSION >= 3006000
MemcacheResponse* New(::google::protobuf::Arena* arena) const override;
#endif
-void CopyFrom(const ::google::protobuf::Message& from);
-void MergeFrom(const ::google::protobuf::Mes
[GitHub] [incubator-brpc] zhoukangsheng opened a new issue, #1906: 调整brpc worker线程数的接口
zhoukangsheng opened a new issue, #1906: URL: https://github.com/apache/incubator-brpc/issues/1906 问题背景：目前，使用brpc框架的服务，在cpu和内存资源富余的情况下，服务的最大吞吐能力与brpc的线程数和并发度设置有关。如果线程数和并发度设置不合理，会出现机器的CPU资源仍有冗余，但是服务的处理能力达到瓶颈的现象。目前brpc提供了调整服务并发度的接口，在某些场景下可以通过提高并发度来提高服务的吞吐；但是，当服务的吞吐能力受限于线程数时，只能通过调整静态配置里的线程数，服务重新上线的方式来调整线程数。因此，想对brpc进行升级，提供可以调整brpc worker线程数的接口，不知这个想法是否可行。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on issue #1906: 调整brpc worker线程数的接口
wwbmmm commented on issue #1906: URL: https://github.com/apache/incubator-brpc/issues/1906#issuecomment-1227099228 通过访问内置服务的接口： /flags/bthread_concurrency?setvalue&withform 可以动态调整worker数量（只能调大不能调小） -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] zhoukangsheng commented on issue #1906: 调整brpc worker线程数的接口
zhoukangsheng commented on issue #1906: URL: https://github.com/apache/incubator-brpc/issues/1906#issuecomment-1227116187 > 通过访问内置服务的接口： /flags/bthread_concurrency?setvalue&withform 可以动态调整worker数量（只能调大不能调小） ok，感谢回复～还有一个疑惑，worker数量不能调小的主要考虑是啥，如果某次调整线程数设置不合理，需要调小，这种场景怎么处理 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[ARTICLE] A useful article about open source
Hi all, https://mp.weixin.qq.com/s/ujVNx_1U_QUbi9UkBbdXhQ [image: image.png] Danese Cooper has been an outspoken FOSS activist for more than 20 years. She has worked for the well-being and health of the FOSS movement for over 20 years, as CTO of Wikipedia, Chief Open Source Evangelist at Sun, Senior Director of Open Source Strategy at Intel, and board member of the Drupal Society, Hardware Foundation, and Open Source Initiative. Seven years ago, while running PayPal's OSPO, Danese began thinking, talking, and writing about endogenous ideas, which she advocates as the next phase of the ongoing FOSS movement. Danese, who now lives in the west of Ireland, is president of InnerSourceCommons.org, an American 501(c)3 nonprofit, and also provides open source (and in-house) related consulting at DaneseWorks, Ltd. This article is a transcript of her keynote talk at ApacheCon Asia 2022, "Endogenous and the Way of Apache: How to Learn Open Source." In this talk, she will share her reasons and methods for creating an "endogenous community" using the Apache approach, and how the new wave of open source curious organizations in different fields are using endogenous practices to help them modernize their engineering culture and prepare themselves for real open source participation. Best Regards, serverglen
Podling Brpc Report Reminder - September 2022
Dear podling, This email was sent by an automated system on behalf of the Apache Incubator PMC. It is an initial reminder to give you plenty of time to prepare your quarterly board report. The board meeting is scheduled for Wed, 21 September 2022. The report for your podling will form a part of the Incubator PMC report. The Incubator PMC requires your report to be submitted 2 weeks before the board meeting, to allow sufficient time for review and submission (Wed, September 07). Please submit your report with sufficient time to allow the Incubator PMC, and subsequently board members to review and digest. Again, the very latest you should submit your report is 2 weeks prior to the board meeting. Candidate names should not be made public before people are actually elected, so please do not include the names of potential committers or PPMC members in your report. Thanks, The Apache Incubator PMC Submitting your Report -- Your report should contain the following: * Your project name * A brief description of your project, which assumes no knowledge of the project or necessarily of its field * A list of the three most important issues to address in the move towards graduation. * Any issues that the Incubator PMC or ASF Board might wish/need to be aware of * How has the community developed since the last report * How has the project developed since the last report. * How does the podling rate their own maturity. This should be appended to the Incubator Wiki page at: https://cwiki.apache.org/confluence/display/INCUBATOR/September2022 Note: This is manually populated. You may need to wait a little before this page is created from a template. Note: The format of the report has changed to use markdown. Mentors --- Mentors should review reports for their project(s) and sign them off on the Incubator wiki page. Signing off reports shows that you are following the project - projects that are not signed may raise alarms for the Incubator PMC. Incubator PMC - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on issue #1906: 调整brpc worker线程数的接口
wwbmmm commented on issue #1906: URL: https://github.com/apache/incubator-brpc/issues/1906#issuecomment-1227966476 动态回收pthread worker在实践中会有一些困难，比如无法把待回收的pthread上正在执行的bthread强制调度走（bthread是主动让出），比如如何回收pthread上面的tls变量（有些是业务创建的，没有释放机制），所以没有支持worker动态调小，要调小只能重启 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on pull request #1904: delete _dl_sym
wwbmmm commented on PR #1904: URL: https://github.com/apache/incubator-brpc/pull/1904#issuecomment-1227970991 This error have been fixed by https://github.com/apache/incubator-brpc/pull/1784 _dl_sym is now weak symbol, it will not cause undefined reference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] serverglen commented on issue #1849: 自定义内置bvar的名称，如qps、latency
serverglen commented on issue #1849: URL: https://github.com/apache/incubator-brpc/issues/1849#issuecomment-1228006597 已合入 #1854 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] serverglen closed issue #1849: 自定义内置bvar的名称，如qps、latency
serverglen closed issue #1849: 自定义内置bvar的名称，如qps、latency URL: https://github.com/apache/incubator-brpc/issues/1849 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] zhoukangsheng commented on issue #1906: 调整brpc worker线程数的接口
zhoukangsheng commented on issue #1906: URL: https://github.com/apache/incubator-brpc/issues/1906#issuecomment-1228014847 > 动态回收pthread worker在实践中会有一些困难，比如无法把待回收的pthread上正在执行的bthread强制调度走（bthread是主动让出），比如如何回收pthread上面的tls变量（有些是业务创建的，没有释放机制），所以没有支持worker动态调小，要调小只能重启 嗯嗯，这些确实是要考虑的问题；能否在收到worker调小的通知后，随机选取几个线程进行标记，之后不再往标记的线程分配bthread任务就可以达到worker调小的目的，不知道这个思路是否可行？另外我们在使用brpc框架时，我们不建议业务代码使用tls变量，当一个bthread被多个线程调度到后，访问tls变量会存在一些未定义的行为；对于一些需要使用tls变量的场景，比如trace，我们参考brpc中的tls在bthread中做了一些二次开发，在bthread切换调度线程时，将tls变量保存在了bthread的context中，当它被其它线程调度到时，再从context中恢复到tls。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[SHARED] ApacheCon Asia 2022 PPT and playback video summary
Hi all, ApacheCon Asia 2022 all conference PPT and playback video are collected here. https://mp.weixin.qq.com/s/RVkfH032yUng0VHPKwJZLw Detailed meeting schedule can be found here https://apachecon.com/acasia2022/zh/tracks.html Best Regards, serverglen
