[GitHub] [incubator-brpc-website] wwbmmm merged pull request #102: fix official website page missing elements
wwbmmm merged PR #102: URL: https://github.com/apache/incubator-brpc-website/pull/102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] serverglen commented on a diff in pull request #1964: support mvariable dump by prometheus rpc service
serverglen commented on code in PR #1964: URL: https://github.com/apache/incubator-brpc/pull/1964#discussion_r1006422609 ## src/brpc/builtin/prometheus_metrics_service.cpp: ## @@ -32,6 +32,8 @@ DECLARE_int32(bvar_latency_p2); DECLARE_int32(bvar_latency_p3); } +DEFINE_bool(mvariable_dump_switch, false, "mvariable dump switch"); Review Comment: 改成 brpc_metrics_mvariable_dump 是不是 好点？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] serverglen commented on a diff in pull request #1964: support mvariable dump by prometheus rpc service
serverglen commented on code in PR #1964: URL: https://github.com/apache/incubator-brpc/pull/1964#discussion_r1006420523 ## src/brpc/builtin/prometheus_metrics_service.cpp: ## @@ -32,6 +32,8 @@ DECLARE_int32(bvar_latency_p2); DECLARE_int32(bvar_latency_p3); } +DEFINE_bool(mvariable_dump_switch, false, "mvariable dump switch"); Review Comment: 还是新增一个flags比较好吧，如果改成FLAGS_bvar_max_dump_multi_dimension_metric_number = 0，每次都会输出WARNING日志。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc-website] Huixxi merged pull request #101: add brpc 1.3.0 release blogs
Huixxi merged PR #101: URL: https://github.com/apache/incubator-brpc-website/pull/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc-website] wasphin commented on issue #100: bRPC下载地址改为https://brpc.apache.org/download前缀
wasphin commented on issue #100: URL: https://github.com/apache/incubator-brpc-website/issues/100#issuecomment-1293003978 同时需要考虑对先前地址的兼容，毕竟已经对外提供了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc-website] serverglen opened a new issue, #100: bRPC下载地址改为https://brpc.apache.org/download前缀
serverglen opened a new issue, #100: URL: https://github.com/apache/incubator-brpc-website/issues/100 目前的下载地址是：https://brpc.apache.org/docs/downloadbrpc/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [DISCUSS] Graduate Apache brpc (incubating) as a TLP
+1, thanks Jerry, I have been looking forward to graduation for a long time. Best regards Wang Wei On Thu, Oct 27, 2022 at 11:54 AM Wang,Weibing wrote: > Thanks, Trista > > I will update the podling website to fix the issue. > > Best regards > Weibing > > On Thu, Oct 27, 2022 at 11:16 AM Trista Pan wrote: > > > > +1, glad to see our community became more active and diverse. > > Please give a look and fix the issues [1] before we officially call for > the graduation vote, Thanks. > > > > > > [1] https://incubator.apache.org/clutch/brpc.html > > > -- > > Trista Pan > > Twitter & Github: tristaZero > > > > > > > > > > On 10/26/2022 17:01，Jerry Tan wrote： > > Hi, guys, > > > > > > Apache brpc (incubating) has learned and grown much since our > > > > incubation in 2018-11-13. It is almost 4 years now. How time flies. > > > > > > Now, I'm glad to call on a discussion about whether we are ready for > > graduation. > > > > if we all agree， I will call for a vote for the graduate. > > > > > > Updates since incubation: > > > > > > 1. We release 0.9.6, 0.9.7, 1.0.0,1.1.0, 1.2.0, 1.3.0, 6 releases by > > different release managers (including Jerry Tan, Zhu Jiashun, Lorin Lee, > > Wang Weibing, Liu Shuai, Hu Xiguo) (see it at > > https://incubator.apache.org/projects/brpc.html) > > > > > > > > 2. We add 5 new PPMC members including Jiashun Zhu, Wang Weibing, Cai > > Daojin, He Lei, and Lorin Lee. > > > > > > > > 3. We add 8 new committers, including Cai Daojin, He Lei, Mou Guiding, > > Lorin Lee, Wang Wei, Liu Shuai, Wang Xiaofeng, and Xiguo Hu. (Chen > > Guangming has passed the vote, is in the process of signing ICLA.) > > > > > > 4. We have 17 members subscribed on the private email list and 61 > engineers > > subscribed on the dev mail list, > > > > The discussion on the dev mail list is active, including release, > roadmap, > > committer related topics. > > > > (See it https://whimsy.apache.org/roster/ppmc/brpc ) > > > > > > 5. Branding issues have been solved and name searching has been > completed. > > > > (see it at https://issues.apache.org/jira/browse/PODLINGNAMESEARCH-202) > > > > > > 6. Assessment of the maturity model is available at > > > https://github.com/apache/incubator-brpc/wiki/Maturity-Assessment-for-bRPC > , > > All answers to these check items are 'Yes'. > > > > > > > > So I feel that we are ready to graduate to be a Top level project now. > > > > > > Our mentors and developers, what is your opinion? Please comments. > > > > > > Thanks. > > - > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > For additional commands, e-mail: dev-h...@brpc.apache.org > >
[GitHub] [incubator-brpc] Tuvie commented on a diff in pull request #1967: add warning for rdma invoke when brpc is not compiled with rdma
Tuvie commented on code in PR #1967:
URL: https://github.com/apache/incubator-brpc/pull/1967#discussion_r1006397471
##
src/brpc/rdma/rdma_helper.cpp:
##
@@ -633,4 +633,19 @@ bool SupportedByRdma(std::string protocol) {
} // namespace rdma
} // namespace brpc
-#endif // if BRPC_WITH_RDMA
\ No newline at end of file
+#else
+
+#include
+#include "butil/logging.h"
+
+namespace brpc {
+namespace rdma {
+void GlobalRdmaInitializeOrDie() {
+LOG(ERROR) << "brpc is not compiled with rdma. "
+ << "Please refer to doc/en/rdma.md to enable it.";
Review Comment:
可以，我加一下
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] cdjingit commented on a diff in pull request #1964: support mvariable dump by prometheus rpc service
cdjingit commented on code in PR #1964: URL: https://github.com/apache/incubator-brpc/pull/1964#discussion_r1006382654 ## src/brpc/builtin/prometheus_metrics_service.cpp: ## @@ -32,6 +32,8 @@ DECLARE_int32(bvar_latency_p2); DECLARE_int32(bvar_latency_p3); } +DEFINE_bool(mvariable_dump_switch, false, "mvariable dump switch"); Review Comment: 这个是不是用FLAGS_bvar_max_dump_multi_dimension_metric_number 为0表示就可以了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [DISCUSS] Graduate Apache brpc (incubating) as a TLP
Thanks, Trista I will update the podling website to fix the issue. Best regards Weibing On Thu, Oct 27, 2022 at 11:16 AM Trista Pan wrote: > > +1, glad to see our community became more active and diverse. > Please give a look and fix the issues [1] before we officially call for the > graduation vote, Thanks. > > > [1] https://incubator.apache.org/clutch/brpc.html > -- > Trista Pan > Twitter & Github: tristaZero > > > > > On 10/26/2022 17:01，Jerry Tan wrote： > Hi, guys, > > > Apache brpc (incubating) has learned and grown much since our > > incubation in 2018-11-13. It is almost 4 years now. How time flies. > > > Now, I'm glad to call on a discussion about whether we are ready for > graduation. > > if we all agree， I will call for a vote for the graduate. > > > Updates since incubation: > > > 1. We release 0.9.6, 0.9.7, 1.0.0,1.1.0, 1.2.0, 1.3.0, 6 releases by > different release managers (including Jerry Tan, Zhu Jiashun, Lorin Lee, > Wang Weibing, Liu Shuai, Hu Xiguo) (see it at > https://incubator.apache.org/projects/brpc.html) > > > > 2. We add 5 new PPMC members including Jiashun Zhu, Wang Weibing, Cai > Daojin, He Lei, and Lorin Lee. > > > > 3. We add 8 new committers, including Cai Daojin, He Lei, Mou Guiding, > Lorin Lee, Wang Wei, Liu Shuai, Wang Xiaofeng, and Xiguo Hu. (Chen > Guangming has passed the vote, is in the process of signing ICLA.) > > > 4. We have 17 members subscribed on the private email list and 61 engineers > subscribed on the dev mail list, > > The discussion on the dev mail list is active, including release, roadmap, > committer related topics. > > (See it https://whimsy.apache.org/roster/ppmc/brpc ) > > > 5. Branding issues have been solved and name searching has been completed. > > (see it at https://issues.apache.org/jira/browse/PODLINGNAMESEARCH-202) > > > 6. Assessment of the maturity model is available at > https://github.com/apache/incubator-brpc/wiki/Maturity-Assessment-for-bRPC, > All answers to these check items are 'Yes'. > > > > So I feel that we are ready to graduate to be a Top level project now. > > > Our mentors and developers, what is your opinion? Please comments. > > > Thanks. - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [DISCUSS] Graduate Apache brpc (incubating) as a TLP
+1, a big time! Best regards, Xiguo On Thu, Oct 27, 2022 at 11:16 AM Trista Pan wrote: > > +1, glad to see our community became more active and diverse. > Please give a look and fix the issues [1] before we officially call for the > graduation vote, Thanks. > > > [1] https://incubator.apache.org/clutch/brpc.html > -- > Trista Pan > Twitter & Github: tristaZero > > > > > On 10/26/2022 17:01，Jerry Tan wrote： > Hi, guys, > > > Apache brpc (incubating) has learned and grown much since our > > incubation in 2018-11-13. It is almost 4 years now. How time flies. > > > Now, I'm glad to call on a discussion about whether we are ready for > graduation. > > if we all agree， I will call for a vote for the graduate. > > > Updates since incubation: > > > 1. We release 0.9.6, 0.9.7, 1.0.0,1.1.0, 1.2.0, 1.3.0, 6 releases by > different release managers (including Jerry Tan, Zhu Jiashun, Lorin Lee, > Wang Weibing, Liu Shuai, Hu Xiguo) (see it at > https://incubator.apache.org/projects/brpc.html) > > > > 2. We add 5 new PPMC members including Jiashun Zhu, Wang Weibing, Cai > Daojin, He Lei, and Lorin Lee. > > > > 3. We add 8 new committers, including Cai Daojin, He Lei, Mou Guiding, > Lorin Lee, Wang Wei, Liu Shuai, Wang Xiaofeng, and Xiguo Hu. (Chen > Guangming has passed the vote, is in the process of signing ICLA.) > > > 4. We have 17 members subscribed on the private email list and 61 engineers > subscribed on the dev mail list, > > The discussion on the dev mail list is active, including release, roadmap, > committer related topics. > > (See it https://whimsy.apache.org/roster/ppmc/brpc ) > > > 5. Branding issues have been solved and name searching has been completed. > > (see it at https://issues.apache.org/jira/browse/PODLINGNAMESEARCH-202) > > > 6. Assessment of the maturity model is available at > https://github.com/apache/incubator-brpc/wiki/Maturity-Assessment-for-bRPC, > All answers to these check items are 'Yes'. > > > > So I feel that we are ready to graduate to be a Top level project now. > > > Our mentors and developers, what is your opinion? Please comments. > > > Thanks. - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re:[DISCUSS] Graduate Apache brpc (incubating) as a TLP
+1, glad to see our community became more active and diverse. Please give a look and fix the issues [1] before we officially call for the graduation vote, Thanks. [1] https://incubator.apache.org/clutch/brpc.html -- Trista Pan Twitter & Github: tristaZero On 10/26/2022 17:01，Jerry Tan wrote： Hi, guys, Apache brpc (incubating) has learned and grown much since our incubation in 2018-11-13. It is almost 4 years now. How time flies. Now, I'm glad to call on a discussion about whether we are ready for graduation. if we all agree， I will call for a vote for the graduate. Updates since incubation: 1. We release 0.9.6, 0.9.7, 1.0.0,1.1.0, 1.2.0, 1.3.0, 6 releases by different release managers (including Jerry Tan, Zhu Jiashun, Lorin Lee, Wang Weibing, Liu Shuai, Hu Xiguo) (see it at https://incubator.apache.org/projects/brpc.html) 2. We add 5 new PPMC members including Jiashun Zhu, Wang Weibing, Cai Daojin, He Lei, and Lorin Lee. 3. We add 8 new committers, including Cai Daojin, He Lei, Mou Guiding, Lorin Lee, Wang Wei, Liu Shuai, Wang Xiaofeng, and Xiguo Hu. (Chen Guangming has passed the vote, is in the process of signing ICLA.) 4. We have 17 members subscribed on the private email list and 61 engineers subscribed on the dev mail list, The discussion on the dev mail list is active, including release, roadmap, committer related topics. (See it https://whimsy.apache.org/roster/ppmc/brpc ) 5. Branding issues have been solved and name searching has been completed. (see it at https://issues.apache.org/jira/browse/PODLINGNAMESEARCH-202) 6. Assessment of the maturity model is available at https://github.com/apache/incubator-brpc/wiki/Maturity-Assessment-for-bRPC, All answers to these check items are 'Yes'. So I feel that we are ready to graduate to be a Top level project now. Our mentors and developers, what is your opinion? Please comments. Thanks.
[incubator-brpc] branch master updated: Update newcommitter.md
This is an automated email from the ASF dual-hosted git repository. jerrytan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git The following commit(s) were added to refs/heads/master by this push: new 84c77340 Update newcommitter.md 84c77340 is described below commit 84c7734025a570db3d18f417518c57d10bfaef3a Author: Tanzhongyi(Jerry Tan) AuthorDate: Thu Oct 27 10:55:59 2022 +0800 Update newcommitter.md --- community/newcommitter.md | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/community/newcommitter.md b/community/newcommitter.md index 89ecb6cc..748aae66 100644 --- a/community/newcommitter.md +++ b/community/newcommitter.md @@ -2,18 +2,21 @@ ## 1. 如何发展committer +### 前置条件 +1. 贡献者commit数量达到10个以上 +2. 贡献者个人有意愿接受邀请成为committer +3. 贡献者订阅dev@brpc.apache.org，并发邮件介绍自己 ### 成为committer的路程 1. 提名者在private@brpc中发起讨论和投票，投票通过即OK （最少3+1， +1 > -1)，投票邮件模版https://community.apache.org/newcommitter.html#committer-vote-template 2. 提名者发送close vote邮件给private@brpc和private@incubator ,标题可以为subject [RESULT][VOTE]，close邮件模版https://community.apache.org/newcommitter.html#close-vote 3. 提名者给被提名者发invite letter，并得到回复后再提示他提交ICLA，模版见https://community.apache.org/newcommitter.html#Committer%20Invite%20Template -4. 被提名者填写[CLA](https://www.apache.org/licenses/contributor-agreements.html), 个人贡献者需要下载[ICLA](https://www.apache.org/licenses/icla.pdf)填写个人信息并签名，发送电子版给 secret...@apache.org。个人信息填写项（除签名外）可以使用 PDF 阅读器或浏览器填写，填写后保存进行签名。签名方式支持： +4. 被提名者填写[CLA](https://www.apache.org/licenses/contributor-agreements.html), 个人贡献者需要下载[ICLA](https://www.apache.org/licenses/icla.pdf)填写个人信息并签名，发送电子版给 secret...@apache.org。（注意：ICLA需要填写信息完全，包括邮寄地址和签名，否则会被ASF的秘书打回）个人信息填写项（除签名外）可以使用 PDF 阅读器或浏览器填写，填写后保存进行签名。签名方式支持： - 打印 pdf 文件，手写签名后扫描为电子版； - 使用支持手写的设备进行电子签名； - 使用 `gpg` 进行电子签名，即对填写好个人基本信息的 pdf 文件进行操作（需要提前生成与登记邮箱匹配的公钥/密钥对）：`gpg --armor --detach-sign icla.pdf`； - 使用 `DocuSign` 进行签名； -注意：ICLA需要填写信息完全，包括邮寄地址和签名。 5. 提名者发送announce邮件到dev@brpc.apache.org @@ -29,7 +32,7 @@ https://id.apache.org/ https://gitbox.apache.org/setup/ -### apache 官网new committer相关的文档 +### Apache 官网new committer相关的文档 * https://community.apache.org/newcommitter.html - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [DISCUSS] Graduate Apache brpc (incubating) as a TLP
+1 Since I joined the brpc community, I have seen that the community grows rapidly: We released new versions every quarter following the Apache workflow. We attract more and more committers from different companies. We discuss more in the mail list. We meet online and offline to make the community more active. We respond to issues and PRs in time. We have more and more enterprise users using brpc. We do everything in the Apache way. I think we are ready to graduate. Hope to see it. Best regards Weibing On Thu, Oct 27, 2022 at 10:27 AM Lorin Lee wrote: > > +1, brpc is being used so widely and has so big impact, glad to see > it's graduation!!! > > Best Regards, > Lorin Lee > > > 牟盖东 于2022年10月27日周四 10:18写道： > > > > +1, a long-awaited milestone! > > > > Shuai Liu 于2022年10月27日周四 10:06写道： > > > > > +1, thanks Jerry, This is really good news. > > > > > > Best Regards, > > > serverglen > > > > > > > > > Wang Xiaofeng 于2022年10月27日周四 08:12写道： > > > > > > > > > > > +1, thanks Jerry for bringing up this discussion, glad to see the bRPC > > > > project moving forward. > > > > > > > > On 2022/10/26 09:01:29 Jerry Tan wrote: > > > > > Hi, guys, > > > > > > > > > > > > > > > Apache brpc (incubating) has learned and grown much since our > > > > > > > > > > incubation in 2018-11-13. It is almost 4 years now. How time flies. > > > > > > > > > > > > > > > Now, I'm glad to call on a discussion about whether we are ready for > > > > > graduation. > > > > > > > > > > if we all agree， I will call for a vote for the graduate. > > > > > > > > > > > > > > > Updates since incubation: > > > > > > > > > > > > > > > 1. We release 0.9.6, 0.9.7, 1.0.0,1.1.0, 1.2.0, 1.3.0, 6 releases by > > > > > different release managers (including Jerry Tan, Zhu Jiashun, Lorin > > > Lee, > > > > > Wang Weibing, Liu Shuai, Hu Xiguo) (see it at > > > > > https://incubator.apache.org/projects/brpc.html) > > > > > > > > > > > > > > > > > > > > 2. We add 5 new PPMC members including Jiashun Zhu, Wang Weibing, Cai > > > > > Daojin, He Lei, and Lorin Lee. > > > > > > > > > > > > > > > > > > > > 3. We add 8 new committers, including Cai Daojin, He Lei, Mou Guiding, > > > > > Lorin Lee, Wang Wei, Liu Shuai, Wang Xiaofeng, and Xiguo Hu. (Chen > > > > > Guangming has passed the vote, is in the process of signing ICLA.) > > > > > > > > > > > > > > > 4. We have 17 members subscribed on the private email list and 61 > > > > engineers > > > > > subscribed on the dev mail list, > > > > > > > > > > The discussion on the dev mail list is active, including release, > > > > roadmap, > > > > > committer related topics. > > > > > > > > > > (See it https://whimsy.apache.org/roster/ppmc/brpc ) > > > > > > > > > > > > > > > 5. Branding issues have been solved and name searching has been > > > > completed. > > > > > > > > > > (see it at https://issues.apache.org/jira/browse/PODLINGNAMESEARCH-202 > > > ) > > > > > > > > > > > > > > > 6. Assessment of the maturity model is available at > > > > > > > > > > > > https://github.com/apache/incubator-brpc/wiki/Maturity-Assessment-for-bRPC > > > > , > > > > > All answers to these check items are 'Yes'. > > > > > > > > > > > > > > > > > > > > So I feel that we are ready to graduate to be a Top level project now. > > > > > > > > > > > > > > > Our mentors and developers, what is your opinion? Please comments. > > > > > > > > > > > > > > > Thanks. > > > > > > > > > > > > > - > > > > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > > > > For additional commands, e-mail: dev-h...@brpc.apache.org > > > > > > > > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > For additional commands, e-mail: dev-h...@brpc.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [DISCUSS] Graduate Apache brpc (incubating) as a TLP
+1, brpc is being used so widely and has so big impact, glad to see it's graduation!!! Best Regards, Lorin Lee 牟盖东 于2022年10月27日周四 10:18写道： > > +1, a long-awaited milestone! > > Shuai Liu 于2022年10月27日周四 10:06写道： > > > +1, thanks Jerry, This is really good news. > > > > Best Regards, > > serverglen > > > > > > Wang Xiaofeng 于2022年10月27日周四 08:12写道： > > > > > > > > +1, thanks Jerry for bringing up this discussion, glad to see the bRPC > > > project moving forward. > > > > > > On 2022/10/26 09:01:29 Jerry Tan wrote: > > > > Hi, guys, > > > > > > > > > > > > Apache brpc (incubating) has learned and grown much since our > > > > > > > > incubation in 2018-11-13. It is almost 4 years now. How time flies. > > > > > > > > > > > > Now, I'm glad to call on a discussion about whether we are ready for > > > > graduation. > > > > > > > > if we all agree， I will call for a vote for the graduate. > > > > > > > > > > > > Updates since incubation: > > > > > > > > > > > > 1. We release 0.9.6, 0.9.7, 1.0.0,1.1.0, 1.2.0, 1.3.0, 6 releases by > > > > different release managers (including Jerry Tan, Zhu Jiashun, Lorin > > Lee, > > > > Wang Weibing, Liu Shuai, Hu Xiguo) (see it at > > > > https://incubator.apache.org/projects/brpc.html) > > > > > > > > > > > > > > > > 2. We add 5 new PPMC members including Jiashun Zhu, Wang Weibing, Cai > > > > Daojin, He Lei, and Lorin Lee. > > > > > > > > > > > > > > > > 3. We add 8 new committers, including Cai Daojin, He Lei, Mou Guiding, > > > > Lorin Lee, Wang Wei, Liu Shuai, Wang Xiaofeng, and Xiguo Hu. (Chen > > > > Guangming has passed the vote, is in the process of signing ICLA.) > > > > > > > > > > > > 4. We have 17 members subscribed on the private email list and 61 > > > engineers > > > > subscribed on the dev mail list, > > > > > > > > The discussion on the dev mail list is active, including release, > > > roadmap, > > > > committer related topics. > > > > > > > > (See it https://whimsy.apache.org/roster/ppmc/brpc ) > > > > > > > > > > > > 5. Branding issues have been solved and name searching has been > > > completed. > > > > > > > > (see it at https://issues.apache.org/jira/browse/PODLINGNAMESEARCH-202 > > ) > > > > > > > > > > > > 6. Assessment of the maturity model is available at > > > > > > > > > https://github.com/apache/incubator-brpc/wiki/Maturity-Assessment-for-bRPC > > > , > > > > All answers to these check items are 'Yes'. > > > > > > > > > > > > > > > > So I feel that we are ready to graduate to be a Top level project now. > > > > > > > > > > > > Our mentors and developers, what is your opinion? Please comments. > > > > > > > > > > > > Thanks. > > > > > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > > > For additional commands, e-mail: dev-h...@brpc.apache.org > > > > > > > > - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: Apply to Become Committer
Welcome zhaogeng! Thanks for your contributions! Lorin Lee 于2022年10月27日周四 10:21写道： > Welcome! > > Wang Wei 于2022年10月26日周三 22:30写道： > > > > Welcome Zhaogeng. > > Thank you for your contribution of RDMA to brpc. > > > > Best Regards. > > > > On Wed, Oct 26, 2022 at 8:48 PM fisherman wrote: > > > > > welcome zhaogeng > > > > > > Jerry Tan 于2022年10月26日周三 17:03写道： > > > > > > > welcome, zhaogeng. > > > > > > > > On 2022/10/26 02:15:55 Hu go wrote: > > > > > Welcome Zhaogeng. > > > > > > > > > > Best Regards, > > > > > Xiguo > > > > > > > > > > On Wed, Oct 26, 2022 at 10:00 AM Weibing Wang > > > wrote: > > > > > > > > > > > > Welcome! > > > > > > > > > > > > On Wed, Oct 26, 2022 at 9:55 AM Shuai Liu > > > > > wrote: > > > > > > > > > > > > > > Welcome Zhaogeng. > > > > > > > > > > > > > > Best Regards, > > > > > > > serverglen > > > > > > > > > > > > > > > > > > > > > Xiaofeng 于2022年10月26日周三 09:01写道： > > > > > > > > > > > > > > > Welcome Zhaogeng! > > > > > > > > > > > > > > > > Regards, > > > > > > > > Xiaofeng > > > > > > > > > > > > > > > > Jiashun Zhu 于 2022年10月26日周三 01:46写道： > > > > > > > > > > > > > > > > > Welcome Zhaogeng. > > > > > > > > > > > > > > > > > > On Tue, 25 Oct 2022 at 17:35, Zhaogeng Li < > lizhaog...@yeah.net > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > Hi all, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I'm Zhaogeng Li (李兆耕), an engineer from Baidu. > > > > > > > > > > Currently, I'm doing something related to high > performance > > > > network > > > > > > > > (e.g. > > > > > > > > > > rdma) inside cloud datacenter. > > > > > > > > > > In Baidu, there are many applications using brpc as the > basic > > > > > > > > > > communication framework. > > > > > > > > > > To enable rdma in brpc, we make these applications use > rdma > > > > much more > > > > > > > > > > easily. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Recently, I commited a PR of rdma to brpc ( > > > > > > > > > > https://github.com/apache/incubator-brpc/pull/1836). > > > > > > > > > > This feature was just merged into master branch as an > > > > experimental > > > > > > > > > feature > > > > > > > > > > in the latest brpc release. > > > > > > > > > > I'm writing this email to apply to become a committer of > brpc > > > > project > > > > > > > > > > formally. > > > > > > > > > > I hope more users can enjoy the rdma feature and give > > > > feedbacks. > > > > > > > > > > Together, we can make rdma as one of the standard > > > > communication method > > > > > > > > in > > > > > > > > > > brpc, to enhance the application performance. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Thanks a lot. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > BR, > > > > > > > > > > Zhaogeng Li @ Baidu > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > - > > > > > > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > > > > > > For additional commands, e-mail: dev-h...@brpc.apache.org > > > > > > > > > > > > > > > > > - > > > > > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > > > > > For additional commands, e-mail: dev-h...@brpc.apache.org > > > > > > > > > > > > > > > > > > - > > > > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > > > > For additional commands, e-mail: dev-h...@brpc.apache.org > > > > > > > > > > > > > > -- > > > --- > > > Best Regards :-) > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > For additional commands, e-mail: dev-h...@brpc.apache.org > >
Re: [DISCUSS] Graduate Apache brpc (incubating) as a TLP
+1, a long-awaited milestone! Shuai Liu 于2022年10月27日周四 10:06写道： > +1, thanks Jerry, This is really good news. > > Best Regards, > serverglen > > > Wang Xiaofeng 于2022年10月27日周四 08:12写道： > > > > > +1, thanks Jerry for bringing up this discussion, glad to see the bRPC > > project moving forward. > > > > On 2022/10/26 09:01:29 Jerry Tan wrote: > > > Hi, guys, > > > > > > > > > Apache brpc (incubating) has learned and grown much since our > > > > > > incubation in 2018-11-13. It is almost 4 years now. How time flies. > > > > > > > > > Now, I'm glad to call on a discussion about whether we are ready for > > > graduation. > > > > > > if we all agree， I will call for a vote for the graduate. > > > > > > > > > Updates since incubation: > > > > > > > > > 1. We release 0.9.6, 0.9.7, 1.0.0,1.1.0, 1.2.0, 1.3.0, 6 releases by > > > different release managers (including Jerry Tan, Zhu Jiashun, Lorin > Lee, > > > Wang Weibing, Liu Shuai, Hu Xiguo) (see it at > > > https://incubator.apache.org/projects/brpc.html) > > > > > > > > > > > > 2. We add 5 new PPMC members including Jiashun Zhu, Wang Weibing, Cai > > > Daojin, He Lei, and Lorin Lee. > > > > > > > > > > > > 3. We add 8 new committers, including Cai Daojin, He Lei, Mou Guiding, > > > Lorin Lee, Wang Wei, Liu Shuai, Wang Xiaofeng, and Xiguo Hu. (Chen > > > Guangming has passed the vote, is in the process of signing ICLA.) > > > > > > > > > 4. We have 17 members subscribed on the private email list and 61 > > engineers > > > subscribed on the dev mail list, > > > > > > The discussion on the dev mail list is active, including release, > > roadmap, > > > committer related topics. > > > > > > (See it https://whimsy.apache.org/roster/ppmc/brpc ) > > > > > > > > > 5. Branding issues have been solved and name searching has been > > completed. > > > > > > (see it at https://issues.apache.org/jira/browse/PODLINGNAMESEARCH-202 > ) > > > > > > > > > 6. Assessment of the maturity model is available at > > > > > > https://github.com/apache/incubator-brpc/wiki/Maturity-Assessment-for-bRPC > > , > > > All answers to these check items are 'Yes'. > > > > > > > > > > > > So I feel that we are ready to graduate to be a Top level project now. > > > > > > > > > Our mentors and developers, what is your opinion? Please comments. > > > > > > > > > Thanks. > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > > For additional commands, e-mail: dev-h...@brpc.apache.org > > > > >
[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1899: Macos workflow
guodongxiaren commented on PR #1899: URL: https://github.com/apache/incubator-brpc/pull/1899#issuecomment-1292873706 > 目前有很多case是关于时间判断的，但macos执行过慢，可能会造成这些case非常不稳定，要不先跳过mac上的ut执行？先把mac编译加到CI里 > > 后面可能需要系统地理一下这些case 可以。我晚点改一下 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on pull request #1899: Macos workflow
wwbmmm commented on PR #1899: URL: https://github.com/apache/incubator-brpc/pull/1899#issuecomment-1292871987 目前有很多case是关于时间判断的，但macos执行过慢，可能会造成这些case非常不稳定，要不先跳过mac上的ut执行？先把mac编译加到CI里 后面可能需要系统地理一下这些case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [DISCUSS] Graduate Apache brpc (incubating) as a TLP
+1, thanks Jerry, This is really good news. Best Regards, serverglen Wang Xiaofeng 于2022年10月27日周四 08:12写道： > > +1, thanks Jerry for bringing up this discussion, glad to see the bRPC > project moving forward. > > On 2022/10/26 09:01:29 Jerry Tan wrote: > > Hi, guys, > > > > > > Apache brpc (incubating) has learned and grown much since our > > > > incubation in 2018-11-13. It is almost 4 years now. How time flies. > > > > > > Now, I'm glad to call on a discussion about whether we are ready for > > graduation. > > > > if we all agree， I will call for a vote for the graduate. > > > > > > Updates since incubation: > > > > > > 1. We release 0.9.6, 0.9.7, 1.0.0,1.1.0, 1.2.0, 1.3.0, 6 releases by > > different release managers (including Jerry Tan, Zhu Jiashun, Lorin Lee, > > Wang Weibing, Liu Shuai, Hu Xiguo) (see it at > > https://incubator.apache.org/projects/brpc.html) > > > > > > > > 2. We add 5 new PPMC members including Jiashun Zhu, Wang Weibing, Cai > > Daojin, He Lei, and Lorin Lee. > > > > > > > > 3. We add 8 new committers, including Cai Daojin, He Lei, Mou Guiding, > > Lorin Lee, Wang Wei, Liu Shuai, Wang Xiaofeng, and Xiguo Hu. (Chen > > Guangming has passed the vote, is in the process of signing ICLA.) > > > > > > 4. We have 17 members subscribed on the private email list and 61 > engineers > > subscribed on the dev mail list, > > > > The discussion on the dev mail list is active, including release, > roadmap, > > committer related topics. > > > > (See it https://whimsy.apache.org/roster/ppmc/brpc ) > > > > > > 5. Branding issues have been solved and name searching has been > completed. > > > > (see it at https://issues.apache.org/jira/browse/PODLINGNAMESEARCH-202) > > > > > > 6. Assessment of the maturity model is available at > > > https://github.com/apache/incubator-brpc/wiki/Maturity-Assessment-for-bRPC > , > > All answers to these check items are 'Yes'. > > > > > > > > So I feel that we are ready to graduate to be a Top level project now. > > > > > > Our mentors and developers, what is your opinion? Please comments. > > > > > > Thanks. > > > > - > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > For additional commands, e-mail: dev-h...@brpc.apache.org > >
[incubator-brpc] branch master updated: Update newcommitter.md
This is an automated email from the ASF dual-hosted git repository. jerrytan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git The following commit(s) were added to refs/heads/master by this push: new 99055916 Update newcommitter.md 99055916 is described below commit 99055916a413a160a00a633977ed2c2271bf1ff5 Author: Tanzhongyi(Jerry Tan) AuthorDate: Thu Oct 27 09:57:09 2022 +0800 Update newcommitter.md --- community/newcommitter.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/community/newcommitter.md b/community/newcommitter.md index 4cd7bc2e..89ecb6cc 100644 --- a/community/newcommitter.md +++ b/community/newcommitter.md @@ -12,6 +12,8 @@ - 使用支持手写的设备进行电子签名； - 使用 `gpg` 进行电子签名，即对填写好个人基本信息的 pdf 文件进行操作（需要提前生成与登记邮箱匹配的公钥/密钥对）：`gpg --armor --detach-sign icla.pdf`； - 使用 `DocuSign` 进行签名； + +注意：ICLA需要填写信息完全，包括邮寄地址和签名。 5. 提名者发送announce邮件到dev@brpc.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [DISCUSS] Graduate Apache brpc (incubating) as a TLP
+1, thanks Jerry for bringing up this discussion, glad to see the bRPC project moving forward. On 2022/10/26 09:01:29 Jerry Tan wrote: > Hi, guys, > > > Apache brpc (incubating) has learned and grown much since our > > incubation in 2018-11-13. It is almost 4 years now. How time flies. > > > Now, I'm glad to call on a discussion about whether we are ready for > graduation. > > if we all agree， I will call for a vote for the graduate. > > > Updates since incubation: > > > 1. We release 0.9.6, 0.9.7, 1.0.0,1.1.0, 1.2.0, 1.3.0, 6 releases by > different release managers (including Jerry Tan, Zhu Jiashun, Lorin Lee, > Wang Weibing, Liu Shuai, Hu Xiguo) (see it at > https://incubator.apache.org/projects/brpc.html) > > > > 2. We add 5 new PPMC members including Jiashun Zhu, Wang Weibing, Cai > Daojin, He Lei, and Lorin Lee. > > > > 3. We add 8 new committers, including Cai Daojin, He Lei, Mou Guiding, > Lorin Lee, Wang Wei, Liu Shuai, Wang Xiaofeng, and Xiguo Hu. (Chen > Guangming has passed the vote, is in the process of signing ICLA.) > > > 4. We have 17 members subscribed on the private email list and 61 engineers > subscribed on the dev mail list, > > The discussion on the dev mail list is active, including release, roadmap, > committer related topics. > > (See it https://whimsy.apache.org/roster/ppmc/brpc ) > > > 5. Branding issues have been solved and name searching has been completed. > > (see it at https://issues.apache.org/jira/browse/PODLINGNAMESEARCH-202) > > > 6. Assessment of the maturity model is available at > https://github.com/apache/incubator-brpc/wiki/Maturity-Assessment-for-bRPC, > All answers to these check items are 'Yes'. > > > > So I feel that we are ready to graduate to be a Top level project now. > > > Our mentors and developers, what is your opinion? Please comments. > > > Thanks. > - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [NEW FEATURE] bRPC RDMA feature
hope to test it fully before 1.4 release On 2022/10/25 06:12:01 Weibing Wang wrote: > Since bRPC 1.3.0 has been released, I have merged the RDMA feature > into master branch. > > RDMA usage doc: > https://github.com/apache/incubator-brpc/blob/master/docs/cn/rdma.md > > Next we will collect rdma user feedback, and plan to release brpc > 1.4.0 with rdma on Jan 2023. > > Thanks > Weibing > > - > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > For additional commands, e-mail: dev-h...@brpc.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on a diff in pull request #1967: add warning for rdma invoke when brpc is not compiled with rdma
zyearn commented on code in PR #1967:
URL: https://github.com/apache/incubator-brpc/pull/1967#discussion_r1006103478
##
src/brpc/rdma/rdma_helper.cpp:
##
@@ -633,4 +633,19 @@ bool SupportedByRdma(std::string protocol) {
} // namespace rdma
} // namespace brpc
-#endif // if BRPC_WITH_RDMA
\ No newline at end of file
+#else
+
+#include
+#include "butil/logging.h"
+
+namespace brpc {
+namespace rdma {
+void GlobalRdmaInitializeOrDie() {
+LOG(ERROR) << "brpc is not compiled with rdma. "
+ << "Please refer to doc/en/rdma.md to enable it.";
Review Comment:
这里需要贴上github的full path方便用户直接点开吗？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on pull request #1968: fix typo in rdma doc
zyearn commented on PR #1968: URL: https://github.com/apache/incubator-brpc/pull/1968#issuecomment-1292523595 这里”使能“应该是enable的意思 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on pull request #1899: Macos workflow
zyearn commented on PR #1899: URL: https://github.com/apache/incubator-brpc/pull/1899#issuecomment-1292515385 看了下主要是两个地方： ``` I1026 15:17:31 5891 bthread_butex_unittest.cpp:61] Joined thread 4294969088 at 232338us [0] Expected: (labs(elp - (th - (bthread_t*)arg + 1) * 10L)) <= (15000L), actual: 131917 vs 15000 ``` ``` bthread_butex_unittest.cpp:59: Failure Expected: (labs(elp - (th - (bthread_t*)arg + 1) * 10L)) <= (15000L), actual: 65739 vs 15000 ``` 再改一改试试？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1899: Macos workflow
guodongxiaren commented on PR #1899: URL: https://github.com/apache/incubator-brpc/pull/1899#issuecomment-1292212191 @zyearn 改了以后还有其他地方失败 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] chenBright opened a new pull request, #1968: fix typo in rdma doc
chenBright opened a new pull request, #1968: URL: https://github.com/apache/incubator-brpc/pull/1968 ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影响): - Breaking backward compatibility(向后兼容性): --- ### Check List: - Please make sure your changes are compilable(请确保你的更改可以通过编译). - When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试). - Please follow [Contributor Covenant Code of Conduct](../CODE_OF_CONDUCT.md).(请遵循贡献者准则). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: Apply to Become Committer
Welcome Zhaogeng. Thank you for your contribution of RDMA to brpc. Best Regards. On Wed, Oct 26, 2022 at 8:48 PM fisherman wrote: > welcome zhaogeng > > Jerry Tan 于2022年10月26日周三 17:03写道： > > > welcome, zhaogeng. > > > > On 2022/10/26 02:15:55 Hu go wrote: > > > Welcome Zhaogeng. > > > > > > Best Regards, > > > Xiguo > > > > > > On Wed, Oct 26, 2022 at 10:00 AM Weibing Wang > wrote: > > > > > > > > Welcome! > > > > > > > > On Wed, Oct 26, 2022 at 9:55 AM Shuai Liu > > wrote: > > > > > > > > > > Welcome Zhaogeng. > > > > > > > > > > Best Regards, > > > > > serverglen > > > > > > > > > > > > > > > Xiaofeng 于2022年10月26日周三 09:01写道： > > > > > > > > > > > Welcome Zhaogeng! > > > > > > > > > > > > Regards, > > > > > > Xiaofeng > > > > > > > > > > > > Jiashun Zhu 于 2022年10月26日周三 01:46写道： > > > > > > > > > > > > > Welcome Zhaogeng. > > > > > > > > > > > > > > On Tue, 25 Oct 2022 at 17:35, Zhaogeng Li > > > wrote: > > > > > > > > > > > > > > > Hi all, > > > > > > > > > > > > > > > > > > > > > > > > I'm Zhaogeng Li (李兆耕), an engineer from Baidu. > > > > > > > > Currently, I'm doing something related to high performance > > network > > > > > > (e.g. > > > > > > > > rdma) inside cloud datacenter. > > > > > > > > In Baidu, there are many applications using brpc as the basic > > > > > > > > communication framework. > > > > > > > > To enable rdma in brpc, we make these applications use rdma > > much more > > > > > > > > easily. > > > > > > > > > > > > > > > > > > > > > > > > Recently, I commited a PR of rdma to brpc ( > > > > > > > > https://github.com/apache/incubator-brpc/pull/1836). > > > > > > > > This feature was just merged into master branch as an > > experimental > > > > > > > feature > > > > > > > > in the latest brpc release. > > > > > > > > I'm writing this email to apply to become a committer of brpc > > project > > > > > > > > formally. > > > > > > > > I hope more users can enjoy the rdma feature and give > > feedbacks. > > > > > > > > Together, we can make rdma as one of the standard > > communication method > > > > > > in > > > > > > > > brpc, to enhance the application performance. > > > > > > > > > > > > > > > > > > > > > > > > Thanks a lot. > > > > > > > > > > > > > > > > > > > > > > > > BR, > > > > > > > > Zhaogeng Li @ Baidu > > > > > > > > > > > > > > > > > > > > > - > > > > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > > > > For additional commands, e-mail: dev-h...@brpc.apache.org > > > > > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > > > For additional commands, e-mail: dev-h...@brpc.apache.org > > > > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > > For additional commands, e-mail: dev-h...@brpc.apache.org > > > > > > -- > --- > Best Regards :-) >
[GitHub] [incubator-brpc] Tuvie opened a new pull request, #1967: add warning for rdma invoke when brpc is not compiled with rdma
Tuvie opened a new pull request, #1967: URL: https://github.com/apache/incubator-brpc/pull/1967 ### What problem does this PR solve? Issue Number: 1966 Problem Summary: When brpc is not compiled with rdma, a binary may not be linked correctly if the application invoke it. ### What is changed and the side effects? Changed: Add warning and force exit in GlobalRdmaInitializeOrDie if BRPC_WITH_RDMA is not defined. Side effects: - Performance effects(性能影响): None - Breaking backward compatibility(向后兼容性): None --- ### Check List: - Please make sure your changes are compilable(请确保你的更改可以通过编译). - When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试). - Please follow [Contributor Covenant Code of Conduct](../CODE_OF_CONDUCT.md).(请遵循贡献者准则). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] Tuvie commented on issue #1966: 编译链接错误
Tuvie commented on issue #1966: URL: https://github.com/apache/incubator-brpc/issues/1966#issuecomment-1292111741 This is because brpc is not compile with rdma. Let me add a warning for this kind of mistake. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] HehuaTang commented on issue #1966: 编译链接错误
HehuaTang commented on issue #1966: URL: https://github.com/apache/incubator-brpc/issues/1966#issuecomment-1291991775 cmake -DWITH_RDMA=on . # in brpc project's directory can fixed this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] HehuaTang closed issue #1966: 编译链接错误
HehuaTang closed issue #1966: 编译链接错误 URL: https://github.com/apache/incubator-brpc/issues/1966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: Apply to Become Committer
welcome zhaogeng Jerry Tan 于2022年10月26日周三 17:03写道： > welcome, zhaogeng. > > On 2022/10/26 02:15:55 Hu go wrote: > > Welcome Zhaogeng. > > > > Best Regards, > > Xiguo > > > > On Wed, Oct 26, 2022 at 10:00 AM Weibing Wang wrote: > > > > > > Welcome! > > > > > > On Wed, Oct 26, 2022 at 9:55 AM Shuai Liu > wrote: > > > > > > > > Welcome Zhaogeng. > > > > > > > > Best Regards, > > > > serverglen > > > > > > > > > > > > Xiaofeng 于2022年10月26日周三 09:01写道： > > > > > > > > > Welcome Zhaogeng! > > > > > > > > > > Regards, > > > > > Xiaofeng > > > > > > > > > > Jiashun Zhu 于 2022年10月26日周三 01:46写道： > > > > > > > > > > > Welcome Zhaogeng. > > > > > > > > > > > > On Tue, 25 Oct 2022 at 17:35, Zhaogeng Li > wrote: > > > > > > > > > > > > > Hi all, > > > > > > > > > > > > > > > > > > > > > I'm Zhaogeng Li (李兆耕), an engineer from Baidu. > > > > > > > Currently, I'm doing something related to high performance > network > > > > > (e.g. > > > > > > > rdma) inside cloud datacenter. > > > > > > > In Baidu, there are many applications using brpc as the basic > > > > > > > communication framework. > > > > > > > To enable rdma in brpc, we make these applications use rdma > much more > > > > > > > easily. > > > > > > > > > > > > > > > > > > > > > Recently, I commited a PR of rdma to brpc ( > > > > > > > https://github.com/apache/incubator-brpc/pull/1836). > > > > > > > This feature was just merged into master branch as an > experimental > > > > > > feature > > > > > > > in the latest brpc release. > > > > > > > I'm writing this email to apply to become a committer of brpc > project > > > > > > > formally. > > > > > > > I hope more users can enjoy the rdma feature and give > feedbacks. > > > > > > > Together, we can make rdma as one of the standard > communication method > > > > > in > > > > > > > brpc, to enhance the application performance. > > > > > > > > > > > > > > > > > > > > > Thanks a lot. > > > > > > > > > > > > > > > > > > > > > BR, > > > > > > > Zhaogeng Li @ Baidu > > > > > > > > > > > > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > > > For additional commands, e-mail: dev-h...@brpc.apache.org > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > > For additional commands, e-mail: dev-h...@brpc.apache.org > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > For additional commands, e-mail: dev-h...@brpc.apache.org > > -- --- Best Regards :-)
[GitHub] [incubator-brpc] serverglen commented on a diff in pull request #1964: support mvariable dump by prometheus rpc service
serverglen commented on code in PR #1964:
URL: https://github.com/apache/incubator-brpc/pull/1964#discussion_r1005599888
##
src/brpc/builtin/prometheus_metrics_service.cpp:
##
@@ -200,6 +200,13 @@ int DumpPrometheusMetricsToIOBuf(butil::IOBuf* output) {
return -1;
}
os.move_to(*output);
+
+PrometheusMetricsDumper dumper_md(, g_server_info_prefix);
Review Comment:
是不是加个flags开关比较好？默认不输出多维度bvar。毕竟有些mbvar的维度可能比较多。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] cdjingit commented on pull request #1964: support mvariable dump by prometheus rpc service
cdjingit commented on PR #1964: URL: https://github.com/apache/incubator-brpc/pull/1964#issuecomment-1291852611 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] HehuaTang opened a new issue, #1966: 编译链接错误
HehuaTang opened a new issue, #1966: URL: https://github.com/apache/incubator-brpc/issues/1966 **Describe the bug (描述bug)** # git pull Already up-to-date. # git branch * master rdma-old # pwd /root/rdma/incubator-brpc/example/rdma_performance/bu make client [ 25%] Linking CXX executable client CMakeFiles/client.dir/client.cpp.o: In function `main': client.cpp:(.text.startup+0x181): undefined reference to `brpc::rdma::GlobalRdmaInitializeOrDie()' collect2: error: ld returned 1 exit status make[3]: *** [client] Error 1 make[2]: *** [CMakeFiles/client.dir/all] Error 2 make[1]: *** [CMakeFiles/client.dir/rule] Error 2 make: *** [client] Error 2 **To Reproduce (复现方法)** master 分支编译错误 **Expected behavior (期望行为)** 版本能够编译通过，测试rdma功能 **Versions (各种版本)** OS:centos7.7 Compiler:gcc brpc: master protobuf:none **Additional context/screenshots (更多上下文/截图)** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on pull request #1964: support mvariable dump by prometheus rpc service
wwbmmm commented on PR #1964: URL: https://github.com/apache/incubator-brpc/pull/1964#issuecomment-1291786786 LGTM @serverglen 有空也看看 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on pull request #1965: fix: domain name length
wwbmmm commented on PR #1965: URL: https://github.com/apache/incubator-brpc/pull/1965#issuecomment-1291755562 建议补充一下边界值的单测 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on a diff in pull request #1965: fix: domain name length
wwbmmm commented on code in PR #1965:
URL: https://github.com/apache/incubator-brpc/pull/1965#discussion_r1005438299
##
src/butil/endpoint.cpp:
##
@@ -304,12 +304,17 @@ int str2endpoint(const char* ip_str, int port, EndPoint*
point) {
int hostname2endpoint(const char* str, EndPoint* point) {
// Should be enough to hold ip address
-char buf[64];
+// The definitive descriptions of the rules for forming domain names
appear in RFC 1035, RFC 1123, RFC 2181,
+// and RFC 5892. The full domain name may not exceed the length of 253
characters in its textual representation
+// (Domain Names - Domain Concepts and Facilities. IETF.
doi:10.17487/RFC1034. RFC 1034.).
+// For cacheline optimize, use buf size as 256;
+char buf[256];
Review Comment:
建议加个static_assert
MAX_DOMAIN_LENGTH < sizeof(buf)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
Re: Apply to Become Committer
welcome, zhaogeng. On 2022/10/26 02:15:55 Hu go wrote: > Welcome Zhaogeng. > > Best Regards, > Xiguo > > On Wed, Oct 26, 2022 at 10:00 AM Weibing Wang wrote: > > > > Welcome! > > > > On Wed, Oct 26, 2022 at 9:55 AM Shuai Liu wrote: > > > > > > Welcome Zhaogeng. > > > > > > Best Regards, > > > serverglen > > > > > > > > > Xiaofeng 于2022年10月26日周三 09:01写道： > > > > > > > Welcome Zhaogeng! > > > > > > > > Regards, > > > > Xiaofeng > > > > > > > > Jiashun Zhu 于 2022年10月26日周三 01:46写道： > > > > > > > > > Welcome Zhaogeng. > > > > > > > > > > On Tue, 25 Oct 2022 at 17:35, Zhaogeng Li wrote: > > > > > > > > > > > Hi all, > > > > > > > > > > > > > > > > > > I'm Zhaogeng Li (李兆耕), an engineer from Baidu. > > > > > > Currently, I'm doing something related to high performance network > > > > (e.g. > > > > > > rdma) inside cloud datacenter. > > > > > > In Baidu, there are many applications using brpc as the basic > > > > > > communication framework. > > > > > > To enable rdma in brpc, we make these applications use rdma much > > > > > > more > > > > > > easily. > > > > > > > > > > > > > > > > > > Recently, I commited a PR of rdma to brpc ( > > > > > > https://github.com/apache/incubator-brpc/pull/1836). > > > > > > This feature was just merged into master branch as an experimental > > > > > feature > > > > > > in the latest brpc release. > > > > > > I'm writing this email to apply to become a committer of brpc > > > > > > project > > > > > > formally. > > > > > > I hope more users can enjoy the rdma feature and give feedbacks. > > > > > > Together, we can make rdma as one of the standard communication > > > > > > method > > > > in > > > > > > brpc, to enhance the application performance. > > > > > > > > > > > > > > > > > > Thanks a lot. > > > > > > > > > > > > > > > > > > BR, > > > > > > Zhaogeng Li @ Baidu > > > > > > > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > > For additional commands, e-mail: dev-h...@brpc.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > For additional commands, e-mail: dev-h...@brpc.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[DISCUSS] Graduate Apache brpc (incubating) as a TLP
Hi, guys, Apache brpc (incubating) has learned and grown much since our incubation in 2018-11-13. It is almost 4 years now. How time flies. Now, I'm glad to call on a discussion about whether we are ready for graduation. if we all agree， I will call for a vote for the graduate. Updates since incubation: 1. We release 0.9.6, 0.9.7, 1.0.0,1.1.0, 1.2.0, 1.3.0, 6 releases by different release managers (including Jerry Tan, Zhu Jiashun, Lorin Lee, Wang Weibing, Liu Shuai, Hu Xiguo) (see it at https://incubator.apache.org/projects/brpc.html) 2. We add 5 new PPMC members including Jiashun Zhu, Wang Weibing, Cai Daojin, He Lei, and Lorin Lee. 3. We add 8 new committers, including Cai Daojin, He Lei, Mou Guiding, Lorin Lee, Wang Wei, Liu Shuai, Wang Xiaofeng, and Xiguo Hu. (Chen Guangming has passed the vote, is in the process of signing ICLA.) 4. We have 17 members subscribed on the private email list and 61 engineers subscribed on the dev mail list, The discussion on the dev mail list is active, including release, roadmap, committer related topics. (See it https://whimsy.apache.org/roster/ppmc/brpc ) 5. Branding issues have been solved and name searching has been completed. (see it at https://issues.apache.org/jira/browse/PODLINGNAMESEARCH-202) 6. Assessment of the maturity model is available at https://github.com/apache/incubator-brpc/wiki/Maturity-Assessment-for-bRPC, All answers to these check items are 'Yes'. So I feel that we are ready to graduate to be a Top level project now. Our mentors and developers, what is your opinion? Please comments. Thanks.
[GitHub] [incubator-brpc] wayslog opened a new pull request, #1965: fix: domain name length
wayslog opened a new pull request, #1965: URL: https://github.com/apache/incubator-brpc/pull/1965 ### What problem does this PR solve? Issue Number: #1911 Problem Summary: hostname2endpoint implement not compatite with domain RFCs. ### What is changed and the side effects? Changed: change the buf length as 256, and use MAX_DOMAIN_LENGTH to check the domain name valid. But I don't have an exists domain to test it. Side effects: - Performance effects(性能影响): hostname2endpoint will allocate more 192 byte memory in stack. - Breaking backward compatibility(向后兼容性): yes --- ### Check List: - Please make sure your changes are compilable(请确保你的更改可以通过编译). - When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试). - Please follow [Contributor Covenant Code of Conduct](../CODE_OF_CONDUCT.md).(请遵循贡献者准则). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] cdjingit commented on a diff in pull request #1964: support mvariable dump by prometheus rpc service
cdjingit commented on code in PR #1964:
URL: https://github.com/apache/incubator-brpc/pull/1964#discussion_r1005264079
##
src/bvar/mvariable.cpp:
##
@@ -246,6 +248,11 @@ size_t MVariable::dump_exposed(Dumper* dumper, const
DumpOptions* options) {
if (entry) {
n += entry->var->dump(dumper, );
}
+ if (n >
static_cast(FLAGS_bvar_max_dump_multi_dimension_metric_number)) {
+LOG(WARNING) << "truncated because of \
Review Comment:
日志里可以打出FLAGS_bvar_max_dump_multi_dimension_metric_number的值
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
