[GitHub] [brpc] zhangke96 commented on pull request #1808: Mongo client

[GitBox]

zhangke96 commented on PR #1808:
URL: https://github.com/apache/brpc/pull/1808#issuecomment-1386769913

   > @zhangke96 mongoclient怎么样了, 我们现在也有这样的需求
   
   最近没弄了，demo可以跑的。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org

[GitHub] [brpc] jenrryyou commented on a diff in pull request #2086: Fix butex wait_pthread handle EINTR

[GitBox]

jenrryyou commented on code in PR #2086:
URL: https://github.com/apache/brpc/pull/2086#discussion_r1073469170


##
src/bthread/butex.cpp:
##
@@ -137,7 +137,21 @@ static void wakeup_pthread(ButexPthreadWaiter* pw) {
 
 bool erase_from_butex(ButexWaiter*, bool, WaiterState);
 
-int wait_pthread(ButexPthreadWaiter& pw, timespec* ptimeout) {
+int wait_pthread(ButexPthreadWaiter& pw, const timespec* abstime) {
+timespec * ptimeout = NULL;
+timespec timeout;
+int64_t timeout_us;
+
+if (abstime != NULL) {
+timeout_us = butil::timespec_to_microseconds(*abstime) - 
butil::gettimeofday_us();
+if (timeout_us < MIN_SLEEP_US) {
+errno = ETIMEDOUT;
+return -1;

Review Comment:
   已经修改，感谢指出



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org

[GitHub] [brpc] jenrryyou commented on a diff in pull request #2086: Fix butex wait_pthread handle EINTR

[GitBox]

jenrryyou commented on code in PR #2086:
URL: https://github.com/apache/brpc/pull/2086#discussion_r1073469472


##
src/bthread/butex.cpp:
##
@@ -137,7 +137,21 @@ static void wakeup_pthread(ButexPthreadWaiter* pw) {
 
 bool erase_from_butex(ButexWaiter*, bool, WaiterState);
 
-int wait_pthread(ButexPthreadWaiter& pw, timespec* ptimeout) {
+int wait_pthread(ButexPthreadWaiter& pw, const timespec* abstime) {
+timespec * ptimeout = NULL;
+timespec timeout;
+int64_t timeout_us;
+
+if (abstime != NULL) {
+timeout_us = butil::timespec_to_microseconds(*abstime) - 
butil::gettimeofday_us();
+if (timeout_us < MIN_SLEEP_US) {
+errno = ETIMEDOUT;
+return -1;
+}
+timeout = butil::microseconds_to_timespec(timeout_us);
+ptimeout = &timeout;
+}
+
 while (true) {
 const int rc = futex_wait_private(&pw.sig, PTHREAD_NOT_SIGNALLED, 
ptimeout);

Review Comment:
   已修改



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org

[GitHub] [brpc] dandyhuang commented on issue #2048: 用户态tcp实现是否会开源呢？

[GitBox]

dandyhuang commented on issue #2048:
URL: https://github.com/apache/brpc/issues/2048#issuecomment-1396331572

   > 在7月份的视频中看到介绍说brpc实现了用户态tcp、去掉了bthread，目前是否已经上线使用？这个feature是否会开源呢？ 
![image](https://user-images.githubusercontent.com/19951954/207209476-eb8bec28-1444-4f90-a89b-c69eac029502.png)
   
   哪个视频呢，能分享一下不。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org

[GitHub] [brpc-website] wasphin commented on pull request #125: Fix download links

[GitBox]

wasphin commented on PR #125:
URL: https://github.com/apache/brpc-website/pull/125#issuecomment-1396567478

   好像是乌龙，校验文件没使用 dlcdn。
   
   等下次发版时我再改回来。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org