Re: [PR] add usercode thread pool for method (brpc)
yanglimingcn commented on PR #2215: URL: https://github.com/apache/brpc/pull/2215#issuecomment-1515725562 @wwbmmm 有时间review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[PR] add usercode thread pool for method (brpc)
yanglimingcn opened a new pull request, #2215: URL: https://github.com/apache/brpc/pull/2215 ### What problem does this PR solve? 1、应用不同接口的处理逻辑不尽相同，qps和延迟也不尽相同，很多时候我们想为某些接口预留一定的能力，比如heartbeat接口或者其它控制层面的接口。 2、应用有些接口延迟比较高，如果这些接口的请求比较多（超过worker数量）会导致其它请求的延迟增加，对于延迟敏感接口产生影响。因此需要将这些延迟高的接口独立出来。 3、不同接口处理逻辑上的不同也需要独立线程池的划分，比如，io请求要提交到绑定了磁盘设备驱动的线程上，在这个特定的线程上磁盘设备驱动完成io的提交和收割工作。 4、一些阻塞worker线程的调用会让这些worker线程不可用，影响bthread的调度，比如worker1排队很多请求，前边一个请求要阻塞worker，虽然后续请求会被调度到其它worker，但是这个过程使任务在不同worker间调度，还是有很多消耗的。 5、不同应用逻辑差异很大，很难在应用层根据服务或者方法将任务很细致的划分到不同线程池，代码实现复杂度很高，在框架层面实现能更加简单。 Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影响): - Breaking backward compatibility(向后兼容性): --- ### Check List: - Please make sure your changes are compilable(请确保你的更改可以通过编译). - When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试). - Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[I] 用brpc报free(): double free detected in tcache 2 (brpc)
trikker opened a new issue, #2214:
URL: https://github.com/apache/brpc/issues/2214
**Describe the bug (描述bug)**
我们项目中用了0.9.7的brpc，代码是前同事写的，我在编译后运行的时候遇到了double free问题，报错如下，这个报错很奇怪，Succeeded
to remove the node居然打印了2次, 但是Starts to remove timeout node只打了一次。
```
E0329 19:17:15.666198 1758 /projectcode/replication/log_replicator.cc:641]
Starts to remove timeout node=10.99.122.213:6211
E0329 19:17:15.666200 1758 /projectcode/replication/log_replicator.cc:641]
Succeeded to remove the node in replication group=10.99.122.213:6211
E0329 19:17:15.666203 1758 /projectcode/replication/log_replicator.cc:641]
Succeeded to remove the node in replication group=^P3
$_^?^@^@2.213:6211
free(): double free detected in tcache 2
```
crash的堆栈如下，看是std::string重复析构了，但是不确认是removed_ip重复析构还是r->options_.peer_id.ToString()重复析构了。
```
(gdb) bt
#0 __pthread_kill (threadid=, signo=signo@entry=6) at
../sysdeps/unix/sysv/linux/pthread_kill.c:56
#1 0x5558e5e77e89 in write_core (sig=sig@entry=6) at
/projectcode/stacktrace.cc:306
#2 0x5558e512660d in handle_fatal_signal (sig=6) at
/projectcode/signal.cc:169
#3
#4 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#5 0x7ff92e801537 in __GI_abort () at abort.c:79
#6 0x7ff92e85a768 in __libc_message (action=action@entry=do_abort,
fmt=fmt@entry=0x7ff92e9783a5 "%s\n") at ../sysdeps/posix/libc_fatal.c:155
#7 0x7ff92e861a5a in malloc_printerr (str=str@entry=0x7ff92e97a6f0
"free(): double free detected in tcache 2") at malloc.c:5347
#8 0x7ff92e863055 in _int_free (av=0x7ff27c20, p=0x7ff27c032400,
have_lock=0) at malloc.c:4201
#9 0x5558e4bf63e8 in std::__cxx11::basic_string, std::allocator >::~basic_string
(this=0x7ff2b07f8ea0, __in_chrg=) at
/usr/include/c++/10/bits/basic_string.h:657
#10 xxxmodule::LogReplicator::RemoveTimeoutNode (args=) at
/projectcode/replication/log_replicator.cc:620
#11 0x7ff92fa9088f in bthread::TaskGroup::task_runner
(skip_remained=) at
/projectcode/deps/brpc-0.9.7/src/bthread/task_group.cpp:295
#12 0x7ff92fa77821 in bthread_make_fcontext () from
/home/test/deps/lib/libbrpc.so
#13 0x in ?? ()
```
最重要的2个函数如下，这2个函数的意思是当前节点超过一段时间没收到某个节点的rpc回复，就用bthread_start_background调用RemoveTimeoutNode函数将其踢掉。
下面的std::string removed_ip = r->options_.peer_id.ToString()是620行
```
void* LogReplicator::RemoveTimeoutNode(void* args) {
LogReplicator* r = (LogReplicator*)args;
std::string removed_ip = r->options_.peer_id.ToString();
LOG(INFO) << "Starts to remove timeout node=" << removed_ip;
std::string conf_str(opt_replication_local_address);
int ret = MyNode::Instance()->RemovePeer(conf_str, removed_ip, true);
if (ret != 0) {
LOG(ERROR) << "Failed to remove the node in replication group=" <<
removed_ip;
} else {
LOG(ERROR) << "Succeeded to remove the node in replication group="
<< removed_ip;
}
}
void LogReplicator::OnHeartbeatReturned(ReplicatorId id, brpc::Controller*
cntl,
AppendLogsRequest* request,
AppendLogsResponse* response,
int64_t rpc_send_time) {
std::unique_ptr cntl_guard(cntl);
std::unique_ptr req_guard(request);
std::unique_ptr res_guard(response);
LogReplicator *r = nullptr;
bthread_id_t dummy_id = { id };
const long start_time_us = butil::gettimeofday_us();
if (bthread_id_lock(dummy_id, (void**)) != 0) {
return;
}
uint timeout = rpc_timeout_seconds;
if (!r->will_be_removed_ &&
((butil::monotonic_time_ms() - r->last_rpc_send_timestamp_) >=
(1000 * timeout))) {
r->will_be_removed_ = true;
bthread_t tid;
bthread_attr_t attr = BTHREAD_ATTR_NORMAL;
if (bthread_start_background(
, ,
RemoveTimeoutNode,
r) != 0) {
LOG(ERROR) << "Fail to remove timeout node.";
}
}
if (cntl->Failed()) {
LOG_IF(WARNING, (++r->consecutive_error_times_) % 10 == 0)
<< " Fail to issue RPC to " << r->options_.peer_id
<< " consecutive_error_times=" << r->consecutive_error_times_ <<
", "
<< cntl->ErrorText();
r->StartHeartbeatTimer(start_time_us);
CHECK_EQ(0, bthread_id_unlock(dummy_id)) << "Fail to unlock " <<
dummy_id;
return;
}
r->consecutive_error_times_ = 0;
r->UpdateLastRPCSendTimestamp(rpc_send_time);
r->StartHeartbeatTimer(start_time_us);
if (request->has_recv_start_num()) {
r->heartbeat_stage_ = 1;
} else if (request->has_empty_dummy()) {
Re: [I] Redis cluster smart client support draft (brpc)
jiangdongzi commented on issue #2142: URL: https://github.com/apache/brpc/issues/2142#issuecomment-1515631119 @wwbmmm @wayslog 又看了下draft, 感觉是不是不用定义新的PreHashLoadBalancer, 只是新定义 `ReplicaPolicy`即可  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [VOTE] Release Apache bRPC 1.5.0
+1 non-binding. I have checked: - [x] the links of the package are valid; - [x] the checksum of the package is valid; - [x] the signature of the package is valid; - [x] RELEASE_VERSION in the source code matches the current release; - [x] LICENSE and NOTICE are not absent, note that we use CI based on Skywalking-eyes to check the license; - [x] no compiled archives bundled in the source archive; - [x] compile passed on an Intel MacOS following the "Compile brpc with cmake" section of getting started. Regards, Xiaofeng On 2023/04/19 12:23:20 Xiguo Hu wrote: > Hi Apache bRPC Community, > > This is a call for vote to release Apache bRPC version 1.5.0 > > [Release Note] > Feature: > - Support IPv6 for DNS resolve by @jsl422 in #2139 > - Support naming timer sampling and worker threads by @ehds in #2136 > - Support different TimeoutConcurrencyConf for different method by > @yanglimingcn in #2112 > - Add bvar is_hidden by @serverglen in #2205 > - Add server concurrency in status builtin service by @chenBright in #2097 > - Add avg latency for prometheus metrics by @Huixxi in #2024 > Bugfix: > - Fix the issue of const unused in the example of RDMA by @goldenbean in #2187 > - Fix domain naming service host name buffer length by @ehds in #2179 > - Fix memory leak of socket by @chenBright #2169 > - Fix not end wait when ns fails to start by @chenBright #2162 > - Fix ci failed with wrong path of libprotoc by @guodongxiaren in #2132 > - Fix the periodic naming service quit problem by @chenBright in #2123 > Enhancement: > - Update github workflows to skip builds for markdown-file-only > changes by @kiminno in #2175 > - Reject initializing FlatMap when nbucket is 0 by @jamesge > - Optimize some codes that violates the C++ One Definition Rule > [-Wodr] by @lrita in #2161 > - Add _Alloc template parameters for FlatMap and FlatSet by @old-bear in #2149 > - Add type BasicStringPiece::const_pointer by @lrita in #2141 > - Operator overloading of PtrContainer by @chenBright in #2107 > - Make sure we can receive at least one request @yanglimingcn in #2106 > - Reduce cpu overhead when using rdma by @Tuvie in #2100 > - Prefer to use env to find bash by @wasphin > Improve/add documents by @haihuju, @tanzhongyi003, @wwbmmm, @wasphin, > @maheshrjl, @chenBright, @NIGHTFIGHTING, @Huixxi, @zuyu, @kiminno, > @wy1433, @20083017, @Thunderbrook > > The release candidates: > https://dist.apache.org/repos/dist/dev/brpc/1.5.0/ > > Git tag for the release: > https://github.com/apache/brpc/releases/tag/1.5.0 > > Release Commit ID: > https://github.com/apache/brpc/commit/d91768b7ece06e64ac351e83c0e791a5f4fbfbb8 > > Keys to verify the Release Candidate: > https://dist.apache.org/repos/dist/dev/brpc/KEYS > > The vote will be open for at least 72 hours or until the necessary number of > votes are reached. > > Please vote accordingly: > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason > > PMC vote is +1 binding, all others are +1 non-binding. > > Checklist for reference: > [ ] Download links are valid. > [ ] Checksums and PGP signatures are valid. > [ ] Source code distributions have correct names matching the current > release. > [ ] LICENSE and NOTICE files are correct for each brpc repo. > [ ] All files have license headers if necessary. > [ ] No compiled archives bundled in source archive. > > Regards, > Xiguo > > - > To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org > For additional commands, e-mail: dev-h...@brpc.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[VOTE] Release Apache bRPC 1.5.0
Hi Apache bRPC Community, This is a call for vote to release Apache bRPC version 1.5.0 [Release Note] Feature: - Support IPv6 for DNS resolve by @jsl422 in #2139 - Support naming timer sampling and worker threads by @ehds in #2136 - Support different TimeoutConcurrencyConf for different method by @yanglimingcn in #2112 - Add bvar is_hidden by @serverglen in #2205 - Add server concurrency in status builtin service by @chenBright in #2097 - Add avg latency for prometheus metrics by @Huixxi in #2024 Bugfix: - Fix the issue of const unused in the example of RDMA by @goldenbean in #2187 - Fix domain naming service host name buffer length by @ehds in #2179 - Fix memory leak of socket by @chenBright #2169 - Fix not end wait when ns fails to start by @chenBright #2162 - Fix ci failed with wrong path of libprotoc by @guodongxiaren in #2132 - Fix the periodic naming service quit problem by @chenBright in #2123 Enhancement: - Update github workflows to skip builds for markdown-file-only changes by @kiminno in #2175 - Reject initializing FlatMap when nbucket is 0 by @jamesge - Optimize some codes that violates the C++ One Definition Rule [-Wodr] by @lrita in #2161 - Add _Alloc template parameters for FlatMap and FlatSet by @old-bear in #2149 - Add type BasicStringPiece::const_pointer by @lrita in #2141 - Operator overloading of PtrContainer by @chenBright in #2107 - Make sure we can receive at least one request @yanglimingcn in #2106 - Reduce cpu overhead when using rdma by @Tuvie in #2100 - Prefer to use env to find bash by @wasphin Improve/add documents by @haihuju, @tanzhongyi003, @wwbmmm, @wasphin, @maheshrjl, @chenBright, @NIGHTFIGHTING, @Huixxi, @zuyu, @kiminno, @wy1433, @20083017, @Thunderbrook The release candidates: https://dist.apache.org/repos/dist/dev/brpc/1.5.0/ Git tag for the release: https://github.com/apache/brpc/releases/tag/1.5.0 Release Commit ID: https://github.com/apache/brpc/commit/d91768b7ece06e64ac351e83c0e791a5f4fbfbb8 Keys to verify the Release Candidate: https://dist.apache.org/repos/dist/dev/brpc/KEYS The vote will be open for at least 72 hours or until the necessary number of votes are reached. Please vote accordingly: [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove with the reason PMC vote is +1 binding, all others are +1 non-binding. Checklist for reference: [ ] Download links are valid. [ ] Checksums and PGP signatures are valid. [ ] Source code distributions have correct names matching the current release. [ ] LICENSE and NOTICE files are correct for each brpc repo. [ ] All files have license headers if necessary. [ ] No compiled archives bundled in source archive. Regards, Xiguo - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[brpc] branch master updated: Update release_en.md
This is an automated email from the ASF dual-hosted git repository. huixxi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new eda61e77 Update release_en.md eda61e77 is described below commit eda61e7762bcea98b85410f80a2fa55e2c618845 Author: HU AuthorDate: Wed Apr 19 19:31:02 2023 +0800 Update release_en.md --- community/release_en.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/community/release_en.md b/community/release_en.md index c5f0fa60..c57d6958 100644 --- a/community/release_en.md +++ b/community/release_en.md @@ -300,7 +300,9 @@ svn --username=lorinlee commit -m "release 1.0.0" ``` ## Verify release - +```bash +cd ~/brpc_svn/dev/brpc/1.0.0 +``` ### 1. Verify SHA512 checksum ```bash - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[brpc] branch master updated: Update release_cn.md
This is an automated email from the ASF dual-hosted git repository. huixxi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 7876 Update release_cn.md 7876 is described below commit 7876143843dec01dedcbdb27634bc6beb58d Author: HU AuthorDate: Wed Apr 19 19:29:24 2023 +0800 Update release_cn.md --- community/release_cn.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/community/release_cn.md b/community/release_cn.md index a37aecb2..b32442f4 100644 --- a/community/release_cn.md +++ b/community/release_cn.md @@ -298,7 +298,9 @@ svn --username=lorinlee commit -m "release 1.0.0" ``` ## 检查发布结果 - +```bash +cd ~/brpc_svn/dev/brpc/1.0.0 +``` ### 1. 检查 sha512 哈希 ```bash - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[brpc] annotated tag 1.5.0 updated (d91768b7 -> b2c3bc4a)
This is an automated email from the ASF dual-hosted git repository. huixxi pushed a change to annotated tag 1.5.0 in repository https://gitbox.apache.org/repos/asf/brpc.git *** WARNING: tag 1.5.0 was modified! *** from d91768b7 (commit) to b2c3bc4a (tag) tagging d91768b7ece06e64ac351e83c0e791a5f4fbfbb8 (commit) replaces 1.3.0 by XiguoHu on Wed Apr 19 17:19:36 2023 +0800 - Log - release 1.5.0 --- No new revisions were added by this update. Summary of changes: - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[brpc] branch release-1.5 updated: Update brpc.spec
This is an automated email from the ASF dual-hosted git repository.
huixxi pushed a commit to branch release-1.5
in repository https://gitbox.apache.org/repos/asf/brpc.git
The following commit(s) were added to refs/heads/release-1.5 by this push:
new d91768b7 Update brpc.spec
d91768b7 is described below
commit d91768b7ece06e64ac351e83c0e791a5f4fbfbb8
Author: HU
AuthorDate: Wed Apr 19 17:12:12 2023 +0800
Update brpc.spec
---
package/rpm/brpc.spec | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/rpm/brpc.spec b/package/rpm/brpc.spec
index f624d95b..62388e45 100644
--- a/package/rpm/brpc.spec
+++ b/package/rpm/brpc.spec
@@ -18,7 +18,7 @@
#
Name: brpc
-Version: 1.4.0
+Version: 1.5.0
Release: 1%{?dist}
Summary: Industrial-grade RPC framework using C++ Language.
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[brpc] branch release-1.5 updated: Update CMakeLists.txt
This is an automated email from the ASF dual-hosted git repository. huixxi pushed a commit to branch release-1.5 in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/release-1.5 by this push: new 8c9316a0 Update CMakeLists.txt 8c9316a0 is described below commit 8c9316a003b2a025f9b6e9036e0a7a991343d7e8 Author: HU AuthorDate: Wed Apr 19 17:11:12 2023 +0800 Update CMakeLists.txt --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 35365b27..4ac815d6 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -34,7 +34,7 @@ if(POLICY CMP0042) cmake_policy(SET CMP0042 NEW) endif() -set(BRPC_VERSION 1.4.0) +set(BRPC_VERSION 1.5.0) SET(CPACK_GENERATOR "DEB") SET(CPACK_DEBIAN_PACKAGE_MAINTAINER "brpc authors") - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[brpc] branch release-1.5 updated: Update RELEASE_VERSION
This is an automated email from the ASF dual-hosted git repository. huixxi pushed a commit to branch release-1.5 in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/release-1.5 by this push: new 0c777bc9 Update RELEASE_VERSION 0c777bc9 is described below commit 0c777bc976423d48acfe5145eaea503560f340a9 Author: HU AuthorDate: Wed Apr 19 17:09:42 2023 +0800 Update RELEASE_VERSION --- RELEASE_VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RELEASE_VERSION b/RELEASE_VERSION index 88c5fb89..bc80560f 100644 --- a/RELEASE_VERSION +++ b/RELEASE_VERSION @@ -1 +1 @@ -1.4.0 +1.5.0 - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[brpc] branch master updated: Update release_en.md
This is an automated email from the ASF dual-hosted git repository. huixxi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new cfa1800b Update release_en.md cfa1800b is described below commit cfa1800b97f825985712005a320a091bf99caf48 Author: HU AuthorDate: Wed Apr 19 16:49:50 2023 +0800 Update release_en.md --- community/release_en.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/community/release_en.md b/community/release_en.md index 9bd22e2e..c5f0fa60 100644 --- a/community/release_en.md +++ b/community/release_en.md @@ -27,7 +27,7 @@ Other: - ... ``` -### 2. Setup GPG +### 2. Setup GPG(Please skip this step if you are not a first time distributor) 1. Install GPG - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[brpc] branch master updated: Update release_cn.md
This is an automated email from the ASF dual-hosted git repository. huixxi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 3a3c5d15 Update release_cn.md 3a3c5d15 is described below commit 3a3c5d1567cc0f000f272a8f900503e2232e8d8a Author: HU AuthorDate: Wed Apr 19 16:49:08 2023 +0800 Update release_cn.md --- community/release_cn.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/community/release_cn.md b/community/release_cn.md index 175c7386..a37aecb2 100644 --- a/community/release_cn.md +++ b/community/release_cn.md @@ -31,7 +31,7 @@ Other: - ... ``` -### 2. 设置 GPG +### 2. 设置 GPG（非首次发版的同学请直接跳过此步骤） 1. 安装 GPG - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [I] bvar导致core (brpc)
haolujun commented on issue #2163: URL: https://github.com/apache/brpc/issues/2163#issuecomment-1514203735 >  我这边也遇到类似问题。 不知道是不是一样的问题。 > > 集成的brpc版本是： brpc-0.9.7-rc05.tar.gz 同样遇到了问题，版本1.4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [I] README h2 link is invalid (brpc)
lorinlee closed issue #2211: README h2 link is invalid URL: https://github.com/apache/brpc/issues/2211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
