Re: [PR] fix bug: switch between stream_rpc and baidu_std (brpc)
wwbmmm commented on PR #2678: URL: https://github.com/apache/brpc/pull/2678#issuecomment-2211691354 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [I] server中brpc::StreamWait卡在了thread::TaskGroup::sched_to (brpc)
chenBright commented on issue #2680: URL: https://github.com/apache/brpc/issues/2680#issuecomment-2211784543 StreamWrite没有返回网络错误，一直返回EAGAIN的话，应该是client挂了，但是server并没有感知到tcp连接断开，发送的数据没有收到client的ack，随后写不进去内核缓冲区后，就一直返回EAGAIN。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [I] backup request可以支持下游错误率高于一定阈值时不生效吗？ (brpc)
chenBright commented on issue #2668: URL: https://github.com/apache/brpc/issues/2668#issuecomment-2211789986 容灾方面是不是可以全面一点？ （周期或者滑动窗口）统计请求的成功率，根据成功率可以做以下策略： 1. lb选实例时，减少访问可用性弱的实例； 2. 减少重试（包括backup request）。 3. 其他，待补充。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[I] 【rdma问题请教】Server收到Client通信后直接core (brpc)
SimonCqk opened a new issue, #2683:
URL: https://github.com/apache/brpc/issues/2683
**Describe the bug (描述bug)**
在我的应用场景中，集成了brpc的多种操作，通过request_attachment或response_attachment收发，包含append、append_with_user_data、swap等多个动作，现尝试启用rdma，但还没有端到端跑通（brpc内置的rdma
example已经跑通）
**To Reproduce (复现方法)**
同时在日志中，存在：
W0706 14:41:19.870314 12521 rdma_endpoint.cpp:567] Fail to read Hello
Message from client:Socket{id=102 fd=1057 addr=33.99.77.245:38992:19733}
(0x0x7f0c83d23cc0) 33.99.77.245:38992
**疑问**
1. global initialize确认生效，尝试了在所有append_user_data的地方都register memeory，没有明显效果；
2. 后面将所有append_user_data直接改成了append，直接copy，也还是会core；
3. 可能导致core的原因有哪些？目前阻塞住了
**Versions (各种版本)**
OS:
Compiler:
brpc:
protobuf:
**Additional context/screenshots (更多上下文/截图)**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [I] Questions about idle_timeout_sec of server (brpc)
chenBright commented on issue #2681: URL: https://github.com/apache/brpc/issues/2681#issuecomment-2211811304 In this case, the connection will be closed until all rpc requests are completed. Idle timeout mechanism only release the additional reference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[PR] Fix malloc dead lock cause by contention profiler (brpc)
chenBright opened a new pull request, #2684: URL: https://github.com/apache/brpc/pull/2684 ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影响): - Breaking backward compatibility(向后兼容性): --- ### Check List: - Please make sure your changes are compilable(请确保你的更改可以通过编译). - When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试). - Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [PR] add bzlmod support (brpc)
oathdruid commented on PR #2670: URL: https://github.com/apache/brpc/pull/2670#issuecomment-2212296577 any suggestion? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [I] server中brpc::StreamWait卡在了thread::TaskGroup::sched_to (brpc)
GreateCode commented on issue #2680: URL: https://github.com/apache/brpc/issues/2680#issuecomment-2212300609 有道理，这样的话，一定时期内都是EAGAIN，while里就判定连接断开，然后return结束。 但是server的连接资源怎么释放？如果sever配置了ServerOptions.idle_timeout_sec=100, 那么超过100s后，server会把该连接释放吗？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [I] gdb_bthread_stack.py not work. (brpc)
Huixxi commented on issue #2674: URL: https://github.com/apache/brpc/issues/2674#issuecomment-2212310641 编译的时候加了-g么？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
(brpc) 01/01: Merge pull request #2678 from howarle/fix_stream_rpc
This is an automated email from the ASF dual-hosted git repository. huixxi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git commit fdc60bab6816cc7a6268fd395c954d814ca406eb Merge: 81ae605d 9c387c0e Author: HU AuthorDate: Sun Jul 7 11:51:26 2024 +0800 Merge pull request #2678 from howarle/fix_stream_rpc fix bug: switch between stream_rpc and baidu_std src/brpc/input_messenger.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [PR] fix bug: switch between stream_rpc and baidu_std (brpc)
Huixxi merged PR #2678: URL: https://github.com/apache/brpc/pull/2678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [PR] Add debug log for Socket health check (brpc)
Huixxi commented on PR #2673: URL: https://github.com/apache/brpc/pull/2673#issuecomment-2212311550 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [PR] Add debug log for Socket health check (brpc)
Huixxi merged PR #2673: URL: https://github.com/apache/brpc/pull/2673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
(brpc) branch master updated (81ae605d -> fdc60bab)
This is an automated email from the ASF dual-hosted git repository. huixxi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git from 81ae605d Merge pull request #2610 from yanglimingcn/bugfix/remove_old_rpcz_directory add 9c387c0e fix bug: switch between stream_rpc and baidu_std new fdc60bab Merge pull request #2678 from howarle/fix_stream_rpc The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/brpc/input_messenger.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
(brpc) branch master updated (fdc60bab -> 7557004e)
This is an automated email from the ASF dual-hosted git repository. huixxi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git from fdc60bab Merge pull request #2678 from howarle/fix_stream_rpc add 931ef3eb Add debug log for Socket health check new 7557004e Merge pull request #2673 from chenBright/debug_hc The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/brpc/details/health_check.cpp | 4 1 file changed, 4 insertions(+) - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
(brpc) 01/01: Merge pull request #2673 from chenBright/debug_hc
This is an automated email from the ASF dual-hosted git repository. huixxi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git commit 7557004e7d6c7eac7b8b418ce134152f0d3e2486 Merge: fdc60bab 931ef3eb Author: HU AuthorDate: Sun Jul 7 11:52:17 2024 +0800 Merge pull request #2673 from chenBright/debug_hc Add debug log for Socket health check src/brpc/details/health_check.cpp | 4 1 file changed, 4 insertions(+) - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [PR] Fix uninitialized local side of Socket (brpc)
Huixxi merged PR #2672: URL: https://github.com/apache/brpc/pull/2672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
(brpc) 01/01: Merge pull request #2672 from chenBright/fix_local_side
This is an automated email from the ASF dual-hosted git repository. huixxi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git commit 8b9138ac4c9c488e236bb9dd1cce8bb3eea173ce Merge: 7557004e edfc0079 Author: HU AuthorDate: Sun Jul 7 11:53:23 2024 +0800 Merge pull request #2672 from chenBright/fix_local_side Fix uninitialized local side of Socket src/brpc/socket.cpp | 5 ++--- test/brpc_socket_unittest.cpp | 11 +++ 2 files changed, 13 insertions(+), 3 deletions(-) - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
(brpc) branch master updated (7557004e -> 8b9138ac)
This is an automated email from the ASF dual-hosted git repository. huixxi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git from 7557004e Merge pull request #2673 from chenBright/debug_hc add edfc0079 Fix uninitialized local side of Socket new 8b9138ac Merge pull request #2672 from chenBright/fix_local_side The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/brpc/socket.cpp | 5 ++--- test/brpc_socket_unittest.cpp | 11 +++ 2 files changed, 13 insertions(+), 3 deletions(-) - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [PR] Use butil::ThreadLocal to store keytable (brpc)
Huixxi commented on PR #2645: URL: https://github.com/apache/brpc/pull/2645#issuecomment-2212314895 请问下按照这样做了设计之后，有具体的性能测试报告么？能够直观的显示这种改造在特定场景下带来的性能提升 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [I] Bvar会丢失数据 (brpc)
Huixxi commented on issue #2682: URL: https://github.com/apache/brpc/issues/2682#issuecomment-2212317073 @serverglen 这个帅哥有空看下 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [I] brpc Stream导致普通RPC无法解析 (brpc)
Huixxi closed issue #2677: brpc Stream导致普通RPC无法解析 URL: https://github.com/apache/brpc/issues/2677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [I] variable.cpp error: ‘StringFlagDestructor’ does not name a type (brpc)
Huixxi closed issue #2679: variable.cpp error: ‘StringFlagDestructor’ does not name a type URL: https://github.com/apache/brpc/issues/2679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
