[GitHub] [incubator-brpc] hairet commented on issue #1025: brpc lack of rwlock implementation
hairet commented on issue #1025: URL: https://github.com/apache/incubator-brpc/issues/1025#issuecomment-1225301469 @zyearn I recently repick some issue and find this rwlock is still not in brpc master. And I updated commit today for #1031 to fix some infrequent bugs which commited 3 years ago in our inner brpc. As #1031 had already stable used in our company in our inner brpc for more than 3 years, I think maybe you can merge this PR now.If there's any worry, maybe you can contact me,Thanks. FYI, #1026 is also mantained by us,but it's an experimental version, we don't use this recent 3 years. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] hairet commented on issue #1025: brpc lack of rwlock implementation
hairet commented on issue #1025: brpc lack of rwlock implementation URL: https://github.com/apache/incubator-brpc/issues/1025#issuecomment-576082950 > so which one is the latest? #1031 or #1026? the implementation in 1031 will be more clear,it should be the latest but in 1031 I got some error when travis-ci do linking like bvar_percentile_unittest.cpp:(.text+0x35): undefined reference to `bvar::detail::Percentile::Percentile()' this seems unreasonable as bavr test and bavr cc_library are not modified in my commit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] hairet commented on issue #1025: brpc lack of rwlock implementation
hairet commented on issue #1025: brpc lack of rwlock implementation URL: https://github.com/apache/incubator-brpc/issues/1025#issuecomment-575973899 you can use this commit,we implement rwlock,and I commit in my fork recently This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] hairet commented on issue #1025: brpc lack of rwlock implementation
hairet commented on issue #1025: brpc lack of rwlock implementation URL: https://github.com/apache/incubator-brpc/issues/1025#issuecomment-575973844 https://github.com/hairet/brpc/commit/b2f23243ba3127db82d7ee17e6caba40bead0ef3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
