[PR] Fix tcp connect interrupt (brpc)
chenBright opened a new pull request, #2664: URL: https://github.com/apache/brpc/pull/2664 ### What problem does this PR solve? Issue Number: Problem Summary: tcp_connect被中断之后,返回结果是有问题的: 1. `bthread_timed_connect / bthread_connect`:`butex_wait`返回0,errno等于`EWOULDBLOCK`或者`EINTR`,最后tcp_connect返回一个未连接成功的socket fd。 2. `pthread_timed_connect `:返回-1,errno等于`EINTR`。 ### What is changed and the side effects? Changed: 当errno等于`EWOULDBLOCK`或者`EINTR`,`pthread_fd_wait / bthread_fd_wait`继续wait到连接成功或者失败。 Side effects: - Performance effects(性能影响): - Breaking backward compatibility(向后兼容性): --- ### Check List: - Please make sure your changes are compilable(请确保你的更改可以通过编译). - When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试). - Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [PR] Fix tcp connect interrupt (brpc)
chenBright commented on PR #2664: URL: https://github.com/apache/brpc/pull/2664#issuecomment-2249582969 @wwbmmm 有空看看 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [PR] Fix tcp connect interrupt (brpc)
wwbmmm commented on PR #2664: URL: https://github.com/apache/brpc/pull/2664#issuecomment-2251845968 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [PR] Fix tcp connect interrupt (brpc)
wwbmmm merged PR #2664: URL: https://github.com/apache/brpc/pull/2664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org