Re: [PR] Support proxy and generic call of baidu protocol (brpc)

2024-06-12 Thread via GitHub 


wwbmmm merged PR #2629:
URL: https://github.com/apache/brpc/pull/2629


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org

Re: [PR] Support proxy and generic call of baidu protocol (brpc)

2024-06-10 Thread via GitHub 


chenBright commented on PR #2629:
URL: https://github.com/apache/brpc/pull/2629#issuecomment-2159676339

   done，rebase解决冲突。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org

Re: [PR] Support proxy and generic call of baidu protocol (brpc)

2024-06-03 Thread via GitHub 


wwbmmm commented on PR #2629:
URL: https://github.com/apache/brpc/pull/2629#issuecomment-2144642932

   @chenBright 这个也冲突了


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org

Re: [PR] Support proxy and generic call of baidu protocol (brpc)

2024-05-08 Thread via GitHub 


wwbmmm commented on PR #2629:
URL: https://github.com/apache/brpc/pull/2629#issuecomment-2100170325

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org

Re: [PR] Support proxy and generic call of baidu protocol (brpc)

2024-05-08 Thread via GitHub 


wwbmmm commented on code in PR #2629:
URL: https://github.com/apache/brpc/pull/2629#discussion_r1593737641


##
src/brpc/controller.h:
##
@@ -305,7 +305,9 @@ friend void policy::ProcessThriftRequest(InputMessageBase*);
 // Get/own SampledRequest for sending dumped requests.
 // Deleted along with controller.
 void reset_sampled_request(SampledRequest* req);
-const SampledRequest* sampled_request() { return _sampled_request; }
+const SampledRequest* sampled_request() const { return _sampled_request; }

Review Comment:
   好吧，那就不改了



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org

Re: [PR] Support proxy and generic call of baidu protocol (brpc)

2024-05-06 Thread via GitHub 


chenBright commented on code in PR #2629:
URL: https://github.com/apache/brpc/pull/2629#discussion_r1591749586


##
src/brpc/controller.h:
##
@@ -305,7 +305,9 @@ friend void policy::ProcessThriftRequest(InputMessageBase*);
 // Get/own SampledRequest for sending dumped requests.
 // Deleted along with controller.
 void reset_sampled_request(SampledRequest* req);
-const SampledRequest* sampled_request() { return _sampled_request; }
+const SampledRequest* sampled_request() const { return _sampled_request; }

Review Comment:
   1. 也不太合适，SampledRequest不仅支持baidu-std协议，还支持其他协议。
   2. 改名字是不是对兼容性不友好？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org

Re: [PR] Support proxy and generic call of baidu protocol (brpc)

2024-05-06 Thread via GitHub 


chenBright commented on code in PR #2629:
URL: https://github.com/apache/brpc/pull/2629#discussion_r1591749339


##
src/brpc/controller.h:
##
@@ -305,7 +305,9 @@ friend void policy::ProcessThriftRequest(InputMessageBase*);
 // Get/own SampledRequest for sending dumped requests.
 // Deleted along with controller.
 void reset_sampled_request(SampledRequest* req);
-const SampledRequest* sampled_request() { return _sampled_request; }
+const SampledRequest* sampled_request() const { return _sampled_request; }

Review Comment:
   1. 也不太合适，SampledRequest不仅支持baidu-std协议，还支持其他协议。
   2. 改名字是不是对兼容性不友好？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org

Re: [PR] Support proxy and generic call of baidu protocol (brpc)

2024-05-06 Thread via GitHub 


chenBright commented on code in PR #2629:
URL: https://github.com/apache/brpc/pull/2629#discussion_r1591749339


##
src/brpc/controller.h:
##
@@ -305,7 +305,9 @@ friend void policy::ProcessThriftRequest(InputMessageBase*);
 // Get/own SampledRequest for sending dumped requests.
 // Deleted along with controller.
 void reset_sampled_request(SampledRequest* req);
-const SampledRequest* sampled_request() { return _sampled_request; }
+const SampledRequest* sampled_request() const { return _sampled_request; }

Review Comment:
   1. 也不太合适，SampledRequest不仅支持baidu-std协议，还支持其他协议。
   2. 改名字是不是对兼容性不友好？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org

Re: [PR] Support proxy and generic call of baidu protocol (brpc)

2024-05-05 Thread via GitHub 


wwbmmm commented on code in PR #2629:
URL: https://github.com/apache/brpc/pull/2629#discussion_r1590504015


##
src/brpc/controller.h:
##
@@ -305,7 +305,9 @@ friend void policy::ProcessThriftRequest(InputMessageBase*);
 // Get/own SampledRequest for sending dumped requests.
 // Deleted along with controller.
 void reset_sampled_request(SampledRequest* req);
-const SampledRequest* sampled_request() { return _sampled_request; }
+const SampledRequest* sampled_request() const { return _sampled_request; }

Review Comment:
   感觉这个名字叫sampled_request是不是不太合适了，可以改成baidu_rpc_request或者baidu_std_request



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org

[PR] Support proxy and generic call of baidu protocol (brpc)

2024-05-01 Thread via GitHub 


chenBright opened a new pull request, #2629:
URL: https://github.com/apache/brpc/pull/2629

   ### What problem does this PR solve?
   
   Issue Number: #2405
   
   Problem Summary:
   
   ### What is changed and the side effects?
   
   Changed:
   
   Side effects:
   - Performance effects(性能影响):
   
   - Breaking backward compatibility(向后兼容性): 
   
   ---
   ### Check List:
   - Please make sure your changes are compilable(请确保你的更改可以通过编译).
   - When providing us with a new feature, it is best to add related 
tests(如果你向我们增加一个新的功能, 请添加相关测试).
   - Please follow [Contributor Covenant Code of 
Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org