Re: Clojure support in buildr
Hi, On Tue, Dec 7, 2010 at 10:10 AM, Chris Dean ctd...@sokitomi.com wrote: Anything I can do to help out with getting Clojure support into the trunk? We still use it daily and would love to see it be in the mainline code. There is a patch in https://issues.apache.org/jira/browse/BUILDR-259 I don't know much about Clojure but I can have a look at it. You could make it easier if you wanted to accelerate the process ;) Best way to do that is goto [1], fork buildr and apply the patches and then make sure that when you run rake spec no (extra) failures are caused by the patch. [1] https://github.com/apache/buildr -- Cheers, Peter Donald
Re: Clojure support in buildr
Best way to do that is goto [1], fork buildr and apply the patches and then make sure that when you run rake spec no (extra) failures are Yep, done all that and submitted a patch in BUILDR-259. Cheers, Chris Dean
Re: Clojure support in buildr
On Tue, Dec 7, 2010 at 11:25 AM, Chris Dean ctd...@sokitomi.com wrote: Best way to do that is goto [1], fork buildr and apply the patches and then make sure that when you run rake spec no (extra) failures are Yep, done all that and submitted a patch in BUILDR-259. Well if you could add a link to the github project then that would great. The way I can just merge it, run the tests and makes it much easier to work over it :) The only github project I see in the issue is not based of current version of buildr (It is based off a version from May) and it is by someone else (Daniel Spiewak) so you will need get him to ok the donation (just get him to add a note to the jira issue as he is already a buildr committer). -- Cheers, Peter Donald
Re: Clojure support in buildr
Peter Donald pe...@realityforge.org writes: Well if you could add a link to the github project then that would great. The way I can just merge it, run the tests and makes it much easier to work over it :) Sure thing. There is a repo at https://github.com/ctdean/buildr But that is also from an older Buildr version. It doesn't match the patch exactly as I have made a few additions to support the current (tiny) user base. BTW, this Clojure patch was was originally submitted on Aug 6. During the discussion then (on the users mailing list) it was suggested that the best way to send a patch is through Jira so that the ASF license grant checkbox can be clicked. Cheers, Chris Dean
Re: Clojure support in buildr
On Tue, Dec 7, 2010 at 12:07 PM, Chris Dean ctd...@sokitomi.com wrote: Peter Donald pe...@realityforge.org writes: Well if you could add a link to the github project then that would great. The way I can just merge it, run the tests and makes it much easier to work over it :) Sure thing. There is a repo at https://github.com/ctdean/buildr But that is also from an older Buildr version. It doesn't match the patch exactly as I have made a few additions to support the current (tiny) user base. kool. If you could merge it with the current Buildr version that would be much appreciated. I am not sure how much change has happened in the last 4 months but enough :) -- Cheers, Peter Donald
Re: Clojure support in buildr
On Mon, Dec 6, 2010 at 3:10 PM, Chris Dean ctd...@sokitomi.com wrote: Anything I can do to help out with getting Clojure support into the trunk? We still use it daily and would love to see it be in the mainline code. There is a patch in https://issues.apache.org/jira/browse/BUILDR-259 Hi Chris, I've been working on your patch on-and-off. I tried to get it done before November but then we had a second baby and other bug-fix type issues took priority and my available time. Most of the work on the patch is to align it with idioms used for other languages. For example, the patch uses options.clojure as namespace for options whereas with other languages options are configured either via the project or via the language module proper. Sometimes it also required fixing/aligning other parts of Buildr. Case in point, back in October I refactored parts of the shell task which already supported clojure so it would use the same artifact(s) and not depend on CLOJURE_HOME being set. One thing I'm not entirely happy with the patch is how it supports multiple language. That's more of a problem with buildr than with your patch but I mention it because clojure exacerbates the issue. The way things are done currently doesn't really compose well with other features of buildr.For instance, with groovy and scala the tooling provides joint compilation and joint documentation. I don't think clojure will support that even down the road so it makes, say, the doc task problematic. I think it would simplify things if the clojure module didn't try to do joint compilation and if we went and fixed that problem at the buildr level instead. I'm hoping that we can multiplex multiple languages into one project tree while retaining several projects instances in buildr. This would keep the model sane. So assuming this simplification then I think clojure support could go in Buildr 1.4.5 (maybe in January? hasn't been discussed yet) and hopefully we can get project multiplexing in that same timeframe. How does that sound? alex
