Re: [VOTE] Apache BVal 3.0.0

[Romain Manni-Bucau]

+1, thanks JL

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le mar. 10 oct. 2023 à 18:25, Jean-Louis Monteiro 
a écrit :

> Hi,
>
> As discussed, here is the vote for Apache BVal 3.0.0
> This is the first fully `jakarta` based release and implements Jakarta Bean
> Validation 3.0 from EE 9. EE 10 actually did not bring anything new so it
> is also compatible with EE 10.
>
> See https://jakarta.ee/specifications/bean-validation/3.0/ for the release
> content
>
> *Git TAG*
> https://github.com/apache/bval/tree/3.0.0
>
> *Sources*
> https://dist.apache.org/repos/dist/dev/bval/bval-3.0.0/
>
> *Staging repo*
> https://repository.apache.org/content/repositories/orgapachebval-1013
>
> *Release notes*
> Bug
>
>- [BVAL-214 <https://issues.apache.org/jira/browse/BVAL-214>] - Missing
>relocate for javax.xml.bind
>- [BVAL-215 <https://issues.apache.org/jira/browse/BVAL-215>] - BVal
>defaultConstraints.properties not relocated
>- [BVAL-216 <https://issues.apache.org/jira/browse/BVAL-216>] -
>ValidationParser fails to read in new jakarta namespace
>- [BVAL-217 <https://issues.apache.org/jira/browse/BVAL-217>] - TCK
>
>  
> org.hibernate.beanvalidation.tck.tests.constraints.crossparameter.GenericAndCrossParameterConstraintTest
>
> New Feature
>
>- [BVAL-218 <https://issues.apache.org/jira/browse/BVAL-218>] - Add
>Jakarta Validation TCK using BVal classifier
>
>
> *Please VOTE*
>
> [+1] go for it
> [+0] meh, don't care
> [-1] stop, with why
>
> The VOTE is open for 72h (or as needed)
>
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>

Re: roll an alpha-1 release?

[Romain Manni-Bucau]

Hi,

What the plan to be final? Idea would be that if alpha is not justified by
coming work let's do a final.

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le ven. 21 avr. 2023 à 08:29, Mark Struberg  a
écrit :

> hi folks!
>
> BVAL-3.0 looks already really decent - thanks for all that hard work!
> What do you think about an alpha-1 release?
>
> I've yesterday published a snapshot to our official ASF snapshots repo to
> be able to work on OpenJPA-4.0.
> But before we do any release of a EE9/10 project we'd need some other
> stable releases first. BVAL is rather low in the dependency graph, so I'd
> go for it soonish.
>
> wdyt?
>
> LieGrue,
> strub

Re: Jakarta EE 10 development

[Romain Manni-Bucau]

+1

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le jeu. 9 févr. 2023 à 12:16, Thomas Andraschko 
a écrit :

> +1
>
> Am Do., 9. Feb. 2023 um 11:51 Uhr schrieb Jean-Louis Monteiro <
> jlmonte...@tomitribe.com>:
>
> > I'll push new snapshot and run in TomEE and if it looks good, I'll maybe
> > start a release if that's ok
> >
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Thu, Feb 9, 2023 at 11:47 AM Jean-Louis Monteiro <
> > jlmonte...@tomitribe.com> wrote:
> >
> > > Awesome
> > >
> > > --
> > > Jean-Louis Monteiro
> > > http://twitter.com/jlouismonteiro
> > > http://www.tomitribe.com
> > >
> > >
> > > On Thu, Feb 9, 2023 at 11:46 AM Thomas Andraschko <
> > > andraschko.tho...@gmail.com> wrote:
> > >
> > >> all tests are passing now!
> > >> i also created github actions for checking each commit/PR
> > >>
> > >> Am Mi., 8. Feb. 2023 um 15:34 Uhr schrieb Jean-Louis Monteiro <
> > >> jlmonte...@tomitribe.com>:
> > >>
> > >> > Hi,
> > >> >
> > >> > Some quick status about the situation.
> > >> > I created a maintenance branch for bval-2.x which is the latest
> javax
> > >> > compatible version.
> > >> >
> > >> > The main development branch is now moved to jakarta namespace and
> all
> > >> APIs
> > >> > updated. Currently the build fails on bval-jsr module because of 2
> > >> tests.
> > >> > It's probably a setup issue.
> > >> >
> > >> > I did a build with -DskipTests and then ran the TCK and got the
> > >> following
> > >> > results. Note that it uses OpenWebBeans 4.0.0-SNAPSHOT which is
> still
> > >> under
> > >> > development but should be enough for us.
> > >> >
> > >> > In essence, signature tests ok
> > >> > In terms of TCK, here is where I am
> > >> >
> > >> > [ERROR] Tests run: 1051, Failures: 104, Errors: 0, Skipped: 0
> > >> >
> > >> > Hope it helps
> > >> > --
> > >> > Jean-Louis Monteiro
> > >> > http://twitter.com/jlouismonteiro
> > >> > http://www.tomitribe.com
> > >> >
> > >>
> > >
> >
>

Re: Migrate to jakarta namespace

[Romain Manni-Bucau]

Hi,

@Francesco, bval has a jakarta version in 2.0.6 (same as openjpa) - if it
helps.
@Thomas: never saw it used nor any user feedback on the list so assuming
they are not used at all.

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le jeu. 12 janv. 2023 à 09:06, Thomas Andraschko <
andraschko.tho...@gmail.com> a écrit :

> what about the extras, romain? are they unused?
>
> Am Do., 12. Jan. 2023 um 08:57 Uhr schrieb Francesco Chicchiriccò <
> ilgro...@apache.org>:
>
> > Hi there,
> > not a dev here, just chiming in because we're moving Syncope to Spring
> > Boot 3 / Jakarta and had to replace our BVal dependencies with Hibernate
> > Validator's just because of namespace issues.
> >
> > Just my 2c: speaking from experience with OpenJPA, shading works but a
> > clean new version would help with usability.
> > Either way, making BVal compatible with Jakarta is something that would
> > definitely help users stick with it and not to be forced to change.
> >
> > Thanks for your work with BVal, everyone.
> > Regards.
> >
> > On 2023/01/10 12:46:49 Thomas Andraschko wrote:
> > > Hi,
> > >
> > > i would like to finally migrate BVal to the jakarta namespace.
> > > WDYT?
> > > I would create a 2.0.x branch and set master to 3.0.0-SNAPSHOT.
> > >
> > > I know that shading has benefits but as we dont have that many releases
> > > each year, i dont think its a big problem for us to handle master and a
> > > second branch if we really need a release.
> > > Also check our JIRA - we dont have any recent bug reports.
> > >
> > > Best regards,
> > > Thomas
> > >
> >
>

Re: Migrate to jakarta namespace

[Romain Manni-Bucau]

My proposal would be:

Remove: all modules but jsr+tck?
Change: align on *last* spec release (we miss a few details/adjustments
iirc)

These are the main visible changes I would care about as an user.


Le mar. 10 janv. 2023 à 19:04, Thomas Andraschko <
andraschko.tho...@gmail.com> a écrit :

> I can also do bigger changes, we just need to talk about it
> What should we change, move or remove?
>
> Matt Benson  schrieb am Di., 10. Jan. 2023, 18:25:
>
> > I'm not strongly opinionated either way here but I will note that if we
> are
> > going to start having a bunch of dependabot upgrade PRs we could increase
> > our release frequency as a result.
> >
> > Matt
> >
> > On Tue, Jan 10, 2023, 10:50 AM Romain Manni-Bucau  >
> > wrote:
> >
> > > Well, the main change is that it will go 2.x so we need to review what
> we
> > > change/drop at the same time (think we should drop extras for ex) so
> > while
> > > I agree it can be fast to switch jakarta and get a 2.x it'd be sad to
> not
> > > take the time to make the project a "single" module (it is what it is
> as
> > of
> > > today now we dropped most of extensions).
> > > And even if 3.x is always a good excuse to not do it this would be a
> pity
> > > for me.
> > >
> > > So once again, if it is just to sed javax/jakarta I don't see any gain
> > for
> > > the project nor users but only some risk.
> > > If we really go 2.x let's go but not half baked - which would hold a
> > > "final" release compared to current state.
> > >
> > > Hope it makes sense.
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > <https://rmannibucau.metawerx.net/> | Old Blog
> > > <http://rmannibucau.wordpress.com> | Github <
> > > https://github.com/rmannibucau> |
> > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > > <
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > >
> > >
> > >
> > > Le mar. 10 janv. 2023 à 17:20, Jean-Louis Monteiro <
> > > jlmonte...@tomitribe.com>
> > > a écrit :
> > >
> > > > Yes agreed. The release or feature frequency makes it substainable
> > > >
> > > > Le mar. 10 janv. 2023, 14:37, Thomas Andraschko <
> > > > andraschko.tho...@gmail.com>
> > > > a écrit :
> > > >
> > > > > Yeah i understand your case with "only migrate when we implement
> new
> > > > > features"
> > > > > but i also have to say that currently its winter and i have more
> time
> > > > >
> > > > > so better now than never and its unlikely that we ship much
> releases
> > > this
> > > > > year, so i dont think we have any big or even any real overhead
> > > > > maybe only like merging 1 commit and do 1 release :D
> > > > >
> > > > >
> > > > > Romain Manni-Bucau  schrieb am Di., 10.
> Jan.
> > > > 2023,
> > > > > 15:02:
> > > > >
> > > > > > I'll probably be on the same camps than for others, if you plan
> to
> > > impl
> > > > > new
> > > > > > jakarta features a clear +1 otherwise let's wait codebase need
> > > changes
> > > > > > cause it reduces costs until it happens (so more a -+0).
> > > > > >
> > > > > > Le mar. 10 janv. 2023 à 13:51, Jean-Louis Monteiro <
> > > > > > jlmonte...@tomitribe.com>
> > > > > > a écrit :
> > > > > >
> > > > > > > Big +1
> > > > > > > After running into this for months, I don't see benefits in
> > shading
> > > > > > really.
> > > > > > > Creating a maintenance branch for 2.x and moving main/master to
> > 3.x
> > > > is
> > > > > > the
> > > > > > > way to go in my opinion.
> > > > > > >
> > > > > > >
> > > > > > > If you need, I can help. I upgraded already the BVal TCK in
> TomEE
> > > in
> > > > > this
> > > > > > > PR https://github.com/apache/tomee/pull/1002
> > > > > > >
> > > > > > > So far I only see 4 failures but I need to update the API to EE
> > 10
> > > > and
> > > > > > run
> > > > > > > again.
> > > > > > > --
> > > > > > > Jean-Louis Monteiro
> > > > > > > http://twitter.com/jlouismonteiro
> > > > > > > http://www.tomitribe.com
> > > > > > >
> > > > > > >
> > > > > > > On Tue, Jan 10, 2023 at 1:47 PM Thomas Andraschko <
> > > > > > > andraschko.tho...@gmail.com> wrote:
> > > > > > >
> > > > > > > > Hi,
> > > > > > > >
> > > > > > > > i would like to finally migrate BVal to the jakarta
> namespace.
> > > > > > > > WDYT?
> > > > > > > > I would create a 2.0.x branch and set master to
> 3.0.0-SNAPSHOT.
> > > > > > > >
> > > > > > > > I know that shading has benefits but as we dont have that
> many
> > > > > releases
> > > > > > > > each year, i dont think its a big problem for us to handle
> > master
> > > > > and a
> > > > > > > > second branch if we really need a release.
> > > > > > > > Also check our JIRA - we dont have any recent bug reports.
> > > > > > > >
> > > > > > > > Best regards,
> > > > > > > > Thomas
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: Migrate to jakarta namespace

[Romain Manni-Bucau]

Well, the main change is that it will go 2.x so we need to review what we
change/drop at the same time (think we should drop extras for ex) so while
I agree it can be fast to switch jakarta and get a 2.x it'd be sad to not
take the time to make the project a "single" module (it is what it is as of
today now we dropped most of extensions).
And even if 3.x is always a good excuse to not do it this would be a pity
for me.

So once again, if it is just to sed javax/jakarta I don't see any gain for
the project nor users but only some risk.
If we really go 2.x let's go but not half baked - which would hold a
"final" release compared to current state.

Hope it makes sense.

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le mar. 10 janv. 2023 à 17:20, Jean-Louis Monteiro 
a écrit :

> Yes agreed. The release or feature frequency makes it substainable
>
> Le mar. 10 janv. 2023, 14:37, Thomas Andraschko <
> andraschko.tho...@gmail.com>
> a écrit :
>
> > Yeah i understand your case with "only migrate when we implement new
> > features"
> > but i also have to say that currently its winter and i have more time
> >
> > so better now than never and its unlikely that we ship much releases this
> > year, so i dont think we have any big or even any real overhead
> > maybe only like merging 1 commit and do 1 release :D
> >
> >
> > Romain Manni-Bucau  schrieb am Di., 10. Jan.
> 2023,
> > 15:02:
> >
> > > I'll probably be on the same camps than for others, if you plan to impl
> > new
> > > jakarta features a clear +1 otherwise let's wait codebase need changes
> > > cause it reduces costs until it happens (so more a -+0).
> > >
> > > Le mar. 10 janv. 2023 à 13:51, Jean-Louis Monteiro <
> > > jlmonte...@tomitribe.com>
> > > a écrit :
> > >
> > > > Big +1
> > > > After running into this for months, I don't see benefits in shading
> > > really.
> > > > Creating a maintenance branch for 2.x and moving main/master to 3.x
> is
> > > the
> > > > way to go in my opinion.
> > > >
> > > >
> > > > If you need, I can help. I upgraded already the BVal TCK in TomEE in
> > this
> > > > PR https://github.com/apache/tomee/pull/1002
> > > >
> > > > So far I only see 4 failures but I need to update the API to EE 10
> and
> > > run
> > > > again.
> > > > --
> > > > Jean-Louis Monteiro
> > > > http://twitter.com/jlouismonteiro
> > > > http://www.tomitribe.com
> > > >
> > > >
> > > > On Tue, Jan 10, 2023 at 1:47 PM Thomas Andraschko <
> > > > andraschko.tho...@gmail.com> wrote:
> > > >
> > > > > Hi,
> > > > >
> > > > > i would like to finally migrate BVal to the jakarta namespace.
> > > > > WDYT?
> > > > > I would create a 2.0.x branch and set master to 3.0.0-SNAPSHOT.
> > > > >
> > > > > I know that shading has benefits but as we dont have that many
> > releases
> > > > > each year, i dont think its a big problem for us to handle master
> > and a
> > > > > second branch if we really need a release.
> > > > > Also check our JIRA - we dont have any recent bug reports.
> > > > >
> > > > > Best regards,
> > > > > Thomas
> > > > >
> > > >
> > >
> >
>

Re: Migrate to jakarta namespace

[Romain Manni-Bucau]

I'll probably be on the same camps than for others, if you plan to impl new
jakarta features a clear +1 otherwise let's wait codebase need changes
cause it reduces costs until it happens (so more a -+0).

Le mar. 10 janv. 2023 à 13:51, Jean-Louis Monteiro 
a écrit :

> Big +1
> After running into this for months, I don't see benefits in shading really.
> Creating a maintenance branch for 2.x and moving main/master to 3.x is the
> way to go in my opinion.
>
>
> If you need, I can help. I upgraded already the BVal TCK in TomEE in this
> PR https://github.com/apache/tomee/pull/1002
>
> So far I only see 4 failures but I need to update the API to EE 10 and run
> again.
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Tue, Jan 10, 2023 at 1:47 PM Thomas Andraschko <
> andraschko.tho...@gmail.com> wrote:
>
> > Hi,
> >
> > i would like to finally migrate BVal to the jakarta namespace.
> > WDYT?
> > I would create a 2.0.x branch and set master to 3.0.0-SNAPSHOT.
> >
> > I know that shading has benefits but as we dont have that many releases
> > each year, i dont think its a big problem for us to handle master and a
> > second branch if we really need a release.
> > Also check our JIRA - we dont have any recent bug reports.
> >
> > Best regards,
> > Thomas
> >
>

Re: [VOTE] Apache BVal 2.0.6

[Romain Manni-Bucau]

+1

Le jeu. 9 juin 2022 à 21:23, Jean-Louis Monteiro 
a écrit :

> my own +1
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Thu, Jun 9, 2022 at 5:53 PM Thomas Andraschko <
> andraschko.tho...@gmail.com> wrote:
>
> > +1
> >
> > thanks, great work to add the jakarta-tck!
> >
> > Am Mi., 8. Juni 2022 um 16:06 Uhr schrieb Jean-Louis Monteiro <
> > jlmonte...@tomitribe.com>:
> >
> > > Hi,
> > >
> > > I'd like to put Apache BVal 2.0.6 up for vote.
> > >
> > > The changes are mainly to support Jakarta namespace and pass standalone
> > > Validation TCK for both EE8 and EE9.
> > >
> > > Sources
> > > https://dist.apache.org/repos/dist/dev/bval/bval-2.0.6/
> > >
> > > Staging repo
> > > https://repository.apache.org/content/repositories/orgapachebval-1012
> > >
> > > Github Tag
> > > https://github.com/apache/bval/tree/2.0.6
> > >
> > > Release notes
> > > https://issues.apache.org/jira/projects/BVAL/versions/12349311
> > >
> > > Bug
> > >
> > >- [BVAL-214 ] -
> > Missing
> > >relocate for javax.xml.bind
> > >- [BVAL-215 ] -
> BVal
> > >defaultConstraints.properties not relocated
> > >- [BVAL-217 ] - TCK
> > >
> > >
> >
> org.hibernate.beanvalidation.tck.tests.constraints.crossparameter.GenericAndCrossParameterConstraintTest
> > >
> > > New Feature
> > >
> > >- [BVAL-218 ] - Add
> > >Jakarta Validation TCK using BVal classifier
> > >
> > >
> > > Please VOTE
> > >
> > > [+1] go ship it
> > > [+0] meh, don't care
> > > [-1] stop, there is a ${showstopper}
> > >
> > > The VOTE is open for 72h
> > > --
> > > Jean-Louis Monteiro
> > > http://twitter.com/jlouismonteiro
> > > http://www.tomitribe.com
> > >
> >
>

Re: Release Apache BVal 2.0.6 as a compatible EE8 and EE9 validation implementation

[Romain Manni-Bucau]

+1

Le ven. 3 juin 2022 à 08:27, Jean-Louis Monteiro 
a écrit :

> Hi all,
>
> We are now fully Jakarta Validation compliant, both for EE8 (javax) and EE
> 9 (jakarta).
> I'd like to release 2.0.6 and create a CSR to get Apache BVal listed as a
> compatible implementation.
>
> Any objections?
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>

Re: Jenkins job to build and deploy snapshots

[Romain Manni-Bucau]

Ping infra maybe on slack, can be a perm issue on nexus.

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le jeu. 7 avr. 2022 à 08:55, Jean-Louis Monteiro 
a écrit :

> Thanks. Then I don't know why I got a 401
>
> Le jeu. 7 avr. 2022 à 08:27, Romain Manni-Bucau  a
> écrit :
>
> > Just redeployed.
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > <https://rmannibucau.metawerx.net/> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > <
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >
> >
> >
> > Le jeu. 7 avr. 2022 à 07:21, Jean-Louis Monteiro <
> jlmonte...@tomitribe.com
> > >
> > a écrit :
> >
> > > I tried it from by box but I'm getting a 401.
> > > Can someone please try it just to see if this is my setup ?
> > >
> > > Le mer. 6 avr. 2022 à 22:49, Romain Manni-Bucau  >
> > a
> > > écrit :
> > >
> > > > Think we always deployes from our box when needed by the past.
> > > >
> > > > Le mer. 6 avr. 2022 à 22:06, Matt Benson  a
> écrit
> > :
> > > >
> > > > > I don't recall us having one. I sort of had the impression that
> > > recurrent
> > > > > snapshots were frowned upon as they might be viewed as
> > > "quasi-releases."
> > > > >
> > > > > Matt
> > > > >
> > > > > On Wed, Apr 6, 2022, 2:57 PM Jean-Louis Monteiro <
> > > > jlmonte...@tomitribe.com
> > > > > >
> > > > > wrote:
> > > > >
> > > > > > Hi,
> > > > > >
> > > > > > Is there a Jenkins job to build and deploy snapshots?
> > > > > > Can't see anything here https://ci-builds.apache.org/
> > > > > >
> > > > > > Thanks
> > > > > > --
> > > > > > Jean-Louis Monteiro
> > > > > > http://twitter.com/jlouismonteiro
> > > > > > http://www.tomitribe.com
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: Jenkins job to build and deploy snapshots

[Romain Manni-Bucau]

Just redeployed.

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le jeu. 7 avr. 2022 à 07:21, Jean-Louis Monteiro 
a écrit :

> I tried it from by box but I'm getting a 401.
> Can someone please try it just to see if this is my setup ?
>
> Le mer. 6 avr. 2022 à 22:49, Romain Manni-Bucau  a
> écrit :
>
> > Think we always deployes from our box when needed by the past.
> >
> > Le mer. 6 avr. 2022 à 22:06, Matt Benson  a écrit :
> >
> > > I don't recall us having one. I sort of had the impression that
> recurrent
> > > snapshots were frowned upon as they might be viewed as
> "quasi-releases."
> > >
> > > Matt
> > >
> > > On Wed, Apr 6, 2022, 2:57 PM Jean-Louis Monteiro <
> > jlmonte...@tomitribe.com
> > > >
> > > wrote:
> > >
> > > > Hi,
> > > >
> > > > Is there a Jenkins job to build and deploy snapshots?
> > > > Can't see anything here https://ci-builds.apache.org/
> > > >
> > > > Thanks
> > > > --
> > > > Jean-Louis Monteiro
> > > > http://twitter.com/jlouismonteiro
> > > > http://www.tomitribe.com
> > > >
> > >
> >
>

Re: ValidationParser fails to parse Jakarta XML configuration files.

[Romain Manni-Bucau]

If not crazy can be great to avoid to need to rereleasz just for that else
ok for me.

Le mer. 6 avr. 2022 à 21:48, Jean-Louis Monteiro 
a écrit :

> Hi,
>
> while working on the TomEE TCK, I realized BVal was not supporting XML
> configuration because of the way we handle XML Namespaces.
>
> We do have a Filter to override the namespace if it does not match what we
> expect, but there was a bug in the logic, so the namespace was only
> overridden for the root element, but our package-info.java is different
> from jakarta namespace.
>
> Long story short, I created an issue and I'm about to push the fix for it.
> https://issues.apache.org/jira/browse/BVAL-216
>
> I went ahead and slightly updated the TCK module locally to see if we can
> also pass the Jakarta Validation 3.0 TCK.
>
> Aside from 2 failures for the test class
> GenericAndCrossParameterConstraintTest. We do pass them all. It's been
> added in 3.0, so it might be something we haven't implemented yet.
>
> I can address it later or in the next big bang version unless someone can
> have a look.
> Created BVal-217 to track it.
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>

Re: Jenkins job to build and deploy snapshots

[Romain Manni-Bucau]

Think we always deployes from our box when needed by the past.

Le mer. 6 avr. 2022 à 22:06, Matt Benson  a écrit :

> I don't recall us having one. I sort of had the impression that recurrent
> snapshots were frowned upon as they might be viewed as "quasi-releases."
>
> Matt
>
> On Wed, Apr 6, 2022, 2:57 PM Jean-Louis Monteiro  >
> wrote:
>
> > Hi,
> >
> > Is there a Jenkins job to build and deploy snapshots?
> > Can't see anything here https://ci-builds.apache.org/
> >
> > Thanks
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
>

Re: Ready for a 2.0.6 release?

[Romain Manni-Bucau]

sounds good to me

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le mar. 5 avr. 2022 à 13:21, Thomas Andraschko 
a écrit :

> should i do a release this week, so we can move forward to jakarta?
> as i said, i would do the work here. we need do it anyway in the future and
> bval seems very stable.
>
> Am Sa., 2. Apr. 2022 um 11:31 Uhr schrieb Romain Manni-Bucau <
> rmannibu...@gmail.com>:
>
> > Le sam. 2 avr. 2022 à 11:15, Jean-Louis Monteiro <
> jlmonte...@tomitribe.com
> > >
> > a écrit :
> >
> > > v3 is a good reason even though it's only in jakarta not in javax as
> far
> > as
> > > I recall
> > >
> >
> > Yep but it is not rare these days to relocate and run on javax and
> jakarta
> > the same bundle so supporting it in javax is good IMHO
> >
> > --
> > > Jean-Louis Monteiro
> > > http://twitter.com/jlouismonteiro
> > > http://www.tomitribe.com
> > >
> > >
> > > On Sat, Apr 2, 2022 at 11:10 AM Romain Manni-Bucau <
> > rmannibu...@gmail.com>
> > > wrote:
> > >
> > > > If we want the relocation to work it is just a matter of fixing the
> > shade
> > > > configuration with a relocating transformer.
> > > > Think it is the way to go since we have a fix since last release
> which
> > is
> > > > to support v3 descriptors so can be worth releasing like that then
> > > > switching codebase to something closer to jakarta maybe since we
> don't
> > > > upgrade it often.
> > > >
> > > > Hope it makes sense.
> > > >
> > > > Romain Manni-Bucau
> > > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > > <https://rmannibucau.metawerx.net/> | Old Blog
> > > > <http://rmannibucau.wordpress.com> | Github <
> > > > https://github.com/rmannibucau> |
> > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > > > <
> > > >
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > >
> > > >
> > > >
> > > > Le sam. 2 avr. 2022 à 10:57, Jean-Louis Monteiro <
> > > jlmonte...@tomitribe.com
> > > > >
> > > > a écrit :
> > > >
> > > > > In case it helps, here is what I had to do in order to get BVal to
> > work
> > > > in
> > > > > TomEE in the jakarta namespace
> > > > >
> > > > > https://github.com/apache/tomee/tree/master/deps/bval-jsr-shade
> > > > >
> > > > > Apologies, this is dirty.
> > > > > --
> > > > > Jean-Louis Monteiro
> > > > > http://twitter.com/jlouismonteiro
> > > > > http://www.tomitribe.com
> > > > >
> > > > >
> > > > > On Sat, Apr 2, 2022 at 10:53 AM Jean-Louis Monteiro <
> > > > > jlmonte...@tomitribe.com> wrote:
> > > > >
> > > > > > If they are just for the relocation which still does not work
> > because
> > > > > > properties are not transformed. Then I agree there is no point in
> > > > > releasing
> > > > > > something that does not work and we'll do better by updating the
> > > source
> > > > > > code itself
> > > > > >
> > > > > > Le ven. 1 avr. 2022 à 14:05, Thomas Andraschko <
> > > > > > andraschko.tho...@gmail.com> a écrit :
> > > > > >
> > > > > >> the last commits, since the last latest release are just for
> > shading
> > > > > >> i can do the release but since we get a "real" jakarta version
> > soon,
> > > > not
> > > > > >> sure if its required
> > > > > >>
> > > > > >> Am Fr., 1. Apr. 2022 um 13:21 Uhr schrieb Matt Benson <
> > > > > mben...@apache.org
> > > > > >> >:
> > > > > >>
> > > > > >> > I guess I haven't been in the right places to see what the
> > > > > requirements

Re: Ready for a 2.0.6 release?

[Romain Manni-Bucau]

Le sam. 2 avr. 2022 à 11:15, Jean-Louis Monteiro 
a écrit :

> v3 is a good reason even though it's only in jakarta not in javax as far as
> I recall
>

Yep but it is not rare these days to relocate and run on javax and jakarta
the same bundle so supporting it in javax is good IMHO

--
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Sat, Apr 2, 2022 at 11:10 AM Romain Manni-Bucau 
> wrote:
>
> > If we want the relocation to work it is just a matter of fixing the shade
> > configuration with a relocating transformer.
> > Think it is the way to go since we have a fix since last release which is
> > to support v3 descriptors so can be worth releasing like that then
> > switching codebase to something closer to jakarta maybe since we don't
> > upgrade it often.
> >
> > Hope it makes sense.
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > <https://rmannibucau.metawerx.net/> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > <
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >
> >
> >
> > Le sam. 2 avr. 2022 à 10:57, Jean-Louis Monteiro <
> jlmonte...@tomitribe.com
> > >
> > a écrit :
> >
> > > In case it helps, here is what I had to do in order to get BVal to work
> > in
> > > TomEE in the jakarta namespace
> > >
> > > https://github.com/apache/tomee/tree/master/deps/bval-jsr-shade
> > >
> > > Apologies, this is dirty.
> > > --
> > > Jean-Louis Monteiro
> > > http://twitter.com/jlouismonteiro
> > > http://www.tomitribe.com
> > >
> > >
> > > On Sat, Apr 2, 2022 at 10:53 AM Jean-Louis Monteiro <
> > > jlmonte...@tomitribe.com> wrote:
> > >
> > > > If they are just for the relocation which still does not work because
> > > > properties are not transformed. Then I agree there is no point in
> > > releasing
> > > > something that does not work and we'll do better by updating the
> source
> > > > code itself
> > > >
> > > > Le ven. 1 avr. 2022 à 14:05, Thomas Andraschko <
> > > > andraschko.tho...@gmail.com> a écrit :
> > > >
> > > >> the last commits, since the last latest release are just for shading
> > > >> i can do the release but since we get a "real" jakarta version soon,
> > not
> > > >> sure if its required
> > > >>
> > > >> Am Fr., 1. Apr. 2022 um 13:21 Uhr schrieb Matt Benson <
> > > mben...@apache.org
> > > >> >:
> > > >>
> > > >> > I guess I haven't been in the right places to see what the
> > > requirements
> > > >> > have been for jakarta migration. Are the few recent commits to
> > master
> > > of
> > > >> > such a nature that it would help users transition to have a last
> > 2.0.x
> > > >> > release?
> > > >> >
> > > >> > Matt
> > > >> >
> > > >> > On Fri, Apr 1, 2022, 4:20 AM Jean-Louis Monteiro <
> > > >> jlmonte...@tomitribe.com
> > > >> > >
> > > >> > wrote:
> > > >> >
> > > >> > > Fine with one last release and then move to Jakarta.
> > > >> > >
> > > >> > >
> > > >> > > Le ven. 1 avr. 2022 à 10:43, Romain Manni-Bucau <
> > > >> rmannibu...@gmail.com>
> > > >> > a
> > > >> > > écrit :
> > > >> > >
> > > >> > > > We have other downstream consumers so guess javax fixes are
> > needed
> > > >> so
> > > >> > ok
> > > >> > > if
> > > >> > > > there is no other fixes than jakarta relocation on master else
> > we
> > > >> > should
> > > >> > > do
> > > >> > > > at least one last javax release IMHO
> > > >> > > >
> > > >> > > > Romain Manni-Bucau
> > > >> > > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > >> > > &

Re: Ready for a 2.0.6 release?

[Romain Manni-Bucau]

If we want the relocation to work it is just a matter of fixing the shade
configuration with a relocating transformer.
Think it is the way to go since we have a fix since last release which is
to support v3 descriptors so can be worth releasing like that then
switching codebase to something closer to jakarta maybe since we don't
upgrade it often.

Hope it makes sense.

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le sam. 2 avr. 2022 à 10:57, Jean-Louis Monteiro 
a écrit :

> In case it helps, here is what I had to do in order to get BVal to work in
> TomEE in the jakarta namespace
>
> https://github.com/apache/tomee/tree/master/deps/bval-jsr-shade
>
> Apologies, this is dirty.
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Sat, Apr 2, 2022 at 10:53 AM Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> wrote:
>
> > If they are just for the relocation which still does not work because
> > properties are not transformed. Then I agree there is no point in
> releasing
> > something that does not work and we'll do better by updating the source
> > code itself
> >
> > Le ven. 1 avr. 2022 à 14:05, Thomas Andraschko <
> > andraschko.tho...@gmail.com> a écrit :
> >
> >> the last commits, since the last latest release are just for shading
> >> i can do the release but since we get a "real" jakarta version soon, not
> >> sure if its required
> >>
> >> Am Fr., 1. Apr. 2022 um 13:21 Uhr schrieb Matt Benson <
> mben...@apache.org
> >> >:
> >>
> >> > I guess I haven't been in the right places to see what the
> requirements
> >> > have been for jakarta migration. Are the few recent commits to master
> of
> >> > such a nature that it would help users transition to have a last 2.0.x
> >> > release?
> >> >
> >> > Matt
> >> >
> >> > On Fri, Apr 1, 2022, 4:20 AM Jean-Louis Monteiro <
> >> jlmonte...@tomitribe.com
> >> > >
> >> > wrote:
> >> >
> >> > > Fine with one last release and then move to Jakarta.
> >> > >
> >> > >
> >> > > Le ven. 1 avr. 2022 à 10:43, Romain Manni-Bucau <
> >> rmannibu...@gmail.com>
> >> > a
> >> > > écrit :
> >> > >
> >> > > > We have other downstream consumers so guess javax fixes are needed
> >> so
> >> > ok
> >> > > if
> >> > > > there is no other fixes than jakarta relocation on master else we
> >> > should
> >> > > do
> >> > > > at least one last javax release IMHO
> >> > > >
> >> > > > Romain Manni-Bucau
> >> > > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> >> > > > <https://rmannibucau.metawerx.net/> | Old Blog
> >> > > > <http://rmannibucau.wordpress.com> | Github <
> >> > > > https://github.com/rmannibucau> |
> >> > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> >> > > > <
> >> > > >
> >> > >
> >> >
> >>
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >> > > > >
> >> > > >
> >> > > >
> >> > > > Le ven. 1 avr. 2022 à 10:22, Thomas Andraschko <
> >> > > > andraschko.tho...@gmail.com>
> >> > > > a écrit :
> >> > > >
> >> > > > > As TomEE had some issues with the TKC and our shaded version -
> >> what
> >> > > about
> >> > > > > doing a Big-Bang change in BVal now?
> >> > > > > Sooner or later we have to do it anyway. BVal is  probably the
> >> most
> >> > > > stable
> >> > > > > lib around TomEE, so i would not care too much about
> >> maintainability.
> >> > > If
> >> > > > we
> >> > > > > have like 1 bug in 1/2 year, we can simply port it to a 2.0.x
> >> branch.
> >> > > > >
> >> > > > &

Re: Ready for a 2.0.6 release?

[Romain Manni-Bucau]

We have other downstream consumers so guess javax fixes are needed so ok if
there is no other fixes than jakarta relocation on master else we should do
at least one last javax release IMHO

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le ven. 1 avr. 2022 à 10:22, Thomas Andraschko 
a écrit :

> As TomEE had some issues with the TKC and our shaded version - what about
> doing a Big-Bang change in BVal now?
> Sooner or later we have to do it anyway. BVal is  probably the most stable
> lib around TomEE, so i would not care too much about maintainability. If we
> have like 1 bug in 1/2 year, we can simply port it to a 2.0.x branch.
>
> I would do the work, i just need a "go" ;D
>
>
> Am Do., 24. März 2022 um 01:46 Uhr schrieb Matt Benson  >:
>
> > New release sounds fine to me. I will try to better understand this new
> > issue.
> >
> > Matt
> >
> > On Wed, Mar 23, 2022, 4:58 PM Romain Manni-Bucau 
> > wrote:
> >
> > > https://github.com/yupiik/maven-shade-transformers/
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > <https://rmannibucau.metawerx.net/> | Old Blog
> > > <http://rmannibucau.wordpress.com> | Github <
> > > https://github.com/rmannibucau> |
> > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > > <
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > >
> > >
> > >
> > > Le mer. 23 mars 2022 à 22:44, Jean-Louis Monteiro <
> > > jlmonte...@tomitribe.com>
> > > a écrit :
> > >
> > > > Created also this one https://issues.apache.org/jira/browse/BVAL-215
> > > > It requires some thoughts for the fix
> > > > --
> > > > Jean-Louis Monteiro
> > > > http://twitter.com/jlouismonteiro
> > > > http://www.tomitribe.com
> > > >
> > > >
> > > > On Wed, Mar 23, 2022 at 10:16 PM Romain Manni-Bucau <
> > > rmannibu...@gmail.com
> > > > >
> > > > wrote:
> > > >
> > > > > sounds good
> > > > >
> > > > > Romain Manni-Bucau
> > > > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > > > <https://rmannibucau.metawerx.net/> | Old Blog
> > > > > <http://rmannibucau.wordpress.com> | Github <
> > > > > https://github.com/rmannibucau> |
> > > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > > > > <
> > > > >
> > > >
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > > >
> > > > >
> > > > >
> > > > > Le mer. 23 mars 2022 à 21:57, Jean-Louis Monteiro <
> > > > > jlmonte...@tomitribe.com>
> > > > > a écrit :
> > > > >
> > > > > > Hi,
> > > > > >
> > > > > > I was working on TomEE for jakarta namespace and I just fixed a
> > > > > relocation
> > > > > > issue with BVal. I am currently deploying snapshots and I'll use
> > them
> > > > in
> > > > > > TomEE. But I wanted to know if there is any issue to release
> 2.0.6
> > > and
> > > > if
> > > > > > not, is there anything pending you guys want to get in?
> > > > > >
> > > > > > Overall, the only issue is the one I created to fix relocation.
> > > > > > --
> > > > > > Jean-Louis Monteiro
> > > > > > http://twitter.com/jlouismonteiro
> > > > > > http://www.tomitribe.com
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: Ready for a 2.0.6 release?

[Romain Manni-Bucau]

https://github.com/yupiik/maven-shade-transformers/

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le mer. 23 mars 2022 à 22:44, Jean-Louis Monteiro 
a écrit :

> Created also this one https://issues.apache.org/jira/browse/BVAL-215
> It requires some thoughts for the fix
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Wed, Mar 23, 2022 at 10:16 PM Romain Manni-Bucau  >
> wrote:
>
> > sounds good
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > <https://rmannibucau.metawerx.net/> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > <
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >
> >
> >
> > Le mer. 23 mars 2022 à 21:57, Jean-Louis Monteiro <
> > jlmonte...@tomitribe.com>
> > a écrit :
> >
> > > Hi,
> > >
> > > I was working on TomEE for jakarta namespace and I just fixed a
> > relocation
> > > issue with BVal. I am currently deploying snapshots and I'll use them
> in
> > > TomEE. But I wanted to know if there is any issue to release 2.0.6 and
> if
> > > not, is there anything pending you guys want to get in?
> > >
> > > Overall, the only issue is the one I created to fix relocation.
> > > --
> > > Jean-Louis Monteiro
> > > http://twitter.com/jlouismonteiro
> > > http://www.tomitribe.com
> > >
> >
>

Re: Ready for a 2.0.6 release?

[Romain Manni-Bucau]

sounds good

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le mer. 23 mars 2022 à 21:57, Jean-Louis Monteiro 
a écrit :

> Hi,
>
> I was working on TomEE for jakarta namespace and I just fixed a relocation
> issue with BVal. I am currently deploying snapshots and I'll use them in
> TomEE. But I wanted to know if there is any issue to release 2.0.6 and if
> not, is there anything pending you guys want to get in?
>
> Overall, the only issue is the one I created to fix relocation.
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>

[jira] [Deleted] (BVAL-212) ^^ ZOMBS ROYALE HACK FREE GEMS ## ZOMBS ROYALE HACK UNLIMITED COINS $$

[Romain Manni-Bucau (Jira)]

 [ 
https://issues.apache.org/jira/browse/BVAL-212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau deleted BVAL-212:



> ^^ ZOMBS ROYALE HACK FREE GEMS ## ZOMBS ROYALE HACK UNLIMITED COINS $$
> --
>
> Key: BVAL-212
> URL: https://issues.apache.org/jira/browse/BVAL-212
> Project: BVal
>  Issue Type: Bug
>Reporter: Cherlyn Johnson
>Priority: Major
>
> h1. %% Zombs Royale Hack Aimbot Pc @@ Zombs Royale Hack Free Gems No Human 
> Verification ^^ Zombs Royale Hack Script ||
>  *[CLICK HERE FOR ZOMBS ROYALE HACK|https://playhack.in/e/908d09e]* 
>  *[CLICK HERE FOR ZOMBS ROYALE HACK|https://playhack.in/e/908d09e]* 
> As a Result of Zombs Royale being a top-notch shot, we generally prefer 
> Entirely automatic weapons as accuracy is less regarding. Attempt to get Your 
> palms in an assault rifle or SMG to start till it's likely to encounter The 
> mythical mini-gun when you have got this bad boy you're ready to unleash a 
> Rockets launchers alongside snipers are great high harm at more number 
> Weapons, but on account of how big the map and in addition the variety of 
> players, You'll actually just utilize those for randomly shooting into the 
> specific distance fretting about that excess kill.
> h2. Zombs Royale Mod Hack Apk
> It's all about the potions. Ammo is rather simple to locate for that reason 
> after You've Got a substantial gun that you don't ever obviously need to be 
> concerned with exercising. Utilize The very initial potions you happen around 
> to create your shield, once in 100 percent
> Store whatever you could easily find the hands-on, all these can truly offer 
> you a hand in Those extreme fire-fights at that you might possibly be 
> battling many contests. We suggest having two separate completely automatic 
> weapons, and ideally an attack Gun and also a minigun, just one high damage 
> weapon, a good rocket launcher or even Sniper, and using the remaining of 
> somebody's slots.
> As a way to get your location booked, you want to complete a few tasks. 
> Remember, it's totally free you simply must accomplish one offer from our 
> patrons. When you're done with it, you will probably be redirected to your 
> page with a huge number of distinct hacks very similar to the Zombs.io hack! 
> You will have an opportunity to inject unlimited Gems into your own game, so 
> begin right now. Get your access pass and cheat in any match you desire!
> h2. How To Hack Zombs Royale To Get Skins
> To obtain an access password that you want to download one app any other 
> offer that you like. If you are not convinced to try it, you can watch how to 
> find free gems tutorial at the top of this article! Have fun, don't abuse 
> this tool, and then please leave a comment should you want any help! We are 
> here for you personally!
> Zombs Royale is an Action game created by End Game. BlueStacks application 
> player is your ideal stage (emulator) to play this Android game on your PC or 
> Mac to get a vivid gaming experience. As with any fight royale match, Zombs 
> Royale can be actually a casino game filled up with a power that appreciates 
> playing. Jump from a moving plane, on to a huge guide where 2D structures 
> will be sitting tight to you. You will probably be coordinated with 99 other 
> separate parts in a conflict for endurance.
> h2. Zombs Royale Hack No Download
> Crush boxes and discover revolutionary weapons that you may use to wreck your 
> own rival. Experience the thrills of the chase and prevent that hazardous 
> gas, which at one point over time will induce one to a specific area on the 
> guide. Be cautious, since you're going to probably be fleeing from this, in a 
> similar course as your foes. At this time when destiny completes, you will 
> come across each other, and also you should get an honest attempt to simply 
> take them out first. Play Zombs Royale on PC with BlueStacks and check if 
> you're going to be the only real ones.
> To really get your area saved, you have to complete perhaps not many 
> undertakings. Try to not stress, it's totally free that you simply need in 
> order to complete one suggestion from our patrons. Furthermore, once you're 
> finished with it, you will be diverted to a page with many various hacks like 
> this Zombs.io hack! You will find a chance to infuse limitless stones into 
> your own game, so begin only at that moment. Get your entry pass and cheat in 
> any game you require.
> h2. Zombs Royale Hack Coins Script
> Zombsroyale.io hack 2021 is a cost-free app made by our designers, that 
> all

[jira] [Deleted] (BVAL-204) ➡️➡️ FREE MINECRAFT ACCOUNT AND PASSWORD GENERATOR ☑️☑️ MINECRAFT GENERATOR PREMIUM ACCOUNT DOWNLOAD ##

[Romain Manni-Bucau (Jira)]

 [ 
https://issues.apache.org/jira/browse/BVAL-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau deleted BVAL-204:



> ➡️➡️ FREE MINECRAFT ACCOUNT AND PASSWORD GENERATOR ☑️☑️ MINECRAFT GENERATOR 
> PREMIUM ACCOUNT DOWNLOAD ##
> ---
>
> Key: BVAL-204
> URL: https://issues.apache.org/jira/browse/BVAL-204
> Project: BVal
>  Issue Type: Bug
>Reporter: Ivan Hill
>Priority: Major
>
> h1. ## Minecraft Premium Account Generator Mediafire ^^ Minecraft Premium 
> Account Online Generator @@ Minecraft Premium Account Generator v3.Zip !!
>  *[CLICK HERE FOR FREE MINECRAFT ACCOUNT|https://gametrick.top/i/27585ce]* 
> 
>  *[CLICK HERE FOR FREE MINECRAFT ACCOUNT|https://gametrick.top/i/27585ce]* 
> 
> Looks like you have any free time to spare time and would want to research 
> infinite worlds on the gaming phenomenon named Minecraft.
> Besides helping people to curl up, Minecraft provides a caliber of gameplay 
> that may inspire imagination & positivity as well as sometimes helps with 
> fostering player IQ.
> The game enables you to build whatever out of the greatest castles into the 
> simplest of homes. Additionally, it has lots of entertaining modes to play 
> along with brilliant features to offer you.
> h2. Free Minecraft Account And Password
> And although the Minecraft match was developed originally for Xbox and PC 
> platforms, it's been expanded to become widely popular on handheld and mobile 
> gadgets.
> However, the unhappy fact is that many people don't get to enjoy playing 
> Minecraft with its full features as it's not entirely free.
> Free Minecraft Accounts generator premium account alts 2021 full list that 
> works with all. You'll be delighted to know you could delight in using the 
> premium edition of Minecraft accounts free of charge through licensed 
> third-party websites.
> h2. Full Access Minecraft Accounts
> The Nulled domain name has always ranked among the very common third-party 
> websites you may visit if you're searching to score the free Premium 
> Minecraft accounts.
> This website is quite unique as you may not be asked to download any support 
> files. Thus, your gaming device is protected against the chance of becoming 
> infected with Trojan viruses.
> Nowadays you have chances to get free Minecraft premium accounts 2020 with 
> login user and password from our alts database!
> Rare Minecraft Premium Accounts 2021 -- Vast world without limitation is what 
> you see on Minecraft. As a match, it provides players a lot of chances to 
> research, create, and perform many things. Essentially, Minecraft is really a 
> casino game in which you decide on your personal aim. There are many modes, 
> such as multiplayer, survival, experience, creative, and spectator. To get 
> into and play, you need a premium account. As opposed to paying, you'll come 
> across free Minecraft premium accounts 2021 to get an alternative.
> h2. How To Get Minecraft For Free On Pc
> Minecraft Fly Hack No Survey is the real thing and can continue you every 
> moment. Please share and send them pages to all your mates to allow them to 
> acquire an edge over their fav video game. We have the most effective working 
> free match generators web I can't stress again there is no human affirmation 
> or download ever. So there is no time for this to waste get Minecraft Account 
> Hack 2018 Nascar now free working hacks and cheats without human verification 
> or download.
> Minecraft Alts Generator, Minecraft Alt Account Generator, Minecraft Free 
> Alts Generator, Free Minecraft Account And Password, Premium Account 
> Generator Minecraft, Minecraft Premium Account Generator Free, Minecraft 
> Hacker Tool, Free Premium Minecraft Account Generator No Surveys, Minecraft 
> Pe Hack Download, Minecraft Free Premium Account Generator Mac, Free 
> Minecraft Premium Account Generator No Survey, Minecraft Alt Generator Free, 
> Minecraft Free Alt Generator, Random Minecraft Account Generator, Minecraft 
> Account Hacks, Cracked Minecraft Accounts, Free Minecraft Java Account, Free 
> Minecraft Accounts No Survey, Minecraft Codes Generator, Premium Account 
> Generator For Minecraft



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Deleted] (BVAL-201) $$ GENSHIN IMPACT HACK NO OFFERS OR SURVEYS %% PRIMOGEMS GENERATOR FOR GENSHIN IMPACT @@

[Romain Manni-Bucau (Jira)]

 [ 
https://issues.apache.org/jira/browse/BVAL-201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau deleted BVAL-201:



> $$ GENSHIN IMPACT HACK NO OFFERS OR SURVEYS %% PRIMOGEMS GENERATOR FOR 
> GENSHIN IMPACT @@
> 
>
> Key: BVAL-201
> URL: https://issues.apache.org/jira/browse/BVAL-201
> Project: BVal
>  Issue Type: Bug
>Reporter: Jan Jackson
>Priority: Major
>
> h1. $$ Genshin Impact Hack Mobile ^^ Genshin Impact Hack Primogems !! No 
> Survey Genshin Impact Hack **
>  *[CLICK HERE FOR GENSHIN IMPACT HACK|https://playhack.in/e/4b7a3b5]* 
>  *[CLICK HERE FOR GENSHIN IMPACT HACK|https://playhack.in/e/4b7a3b5]* 
> Genshin Impact" is really a free-to-play match, but its gacha part is among 
> its heavily compacted attributes. Very good item, miHoYo, the overall game 
> developer supporting the hit RPG title, has a penchant for giving free 
> in-game to players. Here are some ideas about the best way to have free 
> Primogems and Hero's Wit.
> h3. The Best Way To Obtain Free Primogems and Hero's Wit
> About Reddit along with other social media programs,"Genshin Impact" players 
> are still sharing with a newly discovered code that they have used to find 
> free Primogems. MiHoYo has a reputation for craftily falling codes on its 
> official site or on its societal media accounts. Sometimes, it reactivates 
> old codes, which makes this most recent discovery not surprising, 
> particularly for seasoned players.
> h2. Genshin Impact Hack Tool Cheats Generator
> This newly discovered promo-code at the game rewards players with 50 
> Primogems. All they have to do is to key in the code GOLNXLAKC58 on the 
> Redeem code page found on the game's official site. Interestingly, it seems 
> like this newly discovered code is available to all players around all 
> regions and platforms, but other codes are all region-restricted.
> Primogems, a premium currency in struck gacha ARPG title"Genshin Impact," 
> could be hard to get without players spending actual money. However, unknown 
> to many, getting more of those twinkling gems does not necessarily mean 
> spending real-world money. Here are some ideas about the best way to get more 
> Primogems at"Genshin Impact" for free.
> Players that are unfamiliar with redeeming codes will not have difficulty 
> doing so because the steps are simple. They just must go to the official 
> miHoYo gift page and make sure that they are logged in under their account. 
> When on the page, they will need to select their region, input the code as 
> written, and hit Redeem. Travelers will subsequently receive the free goodies 
> in Paimon's inbox.
> h2. Genshin Impact Jailbreak Hack
> Some players can think about the free Primogems from the codes as small 
> gifts, but they mount up easily. Players want 150 Primogems to make a Wish in 
> the match which can provide them 5-star characters and weapons. Getting free 
> in-game items without being forced to explore is already a great reward.
> " Genshin Impact" is now playable on PC and PS-4 and on iOS and Android 
> apparatus. 
> The release of MiHoYo's latest gacha match, Genshin Impact has fans of this 
> genre raving across the match's addictive capabilities. The hack-and-slash 
> combat blended with elemental synergies has attracted a feeling of excitement 
> and excitement to anyone who plays it. Even the narrative and design were 
> heavily praised at which town contrasted its own features to another 
> role-playing match, the Legend of Zelda: Breath of this Wild.
> Genshin Impact hack Crystals and Mora| Genshin Impact Hack No Human 
> Verification No Survey No Offers| Genshin Impact unlimited Crystals and Mora| 
> Hack Genshin Impact Ios| Genshin Impact Hack Mod| Genshin Impact Lucky 
> Patcher Hack| Genshin Impact Elite Trophy Hack| Genshin Impact cheats| 
> Android Genshin Impact Hack| Primogems Generator For Genshin Impact| Genshin 
> Impact Primogems Generator| Genshin Impact Hack Tool Cheats Generator| Hack 
> Genshin Impact Android| Genshin Impact Hack No Survey Download| Stamina Hack 
> Genshin Impact| Genshin Impact Hack Tool Liatools| Genshin Impact Real Hack| 
> Genshin Impact apk mod| Hack Primogems Genshin Impact| Genshin Impact Hack 
> Download



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Deleted] (BVAL-211) ** ZOMBS ROYALE HACK NO HUMAN VERIFICATION %% ZOMBS ROYALE ALL ITEMS HACK ^^

[Romain Manni-Bucau (Jira)]

 [ 
https://issues.apache.org/jira/browse/BVAL-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau deleted BVAL-211:



> ** ZOMBS ROYALE HACK NO HUMAN VERIFICATION %% ZOMBS ROYALE ALL ITEMS HACK ^^
> 
>
> Key: BVAL-211
> URL: https://issues.apache.org/jira/browse/BVAL-211
> Project: BVal
>  Issue Type: Bug
>Reporter: Hazel Graham
>Priority: Major
>
> h1. %% Zombs Royale Skins Hack $$ Zombs Royale Hack Online Games ## Zombs 
> Royale Hack No Download @@
>  *[CLICK HERE FOR ZOMBS ROYALE HACK|https://gametrick.top/i/908d09e]* 
>  *[CLICK HERE FOR ZOMBS ROYALE HACK|https://gametrick.top/i/908d09e]* 
> Properly, to answer this query as fast as possible and keep both you and 
> ourselves a few times, you might want to inspect the video in which all of 
> this has already been explained. Before we head to the cheats, tips & 
> procedure manual component, let us investigate the straightforward of the 
> game; in the event that you already know, then skip this section and mind to 
> the pointers section below. The straightforward -> on this recreation, your 
> objective is to call home to tell the story till the quit.
> h2. Zombs Battle Royale Hack
> The match functions in many manners; solo, squad, duo, along with 50v50. In 
> the majority of these manners, your objective is equal. And to carry out this 
> particular mission, you want to look after plenty of stuff alongside the 
> shield, landing, interacting, concealing, looting, and more. Zombs Royale 
> became released and advanced through give games up, is your present-day 
> conflict royale game at the cellular system.
> The gameplay has been aroused by way of pubg cellphone - one of the most 
> famous wars royale game. Though currently released, Zombs Royale has reached 
> over 1 million downloads from the play store. Now perhaps not simplest looks 
> on cellular, Zombs Royale can be a go-platform game, which means that you can 
> add quite easily play it onto a computer web browser. Within the following 
> column, we are able to direct you on what to download and install the zombs 
> royale apk. Relax out in the solar with season 10: beach party! Release 
> specific new cosmetics by using gambling the game during the season without 
> spending a dime!
> h2. Zombs Royale Hack Aimbot Pc
> Relax out within the solar with season 10: beachfront birthday celebration! 
> Unencumber unique new cosmetics by way of playing the game during the season 
> free of cost! Season five: myths & legends now stays! Acquire a few extremely 
> good cosmetics for free and get the battle pass to get even more as you 
> level! - a few people have seen odd objects falling from the heavens - 
> maintain an eye fixed out for mythical weapons in-sport!
> Zombs Royale Hack Unlimited Gems Generator IOS & Android Cheats No Human 
> Verification. The Anti-Ban Feature offers 100% security for the accounts so 
> that you may never get banned when using these cheats. It gives an extremely 
> user-friendly interface meaning that it can be user-friendly with no person, 
> besides age. All these hacks are upgraded at precisely the identical period 
> as those matches! 24/7 free online access!
> h2. Zombs Royale Hack Extension
> There is no need to download or install something! You do not need to root 
> your own Android device or jailbreak your ios device! Emphasizing Android, 
> i-OS devices along with iPhone, I pad, iPod, iPad Mini cheats without any 
> verification no human verification Gems un-blocked Unlimited. Online for 
> working cheats for Zombs Royale and eventually become the extremely effective 
> player in this wonderful game. If you wish to take your game to another level 
> and increase your odds for winning, you need to utilize totally free now our 
> amazing Zombs Royale Hack Online Cheat Tool. Zombs Royale Cheat Tool may be 
> acquired for the Android or i-OS device, it comes with a user-friendly 
> interface and can be only manageable.
> This Zombs Royale hacks online generator is undetectable due to proxy 
> connection along with also our safety program. It's 128-bit SSL, to issues 
> your accounts as safe because you can so don't be concerned about bans. All 
> our Zombs Royale Hack features an extremely straightforward port to issues 
> it's easy to use. Our hacks are always up to date and so they've developed 
> for each of i-OS along with Android devices. Using Unlimited Gems, you will 
> dominate the Zombs Royale match and win most of or any challenges. This in 
> fact is the most thing reason many top pl

[jira] [Deleted] (BVAL-210) $$ NUTAKU GOLD GENERATOR SURVEYS ^^ NUTAKU GOLD GENERATOR FULL GUIDE %%

[Romain Manni-Bucau (Jira)]

 [ 
https://issues.apache.org/jira/browse/BVAL-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau deleted BVAL-210:



> $$ NUTAKU GOLD GENERATOR SURVEYS ^^ NUTAKU GOLD GENERATOR FULL GUIDE %%
> ---
>
> Key: BVAL-210
> URL: https://issues.apache.org/jira/browse/BVAL-210
> Project: BVal
>  Issue Type: Bug
>Reporter: Mary Nash
>Priority: Major
>
> h1. ## Free Nutaku Gold Coins No Surveys ^^ Nutaku Gold Coin Generator @@ 
> Nutaku Gold Coin Code $$
>  *[CLICK HERE FOR NUTAKU GOLD HACK|https://playhack.in/nutaku/]* 
>  *[CLICK HERE FOR NUTAKU GOLD HACK|https://playhack.in/nutaku/]* 
> This Generator Nutaku Cheat was set up by the Famous Team UNV Cheat Games" 
> and can enable one to add as many Gold Coins as you desire without linking 
> and liberally entirely on the web as our Generator sends processed data to 
> get information from the state game servers.
> h2. How To Get Free Nutaku Gold
> So if you are stuck somewhere, or simply for fun, or even to go beyond a Gold 
> Coins where you are struggling or to turn into one of the better players 
> utilize our Generator and get anything you desire. Our Generator Encrypt Data 
> to guarantee maximum protection and minimal risk.
> Would you like not to buy Gold Coins just to get them for free? Or you need 
> an upgraded Nutaku Hack which functioned on their existing version? Well, it 
> is very easy that even a 10-year-old child can get it done! And it is a true 
> hack for Gold Coins will get you ahead in this game.
> h2. Nutaku Gold Cheat Generator
> But there are just a few conditions that most people encountered, outdated 
> Nutaku Hack cheats certainly are one of these. This new version of the Nutaku 
> Hack Tool will not leave you to use up all your Gold Coins anymore. Our 
> programmers made sure that our Nutaku cheats will enable you to enjoy the 
> capacity with the top action game in Nutaku Gold Coins know that every player 
> needs an improved equipe or players. Nutaku Cheats immediate free Gold Coins 
> Hack Mod in I-OS android platforms real working
> In those days, the mainstream game form of Nutaku hack comes with a fresh 
> idea, an interactive free Gold Coins Generator. Even though this kind of 
> Nutaku cheat code no more utilizes the actual person picture, it is quite 
> similar to this true person videogame in character: there's no playfulness, 
> simply consider the plot and make an option. In the last few years, no matter 
> the i-OS android platform originated from the chain, they are all the 
> spiritual successors of genuine Nutaku cheats, but their production amount 
> and final actual presentation effect are far better compared to the ones of 
> those crude games.
> h2. Nutaku Gold Coin Codes
> If you are a twisted hentai lover and gamer, the location you want to be is 
> Nutaku. What may potentially be definitely better than finding an incredible 
> option of hentai sensual from around the world which also provides you with a 
> hardon?! You can register free of charge by entering your email address and 
> selecting a password and then get started. No matter if you are into hentai 
> games such as RPGs, tower defense, hentai card conflict games, or even dating 
> sims, there is something here to even probably the most discerning hentai 
> gamer who would like to spice things up.
> Nutaku also offers a webpage of their or her own. There they posted a lot of 
> matches with 18+ articles. If you're old enough to be in a position to enjoy 
> these kinds of games, you can go to their site and download the games you 
> really love. There are also games that might be played on the online browser. 
> Pocket Waifu may possibly also be done on a browser by simply enrolling in an 
> entirely free account. The good thing for Android phone users is that the 
> maker has just shown so it will release the game on smart devices utilizing 
> this os.
> h2. Nutaku Gold Coin Hack No Survey
> If you're on this website, you probably understand what you would like. 
> However, we recognize that a few people can never hear regarding this Nutaku 
> adult gambling platform. If you are one of those people -- read this swift 
> advice, register, assess if that is certainly for you. If yes, get back to us 
> now and use the free Nutaku Hack to get Gold.
> Free Minecraft Java Account, Minecraft Free Premium Account Generator Mac, 
> Minecraft Alt Account Generator, Free Minecraft Account And Password, 
> Minecraft Free Alt Generator, Cracked Minecraft Accounts, Minecraft Codes 
> Generator, Minecraft Free Alts G

[jira] [Deleted] (BVAL-205) %% FREE FOLLOWERS ON INSTAGRAM NO SURVEY NO DOWNLOAD $$ BEST FREE INSTAGRAM FOLLOWERS APP ^^

[Romain Manni-Bucau (Jira)]

 [ 
https://issues.apache.org/jira/browse/BVAL-205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau deleted BVAL-205:



> %% FREE FOLLOWERS ON INSTAGRAM NO SURVEY NO DOWNLOAD $$ BEST FREE INSTAGRAM 
> FOLLOWERS APP ^^
> 
>
> Key: BVAL-205
> URL: https://issues.apache.org/jira/browse/BVAL-205
> Project: BVal
>  Issue Type: Bug
>Reporter: Jennifer Scott
>Priority: Major
>
> h1. ^^ How Do You Get Free Followers On Instagram %% Instagram Hack To Get 
> Followers @@ Free Instagram Followers Instantly Trial **
>  *[CLICK HERE FOR INSTAGRAM FOLLOWERS 
> HACK|https://gametrick.top/i/974c68e]*
>  *[CLICK HERE FOR INSTAGRAM FOLLOWERS 
> HACK|https://gametrick.top/i/974c68e]*
> Obtaining free Instagram followers no survey is the way to go. This way, you 
> can generate more organic followers together with human interaction. Growing 
> free Instagram followers no survey will ultimately boost your sales and boost 
> your brand credibility. With this process, waking out of bed to 1,000, 
> 10,000, or even more followers for free without human verification gets 
> rather straightforward.
> h1. Free Followers On Instagram
> The process will normally entail you downloading an app and running it on 
> your smartphone. You'll then have to enter your IG username and then allow 
> the application algorithm to operate by sifting during your IG account to 
> come across articles, geo-tags, hashtags, and other sorts of content that is 
> applicable which potential followers can find interesting.
> A number of the very popular outside IG programs use growth engines that the 
> Instagram app could detect as bots. So, by confirming your email verification 
> code, then the system recognizes that your account will not be compromised by 
> fraudsters. Once you enter your username to request free IG followers, your 
> petition will be redirected to the newsfeed of all different users. This way, 
> you can start generating relevant followership from real accounts in an 
> instant.
> Some third-party IG programs may even ask that you create a 
> follower-generating strategy that might involve you liking or making comments 
> on influencer's articles or sending messages right to your intended audience. 
> With a good strategy, you can generate around 1,000 real Instagram followers 
> after your first week of usage.
> But you need to avoid using unsafe external programs such as generating IG 
> followers since the Instagram algorithm will likely detect and prohibit your 
> account from being a junk manufacturer. You need to make certain you simply 
> use proven software programs and services.
> h3. Total Free & Safe Process
> Can it be getting hard that you attract more followers on Instagram? Do you 
> desire the highest standing on interpersonal networking, which means that 
> your customers will buy the products you are offering? Have you ever been 
> using Instagram for any years however you're unable to find the outcome that 
> you wanted? This usually means that you need free followers for Instagram. We 
> know you are confused about the way it's going to help you out. Here is 
> everything you will need to learn about free followers for Instagram.
> h3. Benefits of getting free followers on Instagram
> The act to getting free followers on Instagram can be really a dependable and 
> quick way to find famous. Investing a lot of effort and time to acquire free 
> Instagram followers can be actually a dependable way to improve the 
> reputation of the company and increase earnings. Having lots of Instagram 
> free followers offers you various advantages. Here are a number of them.
> Instagram Followers App Hack| How To Get More Followers On Instagram For 
> Free| Instagram Hack To Get Followers| How To Increase Instagram Followers 
> Hack| Free Instagram Followers Hack Android| Get More Instagram Followers 
> Free| Get Free Followers On Instagram Without Human Verification| Free 
> Instagram Followers App| Instagram Followers Generator Download| Free 
> Instagram Followers Trial| Free Instagram Followers No Survey Or Human 
> Verification| How To Get More Followers On Instagram Free| Free Instagram 
> Followers No Survey Or Download Website| Instagram Followers Generator 
> Without Human Verification| 20 Free Instagram Followers Trial| Free Followers 
> Instagram| Get Instagram Followers Free Instantly| Instagram Followers Hack 
> No Survey| How To Get More Instagram Followers For Free| Instagram Followers 
> Free Trial



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Deleted] (BVAL-207) ✅✅ COIN MASTER HACK WITHOUT VERIFICATION $$ COIN MASTER FREE SPINS LINK DOWNLOAD ♐♐

[Romain Manni-Bucau (Jira)]

 [ 
https://issues.apache.org/jira/browse/BVAL-207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau deleted BVAL-207:



> ✅✅ COIN MASTER HACK WITHOUT VERIFICATION $$ COIN MASTER FREE SPINS LINK 
> DOWNLOAD ♐♐
> ---
>
> Key: BVAL-207
> URL: https://issues.apache.org/jira/browse/BVAL-207
> Project: BVal
>  Issue Type: Bug
>Reporter: Cornelia Kennedy
>Priority: Major
>
> h1. $$ How To Get Free Spins On Coin Master 2021 || Free Spins Coin Master 
> Link @@ Hack No Survey Club Coin Master Hack No Human Verification !!
>  *[CLICK HERE FOR COIN MASTER FREE 
> SPINS|https://playhack.in/coinmaster/v3/]* 
>  *[CLICK HERE FOR COIN MASTER FREE 
> SPINS|https://playhack.in/coinmaster/v3/]* 
> As soon as you see their village you have the choice to choose which of the 
> mark building you prefer to destroy and attack. By attacking the 
> construction, you're able to earn coin rewards also to which additionally 
> reduces the superstar level of this construction.
> h2. Coin Master Free Spins Hack
> Among the main aspects of the attack characteristic of the game may be that 
> the shield. It enables you to protect the bottom from enemy attacks. If you 
> are attacking an enemy construction and possess a shield that attack will 
> surely be wasted. It's important you maintain your village shielded from 
> enemy attacks by piling around three shields.
> Even in case, you strike a target having a shield which you still earn a 
> seriously good amount of coins. It will also not lessen the celebrity level 
> of your own village.
> You are able to earn coins together with daily free spins too well; every-day 
> make sure to get your free daily spins. With the daily free spins feature, 
> you are awarded free spins from which you can really have a fantastic 
> addition of coins that can aid you with building your own village.
> h2. Coin Master Daily Free Spins Link App
> Together with raiding attack and development of your own villages, Coin 
> Master also has a pet accompanying you option where adorable monsters join 
> you around raids and attacks. Various pets bring cool bonuses that can help 
> you together becoming the finest Coin master. Collars segment can be accessed 
> through your pet screen in the game menu, so you might also get access to the 
> feature by tapping on the egg beneath the roulette slot machine.
> Each time a pet has been selected their bonus remains together for the next 
> four weeks. Great bonuses of pets may genuinely help get good advantages 
> while raiding and attacking other player's villages. After four weeks that 
> the furry friend will probably fall back asleep and also the bonuses will 
> stop for a specific period of time. This resting or recovery period could be 
> sped up by massaging your pets with snacks. Pet effects like added rewards, 
> blocking enemy attacks, etc. could be increases by giving them XP potions 
> that level them up.
> Treats might be got either through the slot machine rewards or you may 
> directly purchase them using a real income. Treats are rewarded together side 
> the essential rewards so that you do not need to spend extra spins from the 
> slot machine.
> h2. Coin Master Card Collection Hack
> You'll get points whenever you invite friends and family with your website or 
> by referral code. This match is linked to facebook therefore you can invite 
> all of your Facebook friends. It's going to find a fantastic reach. You'll 
> get much more coins.
> Coin Master Hack Spin Generator, Coin Master Daily Free Spins And Coins, Get 
> Free Spins On Coin Master, Coin Master Daily Free Spins Link 2021, Coin 
> Master Free Spins Hack, Coin Master Spins Hack 2021, How To Hack Coin Master, 
> Coin Master Hack Download Mod Fname, Coin Master Hack Tool V1.9 Download Free 
> Pc, Coin Master Hack 3.5.8, Hack Coin Master Apk, Daily Free Coin Master 
> Spins, Coin Master Free Spins Link Today, Coin Master Hack Xyz, Coin Master 
> Free Spins Link No Verification, Coin Master Daily Free Spins Link App, Coin 
> Master Free Spins Link Blogspot 2021, Coin Master Attack Hack, Coin Master 
> Mod Apk Latest Hack With Unlimited Free Spins, Coin Master Daily Free Spins



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Deleted] (BVAL-209) ^^ ONLINE NUTAKU GOLD GENERATOR $$ NUTAKU GOLD COIN CODES REDDIT %%

[Romain Manni-Bucau (Jira)]

 [ 
https://issues.apache.org/jira/browse/BVAL-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau deleted BVAL-209:



> ^^ ONLINE NUTAKU GOLD GENERATOR $$ NUTAKU GOLD COIN CODES REDDIT %%
> ---
>
> Key: BVAL-209
> URL: https://issues.apache.org/jira/browse/BVAL-209
> Project: BVal
>  Issue Type: Bug
>Reporter: Maria Lee
>Priority: Major
>
> h1. ## Nutaku Free Redeem Codes || Nutaku Gold Generator Password @@ Nutaku 
> Gold Coin Hack $$
>  *[CLICK HERE FOR NUTAKU GOLD HACK|https://playhack.in/nutaku/]* 
>  *[CLICK HERE FOR NUTAKU GOLD HACK|https://playhack.in/nutaku/]* 
> It is compatible with all devices you will need to use our Online hack on any 
> platform if it's PC, Android, or even iOS.Here will be the steps that have to 
> be followed closely Firstly All Enter Your Username Locate the Country from 
> the list Select the machine onto which you are utilizing the program Locate 
> the Amount as these are added consecutively Now Select generate now button. 
> How to enter cheat codes Nutaku hacks no human verification no survey no 
> offers Gold Coins, It is compatible with all devices you will need to use our 
> Online hack on any platform if it's PC, Android, or even i-OS.
> h2. Nutaku Gold Coin Hack No Survey
> Nutaku is just one of the most useful online platforms to play hentai or even 
> +18 games. It has rather many matches, which everybody is able to play in 
> order to discover the one this may be definitely the most enjoyable for most 
> of them. However, why Nutaku is indeed exceptional? It's something similar to 
> Steam, you're able to have there your friends, games, so you may even buy 
> Gold which is the currency to buy things in matches. Unfortunately gold is 
> occasionally too expensive and not everybody can afford to buy coins. 
> However,... we have found a solution to all issues linked to money on the 
> site.
> h2. How To Get Free Nutaku Gold
> We have made a simple Nutaku Generator that produces unlimited levels of gold 
> and you also may use it daily, whenever you are in need of coins. Just open 
> the connection to the button and use this Nutaku cheat. Simple right? The 
> main reason why we do this is simple. We found a bug on their site which 
> allows hacking Nutaku (add gold into account) but the process of doing that 
> isn't that simple. We packed the entire process in one program and simplified 
> all of the steps that everybody is able to utilize and acquire unlimited 
> coins.
> To avail of this free gold, all you should do is log into your accounts on 
> Nutaku.net and you'll need to enter the coupon code'WAIFULAIFU', and also 
> you're going to have the ability to redeem your free gold. If you currently 
> do not have a merchant account of Nutaku's platform, then it is possible to 
> head to Nutaku.net and create one. It is absolutely free and you may enjoy a 
> lot of free adult titles without paying one dime. But with the free Nutaku 
> Gold, you'll be able to purchase a few really cool in-game items in any game 
> you like.
> h2. Nutaku Gold Generator Surveys
> In just about almost any age, Nutaku free gold codes will necessarily attract 
> hidden dangers. Once the shackles are opened, then they'll be repaid even 
> more. Jia Baoyu, as a youth, dwelt at the heap of women, and finally became a 
> monk without difficulty. But once the Nutaku gold coupon can be found, it is 
> frequently difficult to return to the ascetic existence in earlier times 
> which is the so-called Nutaku fresh GiftCards".
> After all, childhood always needs to be published, just through societal 
> movement without piston movement. Even though there are a lot of Nutaku free 
> gold codes in 2021, from the 300 strong men of Sparta to now, the root of 
> every inch of immunity is fundamentally the exact same, which is, there are 
> thorns in people's hearts.
> h2. Nutaku Gold Coin Generator No Survey
> This short guide is something about a Nutaku Gold Hack, a solution intended 
> to provide you with coins and cheat manners you can use to engage in games 
> for free. However, before you start generating free Nutaku gold, you ought to 
> know this mature gambling platform as it isn't just a typical company but a 
> giant that has changed the entire market. First of all, it offers games with 
> mature content and it's really LGBT-friendly as many games available there 
> are manufactured for gay, lesbian and transgender players.
> Nutaku Gold Hack Download, How To Get Nutaku Gold, Nutaku Gold Codes, Nutaku 
> Coupons, Free Gift Codes Net, Free

[jira] [Deleted] (BVAL-206) %% FREE INSTAGRAM FOLLOWERS NO DOWNLOAD ## HOW TO GET 10K FOLLOWERS ON INSTAGRAM FREE !!

[Romain Manni-Bucau (Jira)]

 [ 
https://issues.apache.org/jira/browse/BVAL-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau deleted BVAL-206:



> %% FREE INSTAGRAM FOLLOWERS NO DOWNLOAD ## HOW TO GET 10K FOLLOWERS ON 
> INSTAGRAM FREE !!
> 
>
> Key: BVAL-206
> URL: https://issues.apache.org/jira/browse/BVAL-206
> Project: BVal
>  Issue Type: Bug
>Reporter: Jose Paradis
>Priority: Major
>
> h1. !! Instagram Followers Bot Free @@ Free Trial Instagram Followers ## How 
> Do You Get Free Followers On Instagram ^^
>  *[CLICK HERE FOR INSTAGRAM FOLLOWERS 
> HACK|https://gametrick.top/i/824782d]*
>  *[CLICK HERE FOR INSTAGRAM FOLLOWERS 
> HACK|https://gametrick.top/i/824782d]*
> If you purchase followers or fans, you will be in a position to bring in more 
> real followers to your account. You will be on the trending listing of 
> Instagram. This will raise the engagement amount as more customers will 
> probably be considering purchasing the products that you have to offer. This 
> will surely increase your earnings. You will see that more folks will reach 
> out to you and attempt to join with you only because you have more followers. 
> It will turn you into an influencer on Instagram.
> h2. Tips to Increase Your Disposition
> In spite of the undeniable fact that Instagram is a visual system, your 
> captions assume a major role in increasing engagement, in this way helping 
> you receive free IG followers. Captions in customers' feeds cut off after a 
> few lines of content, so pass on the maximum and persuasive data directly off 
> the best.
> h3. Make a Great profile and profile
> Your profile could be the base of your essence on Instagram, and also an 
> all-around created one is essential to developing your own audience. All 
> things considered, will tap the follow-up grab onto a profile that's 
> unappealing, incomplete, and uncertain? Your Instagram profile needs to 
> include your own name, username, password site, and bio.
> h2. Get free Instagram followers
> In the event the aforementioned hints are not employed by you personally 
> there isn't anything to fret about. We've got the best services out there for 
> you in the form of free Instagram followers. Whether you are a newcomer to 
> Instagram or have been using the most social networking platform for decades 
> do not worry because we've just the ideal services that you need.
> We've got different varieties of bundles out there in that it is simple to 
> acquire the followers which you want. Once your profile is going to possess 
> free followers you'll surely observe a rise in your popularity and more 
> people will start following your profile and they will surely get the goods 
> or services that you have to offer. Our free Instagram followers bundles are 
> offered at the most affordable rate. Without further delay get the package 
> that you need to eventually become famous.
> h3. Strategies for Organic Growth on Instagram
> With more followers on Instagram really isn't the one thing you have to look 
> at. It's very important that you work in your account too because that's the 
> only way free followers can allow you to draw more followers. Here are a few 
> things you will need to consider.
> h2. Boost Your Instagram Account
> When you are working to secure more Instagram followers, it is extremely 
> vital that you have your account maximized. Think about that the Instagram 
> bio of your brand since the home page to your account. Optimizing your 
> account will helps you to receive Instagram followers fast free. Keep your 
> username as quest inviting as can reasonably be expected. If your company 
> name is more, abbreviate it to something that the audience recognizes. Make 
> an effort not to include numbers or any unique characters in a username.
> Real Instagram Followers Free, Instagram Followers Generator Without Survey, 
> Instagram Generator Followers, Instagram Followers Free, Instagram Followers 
> Free Trial Fast, Instagram Followers Generator Free, Grow Instagram Followers 
> Free, Get 100 Followers On Instagram For Free, Auto Followers Insta, Hack 
> Followers Instagram, Free Ig Followers No Surveys, Free Followers On 
> Instagram Instantly, Free Followers On Instagram, Instagram Followers 
> Generator Online, Hack Instagram Followers No Survey, Instagram Followers 
> Hack App, Follower Free Instagram, Auto Followers Instagram Free Online, Free 
> Insta Followers No Survey, Free Instagram Follower



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Deleted] (BVAL-195) @@ FREE GOOGLE PLAY REDEEM CODES GIVEAWAY $$ GOOGLE PLAY GIFT CARD GENERATOR &

[Romain Manni-Bucau (Jira)]

 [ 
https://issues.apache.org/jira/browse/BVAL-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau deleted BVAL-195:



> @@ FREE GOOGLE PLAY REDEEM CODES GIVEAWAY $$ GOOGLE PLAY GIFT CARD GENERATOR 
> &&
> ---
>
> Key: BVAL-195
> URL: https://issues.apache.org/jira/browse/BVAL-195
> Project: BVal
>  Issue Type: Bug
>Reporter: Yvette Ross
>Priority: Major
>
> h1. ^^ Free Google Play Codes List 2021 ## Google Play Gift Card Codes Unused 
> @@ Google Play Gift Card Generator **
>  *[CLICK HERE FOR GOOGLE PLAY PROMO CODE|https://playhack.in/e/3e6c968]* 
>  *[CLICK HERE FOR GOOGLE PLAY PROMO CODE|https://playhack.in/e/3e6c968]* 
> Egift cards stand for electronic gift cards. This means that you won't have a 
> concrete gift card when you get an e gift card. As an alternative, you may 
> typically be emailed an e-gift card number or bar code whenever you purchase 
> out of websites like Zeek, Amazon or card pool. When you have ever viewed a 
> traditional physical gift card, then you have probably already noticed the 
> string of numbers. These amounts are the exact same as the amounts you'll get 
> for your e gift card. Advancements in technology have just managed to get so 
> that we can step away from needing to have a tangible card to swipe.
> h2. Free Google Play Store Redeem Codes
> When you are shopping you'll employ your e gift card the same way as you 
> would a normal gift card. If you are making a purchase online, only enter the 
> code at the suitable field, the exact same way that you would if you 
> experienced the actual card sitting facing you personally. If you are in a 
> store, you can consult the salesperson to either scan the barcode or show 
> them your gift Card number out of your email.
> The Google Play program offers its users countless icons, Movies, TV Shows, 
> Books, etc.. People across all age classes would really like to access this 
> online library. But, Google has several restrictions that do not allow 
> underage users from accessing the Google Wallet.
> In the event that you can't purchase the gift cards at this time, we've got 
> free Google Play gift cards for you. These gift cards give you access to a 
> whole new electronic experience; nothing is stopping you! When most retailers 
> and internet sites sell gift cards beginning $10, $20, $25 with your 
> generator, you'll get Google Play gift cards free of cost.
> h1. Google Play Card Codes Free
> h3. What is the Google Play gift card?
> Google play gift card is used to get Google services including Apps, Movies, 
> Books, Newsstand, new music, and Memberships, Google isn't the seller of its 
> Google Play gift cards. You can purchase these cards from various online and 
> offline retailers. Digital gift cards like Google Play card is a wonderful 
> means to purchase any services inside Google Play.
> h3. Free GooglePlay GiftCards
> We can help you save a great deal of money with this particular generator. 
> The prospective outcomes that you may do using the produced codes are 
> gigantic. With the free codes, you can purchase a thousand distinguishing 
> applications. In any scenario, it's increasingly what you're able to download 
> using the Google play blessing card code. Employing a Google Play Donation 
> Card Generator is most likely the least demanding method of getting free 
> codes. This online apparatus is not anything but difficult to utilize and 
> within only a few steps you are prepared to find unconditional gift cards. 
> The good part of generating codes is just as with any other gift card codes 
> you can redeem them. It is apparent that getting free Google Donation Card 
> Codes is easy and you can do it all yourself. This is by pick the best 
> generator tool that we give you on this site.
> Google Play Gift Code| Free Google Play Redeem Codes No Survey| Google Play 
> Redemption Code Free| How To Earn Google Play Points| Google Play Credits 
> Hack| Google Redeem Code Free| Free Google Play Promo Codes 2021| Google Play 
> Promo Code Free| Google Gift Card Free| Free Play Store Gift Cards| Google 
> Play Store Redeem Codes| Google Play $1 Code| Free $5 Google Play Code| Free 
> Google Play Cards| Free Play Store Codes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Deleted] (BVAL-188) HOW DO YOU GET THE FREE SKINS ON FORTNITE ^$# NO HUMAN VERIFICATION 2021 %$#

[Romain Manni-Bucau (Jira)]

 [ 
https://issues.apache.org/jira/browse/BVAL-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau deleted BVAL-188:



> HOW DO YOU GET THE FREE SKINS ON FORTNITE ^$# NO HUMAN VERIFICATION 2021 %$#
> 
>
> Key: BVAL-188
> URL: https://issues.apache.org/jira/browse/BVAL-188
> Project: BVal
>  Issue Type: Bug
>Reporter: Israel Mills
>Priority: Major
>
> h1. $#How To Free Skins In Fortnite Videos %$# Free Account Fortnite With 
> Skins List #@! Get Free Skins On Fortnite Ps4 %*&
>  
>  [CLICK HERE FOR FREE FORTNITE SKINS|https://playhack.in/fortnite-skins/] 
>  [CLICK HERE FOR FREE FORTNITE SKINS|https://playhack.in/fortnite-skins/] 
>  
> The simplest possible means to become abundant with Fortnite skins 100% 
> working |100 percent Free Free Skin Fortnite. Generate thousands of free 
> Fortnite skins per day? All devices supported our newest Fortnite hack tool. 
> We predicted it Free Free Skin Fortnite. Are you aware how to receive free 
> Fortnite Skins? Keep reading we'll show you how. Welcome into our new tool 
> that the Free Free Skin Fortnite, this can be your all-around source and 
> guide to all of the manners of getting Skins in Fortnite. [[Fortnite Skin 
> Generator -Free Fortnite Skins]] No Human Verification Skins Generator, Skins 
> Generators, Free Skins Generator, FREE Skins Fortnite, FREE Skins HACK, 
> Fortnite.
> h2. FREE FORTNITE SKINS -- HOW TO Find FORTNITE SKINS FREE OF CHARGE
> h3. Can I Get Free Skins In Fortnite
> Looking for the Hottest Free Fortnite skins? You may have arrived at the 
> right place. With this article, you will have the necessary knowledge to gain 
> the most sought-after Fortnite skins now!
> Just a Little about Fortnite: Short Launch
> Fornite: Battle Royale is among the most sought-after game since 2017. It has 
> an introduction release declared a whooping 100 million new users online. 
> Most of which are teens. No matter how the game encompasses different age 
> mounts that gives it that the mass appeal every gambling company wishes for. 
> Epic Games has really exploited a power with Fortnite's most current addition 
> to its already jam-packed games.
> What Makes Fornite Unique:
> h2. Free Account Fortnite With Skins List
> Along with its already exciting battle royale environment. What distinguishes 
> it from the pack is it's cross platform capacities. Gaming consoles are 
> included into the combination like PS4, nintendo and Xbox you. This made 
> fortnite even more popular with children. 1 rumor has it, which Sony was 
> reluctant to add fortnite into its gambling environment. But, discussions 
> have pushed through making it possible for its ever-so-popular game playable 
> on a few of the most used platforms for the last decades.
>  
> Free To Use Fortnite Skins| How To Get Free Skins In Fortnite Ps4| Free 
> Account With All Fortnite Skins| How To Get Free Fortnite Skins From Twitch| 
> Fortnite Skins Free Download| How To Get Free Skins In Fortnite Promoncodes| 
> Fortnite Free Skins Challenge| How To Get Free Fortnite Skins Girl| Fortnite 
> Free Skins Generator| How To Free Skins In Fortnite Videos| Fortnite Free 
> Skins Xbox One| Fortnite Get Free Skins On Monile| Twitch Free Fortnite 
> Skins| Get Free Skins In Fortnite Ps4| Can You Get Free Skins In Fortnite



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Deleted] (BVAL-189) $#$ FORTNITE ACCOUNT GENERATOR FREE PS4 *&% FREE PSN FORTNITE ACCOUNT GENERATOR &^$# NO HUMAN VERIFICATION 2021

[Romain Manni-Bucau (Jira)]

 [ 
https://issues.apache.org/jira/browse/BVAL-189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau deleted BVAL-189:



> $#$ FORTNITE ACCOUNT GENERATOR FREE PS4 *&% FREE PSN FORTNITE ACCOUNT 
> GENERATOR &^$# NO HUMAN VERIFICATION 2021
> ---
>
> Key: BVAL-189
> URL: https://issues.apache.org/jira/browse/BVAL-189
> Project: BVal
>  Issue Type: Bug
>Reporter: Laura Quiroz
>Priority: Major
>
> h1. ^^ Fortnite Account Generator Free Pc %% Free Fortnite Account Generator 
> With Skins $$ Real Fortnite Account Generator @@ 
>  *[CLICK HERE FOR FREE FORTNITE ACCOUNTS 
> GENERATOR|https://playhack.in/fortnite-accounts/]* 
>  *[CLICK HERE FOR FREE FORTNITE ACCOUNTS 
> GENERATOR|https://playhack.in/fortnite-accounts/]* 
> Certainly one of the best ways to get free Fortnite accounts with skins 2021 
> is by visiting specific websites online. Being a world-famous match, Fortnite 
> is basically played with everyone. This is the reason why numerous sites 
> understand that they need to entice visitors by supplying free Fortnite 
> accounts.
> Better still, the majority of these give away the accounts along with free 
> skins and infrequent items also. Below are some of the best websites where 
> you can generate Fortnite accounts for free. Basically, it merely needs you 
> to perform a number of surveys. After the surveys are done, you're free to 
> obtain as many Fortnite accounts as you'd like. The surveys are not tough to 
> perform too. It may be done with it in under one hour or two.
> h2. Free Fortnite Account Generator Discord
> Hack1vo provides free Fortnite accounts with skins 2021 to get all kinds of 
> Fortnite matches you play, including the Super De Luxe Edition and the 
> Restricted Edition too. Then, you want to split the website. Just when you 
> share the web site, you're going to have the ability to click the 
> box"Create". Click on it and then you are going to be asked to fill in a few 
> surveys. After the poll is completed, you're going to be sent the free 
> accounts with skins instantly.
> At this time you are aware there are lots of websites you may access to own 
> free accounts for Fortnite. You can visit them instantly and get started 
> collecting the awesome free skins in the accounts. Remember dozens of 
> websites are free.
> h2. Working Fortnite Account Generator
> This indicates if you're requested to provide for bank card information, you 
> need to bypass it because it could be unwelcome scams. Once you have the 
> desired free Fortnite accounts with all the rare and exclusive skins out of 
> those websites, playing with the match should be more fun because you've 
> gained lots of infrequent skins and probably tons of V-Bucks from all those 
> free Fortnite accounts with skins 2021.
> The site claims to be the #1 source to get free Fortnite accounts and based 
> on them, 99% of these accounts provided to users should work without qualms. 
> It's completely valid and risk-free and also you will not actually have to 
> pay a penny to receive your dream account provided you may not venture into 
> the Premium account department.
> Free Skins Generator, FREE Skins Fortnite, FREE Skins HACK, Fortnite 
> Generator, Fortnite Skins HACK, Fortnite HACK, Fortnite ACCOUNT GENERATOR PS 
> 4, Fortnite FREE Skins GENERATOR, Skins Generator By applying this method, 
> You'll Have a way to getskins that are not even yet in these store. Codes 
> which are increasingly being sold on sites like eBay can be found here for 
> free! Before we enter in to the skins generator let us brief you regarding 
> this match. It's only a Battle poker game which has many different 
> personalities and each character may alter their ensemble. You may change the 
> outfits in line with the categories like conflict pass outfits, holiday 
> dresses and promotional outfits.
> Fortnite Account Generator Ps4| Random Rare Fortnite Account Generator| 
> Shotgunraids Fortnite Account Generator| Epic Fortnite Random Account 
> Generator| Fortnite Generator Account| Fortnite App| Random Fortnite Account 
> Generator Free| Free Fortnite Accounts| Fortnite Account Generator Download| 
> Fortnite Random Account Generator| Fortnite Generator Account| Free Fortnite 
> Account Generator Nintendo Switch| Free Account Generator For Fortnite| 
> Fortnite Account Generator Xbox| Real Fortnite Account Generator



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Deleted] (BVAL-191) ## HOW TO GET FREE ROBUX ON ROBLOX %% FREE ROBUX NO HUMAN VERIFICATION OR SURVEY 2021 !!

[Romain Manni-Bucau (Jira)]

 [ 
https://issues.apache.org/jira/browse/BVAL-191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau deleted BVAL-191:



> ## HOW TO GET FREE ROBUX ON ROBLOX %% FREE ROBUX NO HUMAN VERIFICATION OR 
> SURVEY 2021 !!
> 
>
> Key: BVAL-191
> URL: https://issues.apache.org/jira/browse/BVAL-191
> Project: BVal
>  Issue Type: Bug
>Reporter: James Salgado
>Priority: Major
>
> h1. ^^ How To Hack In Roblox ** Robux Generator No Survey No Password ** 
> Robux Generator Free !!
>  [*CLICK HERE FOR FREE ROBUX*|https://gametrick.top/i/8f27d41] 
>  [*CLICK HERE FOR FREE ROBUX*|https://gametrick.top/i/8f27d41] 
> Unfortunately, there really are a lot of Robux scams out there, and you will 
> need to avoid them at all costs. Before we offer you valid methods to earn 
> Robux for free, let us deal with a scam first. Using a Robux generator can 
> seriously affect your fun. That is because most Robux generators have been 
> evaporating!
> h2. Robux Generator No Survey No Password
> Robux generators can also be named Robux hacks or Robux clawbacks. It will 
> not matter; they are all off-the-shelf tips. These things usually contain 
> malicious features, like viruses, or even perhaps a scam. Roblox is free to 
> play with but to take advantage of this, you still want Robux.
> Some questionable people like to take advantage of this request by making 
> offers that are too good to be genuine. Therefore as of now, it's the perfect 
> opportunity for two or three incredible gift suggestions voucher generators. 
> Many sites guarantee to get your most recent gift coupons. You will find the 
> freshest Gift card issuers out of our site. You will as of now getting bank 
> cards and Present cards from one of those natural driving brands in the 
> market.
> All these generators are working always, and you will create a vast scope of 
> card codes. The algorithmic application of the card codes generator works 
> brilliantly and pursues your credit and gift voucher rules.
> h2. How To Get Robux For Free On Roblox
> You can use these credit and present coupon subtleties where you want to book 
> any building, lodgings, or paying for nourishment, in-application buys, 
> trying to find any match on the web or even disconnected. You'll likewise buy 
> things from internet business stores in any place that you don't wish to 
> share with you with your genuine details. The entirety of one's subtleties 
> along with your character is solid covered up in this manner that you don't 
> have to stress with respect to yourself.
> How To Get Roblox Hacks, Hack To Get Robux, How To Get Free Unlimited Robux, 
> Robux Hack Me, Free Robux Hack, Roblox Free Robux, How Do You Get Free Robux 
> On Roblox, Robux Free, Free Robux Today, How To Get Robux For Free 2021, 
> Human Verification, How To Get Free Robux On A Phone, Roblox Account 
> Generator, How To Get Free Robux 2021 Easy, Robux Hack No Verification



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Deleted] (BVAL-193) ^^ HOW TO EARN VBUCKS FORTNITE BATTLE ROYALE ## FREE V BUCKS WITHOUT VERIFICATION %%

[Romain Manni-Bucau (Jira)]

 [ 
https://issues.apache.org/jira/browse/BVAL-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau deleted BVAL-193:



> ^^ HOW TO EARN VBUCKS FORTNITE BATTLE ROYALE ## FREE V BUCKS WITHOUT 
> VERIFICATION %%
> 
>
> Key: BVAL-193
> URL: https://issues.apache.org/jira/browse/BVAL-193
> Project: BVal
>  Issue Type: Bug
>Reporter: Lillian Severns
>Priority: Major
>
> h1. ** Free V Bucks No Human Verification Ps4 @@ Fortnite V Bucks Codes %% 
> Free V Bucks Generator 2021 ^^
>  *[CLICK HERE FOR FREE FORTNITE V BUCKS|https://gametrick.top/i/5b74d14]* 
>  *[CLICK HERE FOR FREE FORTNITE V BUCKS|https://gametrick.top/i/5b74d14]* 
> There are lots of games still to come for the PS5, and this really is 
> absolutely out of a general consumer perspective with a little expertise but 
> no serious technical knowledge. I'm not planning to become the main one to 
> split hairs between that which is and is not 4K; there are others much better 
> suited to it. However, in terms of what it was like to actually experience 
> the games for the very first time as someone that has set plenty of effort 
> and time in previous play-station productions, well, it ends there is still 
> plenty to say.
> h2. How To Get V Bucks On Fortnite
> Ways to have free V-Bucks This is probably the most sought-after question on 
> Google by the Fortnite players. However, the answer is comparatively hard. 
> There are tons of suggestions for V-Bucks Free. Perhaps you have already 
> tried them. However, they didn't work out, right? Do not worry. You have 
> landed in the perfect location. If you undergo this piece, you may certainly 
> add a few V-Bucks to your account right away. And you know things you need to 
> do? Nothing literally. Yes, it's real. Only read the whole article line by 
> line with the utmost monitoring. Believe me; your free v bucks are waiting 
> for one to grab them. So let us get into the specifics.
> Just how Much Can V-Bucks Price there isn't any means the V-Bucks will walk 
> towards you. You want to either earn them or buy them. Earning them by 
> playing one after another degree is a difficult job since it demands plenty 
> of patience. Therefore the Fortnite players would rather get them some time 
> to jump into the next degree. But buying V-Bucks requires plenty of funds. 
> You always have the option to get them from the Fortnite Store or every other 
> PlayStation. Let's check how much they are able to offer you.
> h2. Fortnite V Bucks Hack Download
> You may purchase 1000 V-Bucks for $9.99, 2500 for $24.99 with an advantage of 
> 300 V-Bucks, 4000 for $59.99 using an additional 1000 V-Bucks as an 
> advantage. 1 V-Bucks can run you $99.99, and you also will get 3500 
> V-Bucks like an advantage. Watch, they're not always economical, rather 
> pretty pricey. How to Get Free V-Bucks So imagine if you get them for free 
> without paying one buck? Can not it be great? On our website, we're providing 
> this exclusive limited offer. But first, let us discuss the slow-paced 
> methods of becoming V-bucks free.
> The V-Bucks you will get by following the procedures below may be Utilized in 
> Battle Royale, Creative in Addition to in Save the World modes. It's possible 
> to spend them on buying things like couches, gliders, emotes, and the latest 
> Fight Pass in the initial two modes. By playing with the PvE in Conserve the 
> World manner, you can purchase your favorite personalities, x-ray Llamas 
> containing weapons, and a lot more. But, let us explore the possibilities to 
> get this free in-game money. Daily log-ins: This really is the quickest of 
> all the ways to get a free V-Bucks just by logging into your Epic account.
> h2. How To Get Free V-bucks
> An everyday login to Fortnite can add a few bucks into your account. Though 
> the quantity is not that good, it's still well worth it. Because you just 
> need to log into each and every day, nothing longer than that. Being a 
> Fortnite enthusiast, this is not a challenging endeavor to reach for anybody. 
> But, you may well not enjoy the method since it's the slowest procedure to 
> get V-Bucks quickly. However, there is no harm in collecting a few free cash 
> every day without doing such a thing.
> Free Vbucks Generator, Free Vbucks, V Bucks Fortnite, How To Earn Free V 
> Bucks, Earn Free V Bucks, How To Gift V Bucks In Fortnite, How To Get Free V 
> Bucks In Fortnite Pc, Free V Bucks Meme, Fortnite Publisher, Free Fortnite 
> Hacks, V Bucks Hack, Fortnite Hacker, V Bucks Codes, Fortnite Code Generator, 
> Fortnite Save The World V Bucks, Fortnite Free V Bucks



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Deleted] (BVAL-187) FREE FORTNITE SKINS CODES ^$ FORTNITE FREE SKINS GENERATOR #@ NO HUMAN VERIFICATION

[Romain Manni-Bucau (Jira)]

 [ 
https://issues.apache.org/jira/browse/BVAL-187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau deleted BVAL-187:



> FREE FORTNITE SKINS CODES ^$ FORTNITE FREE SKINS GENERATOR #@ NO HUMAN 
> VERIFICATION
> ---
>
> Key: BVAL-187
> URL: https://issues.apache.org/jira/browse/BVAL-187
> Project: BVal
>  Issue Type: Bug
>Reporter: Theresa Beck
>Priority: Major
>
> h1. How To Get Free Skins In Fortnite Ps4 2021 %^& Free Fortnite Accounts 
> With Skins 2021 @%(
>  [CLICK HERE FOR FREE FORTNITE SKINS|https://playhack.in/fortnite-skins/] 
>  [CLICK HERE FOR FREE FORTNITE SKINS|https://playhack.in/fortnite-skins/] 
> Furthermore, stay away from internet sites with all extensions of both .pw, 
> .tk or alternative non degree domain extensions. These websites shout spam 
> from there name. Additionally, installation of 3rd party program sources may 
> possibly be done with extra maintenance. These may possibly bring about rogue 
> apps which might wreak havoc to your system. This also applies to each 
> platform.
> Adding more spice into the table would be your brilliant marketing technique 
> employed in-game which was the dancing routines. 1 particular dance routing 
> was that the floss dance that was ways to provoke enemies in-game. It turned 
> out well understood that it was used in football games. In turn, the incident 
> sparked attention among football fans which just made fortnite game even more 
> populated.
> h2. How To Get All The Skins In Fortnite For Free
> h3. The Way to Receive Free Fortnite Skins Seasons 9 & 10:
> Include your self with specific location events be it by country or by 
> region. These events not just grant you access to skins but also many 
> different special items offered for a limited time only.
> There may be also free fortnite skin codes released via events so you should 
> listen to the official face-book or alternative social media stations owned 
> by Epic Games.
> Using fortnite skins free tool would be an wonderful addition each gamer. 
> But, let us not be intimidated by mere costume coolness. Concentrate on 
> building your skills in-game. We'll be releasing a guide for this later on.
> Free Falling Fortnite Skins, Get Free Fortnite Skins, Get Free Skins In 
> Fortnite, Fortnite All Free Skins On Pc, How To Get Free Fortnite Skins Xbox 
> One, Get Free Skins On Fortnite, Edit Fortnite Files For Free Skins, How To 
> Get Free Skins In Fortnite Season 9, Top 10 Free Fortnite Skins, Games Free 
> Fortnite Skins, Free Skins On Fortnite, Can I Get Free Skins In Fortnite, 
> Fortnite Free Skins Generator Season 11, Ok Google Can You Get Free Skins 
> From For Fortnite, Free Fortnite Skins Xbox One Hack
> h2. How To Get Fortnite Skins Free
> h3. Free Fortnite Skins:How To Receive Free Skins Fornite
> For all anyone of you who are hunting for Free fortnite skins we urge you to 
> read through the epic guide below provided by skinsfy. We've put together a 
> nifty list that may aide you in your own quest for skins. You should be 
> mindful idea that some of the most popular fortnite skins now wont be just as 
> far as popular in the next coming months. Therefore, if you're likely to pay 
> a dime because of this make sure to choose the perfect skins for you 
> personally.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Deleted] (BVAL-190) @@ RANDOM FORTNITE ACCOUNT GENERATOR WITH SKINS %$ FORTNITE HACKED ACCOUNT GENERATOR ^^

[Romain Manni-Bucau (Jira)]

 [ 
https://issues.apache.org/jira/browse/BVAL-190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau deleted BVAL-190:



> @@ RANDOM FORTNITE ACCOUNT GENERATOR WITH SKINS %$ FORTNITE HACKED ACCOUNT 
> GENERATOR ^^
> ---
>
> Key: BVAL-190
> URL: https://issues.apache.org/jira/browse/BVAL-190
> Project: BVal
>  Issue Type: Bug
>Reporter: Angela Weiner
>Priority: Major
>
> h1. ## Fortnite Account Generator Unblocked %% Fire Alts Fortnite Account 
> Generator && New Fortnite Account Generator **
>  *[CLICK HERE FOR FREE FORTNITE ACCOUNTS 
> GENERATOR|https://playhack.in/fortnite-accounts/]* 
>  *[CLICK HERE FOR FREE FORTNITE ACCOUNTS 
> GENERATOR|https://playhack.in/fortnite-accounts/]* 
> According to the countless people on your morning train commute huddled over 
> games onto their apparatus, mobile technology has made the love of digital 
> gaming disperse beyond hardcore console consumers and internet gaming 
> players. Fortnite: Battle Royale is one of the very popular games on the 
> planet. The collection could publish shirts, T-shirts, and trousers in 
> addition to games. Taking place in an open environ, Fortnite sees 100 players 
> drop onto an island and the whole aim is always to"compete" for survival 
> until a player doubles the winner. But while doing so, players might have to 
> locate hidden items such as weapons scattered all over the map to help them 
> last more.
> h2. Free Fortnite Account Generator
> Today, we are likely to list each of the free Fortnite accounts using email 
> and password and they do comprise a ton of skins.
> For people oblivious, every internet videogame that falls under the conflict 
> royale genre works under the exact simple premise and as the likes of Radical 
> Heights, Islands of Nyne and Darwin Project collapsed, Fortnite painlessly 
> took the web by"storm" and this is all thanks to the simple fact that it's 
> free.
> Being a survival match where players can easily team up or play with solo, 
> Fortnite gameplay begins with all contestants parachuting onto an island 
> armed just with a pickaxe, and the principal purpose is always to scavenge 
> for arsenal that can be used to get fortifications whilst fending off enemy 
> players and/or squads. Additionally, there's no human verification needed 
> provided that there is just a constant tried to find a merchant account out 
> of our generator before. You must understand that as soon as you receive inch 
> account we can't allow you to acquire additional without affirming yourself.
> h2. Free Fortnite Account Generator Nintendo Switch
> Otherwise a single individual would sneak all of our accounts and there might 
> possibly be none left to the others of you. Regardless, in the event that you 
> receive lucky, you will get a stacked Fortnite account out of our incredible 
> generator and you'll have a lot of skins to enjoy without needing to utilize 
> your luck again and find a second. What exactly are you currently awaiting? 
> Get your free working Fortnite accounts high in skins at the moment, while 
> our generator remains busy!
> Our Fortnite Generator has a first-class success price, which means you may 
> climb to 5,000 V-Bucks at no time in any way. Epic has a strong association 
> with Disney and its own horde properties, also we've seen Avengers characters 
> as skins neighboring restricted time match styles including Infinity War and 
> end game scalawag Thanos and other Marvel legend. However, this really is 
> actually the first time when we've seen such vital characters out of one of 
> the world's most well-known establishments being marketed as skins. 
> Previously, Epic has included Dark Widow and Starlord skins, also it 
> immediately allows you employ notorious Marvel weapons like Captain America's 
> defense and Thor's sled.
> h2. Free Fortnite Accounts Email And Password
> Now assuming you're in short supply of money and/or V-Bucks to devote to 
> certain things such as skins, emotes, and much more, then you are better off 
> using these free Fortnite account generators. However, if you find them too 
> overwhelming, then here is a summary of all the free Fortnite accounts that 
> contain rare skins. Free Fortnite Accounts With Skins 2021 -- Many players 
> nowadays must search for free Fortnite accounts with skins 2021. Fortnite may 
> be the most renowned sandbox game at this moment. It has been played with 
> numerous people around the world and most of them are addicted to this match 
> at this ti

[jira] [Deleted] (BVAL-194) %% FREE FORTNITE VBUCKS $$ VBUCKS FORTNITE BATTLE ROYALE ## FORTNITE SAVE THE WORLD V BUCKS @@

[Romain Manni-Bucau (Jira)]

 [ 
https://issues.apache.org/jira/browse/BVAL-194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau deleted BVAL-194:



> %% FREE FORTNITE VBUCKS $$ VBUCKS FORTNITE BATTLE ROYALE ## FORTNITE SAVE THE 
> WORLD V BUCKS @@
> --
>
> Key: BVAL-194
> URL: https://issues.apache.org/jira/browse/BVAL-194
> Project: BVal
>  Issue Type: Bug
>Reporter: Megan Chase
>Priority: Major
>
> h1. ^^ V Bucks Generator No Verification ** How Do You Get V Bucks In 
> Fortnite ** Fortnite V Bucks Hack @@
>  *[CLICK HERE FOR FREE FORTNITE V BUCKS|https://playhack.in/e/ac68755]* 
>  *[CLICK HERE FOR FREE FORTNITE V BUCKS|https://playhack.in/e/ac68755]* 
> We suggest you be careful when choosing this type of V-Bucks generator 
> platform to hack V-Bucks. Because there are loads of scammers, just do not 
> fall for anybody. As we are a true site offering V-Bucks truly, we do not 
> want one to fall prey to a scam website. Just try our website hacks, and we 
> guarantee you that a 100% return. Additionally, it could be best if you 
> remembered that this offer is for limited clients. Thus, do not overlook it 
> by letting others grab it first. Instantly click on the link below and 
> receive the offer whenever possible.
> h2. Fortnite How To Earn V Bucks
> We promise you to actually be the most powerful free V-Bucks generator 
> online. So, why spend your time rather than using this kind of incredible 
> platform to grab the V-Bucks without breaking such a thing? Please rush up 
> and become one of our lucky clients to get a free V-Bucks to upgrade for 
> another location Fortnite degree. Just stick to the process we mentioned and 
> win Fortnite hack V-Bucks with just some basic clicks. Hopefully, you will be 
> able to bring some instant V-Bucks to your epic account.
> h2. How To Gift V Bucks In Fortnite
> For those that once could play Fortnite on i-OS or Mac devices, Epic Games is 
> giving out free V-Bucks to compensate to get Apple obstructing game upgrades. 
> Fortnite cellphone and Mac players haven't had access to the latest upgrades 
> since August in light of an ongoing lawsuit between Epic Games along with 
> Apple.
> About August 1-3, Epic Games released an upgrade for Fortnite on i-OS and 
> also Android devices that will allow players to undermine their device's app 
> shop and purchase V-Bucks directly from Epic Games at a discounted price. 
> Apple was the first ever to prohibit Fortnite out of its app-store along with 
> almost any future upgrades. In retaliation to the ban, Epic Games filed a 
> suit against Apple for harboring an anti-competitive market along with many 
> other claims. Fortnite cellular players have since fled to other platforms or 
> have remained platformless.
> h2. Fortnite Free V Bucks Code Ps4
> The Fortnite i-OS and Mac community continue to voice its phobias under 
> almost every place made by Fortnite-related accounts. They've always been 
> discovered, and Epic Games announced via the Fortnite Status Twitter account 
> which select Fortnite cellphone and Mac players would be receiving a V-Buck 
> grant. This doesn't affect all Fortnite cellphone users, only those that 
> purchased V-Bucks through the Apple app store and have yet to pay them. Epic 
> Games is diminishing the number of unspent V-Bucks which were purchased 
> through the app-store to get i-OS and through the Epic Games Store on Mac, 
> with the replacement V-Bucks usable on almost any stage.
> h2. Fortnite V Bucks Generator
> In case this really is an attempt for Epic Games to maintain gamers out of 
> Mac and i-OS, it sure is a weird means to do so. Epic is offering to double 
> the number of unused V-Bucks which were purchased on currently defunct 
> platforms almost 3 months ago. It's hard to imagine that a new player 
> wouldn't have spent V-Bucks they purchased that long ago if they had the 
> chance, of course, should they continue to remain platformless, extra 
> unspendable V-Bucks will merely remind players that they cannot play Fortnite 
> in their stage on choice.
> No matter it's nice of Epic Games to acknowledge the cellphone Fortnite 
> community and benefit them for their own patients. Epic asserts that its 
> litigation will be for the good of most app founders who fall prey to Apple's 
> predatory 30 percent cut of in-app purchases. If that truly is the case, 
> subsequently Fortnite i-OS players ought to be okay with missing out on 
> quality match time if it's for the higher good.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Migrating the website

[Romain Manni-Bucau]

Hi Andrew,

https://svn.apache.org/repos/infra/websites/production/bval/content/ does
not change right? We still get this html served but CMS will be stopped, no?
If so I think we are good, if not, how can we get this svn to the new
location?

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le mar. 9 févr. 2021 à 15:21, Andrew Wetmore  a écrit :

> Hi:
>
> Happy new year!
>
> The task is to move creation of your website off the Apache CMS and onto
> another technology like Pelican. If your website is fairly static this
> should not be a hard task; if there are complexities, Infra is happy to
> advise.
>
> However, we need to get going on this, as bval is among the last TLPs
> still on the Apache CMS.
>
> Andrew
>
> On 2020/10/28 20:30:14, Romain Manni-Bucau  wrote:
> > Hi Andrew,
> >
> > Don't think we have a ticket yet but the task is mainly moving
> > https://svn.apache.org/repos/infra/websites/production/bval/content/ to
> the
> > new home - guess we would be happy with that for now.
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > <https://rmannibucau.metawerx.net/> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
> >
> >
> > Le mer. 28 oct. 2020 à 19:13, Andrew Wetmore  a
> écrit :
> >
> > > Hi, all:
> > >
> > > Have you made any progress on this project? If you have started a Jira
> > > ticket for Infra so we can track what we need to do to help you along,
> what
> > > is its number?
> > >
> > > Thanks!
> > >
> > > Andrew
> > >
> > > On Mon, Sep 14, 2020 at 11:11 AM Andrew Wetmore 
> > > wrote:
> > >
> > > > Hi:
> > > >
> > > > Have y'all had a chance to start a Jira ticket to cover migration of
> your
> > > > project website off the CMS and onto another static-site generator?
> Infra
> > > > is happy to help, but it is good to have a Jira ticket so nothing
> slips
> > > off
> > > > the list.
> > > >
> > > > Andrew
> > > >
> > > > --
> > > > Andrew Wetmore
> > > > Technical Writer-Editor
> > > > Infra
> > > > *Apache Software Foundation*
> > > > andr...@apache.org
> > > >
> > >
> > >
> > > --
> > > Andrew Wetmore
> > > Technical Writer-Editor
> > > Infra
> > > *Apache Software Foundation*
> > > andr...@apache.org
> > >
> >
>

[jira] [Commented] (BVAL-184) Support for proxied instances

[Romain Manni-Bucau (Jira)]

[ 
https://issues.apache.org/jira/browse/BVAL-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257227#comment-17257227
 ] 

Romain Manni-Bucau commented on BVAL-184:
-

[~gpetracek] same with weld, it can't work until something else initializes the 
bean (which can be the case in some rare cases cause weld bypasses the proxies 
but in general it is not and "by spec"). Once again I see it working in some 
cases but it is not a generic CDI integration so not good enough yet IMHO. The 
overhead is not just some instance check when proxies already go through 
validation (ignored today), it is way more and depends the SPI impl, in tomee, 
depending the context (ie not standalone) it can become costly. Interceptors 
always work, even for nested case, you just code it differently which is one of 
the point of my remark: your use case is doable as of today with the spec (bval 
+ cdi apps). That said I agree to add it while there is no implicit loading of 
the resolver, ie programmatic (no SPI since it is NOT needed), a toggle in the 
apache factory (i like it less but works) or, fine too, a new 
"bval-extension-proxy" module which implements another provider and let the 
user pick the provider he wants explicitly when he needs it. Just ensure to not 
add any SPI OOTB please, a boolean.parse is ok, a setX is ok but I would avoid 
everything else.

Can help in a week or so to either code the new provider in the new module or 
toggle (setter is already in your branch and fine for me if we drop the SPI 
auto loading *by default*).

> Support for proxied instances
> -
>
> Key: BVAL-184
> URL: https://issues.apache.org/jira/browse/BVAL-184
> Project: BVal
>  Issue Type: New Feature
>Reporter: Gerhard Petracek
>Assignee: Gerhard Petracek
>Priority: Major
>
> currently org.apache.bval.jsr.util.Proxies just detects the real class, but 
> that means only getters can get annotated.
> with a spi like
> {code}
> public interface InstanceResolver extends Comparable {
>  T resolveInstance(T instance);
> //...
> }
> {code}
> it would be possible to create resolvers for external libs (like owb, weld, 
> ...)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (BVAL-184) Support for proxied instances

[Romain Manni-Bucau (Jira)]

[ 
https://issues.apache.org/jira/browse/BVAL-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257051#comment-17257051
 ] 

Romain Manni-Bucau commented on BVAL-184:
-

[~gpetracek] just few fixes on your summary to correct some points

1.
{noformat}
@"not guaranteed to work":
in case of proxies in general that's correct (i never said something 
different), however,
in case proxies support it (like owb- and weld-proxies), it's possible to 
support it.{noformat}
it is not guaranteed to work for CDI as I showed with your sample, it would 
only work if the bean was already touched and exists in current context which 
is not guaranteed at all (first JAX-RS request makes it wrong generally for app 
scoped beans for ex).

 

 

2. perf: indeed if you dont enable it you don't have much regression but if you 
do it is costing for nothing compared to today (even if usage is not always 
fully expected it happens you get proxies in the validator already).

3. one point you didn't mention is that with bval interceptor the programmatic 
validation is almost no more needed (even in JSF) and here you get the 
unwrapped instance generally so it already works as expected until it is nested

4. worse case I guess we can drop the SPI and enforce to set it 
programmatically to avoid to have it automatic, would be acceptable since then 
user really intended to use that whereas the SPI would magically break apps 
(either functionally due to 3 or for perf in some cases), wdyt?

> Support for proxied instances
> -
>
> Key: BVAL-184
> URL: https://issues.apache.org/jira/browse/BVAL-184
> Project: BVal
>  Issue Type: New Feature
>Reporter: Gerhard Petracek
>Assignee: Gerhard Petracek
>Priority: Major
>
> currently org.apache.bval.jsr.util.Proxies just detects the real class, but 
> that means only getters can get annotated.
> with a spi like
> {code}
> public interface InstanceResolver extends Comparable {
>  T resolveInstance(T instance);
> //...
> }
> {code}
> it would be possible to create resolvers for external libs (like owb, weld, 
> ...)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (BVAL-184) Support for proxied instances

[Romain Manni-Bucau (Jira)]

[ 
https://issues.apache.org/jira/browse/BVAL-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17246348#comment-17246348
 ] 

Romain Manni-Bucau commented on BVAL-184:
-

I see, so you would validate a proxy where field validation is not expected 
until you use getters - which go through the proxy, I now get what you meant. 
For me it is expected to not work and it can not work generally speaking - your 
sample just being one particular case, here are the issues I see out of my head:
 # the unwrapping you implemented is not guaranteed to work, it just works in 
some particular cases
 # such bean validations are expected to be done in the bean (in postconstruct 
or so, validating them on methods or elsewhere - anywhere not aligned on the 
scope - is an antipattern)
 # a resolver is not enough until you have a global chain resolver since you 
must resolve owb proxies, potentially cglib ones, bytebuddy ones, javassist 
ones java.util.proxy ones and finally just return the instance you got as input 
otherwise the same exact bug applies
 # In terms of performance it is a huge regression for most apps (none will use 
that feature since it is not in the spec)

I suspect it can make sense for BValInterceptor more than manual validator case 
where caller can unwrap it when needed already so a SPI wouldn't help and 
BValInterceptor can be replaced by another impl thanks to CDI extension (and 
just be extended to return the right instance in InvocationContext if needed 
but CDI already does it).

So at the end I'm not sure there is really more gain to implement it than 
drawbacks and there is no cases where user can't solve it properly without any 
SPI AFAIK.

> Support for proxied instances
> -
>
> Key: BVAL-184
> URL: https://issues.apache.org/jira/browse/BVAL-184
> Project: BVal
>  Issue Type: New Feature
>Reporter: Gerhard Petracek
>Assignee: Gerhard Petracek
>Priority: Major
>
> currently org.apache.bval.jsr.util.Proxies just detects the real class, but 
> that means only getters can get annotated.
> with a spi like
> {code}
> public interface InstanceResolver extends Comparable {
>  T resolveInstance(T instance);
> //...
> }
> {code}
> it would be possible to create resolvers for external libs (like owb, weld, 
> ...)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (BVAL-184) Support for proxied instances

[Romain Manni-Bucau (Jira)]

[ 
https://issues.apache.org/jira/browse/BVAL-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17246164#comment-17246164
 ] 

Romain Manni-Bucau commented on BVAL-184:
-

Do you have some broken example?

Current impl works for owb and weld and we want the class more than the 
instance generally.

Also not sure of getter point, works for fields too.

> Support for proxied instances
> -
>
> Key: BVAL-184
> URL: https://issues.apache.org/jira/browse/BVAL-184
> Project: BVal
>  Issue Type: New Feature
>Reporter: Gerhard Petracek
>Assignee: Gerhard Petracek
>Priority: Major
>
> currently org.apache.bval.jsr.util.Proxies just detects the real class, but 
> that means only getters can get annotated.
> with a spi like
> {code}
> public interface InstanceResolver extends Comparable {
>  T resolveInstance(T instance);
> //...
> }
> {code}
> it would be possible to create resolvers for external libs (like owb, weld, 
> ...)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Migrating the website

[Romain Manni-Bucau]

Hi Andrew,

Don't think we have a ticket yet but the task is mainly moving
https://svn.apache.org/repos/infra/websites/production/bval/content/ to the
new home - guess we would be happy with that for now.

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le mer. 28 oct. 2020 à 19:13, Andrew Wetmore  a écrit :

> Hi, all:
>
> Have you made any progress on this project? If you have started a Jira
> ticket for Infra so we can track what we need to do to help you along, what
> is its number?
>
> Thanks!
>
> Andrew
>
> On Mon, Sep 14, 2020 at 11:11 AM Andrew Wetmore 
> wrote:
>
> > Hi:
> >
> > Have y'all had a chance to start a Jira ticket to cover migration of your
> > project website off the CMS and onto another static-site generator? Infra
> > is happy to help, but it is good to have a Jira ticket so nothing slips
> off
> > the list.
> >
> > Andrew
> >
> > --
> > Andrew Wetmore
> > Technical Writer-Editor
> > Infra
> > *Apache Software Foundation*
> > andr...@apache.org
> >
>
>
> --
> Andrew Wetmore
> Technical Writer-Editor
> Infra
> *Apache Software Foundation*
> andr...@apache.org
>

Re: [VOTE] Apache BVal 2.0.5 Release Candidate

[Romain Manni-Bucau]

+1

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le mer. 21 oct. 2020 à 13:47, Daniel Cunha  a écrit :

> +1
>
> Em qua., 21 de out. de 2020 às 06:55, Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> escreveu:
>
> > +1
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Tue, Oct 20, 2020 at 11:11 AM Thomas Andraschko <
> > andraschko.tho...@gmail.com> wrote:
> >
> > > I've created a 2.0.5 release candidate, with the following artifacts
> > > up for a vote:
> > >
> > > Git source tag:https://gitbox.apache.org/repos/asf?p=bval.git;a=tags
> > >
> > > Maven staging repo:
> > > https://repository.apache.org/content/repositories/orgapachebval-1011/
> > >
> > > Source release:https://dist.apache.org/repos/dist/dev/bval/2.0.5
> > >
> > > Generated site:
> > > https://dist.apache.org/repos/dist/dev/bval/2.0.5/site/index.html
> > >
> > > PGP release keys:http://www.apache.org/dist/bval/KEYS
> > >
> > > The vote will be open for at least 72 hours.
> > >
> > > [ ] +1  approve
> > > [ ] +0  no opinion
> > > [ ] -1  disapprove (and reason why)
> > >
> >
>
>
> --
> Daniel "soro" Cunha
> https://twitter.com/dvlc_
>

Re: Time for release?

[Romain Manni-Bucau]

Oki, it was a bug in the tck version tomee was using, got it.
So looks we are in good shape!

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le ven. 16 oct. 2020 à 16:07, Jean-Louis Monteiro 
a écrit :

> No I upgraded the TCK, ran with 3 latest versions including 2.0.5 SNAPSHOT
> and worked.
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Fri, Oct 16, 2020 at 4:04 PM Romain Manni-Bucau 
> wrote:
>
> > Was it a bug in tomee? (= no change required in bval?)
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > <https://rmannibucau.metawerx.net/> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > <
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >
> >
> >
> > Le ven. 16 oct. 2020 à 15:51, Jean-Louis Monteiro <
> > jlmonte...@tomitribe.com>
> > a écrit :
> >
> > > Ok all working now.
> > > TCK is green in TomEE
> > > --
> > > Jean-Louis Monteiro
> > > http://twitter.com/jlouismonteiro
> > > http://www.tomitribe.com
> > >
> > >
> > > On Mon, Oct 5, 2020 at 2:26 PM Romain Manni-Bucau <
> rmannibu...@gmail.com
> > >
> > > wrote:
> > >
> > > > Looked quickly, seems master does not work in TomEE:
> > > >
> > > > [ERROR] Tests run: 1043, Failures: 1, Errors: 0, Skipped: 0, Time
> > > elapsed:
> > > > 49.498 s <<< FAILURE! - in TestSuite
> > > > [ERROR]
> > > >
> > > >
> > >
> >
> testGetParameterDescriptorsForConstructorOfInnerClass(org.hibernate.beanvalidation.tck.tests.metadata.ExecutableDescriptorTest)
> > > >  Time elapsed: 0.01 s  <<< FAILURE!
> > > > java.lang.ClassCastException: [Ljava.lang.annotation.Annotation;
> cannot
> > > be
> > > > cast to [Ljavax.validation.groups.ConvertGroup;
> > > > at
> > > >
> > > >
> > >
> >
> org.apache.bval.jsr.metadata.ReflectionBuilder$ForContainer.getGroupConversions(ReflectionBuilder.java:246)
> > > > at
> > > >
> > > >
> > >
> >
> org.apache.bval.jsr.descriptor.MetadataReader$ForContainer.getGroupConversions(MetadataReader.java:297)
> > > > at
> > > >
> > > >
> > >
> >
> org.apache.bval.jsr.descriptor.CascadableContainerD.(CascadableContainerD.java:43)
> > > > at
> org.apache.bval.jsr.descriptor.ParameterD.(ParameterD.java:41)
> > > > at
> > > >
> > > >
> > >
> >
> org.apache.bval.jsr.descriptor.MetadataReader$ForExecutable.lambda$getParameterDescriptors$0(MetadataReader.java:356)
> > > > at java.util.stream.IntPipeline$4$1.accept(IntPipeline.java:250)
> > > > at
> > > >
> > > >
> > >
> >
> java.util.stream.Streams$RangeIntSpliterator.forEachRemaining(Streams.java:110)
> > > > at java.util.Spliterator$OfInt.forEachRemaining(Spliterator.java:693)
> > > > at
> > java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482)
> > > > at
> > > >
> > > >
> > >
> >
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
> > > > at
> > > >
> > >
> >
> java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
> > > > at
> > java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
> > > > at
> > java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:566)
> > > > at
> > > >
> > > >
> > >
> >
> org.apache.bval.jsr.descriptor.MetadataReader$ForExecutable.getParameterDescriptors(MetadataReader.java:357)
> > > > at
> > org.apache.bval.jsr.descriptor.ExecutableD.(ExecutableD.java:46)
> > > > at
> > >
> org.apache.bval.jsr.descriptor.ConstructorD.(ConstructorD.java:29)
> > > > at
> > > >
> > > >
> > >
>

Re: Time for release?

[Romain Manni-Bucau]

Looked quickly, seems master does not work in TomEE:

[ERROR] Tests run: 1043, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
49.498 s <<< FAILURE! - in TestSuite
[ERROR]
testGetParameterDescriptorsForConstructorOfInnerClass(org.hibernate.beanvalidation.tck.tests.metadata.ExecutableDescriptorTest)
 Time elapsed: 0.01 s  <<< FAILURE!
java.lang.ClassCastException: [Ljava.lang.annotation.Annotation; cannot be
cast to [Ljavax.validation.groups.ConvertGroup;
at
org.apache.bval.jsr.metadata.ReflectionBuilder$ForContainer.getGroupConversions(ReflectionBuilder.java:246)
at
org.apache.bval.jsr.descriptor.MetadataReader$ForContainer.getGroupConversions(MetadataReader.java:297)
at
org.apache.bval.jsr.descriptor.CascadableContainerD.(CascadableContainerD.java:43)
at org.apache.bval.jsr.descriptor.ParameterD.(ParameterD.java:41)
at
org.apache.bval.jsr.descriptor.MetadataReader$ForExecutable.lambda$getParameterDescriptors$0(MetadataReader.java:356)
at java.util.stream.IntPipeline$4$1.accept(IntPipeline.java:250)
at
java.util.stream.Streams$RangeIntSpliterator.forEachRemaining(Streams.java:110)
at java.util.Spliterator$OfInt.forEachRemaining(Spliterator.java:693)
at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482)
at
java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
at
java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:566)
at
org.apache.bval.jsr.descriptor.MetadataReader$ForExecutable.getParameterDescriptors(MetadataReader.java:357)
at org.apache.bval.jsr.descriptor.ExecutableD.(ExecutableD.java:46)
at org.apache.bval.jsr.descriptor.ConstructorD.(ConstructorD.java:29)
at
org.apache.bval.jsr.descriptor.MetadataReader$ForBean.lambda$getConstructors$7(MetadataReader.java:212)
at java.util.HashMap.forEach(HashMap.java:1289)
at
org.apache.bval.jsr.descriptor.MetadataReader$ForBean.getConstructors(MetadataReader.java:208)
at org.apache.bval.jsr.descriptor.BeanD.(BeanD.java:62)
at
org.apache.bval.jsr.descriptor.DescriptorManager.getBeanDescriptor(DescriptorManager.java:79)
at
org.apache.bval.jsr.ValidatorImpl.getConstraintsForClass(ValidatorImpl.java:48)
at
org.hibernate.beanvalidation.tck.util.TestUtil.getConstructorDescriptor(TestUtil.java:148)
at
org.hibernate.beanvalidation.tck.tests.metadata.Executables.parameterConstrainedConstructorOfInnerClass(Executables.java:113)
at
org.hibernate.beanvalidation.tck.tests.metadata.ExecutableDescriptorTest.testGetParameterDescriptorsForConstructorOfInnerClass(ExecutableDescriptorTest.java:110)

So guess we must fix it before we release, isnt it?

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le lun. 5 oct. 2020 à 14:12, Jean-Louis Monteiro 
a écrit :

> Thanks Thomas.
> I'll check it out with Romain if he has some spare cycles
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Mon, Oct 5, 2020 at 2:10 PM Thomas Andraschko <
> andraschko.tho...@gmail.com> wrote:
>
> > +1 from my side
> > i just dont have time currently.
> > Romain maybe?
> >
> > Am Mo., 5. Okt. 2020 um 13:58 Uhr schrieb Jean-Louis Monteiro <
> > jlmonte...@tomitribe.com>:
> >
> > > up?
> > > --
> > > Jean-Louis Monteiro
> > > http://twitter.com/jlouismonteiro
> > > http://www.tomitribe.com
> > >
> > >
> > > On Wed, Sep 30, 2020 at 11:09 AM Jean-Louis Monteiro <
> > > jlmonte...@tomitribe.com> wrote:
> > >
> > > > Hey guys,
> > > >
> > > > Would it be possible to have a release for Apache BVal?
> > > > --
> > > > Jean-Louis Monteiro
> > > > http://twitter.com/jlouismonteiro
> > > > http://www.tomitribe.com
> > > >
> > >
> >
>

[jira] [Resolved] (BVAL-183) Memory leak on ValueExtractors

[Romain Manni-Bucau (Jira)]

 [ 
https://issues.apache.org/jira/browse/BVAL-183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau resolved BVAL-183.
-
Fix Version/s: 2.0.5
   Resolution: Fixed

> Memory leak on ValueExtractors
> --
>
> Key: BVAL-183
> URL: https://issues.apache.org/jira/browse/BVAL-183
> Project: BVal
>  Issue Type: Bug
>Reporter: Jean-Louis Monteiro
>Priority: Major
> Fix For: 2.0.5
>
> Attachments: leak1.png, leak2.png
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> When using Apache BVal on a JAX RS endpoint, even if there is nothing to 
> validate, Apache CXF will call executableValidator to validate the 
> parameters, the return value and so on.
>  
> When creating the validator from the factory, the value extractors will be 
> created again and again, with the child creating memory leaks (see picture of 
> a small REST endpoint without validation constraints - after a few minutes, 
> memory is full of Lazy and ValueExtractors).
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Project website

[Romain Manni-Bucau]

Hi Andrew,

AFAIK we push the mvn website in
https://svn.apache.org/repos/infra/websites/production/bval/content/ and
tend to use the cms to edit the download page but it can be done directly
in svn without any issue (not sure anyone did anything else).

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le lun. 17 août 2020 à 13:57, Andrew Wetmore  a écrit :

> Hi:
>
> I wrote to you two weeks ago about your project website, but have not seen
> a response. Whom should I contact directly? I am trying to see whether your
> project still uses the Apache CMS and, if so, what your plans are to
> migrate off it.
>
> Thanks in advance for your help.
>
> Andrew
>
> On Tue, Aug 4, 2020 at 10:37 AM Andrew Wetmore  wrote:
>
> > Hi:
> >
> > I am part of the Infrastructure team, and am writing to ask whether your
> > project is still using the Apache CMS for your project website. As you
> > know, the CMS is reaching end-of-life, and we need projects to move their
> > websites onto a different option within the next few weeks.
> >
> > There are several alternatives available, including those listed on this
> > page [1] on managing project websites. Infra is assembling a Wiki page
> [2]
> > on migrating a website from the CMS, and is looking forward to helping
> > projects with this transition.
> >
> > Please let me know whether your site is still on the Apache CMS and, if
> > so, who will be the project point-of-contact with Infra for the
> migration.
> >
> > Thank you!
> >
> >
> >
> >
> > [1] https://infra.apache.org/project-site.html
> >
> > [2]
> >
> https://cwiki.apache.org/confluence/display/INFRA/Migrate+your+project+website+from+the+Apache+CMS
> >
> >
> > --
> > Andrew Wetmore
> > Technical Writer-Editor
> > Infra
> > *Apache Software Foundation*
> > andr...@apache.org
> >
> >
> > <
> https://www.avast.com/sig-email?utm_medium=email_source=link_campaign=sig-email_content=webmail>
> Virus-free.
> > www.avast.com
> > <
> https://www.avast.com/sig-email?utm_medium=email_source=link_campaign=sig-email_content=webmail
> >
> > <#m_2342671465517883630_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
> >
>
>
> --
> Andrew Wetmore
> Technical Writer-Editor
> Infra
> *Apache Software Foundation*
> andr...@apache.org
>

[jira] [Commented] (BVAL-182) CDI deployment failure:WELD-001409

[Romain Manni-Bucau (Jira)]

[ 
https://issues.apache.org/jira/browse/BVAL-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138367#comment-17138367
 ] 

Romain Manni-Bucau commented on BVAL-182:
-

[~tandraschko] best we can do is to let hibernate-validator handle the cdi bean 
(-Dbval-in-container *on the jvm*, not a connection pool ;)) or the app can fix 
it with a custom extension vetoing the bean it does not need. Not sure we'd do 
much more at bval level.

> CDI deployment failure:WELD-001409
> --
>
> Key: BVAL-182
> URL: https://issues.apache.org/jira/browse/BVAL-182
> Project: BVal
>  Issue Type: Bug
>Reporter: uma.maheswar
>Priority: Major
>
> while deploying Syncope war file in glassfish server i m getting this issue.
> Error occurred during deployment: Exception while loading the app : CDI 
> deployment failure:WELD-001409: Ambiguous dependencies for type Validator 
> with qualifiers @Default at injection point [UnbackedAnnotatedField] @Inject 
> private 
> org.hibernate.validator.internal.cdi.interceptor.ValidationInterceptor.validator
>  at
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (BVAL-182) CDI deployment failure:WELD-001409

[Romain Manni-Bucau (Jira)]

[ 
https://issues.apache.org/jira/browse/BVAL-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115724#comment-17115724
 ] 

Romain Manni-Bucau commented on BVAL-182:
-

Hi [~Ebm_unit1] , did you try to set -Dbval.in-container=true?

> CDI deployment failure:WELD-001409
> --
>
> Key: BVAL-182
> URL: https://issues.apache.org/jira/browse/BVAL-182
> Project: BVal
>  Issue Type: Bug
>Reporter: uma.maheswar
>Priority: Major
>
> while deploying Syncope war file in glassfish server i m getting this issue.
> Error occurred during deployment: Exception while loading the app : CDI 
> deployment failure:WELD-001409: Ambiguous dependencies for type Validator 
> with qualifiers @Default at injection point [UnbackedAnnotatedField] @Inject 
> private 
> org.hibernate.validator.internal.cdi.interceptor.ValidationInterceptor.validator
>  at
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (BVAL-181) bval-guice 0.5 does not work with Java 11

[Romain Manni-Bucau (Jira)]

[ 
https://issues.apache.org/jira/browse/BVAL-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111820#comment-17111820
 ] 

Romain Manni-Bucau commented on BVAL-181:
-

Hi [~BinaryJohn], I suspect we can just upgrade guice in the module for next 
release. Do you want to give a try doing a PR on github?

> bval-guice 0.5 does not work with Java 11
> -
>
> Key: BVAL-181
> URL: https://issues.apache.org/jira/browse/BVAL-181
> Project: BVal
>  Issue Type: Bug
>Reporter: John Doe
>Priority: Major
>
> bval-guice 0.5 (latest version) does not work with Java 11. It still works 
> with Java 8.
> Simple example code that causes failure with stacktrace
> {code:java}
> ValidationModule module = new org.apache.bval.guice.ValidationModule();
> com.google.inject.Guice.createInjector(module);
> {code}
> Problem seems to be that validation package is using old version of bundle 
> library, which is not compatible with Java 11. 
> But if I update the org.apache.bval.bundle from 0.5 to 2.0.3 version using 
> maven dependencies, new error appears
> {code:java}
> java.lang.NoClassDefFoundError: 
> org/apache/bval/jsr303/DefaultMessageInterpolator
> {code}
> What needs to be done:
> - New version of bval-guice using latest bundle library should be created (to 
> fix problems within the bundle lib) and problems like the 
> NoClassDefFoundError error above should be fixed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (BVAL-179) ValidationMessages.properties not found

[Romain Manni-Bucau (Jira)]

[ 
https://issues.apache.org/jira/browse/BVAL-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959023#comment-16959023
 ] 

Romain Manni-Bucau commented on BVAL-179:
-

If it helps: 
[https://github.com/apache/bval/blob/master/bval-jsr/src/main/java/org/apache/bval/jsr/DefaultMessageInterpolator.java#L239]
 should be the app loader, bval uses TCCL so maybe tomee should set it in lazy 
validator or so.

> ValidationMessages.properties not found
> ---
>
> Key: BVAL-179
> URL: https://issues.apache.org/jira/browse/BVAL-179
> Project: BVal
>  Issue Type: Bug
>  Components: jpa
>Affects Versions: 2.0.3
> Environment: Apache TomEE Plus 8.0.0
> OpenJDK 12
> Windows 10
> Apache Netbeans 11.1
>Reporter: Cédric Servais
>Priority: Major
>
> Hello,
>  
> I'm using Apache TomEE for a home project and I was trying to move bean 
> validation towards my entities. Doing so, everything is working fine. 
> However, when I tried to use localized messages according to the specs 
> (ValidationMessages.properties at the root of the classpath) but I've been 
> unfortunate, my expression \{users.name.notnull} is displayed as such in my 
> rendered JSF form and it seems that no replacement is being performed by BVAL.
>  
> I've tried to locate the possible issue but I've been quite unfortunate. Any 
> help would be welcome.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (BVAL-179) ValidationMessages.properties not found

[Romain Manni-Bucau (Jira)]

[ 
https://issues.apache.org/jira/browse/BVAL-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958256#comment-16958256
 ] 

Romain Manni-Bucau commented on BVAL-179:
-

Hi Cédric, this is what is coded until you set a custom message interpolator. 
Are you sure you dont have one through jsf or one extension?

> ValidationMessages.properties not found
> ---
>
> Key: BVAL-179
> URL: https://issues.apache.org/jira/browse/BVAL-179
> Project: BVal
>  Issue Type: Bug
>  Components: jpa
>Affects Versions: 2.0.3
> Environment: Apache TomEE Plus 8.0.0
> OpenJDK 12
> Windows 10
> Apache Netbeans 11.1
>Reporter: Cédric Servais
>Priority: Major
>
> Hello,
>  
> I'm using Apache TomEE for a home project and I was trying to move bean 
> validation towards my entities. Doing so, everything is working fine. 
> However, when I tried to use localized messages according to the specs 
> (ValidationMessages.properties at the root of the classpath) but I've been 
> unfortunate, my expression \{users.name.notnull} is displayed as such in my 
> rendered JSF form and it seems that no replacement is being performed by BVAL.
>  
> I've tried to locate the possible issue but I've been quite unfortunate. Any 
> help would be welcome.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (BVAL-178) bval 1.1.3 release

[Romain Manni-Bucau (Jira)]

[ 
https://issues.apache.org/jira/browse/BVAL-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927391#comment-16927391
 ] 

Romain Manni-Bucau commented on BVAL-178:
-

[~kopkar] will try to work on it next week so likely in 1 or 2 weeks.

> bval 1.1.3 release
> --
>
> Key: BVAL-178
> URL: https://issues.apache.org/jira/browse/BVAL-178
> Project: BVal
>  Issue Type: Task
>Reporter: Rafał Kopka
>Priority: Major
>
> Bval branch - bval-1.1.x contains a few fixes we need. Do you have the plan 
> to release version 1.1.3?



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (BVAL-174) Return Parameter Validation Ignore void methods

[Romain Manni-Bucau (Jira)]

[ 
https://issues.apache.org/jira/browse/BVAL-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925400#comment-16925400
 ] 

Romain Manni-Bucau commented on BVAL-174:
-

Hmm, it does not change anything for end users at all. Qualifiers are there for 
that. Bean validation does not help at all, even makes it more complicated and 
intricate in terms of spec overlapping. It also has a big drawback, falling in 
bean validation/jaxrs integration so status code and payload would be wrong or 
would need to be customizable. The bean validation error handling is also 
broken (no more bean path for example, so form integration is unusable).
The trade off complexity/feature is way too high IMHO compared to a pure CDI 
solution (which can integrate to jaxrs for not cdi beans endpoints if desired 
but it is out of scope of microprofile).

> Return Parameter Validation Ignore void methods
> ---
>
> Key: BVAL-174
> URL: https://issues.apache.org/jira/browse/BVAL-174
> Project: BVal
>  Issue Type: Improvement
>Affects Versions: 2.0.0
>Reporter: David Blevins
>Priority: Major
> Fix For: 2.0.3
>
> Attachments: BVAL-174.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Given the following annotation:
> {code:java}
> import javax.validation.ConstraintValidator;
> import javax.validation.ConstraintValidatorContext;
> import javax.validation.Payload;
> import java.lang.annotation.Documented;
> import java.lang.annotation.Retention;
> import java.lang.annotation.Target;
> import java.util.Set;
> import static java.lang.annotation.ElementType.ANNOTATION_TYPE;
> import static java.lang.annotation.ElementType.METHOD;
> import static java.lang.annotation.RetentionPolicy.RUNTIME;
> @Documented
> @javax.validation.Constraint(validatedBy = {Audience.Constraint.class})
> @Target({METHOD, ANNOTATION_TYPE})
> @Retention(RUNTIME)
> public @interface Audience {
> String value();
> Class[] groups() default {};
> String message() default "The 'aud' claim must contain '{value}'";
> Class[] payload() default {};
> class Constraint implements ConstraintValidator {
> private Audience audience;
> @Override
> public void initialize(final Audience constraint) {
> this.audience = constraint;
> }
> @Override
> public boolean isValid(final JsonWebToken value, final 
> ConstraintValidatorContext context) {
> final Set audience = value.getAudience();
> return audience != null && 
> audience.contains(this.audience.value());
> }
> }
> }
> {code}
> BVal wil successfully avoid throwing errors when placed on a method like the 
> following:
> {code:java}
> @GET
> @Path("foo")
> @Audience("movies")
> @RolesAllowed({"manager", "user"})
> public Movie getMovie() {
> return new Movie(1, "The Matrix", "Lana Wachowski");
> }
> {code}
> However on a method that returns void an exception will be throwing stating 
> BVal cannot find a ConstraintValidator for return type void.
> {code:java}
> @POST
> @Audience("movies")
> @RolesAllowed("manager")
> public void addMovie(Movie newMovie) {
> store.put(newMovie.getId(), newMovie);
> }
> {code}
> If the BValInterceptor is updated to ignore checking return values of void 
> methods, it appears to pass the Bean Validation TCK and solves the issue.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (BVAL-174) Return Parameter Validation Ignore void methods

[Romain Manni-Bucau (Jira)]

[ 
https://issues.apache.org/jira/browse/BVAL-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925382#comment-16925382
 ] 

Romain Manni-Bucau commented on BVAL-174:
-

If ambiguous David, I agree there is space in microprofile-jwt-auth to have a 
built in interceptor not javax.security based.
The API you propose is a good start too.
Now, in terms of impl, I dislike it would depend on bval in terms of stack + I 
fail to see the benefit. Did you do the CDI based impl? It is quite trivial 
since jwt is injected.

For example for a jaxrs flavor, here is an impl:


{code}
@Provider
@Dependent
public class EnforceEndpointSecurity implements DynamicFeature {
@Inject
private JsonWebToken token;

@Inject
private AuditConfiguration configuration;

@Override
public void configure(final ResourceInfo resourceInfo, final FeatureContext 
context) {
final String className = resourceInfo.getResourceClass().getName();
if (className.startsWith("org.microprofileext.openapi.swaggerui.")) { 
// no security
return;
}
if (!className.startsWith("org.talend.")) {
context.register(new 
CheckStaticTokenPresence(configuration::monitoringToken));
} else if 
(!resourceInfo.getResourceMethod().isAnnotationPresent(EnableAnonymous.class)) {
context.register(new CheckJwtPresence(token));
}
}

private static class CheckPresence implements ContainerRequestFilter {
private final Function check;

private CheckPresence(final Function 
check) {
this.check = check;
}

@Override
public void filter(final ContainerRequestContext requestContext) {
try {
if (!check.apply(requestContext)) {
unauthenticated(requestContext);
}
} catch (final RuntimeException re) {
unauthenticated(requestContext);
}
}

private void unauthenticated(final ContainerRequestContext 
requestContext) {

requestContext.abortWith(Response.status(Response.Status.UNAUTHORIZED)
.entity(new ErrorMessage("Forbidden request"))
.build());
}
}

private static class CheckJwtPresence extends CheckPresence {
private CheckJwtPresence(final JsonWebToken token) {
super(ignored -> token.getRawToken() != null);
}
}

private static class CheckStaticTokenPresence extends CheckPresence {
private CheckStaticTokenPresence(final Supplier token) {
super(context -> 
token.get().equals(context.getHeaderString(HttpHeaders.AUTHORIZATION)));
}
}
}
{code}

> Return Parameter Validation Ignore void methods
> ---
>
> Key: BVAL-174
> URL: https://issues.apache.org/jira/browse/BVAL-174
> Project: BVal
>  Issue Type: Improvement
>Affects Versions: 2.0.0
>Reporter: David Blevins
>Priority: Major
> Fix For: 2.0.3
>
> Attachments: BVAL-174.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Given the following annotation:
> {code:java}
> import javax.validation.ConstraintValidator;
> import javax.validation.ConstraintValidatorContext;
> import javax.validation.Payload;
> import java.lang.annotation.Documented;
> import java.lang.annotation.Retention;
> import java.lang.annotation.Target;
> import java.util.Set;
> import static java.lang.annotation.ElementType.ANNOTATION_TYPE;
> import static java.lang.annotation.ElementType.METHOD;
> import static java.lang.annotation.RetentionPolicy.RUNTIME;
> @Documented
> @javax.validation.Constraint(validatedBy = {Audience.Constraint.class})
> @Target({METHOD, ANNOTATION_TYPE})
> @Retention(RUNTIME)
> public @interface Audience {
> String value();
> Class[] groups() default {};
> String message() default "The 'aud' claim must contain '{value}'";
> Class[] payload() default {};
> class Constraint implements ConstraintValidator {
> private Audience audience;
> @Override
> public void initialize(final Audience constraint) {
> this.audience = constraint;
> }
> @Override
> public boolean isValid(final JsonWebToken value, final 
> ConstraintValidatorContext context) {
> final Set audience = value.getAudience();
> return audience != null && 
> audience.contains(this.audience.value());
> }
> }
> }
> {code}
> BVal wil successfully avoid throwing errors when placed on a method like the 
> following:
> {code

[jira] [Commented] (BVAL-174) Return Parameter Validation Ignore void methods

[Romain Manni-Bucau (Jira)]

[ 
https://issues.apache.org/jira/browse/BVAL-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925364#comment-16925364
 ] 

Romain Manni-Bucau commented on BVAL-174:
-

To give back the credit the change happent between spec v1.0#appendix-C and 
spec v2.0, was not from me ;).

I kind of agree on the experiment side but fail to see value in bean validation 
when you have CDI - and when you have not, context does not mean anything we 
can rely upon in a generic impl.

> Return Parameter Validation Ignore void methods
> ---
>
> Key: BVAL-174
> URL: https://issues.apache.org/jira/browse/BVAL-174
> Project: BVal
>  Issue Type: Improvement
>Affects Versions: 2.0.0
>Reporter: David Blevins
>Priority: Major
> Fix For: 2.0.3
>
> Attachments: BVAL-174.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Given the following annotation:
> {code:java}
> import javax.validation.ConstraintValidator;
> import javax.validation.ConstraintValidatorContext;
> import javax.validation.Payload;
> import java.lang.annotation.Documented;
> import java.lang.annotation.Retention;
> import java.lang.annotation.Target;
> import java.util.Set;
> import static java.lang.annotation.ElementType.ANNOTATION_TYPE;
> import static java.lang.annotation.ElementType.METHOD;
> import static java.lang.annotation.RetentionPolicy.RUNTIME;
> @Documented
> @javax.validation.Constraint(validatedBy = {Audience.Constraint.class})
> @Target({METHOD, ANNOTATION_TYPE})
> @Retention(RUNTIME)
> public @interface Audience {
> String value();
> Class[] groups() default {};
> String message() default "The 'aud' claim must contain '{value}'";
> Class[] payload() default {};
> class Constraint implements ConstraintValidator {
> private Audience audience;
> @Override
> public void initialize(final Audience constraint) {
> this.audience = constraint;
> }
> @Override
> public boolean isValid(final JsonWebToken value, final 
> ConstraintValidatorContext context) {
> final Set audience = value.getAudience();
> return audience != null && 
> audience.contains(this.audience.value());
> }
> }
> }
> {code}
> BVal wil successfully avoid throwing errors when placed on a method like the 
> following:
> {code:java}
> @GET
> @Path("foo")
> @Audience("movies")
> @RolesAllowed({"manager", "user"})
> public Movie getMovie() {
> return new Movie(1, "The Matrix", "Lana Wachowski");
> }
> {code}
> However on a method that returns void an exception will be throwing stating 
> BVal cannot find a ConstraintValidator for return type void.
> {code:java}
> @POST
> @Audience("movies")
> @RolesAllowed("manager")
> public void addMovie(Movie newMovie) {
> store.put(newMovie.getId(), newMovie);
> }
> {code}
> If the BValInterceptor is updated to ignore checking return values of void 
> methods, it appears to pass the Bean Validation TCK and solves the issue.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (BVAL-174) Return Parameter Validation Ignore void methods

[Romain Manni-Bucau (Jira)]

[ 
https://issues.apache.org/jira/browse/BVAL-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925356#comment-16925356
 ] 

Romain Manni-Bucau commented on BVAL-174:
-

Changes are actually aligned on the spec.

Things to consider:
 # Validation is lazy per class
 # CDI integration preload classes model during scanning - making it eager
 # Putting a validation which is invalid anywhere must fail
 # JakartaEE/JavaEE enforces validation during startup to not fail at runtime 
if possible

 

Put altogether, I think we are quite good currently.

As mentionned on the list, the original use case does not bzlong to bean 
validation IMHO but just a plain CDI interceptor - note that it does not break 
the API ;) - which are designed for exactly that. Bean validation is not about 
contextual data but about direct instances.

 

> Return Parameter Validation Ignore void methods
> ---
>
> Key: BVAL-174
> URL: https://issues.apache.org/jira/browse/BVAL-174
> Project: BVal
>  Issue Type: Improvement
>Affects Versions: 2.0.0
>Reporter: David Blevins
>Priority: Major
> Fix For: 2.0.3
>
> Attachments: BVAL-174.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Given the following annotation:
> {code:java}
> import javax.validation.ConstraintValidator;
> import javax.validation.ConstraintValidatorContext;
> import javax.validation.Payload;
> import java.lang.annotation.Documented;
> import java.lang.annotation.Retention;
> import java.lang.annotation.Target;
> import java.util.Set;
> import static java.lang.annotation.ElementType.ANNOTATION_TYPE;
> import static java.lang.annotation.ElementType.METHOD;
> import static java.lang.annotation.RetentionPolicy.RUNTIME;
> @Documented
> @javax.validation.Constraint(validatedBy = {Audience.Constraint.class})
> @Target({METHOD, ANNOTATION_TYPE})
> @Retention(RUNTIME)
> public @interface Audience {
> String value();
> Class[] groups() default {};
> String message() default "The 'aud' claim must contain '{value}'";
> Class[] payload() default {};
> class Constraint implements ConstraintValidator {
> private Audience audience;
> @Override
> public void initialize(final Audience constraint) {
> this.audience = constraint;
> }
> @Override
> public boolean isValid(final JsonWebToken value, final 
> ConstraintValidatorContext context) {
> final Set audience = value.getAudience();
> return audience != null && 
> audience.contains(this.audience.value());
> }
> }
> }
> {code}
> BVal wil successfully avoid throwing errors when placed on a method like the 
> following:
> {code:java}
> @GET
> @Path("foo")
> @Audience("movies")
> @RolesAllowed({"manager", "user"})
> public Movie getMovie() {
> return new Movie(1, "The Matrix", "Lana Wachowski");
> }
> {code}
> However on a method that returns void an exception will be throwing stating 
> BVal cannot find a ConstraintValidator for return type void.
> {code:java}
> @POST
> @Audience("movies")
> @RolesAllowed("manager")
> public void addMovie(Movie newMovie) {
> store.put(newMovie.getId(), newMovie);
> }
> {code}
> If the BValInterceptor is updated to ignore checking return values of void 
> methods, it appears to pass the Bean Validation TCK and solves the issue.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Fwd: [jira] [Created] (BVAL-178) bval 1.1.3 release

[Romain Manni-Bucau]

Hi all,

I'll probably be short in time the 2 coming weeks for that but think it is
good to do it anytime soon.
Anyone having time for it? If not I will try to not forget to come back on
it end of september.

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


-- Forwarded message -
De : Rafał Kopka (Jira) 
Date: jeu. 29 août 2019 à 13:41
Subject: [jira] [Created] (BVAL-178) bval 1.1.3 release
To: 


Rafał Kopka created BVAL-178:


 Summary: bval 1.1.3 release
 Key: BVAL-178
 URL: https://issues.apache.org/jira/browse/BVAL-178
 Project: BVal
  Issue Type: Task
Reporter: Rafał Kopka


Bval branch - bval-1.1.x contains a few fixes we need. Do you have the plan
to release version 1.1.3?



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Re: [RESULT] [VOTE] Apache BVal 2.0.3 Release Candidate

[Romain Manni-Bucau]

Thanks Thomas and kudo for the release!

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le lun. 19 août 2019 à 09:49, Thomas Andraschko 
a écrit :

> The vote has passed with the following results:
>
> +1Romain Manni-Bucau (binding)Matt Benson(binding)
> Mark Struberg(binding)
> Thomas Andraschko(binding)
>
> I will proceed with the next steps.
>
> Best regards,
>
> Thomas
>

Re: [VOTE] Apache BVal 2.0.3 Release Candidate

[Romain Manni-Bucau]

+1

Le lun. 12 août 2019 à 12:24, Thomas Andraschko 
a écrit :

> Hi,
>
> I've created a 2.0.3 release candidate, with the following artifacts
> up for a vote:e:
>
> Git source tag:https://gitbox.apache.org/repos/asf?p=bval.git;a=tags
>
> Maven staging repo:
> https://repository.apache.org/content/repositories/orgapachebval-1009/
>
> Source release:https://dist.apache.org/repos/dist/dev/bval/2.0.3
>
> Generated site:
> https://dist.apache.org/repos/dist/dev/bval/2.0.3/site/index.html
>
> PGP release keys:http://www.apache.org/dist/bval/KEYS
>
> The vote will be open for at least 72 hours.
>
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
>

Re: Release?

[Romain Manni-Bucau]

Hi Thomas,

the process is online at http://bval.apache.org/release-process.html

long story short, it should just be a matter of release:prepare
release:perform if you already have your gpg key set up (+ standard dev
area stuff)

please shout if you feel lost anywhere ;)

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le sam. 10 août 2019 à 17:07, Thomas Andraschko 
a écrit :

> Hi,
>
> it seems that the TomEE guys are now ok with updating BVal, so it would be
> great if we can get a new release out.
>
> Would anyone like to do it?
> Otherwise, is there a release checklist or something? (I only did a release
> @ apache once).
>
> Regards,
> Thomas
>

[jira] [Resolved] (BVAL-177) Multithreaded application may use uninitilized validator

[Romain Manni-Bucau (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BVAL-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau resolved BVAL-177.
-
   Resolution: Fixed
Fix Version/s: 1.1.3

[~Świątek] thanks a lot for the patch, it had been applied.

> Multithreaded application may use uninitilized validator
> 
>
> Key: BVAL-177
> URL: https://issues.apache.org/jira/browse/BVAL-177
> Project: BVal
>  Issue Type: Bug
>Affects Versions: 1.1.2
>Reporter: Łukasz Świątek
>Priority: Major
> Fix For: 1.1.3
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Due to race condition in 
> org.apache.bval.jsr.ConstraintValidation#validateGroupContext when first 
> creating the validator, some threads may use uninitialized validator



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Resolved] (BVAL-170) BVAL 2.x is very very slow

[Romain Manni-Bucau (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BVAL-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau resolved BVAL-170.
-
   Resolution: Fixed
Fix Version/s: 2.0.3

> BVAL 2.x is very very slow
> --
>
> Key: BVAL-170
> URL: https://issues.apache.org/jira/browse/BVAL-170
> Project: BVal
>  Issue Type: Bug
>  Components: jsr303
>Affects Versions: 1.1.2, 2.0.0
>Reporter: Thomas Andraschko
>Priority: Critical
> Fix For: 2.0.3
>
> Attachments: bval1.patch, bval2.patch, bval3.patch
>
>
> Simple case:
> [https://gist.github.com/tandraschko/160195cfd35c22d8519a4304856fab65]
> With BVal it takes on my machine around 20 seconds.
> Hibernate Validator 6 takes around 1 second.
> I also checked the hibernate validator benchmark for a case and here is a 
> extract of one case with operations per seconds:
> HV 6: 874
> BV 1.1: 347
> BV 2.0: 53



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Re: BVAL-174 Return Parameter Validation Ignore void methods

[Romain Manni-Bucau]

Hmm, think a few things are mixed up here so let's try to develop my view
and see how it can meet:

1. I think the spirit of Bean Validation is the same than in EE, i.e. try
to harness the programming model so if anything can't be supported then
fail (~https://beanvalidation.org/2.0/spec/#exception-constraintdeclaration to
quote a simple part of the spec)
2. Bean Validation is also about being declarative so not about being
"contextual" as CDI can be which would break its static side which makes
its value
3. What you describe is more a CDI interceptor doing the Jwt lookup and
validating it - potentally with Bean Validation programmatically.

Now personally I tend to validate the jwt through a parameter passing in
method which would enable to use bean validation as usual. If you think
JAX-RS - I guess it is where you are coming from? it can be trivial to make
the Jwt a @Context  through a context provider and then validating it is as
easy as putting a @ValidJwt on the param.

Does it make some sense?

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le jeu. 11 juil. 2019 à 10:51, David Blevins  a
écrit :

> Thanks for the ping and sorry this fell off my radar.  Even more, thanks
> for the work!
>
> If we threw some kind of exception, this can work.  It would be a little
> bit expensive in practice as it would be happening every time, which means
> anyone who uses this feature will pay the cost of triggering a stack trace
> each call.  This could still be someone what livable as they're
> theoretically also doing an RSA public key check in the same call, which
> I'd expect to be more expensive (untested assumption).
>
> For this to work fully, we'd need some way to tell the BValInterceptor to
> catch the exception and keep going.  Right around here we'd need some logic
> that catches the "no valid constraints" exception and still keeps going:
>
>  -
> https://github.com/apache/bval/blob/master/bval-jsr/src/main/java/org/apache/bval/cdi/BValInterceptor.java#L163
>
> Which TCK test failed and is there a PR that has the code you two tried
> that caused it to fail?
>
> Thinking out loud, the most ideal outcome is that the constraints that can
> apply are applied.  Those that cannot apply are simply ignored.
> Theoretically, a user could have a few constraints on the method: some
> aimed at the return value, some aimed at contextual data like the JWT.
> Let's imagine this scenario:
>
> @OrangeToken
> @GreenReturn
> public Green paint() {
> //...
> }
>
> We'll say under the covers the validator impls are:
>
> - @OrangeToken validatedBy = class OrangeTokenConstraint implements
> ConstraintValidator
> - @GreenReturn validatedBy = class GreenReturnConstraint implements
> ConstraintValidator
>
> Here's how throwing an exception could play out:
>
> - BValInterceptor sees `OrangeTokenConstraint` cannot apply to `Green`
> and throws an exception.  `GreenReturnConstraint` is therefore not
> enforced, but should.
> - MPJWTValidatorInterceptor sees `GreenReturnConstraint` cannot apply
> to `JsonWebToken` and throws an exception. `OrangeTokenConstraint` is
> therefore not enforced, but should.
>
> The call is allowed to complete even though both the return value and
> contextual @RequestScoped JsonWebToken are potentially not valid.
>
> I'd have to look around the failing TCK test to figure out what is most in
> spirit with the Bean Validation TCK, but it might be the case there's some
> future standardization work that has to be done and some meta-data we need
> to invent.  Maybe the opportunity for us to pave some new ground.
>
> The basic concept is:
>
>   - There might be CDI contextual objects a user might want to validate
> before a method is called (new feature)
>   - There might be a return value a user might want to validate after a
> method is called (the existing feature)
>
> Essentially, some of them are before advice and some after advice.  One
> flavor of the before advice could be to validate an object that is found in
> a CDI Scope.
>
> Short term, could we perhaps require someone put some kind of annotation
> on their Constraint annotation or ConstraintValidator that basically says
> "don't include me in the return value constraints", so those do not show up
> in `ReturnValueDescriptor`.  It could be something very blunt and direct
> like @DescriptorType
>
> This is not really a complete idea

[jira] [Resolved] (BVAL-174) Return Parameter Validation Ignore void methods

[Romain Manni-Bucau (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BVAL-174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau resolved BVAL-174.
-
Resolution: Fixed

> Return Parameter Validation Ignore void methods
> ---
>
> Key: BVAL-174
> URL: https://issues.apache.org/jira/browse/BVAL-174
> Project: BVal
>  Issue Type: Improvement
>Affects Versions: 2.0.0
>Reporter: David Blevins
>Priority: Major
> Fix For: 2.0.3
>
> Attachments: BVAL-174.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Given the following annotation:
> {code:java}
> import javax.validation.ConstraintValidator;
> import javax.validation.ConstraintValidatorContext;
> import javax.validation.Payload;
> import java.lang.annotation.Documented;
> import java.lang.annotation.Retention;
> import java.lang.annotation.Target;
> import java.util.Set;
> import static java.lang.annotation.ElementType.ANNOTATION_TYPE;
> import static java.lang.annotation.ElementType.METHOD;
> import static java.lang.annotation.RetentionPolicy.RUNTIME;
> @Documented
> @javax.validation.Constraint(validatedBy = {Audience.Constraint.class})
> @Target({METHOD, ANNOTATION_TYPE})
> @Retention(RUNTIME)
> public @interface Audience {
> String value();
> Class[] groups() default {};
> String message() default "The 'aud' claim must contain '{value}'";
> Class[] payload() default {};
> class Constraint implements ConstraintValidator {
> private Audience audience;
> @Override
> public void initialize(final Audience constraint) {
> this.audience = constraint;
> }
> @Override
> public boolean isValid(final JsonWebToken value, final 
> ConstraintValidatorContext context) {
> final Set audience = value.getAudience();
> return audience != null && 
> audience.contains(this.audience.value());
> }
> }
> }
> {code}
> BVal wil successfully avoid throwing errors when placed on a method like the 
> following:
> {code:java}
> @GET
> @Path("foo")
> @Audience("movies")
> @RolesAllowed({"manager", "user"})
> public Movie getMovie() {
> return new Movie(1, "The Matrix", "Lana Wachowski");
> }
> {code}
> However on a method that returns void an exception will be throwing stating 
> BVal cannot find a ConstraintValidator for return type void.
> {code:java}
> @POST
> @Audience("movies")
> @RolesAllowed("manager")
> public void addMovie(Movie newMovie) {
> store.put(newMovie.getId(), newMovie);
> }
> {code}
> If the BValInterceptor is updated to ignore checking return values of void 
> methods, it appears to pass the Bean Validation TCK and solves the issue.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (BVAL-176) setAccessible handling is broken for multithreaded apps with SecurityManager

[Romain Manni-Bucau (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BVAL-176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau updated BVAL-176:

Fix Version/s: 1.1.3

> setAccessible handling is broken for multithreaded apps with SecurityManager
> 
>
> Key: BVAL-176
> URL: https://issues.apache.org/jira/browse/BVAL-176
> Project: BVal
>  Issue Type: Bug
>Affects Versions: 1.1.2, 2.0.0
>Reporter: Tomasz Wysocki
>Priority: Major
> Fix For: 1.1.3, 2.0.3
>
> Attachments: ReflectionAccessibilityTest.java
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Currently when using security manager field/method accessible flag will be 
> reset back to false.
> This does not work for multithreaded apps due to lack of synchronization 
> between threads. 
> The effect is exception while validating due to invalid access to protected 
> or private members of target object.
> Workaround is to make all validated members public or synchronize on 
> Validator instance.
> This issue contains a test case to show the effect when security manager is 
> installed and there is no synchronization as well as a patch to 1.1.2.
> This issue applies to bval2 as well but I haven't made a patch.
> Below is proposed resolution:
> Remove reseting of accessible flag when security manager is present
>      
> And rationale:
>  This feature will not work without some synchronization on the
>  reflection data itself in multithreaded environment.
>      
>  Therefore the feature has been removed due to following concerns:
>      
>  1. resetting accessible flag for security manager does not mean that for
>  short period of time the flag is not actually set and bad code could
>  exploit that - therefore resetting accesible back is not really making
>  it unaccessible to other code - this is design flaw. If accessible flag
>  would be per thread it would work much better.
>      
>  2. since accessible flag is global it would require synchronization to 
> make it work correctly,
>   which is costly. Current implementation just breaks for SM present case
>  - it throws 'inaccessible' exceptions since it does not synchronize at
>  all.
>      
>  3. there is no saying what would need to be synchronized (probably the
>  field or method reflected instances but it is not specified). Therefore
>  synchronizing it would work only within scope of a single framework
>  (bval).
>      
>  4. other frameworks typically don't reset back accessible and just keep
>  the flag set. Therefore any synchronization mechanism specific to bval 
> would not cooperate
>  nicely or at all with other frameworks (like spring for instance).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (BVAL-176) setAccessible handling is broken for multithreaded apps with SecurityManager

[Romain Manni-Bucau (JIRA)]

[ 
https://issues.apache.org/jira/browse/BVAL-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860677#comment-16860677
 ] 

Romain Manni-Bucau commented on BVAL-176:
-

[~tawek] thanks a lot, applied :)

> setAccessible handling is broken for multithreaded apps with SecurityManager
> 
>
> Key: BVAL-176
> URL: https://issues.apache.org/jira/browse/BVAL-176
> Project: BVal
>  Issue Type: Bug
>Affects Versions: 1.1.2, 2.0.0
>Reporter: Tomasz Wysocki
>Priority: Major
> Fix For: 1.1.3, 2.0.3
>
> Attachments: ReflectionAccessibilityTest.java
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Currently when using security manager field/method accessible flag will be 
> reset back to false.
> This does not work for multithreaded apps due to lack of synchronization 
> between threads. 
> The effect is exception while validating due to invalid access to protected 
> or private members of target object.
> Workaround is to make all validated members public or synchronize on 
> Validator instance.
> This issue contains a test case to show the effect when security manager is 
> installed and there is no synchronization as well as a patch to 1.1.2.
> This issue applies to bval2 as well but I haven't made a patch.
> Below is proposed resolution:
> Remove reseting of accessible flag when security manager is present
>      
> And rationale:
>  This feature will not work without some synchronization on the
>  reflection data itself in multithreaded environment.
>      
>  Therefore the feature has been removed due to following concerns:
>      
>  1. resetting accessible flag for security manager does not mean that for
>  short period of time the flag is not actually set and bad code could
>  exploit that - therefore resetting accesible back is not really making
>  it unaccessible to other code - this is design flaw. If accessible flag
>  would be per thread it would work much better.
>      
>  2. since accessible flag is global it would require synchronization to 
> make it work correctly,
>   which is costly. Current implementation just breaks for SM present case
>  - it throws 'inaccessible' exceptions since it does not synchronize at
>  all.
>      
>  3. there is no saying what would need to be synchronized (probably the
>  field or method reflected instances but it is not specified). Therefore
>  synchronizing it would work only within scope of a single framework
>  (bval).
>      
>  4. other frameworks typically don't reset back accessible and just keep
>  the flag set. Therefore any synchronization mechanism specific to bval 
> would not cooperate
>  nicely or at all with other frameworks (like spring for instance).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (BVAL-176) setAccessible handling is broken for multithreaded apps with SecurityManager

[Romain Manni-Bucau (JIRA)]

[ 
https://issues.apache.org/jira/browse/BVAL-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859705#comment-16859705
 ] 

Romain Manni-Bucau commented on BVAL-176:
-

Hello [~tawek], finally managed to get the 1.1.x branch at 
https://github.com/apache/bval/tree/bval-1.1.x. Do you want to rework your 
patch for 1.1.x?

> setAccessible handling is broken for multithreaded apps with SecurityManager
> 
>
> Key: BVAL-176
> URL: https://issues.apache.org/jira/browse/BVAL-176
> Project: BVal
>  Issue Type: Bug
>Affects Versions: 1.1.2, 2.0.0
>Reporter: Tomasz Wysocki
>Priority: Major
> Fix For: 2.0.3
>
> Attachments: ReflectionAccessibilityTest.java
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Currently when using security manager field/method accessible flag will be 
> reset back to false.
> This does not work for multithreaded apps due to lack of synchronization 
> between threads. 
> The effect is exception while validating due to invalid access to protected 
> or private members of target object.
> Workaround is to make all validated members public or synchronize on 
> Validator instance.
> This issue contains a test case to show the effect when security manager is 
> installed and there is no synchronization as well as a patch to 1.1.2.
> This issue applies to bval2 as well but I haven't made a patch.
> Below is proposed resolution:
> Remove reseting of accessible flag when security manager is present
>      
> And rationale:
>  This feature will not work without some synchronization on the
>  reflection data itself in multithreaded environment.
>      
>  Therefore the feature has been removed due to following concerns:
>      
>  1. resetting accessible flag for security manager does not mean that for
>  short period of time the flag is not actually set and bad code could
>  exploit that - therefore resetting accesible back is not really making
>  it unaccessible to other code - this is design flaw. If accessible flag
>  would be per thread it would work much better.
>      
>  2. since accessible flag is global it would require synchronization to 
> make it work correctly,
>   which is costly. Current implementation just breaks for SM present case
>  - it throws 'inaccessible' exceptions since it does not synchronize at
>  all.
>      
>  3. there is no saying what would need to be synchronized (probably the
>  field or method reflected instances but it is not specified). Therefore
>  synchronizing it would work only within scope of a single framework
>  (bval).
>      
>  4. other frameworks typically don't reset back accessible and just keep
>  the flag set. Therefore any synchronization mechanism specific to bval 
> would not cooperate
>  nicely or at all with other frameworks (like spring for instance).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Gitbox missing tags (was: Re: [jira] [Commented] (BVAL-176) setAccessible handling is broken for multithreaded apps with SecurityManager)

[Romain Manni-Bucau]

Infra said we should do it ourselves so will try git-svn to import back our
tags, sounds long with the almost 2m of commits on svn, even on a subpath :s

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le mar. 4 juin 2019 à 19:27, Romain Manni-Bucau  a
écrit :

> FYI: https://issues.apache.org/jira/browse/INFRA-18565
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github
> <https://github.com/rmannibucau> | LinkedIn
> <https://www.linkedin.com/in/rmannibucau> | Book
> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>
>
> Le lun. 3 juin 2019 à 08:51, Romain Manni-Bucau  a
> écrit :
>
>> Hello everyone,
>>
>> Do you know where are our 1.x tags/branches? Lost in svn migration?
>> Should we ask infra?
>>
>> Romain Manni-Bucau
>> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
>> <https://rmannibucau.metawerx.net/> | Old Blog
>> <http://rmannibucau.wordpress.com> | Github
>> <https://github.com/rmannibucau> | LinkedIn
>> <https://www.linkedin.com/in/rmannibucau> | Book
>> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>>
>>
>> -- Forwarded message -
>> De : Tomasz Wysocki (JIRA) 
>> Date: lun. 3 juin 2019 à 08:48
>> Subject: [jira] [Commented] (BVAL-176) setAccessible handling is broken
>> for multithreaded apps with SecurityManager
>> To: 
>>
>>
>>
>> [
>> https://issues.apache.org/jira/browse/BVAL-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854274#comment-16854274
>> ]
>>
>> Tomasz Wysocki commented on BVAL-176:
>> -
>>
>> I would be grateful for 1.1.x maintenance branch (fabb6c4) and prompt
>> release of 1.1.3 to avoid custom version.
>>
>> I will do a master fix shortly (second PR).
>>
>>
>>
>> > setAccessible handling is broken for multithreaded apps with
>> SecurityManager
>> >
>> 
>> >
>> > Key: BVAL-176
>> > URL: https://issues.apache.org/jira/browse/BVAL-176
>> > Project: BVal
>> >  Issue Type: Bug
>> >Affects Versions: 1.1.2, 2.0.0
>> >Reporter: Tomasz Wysocki
>> >Priority: Major
>> > Fix For: 1.1.3
>> >
>> > Attachments: ReflectionAccessibilityTest.java
>> >
>> >  Time Spent: 10m
>> >  Remaining Estimate: 0h
>> >
>> > Currently when using security manager field/method accessible flag will
>> be reset back to false.
>> > This does not work for multithreaded apps due to lack of
>> synchronization between threads.
>> > The effect is exception while validating due to invalid access to
>> protected or private members of target object.
>> > Workaround is to make all validated members public or synchronize on
>> Validator instance.
>> > This issue contains a test case to show the effect when security
>> manager is installed and there is no synchronization as well as a patch to
>> 1.1.2.
>> > This issue applies to bval2 as well but I haven't made a patch.
>> > Below is proposed resolution:
>> > Remove reseting of accessible flag when security manager is present
>> >
>> > And rationale:
>> >  This feature will not work without some synchronization on the
>> >  reflection data itself in multithreaded environment.
>> >
>> >  Therefore the feature has been removed due to following concerns:
>> >
>> >  1. resetting accessible flag for security manager does not mean
>> that for
>> >  short period of time the flag is not actually set and bad code
>> could
>> >  exploit that - therefore resetting accesible back is not really
>> making
>> >  it unaccessible to other code - this is design flaw. If accessible
>> flag
>> >  would be per thread it would work much better.
>> &g

[jira] [Commented] (BVAL-176) setAccessible handling is broken for multithreaded apps with SecurityManager

[Romain Manni-Bucau (JIRA)]

[ 
https://issues.apache.org/jira/browse/BVAL-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858520#comment-16858520
 ] 

Romain Manni-Bucau commented on BVAL-176:
-

linking to INFRA-18565 since we need that to apply on 1.1.x

> setAccessible handling is broken for multithreaded apps with SecurityManager
> 
>
> Key: BVAL-176
> URL: https://issues.apache.org/jira/browse/BVAL-176
> Project: BVal
>  Issue Type: Bug
>Affects Versions: 1.1.2, 2.0.0
>Reporter: Tomasz Wysocki
>Priority: Major
> Fix For: 2.0.3
>
> Attachments: ReflectionAccessibilityTest.java
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Currently when using security manager field/method accessible flag will be 
> reset back to false.
> This does not work for multithreaded apps due to lack of synchronization 
> between threads. 
> The effect is exception while validating due to invalid access to protected 
> or private members of target object.
> Workaround is to make all validated members public or synchronize on 
> Validator instance.
> This issue contains a test case to show the effect when security manager is 
> installed and there is no synchronization as well as a patch to 1.1.2.
> This issue applies to bval2 as well but I haven't made a patch.
> Below is proposed resolution:
> Remove reseting of accessible flag when security manager is present
>      
> And rationale:
>  This feature will not work without some synchronization on the
>  reflection data itself in multithreaded environment.
>      
>  Therefore the feature has been removed due to following concerns:
>      
>  1. resetting accessible flag for security manager does not mean that for
>  short period of time the flag is not actually set and bad code could
>  exploit that - therefore resetting accesible back is not really making
>  it unaccessible to other code - this is design flaw. If accessible flag
>  would be per thread it would work much better.
>      
>  2. since accessible flag is global it would require synchronization to 
> make it work correctly,
>   which is costly. Current implementation just breaks for SM present case
>  - it throws 'inaccessible' exceptions since it does not synchronize at
>  all.
>      
>  3. there is no saying what would need to be synchronized (probably the
>  field or method reflected instances but it is not specified). Therefore
>  synchronizing it would work only within scope of a single framework
>  (bval).
>      
>  4. other frameworks typically don't reset back accessible and just keep
>  the flag set. Therefore any synchronization mechanism specific to bval 
> would not cooperate
>  nicely or at all with other frameworks (like spring for instance).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (BVAL-176) setAccessible handling is broken for multithreaded apps with SecurityManager

[Romain Manni-Bucau (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BVAL-176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau updated BVAL-176:

Fix Version/s: (was: 1.1.3)

> setAccessible handling is broken for multithreaded apps with SecurityManager
> 
>
> Key: BVAL-176
> URL: https://issues.apache.org/jira/browse/BVAL-176
> Project: BVal
>  Issue Type: Bug
>Affects Versions: 1.1.2, 2.0.0
>Reporter: Tomasz Wysocki
>Priority: Major
> Fix For: 2.0.3
>
> Attachments: ReflectionAccessibilityTest.java
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Currently when using security manager field/method accessible flag will be 
> reset back to false.
> This does not work for multithreaded apps due to lack of synchronization 
> between threads. 
> The effect is exception while validating due to invalid access to protected 
> or private members of target object.
> Workaround is to make all validated members public or synchronize on 
> Validator instance.
> This issue contains a test case to show the effect when security manager is 
> installed and there is no synchronization as well as a patch to 1.1.2.
> This issue applies to bval2 as well but I haven't made a patch.
> Below is proposed resolution:
> Remove reseting of accessible flag when security manager is present
>      
> And rationale:
>  This feature will not work without some synchronization on the
>  reflection data itself in multithreaded environment.
>      
>  Therefore the feature has been removed due to following concerns:
>      
>  1. resetting accessible flag for security manager does not mean that for
>  short period of time the flag is not actually set and bad code could
>  exploit that - therefore resetting accesible back is not really making
>  it unaccessible to other code - this is design flaw. If accessible flag
>  would be per thread it would work much better.
>      
>  2. since accessible flag is global it would require synchronization to 
> make it work correctly,
>   which is costly. Current implementation just breaks for SM present case
>  - it throws 'inaccessible' exceptions since it does not synchronize at
>  all.
>      
>  3. there is no saying what would need to be synchronized (probably the
>  field or method reflected instances but it is not specified). Therefore
>  synchronizing it would work only within scope of a single framework
>  (bval).
>      
>  4. other frameworks typically don't reset back accessible and just keep
>  the flag set. Therefore any synchronization mechanism specific to bval 
> would not cooperate
>  nicely or at all with other frameworks (like spring for instance).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (BVAL-176) setAccessible handling is broken for multithreaded apps with SecurityManager

[Romain Manni-Bucau (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BVAL-176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau resolved BVAL-176.
-
Resolution: Fixed

fixed on master for now, will apply the backport ASAP

> setAccessible handling is broken for multithreaded apps with SecurityManager
> 
>
> Key: BVAL-176
> URL: https://issues.apache.org/jira/browse/BVAL-176
> Project: BVal
>  Issue Type: Bug
>Affects Versions: 1.1.2, 2.0.0
>Reporter: Tomasz Wysocki
>Priority: Major
> Fix For: 2.0.3
>
> Attachments: ReflectionAccessibilityTest.java
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Currently when using security manager field/method accessible flag will be 
> reset back to false.
> This does not work for multithreaded apps due to lack of synchronization 
> between threads. 
> The effect is exception while validating due to invalid access to protected 
> or private members of target object.
> Workaround is to make all validated members public or synchronize on 
> Validator instance.
> This issue contains a test case to show the effect when security manager is 
> installed and there is no synchronization as well as a patch to 1.1.2.
> This issue applies to bval2 as well but I haven't made a patch.
> Below is proposed resolution:
> Remove reseting of accessible flag when security manager is present
>      
> And rationale:
>  This feature will not work without some synchronization on the
>  reflection data itself in multithreaded environment.
>      
>  Therefore the feature has been removed due to following concerns:
>      
>  1. resetting accessible flag for security manager does not mean that for
>  short period of time the flag is not actually set and bad code could
>  exploit that - therefore resetting accesible back is not really making
>  it unaccessible to other code - this is design flaw. If accessible flag
>  would be per thread it would work much better.
>      
>  2. since accessible flag is global it would require synchronization to 
> make it work correctly,
>   which is costly. Current implementation just breaks for SM present case
>  - it throws 'inaccessible' exceptions since it does not synchronize at
>  all.
>      
>  3. there is no saying what would need to be synchronized (probably the
>  field or method reflected instances but it is not specified). Therefore
>  synchronizing it would work only within scope of a single framework
>  (bval).
>      
>  4. other frameworks typically don't reset back accessible and just keep
>  the flag set. Therefore any synchronization mechanism specific to bval 
> would not cooperate
>  nicely or at all with other frameworks (like spring for instance).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Fwd: [jira] [Commented] (BVAL-176) setAccessible handling is broken for multithreaded apps with SecurityManager

[Romain Manni-Bucau]

Hello everyone,

Do you know where are our 1.x tags/branches? Lost in svn migration? Should
we ask infra?

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


-- Forwarded message -
De : Tomasz Wysocki (JIRA) 
Date: lun. 3 juin 2019 à 08:48
Subject: [jira] [Commented] (BVAL-176) setAccessible handling is broken for
multithreaded apps with SecurityManager
To: 



[
https://issues.apache.org/jira/browse/BVAL-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854274#comment-16854274
]

Tomasz Wysocki commented on BVAL-176:
-

I would be grateful for 1.1.x maintenance branch (fabb6c4) and prompt
release of 1.1.3 to avoid custom version.

I will do a master fix shortly (second PR).



> setAccessible handling is broken for multithreaded apps with
SecurityManager
>

>
> Key: BVAL-176
> URL: https://issues.apache.org/jira/browse/BVAL-176
> Project: BVal
>  Issue Type: Bug
>Affects Versions: 1.1.2, 2.0.0
>Reporter: Tomasz Wysocki
>Priority: Major
> Fix For: 1.1.3
>
> Attachments: ReflectionAccessibilityTest.java
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently when using security manager field/method accessible flag will
be reset back to false.
> This does not work for multithreaded apps due to lack of synchronization
between threads.
> The effect is exception while validating due to invalid access to
protected or private members of target object.
> Workaround is to make all validated members public or synchronize on
Validator instance.
> This issue contains a test case to show the effect when security manager
is installed and there is no synchronization as well as a patch to 1.1.2.
> This issue applies to bval2 as well but I haven't made a patch.
> Below is proposed resolution:
> Remove reseting of accessible flag when security manager is present
>
> And rationale:
>  This feature will not work without some synchronization on the
>  reflection data itself in multithreaded environment.
>
>  Therefore the feature has been removed due to following concerns:
>
>  1. resetting accessible flag for security manager does not mean that
for
>  short period of time the flag is not actually set and bad code could
>  exploit that - therefore resetting accesible back is not really
making
>  it unaccessible to other code - this is design flaw. If accessible
flag
>  would be per thread it would work much better.
>
>  2. since accessible flag is global it would require synchronization
to make it work correctly,
>   which is costly. Current implementation just breaks for SM present
case
>  - it throws 'inaccessible' exceptions since it does not synchronize
at
>  all.
>
>  3. there is no saying what would need to be synchronized (probably
the
>  field or method reflected instances but it is not specified).
Therefore
>  synchronizing it would work only within scope of a single framework
>  (bval).
>
>  4. other frameworks typically don't reset back accessible and just
keep
>  the flag set. Therefore any synchronization mechanism specific to
bval would not cooperate
>  nicely or at all with other frameworks (like spring for instance).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (BVAL-176) setAccessible handling is broken for multithreaded apps with SecurityManager

[Romain Manni-Bucau (JIRA)]

[ 
https://issues.apache.org/jira/browse/BVAL-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854199#comment-16854199
 ] 

Romain Manni-Bucau commented on BVAL-176:
-

+1, recall we spotted it in early 1.1 snapshots but not sure why it hasnt been 
fixed yet
Do you mind doing a PR on master? We can create a maintenance branch for 1.1.x 
if you need it - is it why you did the PR on the 1.1.2?

> setAccessible handling is broken for multithreaded apps with SecurityManager
> 
>
> Key: BVAL-176
> URL: https://issues.apache.org/jira/browse/BVAL-176
> Project: BVal
>  Issue Type: Bug
>Affects Versions: 1.1.2, 2.0.0
>Reporter: Tomasz Wysocki
>Priority: Major
> Fix For: 1.1.3
>
> Attachments: ReflectionAccessibilityTest.java
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently when using security manager field/method accessible flag will be 
> reset back to false.
> This does not work for multithreaded apps due to lack of synchronization 
> between threads. 
> The effect is exception while validating due to invalid access to protected 
> or private members of target object.
> Workaround is to make all validated members public or synchronize on 
> Validator instance.
> This issue contains a test case to show the effect when security manager is 
> installed and there is no synchronization as well as a patch to 1.1.2.
> This issue applies to bval2 as well but I haven't made a patch.
> Below is proposed resolution:
> Remove reseting of accessible flag when security manager is present
>      
> And rationale:
>  This feature will not work without some synchronization on the
>  reflection data itself in multithreaded environment.
>      
>  Therefore the feature has been removed due to following concerns:
>      
>  1. resetting accessible flag for security manager does not mean that for
>  short period of time the flag is not actually set and bad code could
>  exploit that - therefore resetting accesible back is not really making
>  it unaccessible to other code - this is design flaw. If accessible flag
>  would be per thread it would work much better.
>      
>  2. since accessible flag is global it would require synchronization to 
> make it work correctly,
>   which is costly. Current implementation just breaks for SM present case
>  - it throws 'inaccessible' exceptions since it does not synchronize at
>  all.
>      
>  3. there is no saying what would need to be synchronized (probably the
>  field or method reflected instances but it is not specified). Therefore
>  synchronizing it would work only within scope of a single framework
>  (bval).
>      
>  4. other frameworks typically don't reset back accessible and just keep
>  the flag set. Therefore any synchronization mechanism specific to bval 
> would not cooperate
>  nicely or at all with other frameworks (like spring for instance).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: BVAL-174 Return Parameter Validation Ignore void methods

[Romain Manni-Bucau]

Will wait for Matt feedback and we should recheck the spec but can help mid
june yes. Have to admit i also see it as a good opportunity to enter the
codebase to maybe a good call for contribution ;)

We should probably try to release the 2.0.3 which fix some thread safety
issues

Le mer. 22 mai 2019 à 09:31, Thomas Andraschko 
a écrit :

> So will you take care of it, Romain? You also know the codebase much better
> :D
>
> Am Mi., 22. Mai 2019 um 07:30 Uhr schrieb Romain Manni-Bucau <
> rmannibu...@gmail.com>:
>
> > PS: quick workaround is to add the supported target explicitly to avoid
> > RETURN_TYPE I guess, not sure how elegant it is though
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > <https://rmannibucau.metawerx.net/> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > <
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >
> >
> >
> > Le mer. 22 mai 2019 à 07:18, Romain Manni-Bucau 
> a
> > écrit :
> >
> > > Ok,
> > >
> > > had a quick look, for executable validator types are not validated -
> > > see org.apache.bval.jsr.metadata.ReflectionBuilder.ForExecutable
> > >
> > > I guess the ComputeConstraintValidatorClass logic should be imported in
> > > executable path, not fully sure what the spec says but we should
> clearly
> > > avoid the runtime solution since here we can avoid the interceptor
> > > completely IMHO.
> > >
> > > Here is a test to reproduce - simpler - if it helps:
> > >
> > > /*
> > >  *  Licensed to the Apache Software Foundation (ASF) under one or more
> > >  *  contributor license agreements.  See the NOTICE file distributed
> with
> > >  *  this work for additional information regarding copyright ownership.
> > >  *  The ASF licenses this file to You under the Apache License, Version
> > 2.0
> > >  *  (the "License"); you may not use this file except in compliance
> with
> > >  *  the License.  You may obtain a copy of the License at
> > >  *
> > >  * http://www.apache.org/licenses/LICENSE-2.0
> > >  *
> > >  *  Unless required by applicable law or agreed to in writing, software
> > >  *  distributed under the License is distributed on an "AS IS" BASIS,
> > >  *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> > implied.
> > >  *  See the License for the specific language governing permissions and
> > >  *  limitations under the License.
> > >  */
> > > package org.apache.bval.jsr;
> > >
> > > import static java.lang.annotation.RetentionPolicy.RUNTIME;
> > > import static org.junit.Assert.assertFalse;
> > >
> > > import java.lang.annotation.Retention;
> > >
> > > import javax.validation.Constraint;
> > > import javax.validation.ConstraintValidator;
> > > import javax.validation.ConstraintValidatorContext;
> > > import javax.validation.Payload;
> > > import javax.validation.Validation;
> > > import javax.validation.ValidatorFactory;
> > > import javax.validation.metadata.MethodDescriptor;
> > > import javax.validation.metadata.ReturnValueDescriptor;
> > >
> > > import org.junit.Test;
> > >
> > > public class ReturnVoidConstraintTest {
> > > @Test
> > > public void checkIgnored() {
> > > final ValidatorFactory factory =
> > Validation.buildDefaultValidatorFactory();
> > > final MethodDescriptor method = factory.getValidator()
> > > .getConstraintsForClass(Container.class)
> > > .getConstraintsForMethod("passthrough");
> > > final ReturnValueDescriptor descriptor =
> > method.getReturnValueDescriptor();
> > > if (descriptor != null) {
> > >
> >  assertFalse(descriptor.getConstraintDescriptors().toString(),
> > descriptor.hasConstraints());
> > > } // else ok
> > > factory.close();
> > > }
> > >
> > > public static class Container {
> > > @Password
> > > public void passthrough() {
> > > // no-op
> > > }
> > > }
> > >
> > > @Retention(RUNTIME)
> > > @Constraint(validatedB

Re: BVAL-174 Return Parameter Validation Ignore void methods

[Romain Manni-Bucau]

PS: quick workaround is to add the supported target explicitly to avoid
RETURN_TYPE I guess, not sure how elegant it is though

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le mer. 22 mai 2019 à 07:18, Romain Manni-Bucau  a
écrit :

> Ok,
>
> had a quick look, for executable validator types are not validated -
> see org.apache.bval.jsr.metadata.ReflectionBuilder.ForExecutable
>
> I guess the ComputeConstraintValidatorClass logic should be imported in
> executable path, not fully sure what the spec says but we should clearly
> avoid the runtime solution since here we can avoid the interceptor
> completely IMHO.
>
> Here is a test to reproduce - simpler - if it helps:
>
> /*
>  *  Licensed to the Apache Software Foundation (ASF) under one or more
>  *  contributor license agreements.  See the NOTICE file distributed with
>  *  this work for additional information regarding copyright ownership.
>  *  The ASF licenses this file to You under the Apache License, Version 2.0
>  *  (the "License"); you may not use this file except in compliance with
>  *  the License.  You may obtain a copy of the License at
>  *
>  * http://www.apache.org/licenses/LICENSE-2.0
>  *
>  *  Unless required by applicable law or agreed to in writing, software
>  *  distributed under the License is distributed on an "AS IS" BASIS,
>  *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
>  *  See the License for the specific language governing permissions and
>  *  limitations under the License.
>  */
> package org.apache.bval.jsr;
>
> import static java.lang.annotation.RetentionPolicy.RUNTIME;
> import static org.junit.Assert.assertFalse;
>
> import java.lang.annotation.Retention;
>
> import javax.validation.Constraint;
> import javax.validation.ConstraintValidator;
> import javax.validation.ConstraintValidatorContext;
> import javax.validation.Payload;
> import javax.validation.Validation;
> import javax.validation.ValidatorFactory;
> import javax.validation.metadata.MethodDescriptor;
> import javax.validation.metadata.ReturnValueDescriptor;
>
> import org.junit.Test;
>
> public class ReturnVoidConstraintTest {
> @Test
> public void checkIgnored() {
> final ValidatorFactory factory = 
> Validation.buildDefaultValidatorFactory();
> final MethodDescriptor method = factory.getValidator()
> .getConstraintsForClass(Container.class)
> .getConstraintsForMethod("passthrough");
> final ReturnValueDescriptor descriptor = 
> method.getReturnValueDescriptor();
> if (descriptor != null) {
> assertFalse(descriptor.getConstraintDescriptors().toString(), 
> descriptor.hasConstraints());
> } // else ok
> factory.close();
> }
>
> public static class Container {
> @Password
> public void passthrough() {
> // no-op
> }
> }
>
> @Retention(RUNTIME)
> @Constraint(validatedBy = Password.Impl.class)
> public @interface Password {
> Class[] groups() default {};
> String message() default "failed";
> Class[] payload() default {};
>
> class Impl implements ConstraintValidator {
> @Override
> public boolean isValid(final String value, final 
> ConstraintValidatorContext context) {
> return false;
> }
> }
> }
> }
>
>
> Unrelated notes: seems tomee lost the github links for examples + a
> requestscoped jaxrs endpoint with a local map as storage will likely always
> return an empty list in the @GET ;).
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github
> <https://github.com/rmannibucau> | LinkedIn
> <https://www.linkedin.com/in/rmannibucau> | Book
> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>
>
> Le mer. 22 mai 2019 à 05:17, David Blevins  a
> écrit :
>
>> > On May 21, 2019, at 2:20 PM, Romain Manni-Bucau 
>> wrote:
>> >
>> > Probably a "too late to comment" thing but why is this true
>> > constraintsForMethod.hasConstrainedReturnValue())
>> >
>> > Gue

Re: BVAL-174 Return Parameter Validation Ignore void methods

[Romain Manni-Bucau]

Ok,

had a quick look, for executable validator types are not validated -
see org.apache.bval.jsr.metadata.ReflectionBuilder.ForExecutable

I guess the ComputeConstraintValidatorClass logic should be imported in
executable path, not fully sure what the spec says but we should clearly
avoid the runtime solution since here we can avoid the interceptor
completely IMHO.

Here is a test to reproduce - simpler - if it helps:

/*
 *  Licensed to the Apache Software Foundation (ASF) under one or more
 *  contributor license agreements.  See the NOTICE file distributed with
 *  this work for additional information regarding copyright ownership.
 *  The ASF licenses this file to You under the Apache License, Version 2.0
 *  (the "License"); you may not use this file except in compliance with
 *  the License.  You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 *  Unless required by applicable law or agreed to in writing, software
 *  distributed under the License is distributed on an "AS IS" BASIS,
 *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 *  See the License for the specific language governing permissions and
 *  limitations under the License.
 */
package org.apache.bval.jsr;

import static java.lang.annotation.RetentionPolicy.RUNTIME;
import static org.junit.Assert.assertFalse;

import java.lang.annotation.Retention;

import javax.validation.Constraint;
import javax.validation.ConstraintValidator;
import javax.validation.ConstraintValidatorContext;
import javax.validation.Payload;
import javax.validation.Validation;
import javax.validation.ValidatorFactory;
import javax.validation.metadata.MethodDescriptor;
import javax.validation.metadata.ReturnValueDescriptor;

import org.junit.Test;

public class ReturnVoidConstraintTest {
@Test
public void checkIgnored() {
final ValidatorFactory factory =
Validation.buildDefaultValidatorFactory();
final MethodDescriptor method = factory.getValidator()
.getConstraintsForClass(Container.class)
.getConstraintsForMethod("passthrough");
final ReturnValueDescriptor descriptor =
method.getReturnValueDescriptor();
if (descriptor != null) {
assertFalse(descriptor.getConstraintDescriptors().toString(),
descriptor.hasConstraints());
} // else ok
factory.close();
}

public static class Container {
@Password
public void passthrough() {
// no-op
}
}

@Retention(RUNTIME)
@Constraint(validatedBy = Password.Impl.class)
public @interface Password {
Class[] groups() default {};
String message() default "failed";
Class[] payload() default {};

class Impl implements ConstraintValidator {
@Override
public boolean isValid(final String value, final
ConstraintValidatorContext context) {
return false;
}
}
}
}


Unrelated notes: seems tomee lost the github links for examples + a
requestscoped jaxrs endpoint with a local map as storage will likely always
return an empty list in the @GET ;).

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le mer. 22 mai 2019 à 05:17, David Blevins  a
écrit :

> > On May 21, 2019, at 2:20 PM, Romain Manni-Bucau 
> wrote:
> >
> > Probably a "too late to comment" thing but why is this true
> > constraintsForMethod.hasConstrainedReturnValue())
> >
> > Guess the code was right and either this method impl needs your diff or
> the
> > use case is invalid.
>
> Never too late :)  There is very likely a better fix and perhaps there is
> a bug here that needs a much better resolution than the hack I threw in
> under time pressure.
>
> What I noticed is that if the method return type is say `String`, all of
> the ConstraintValidators on the method that do not apply to String are
> simply ignored.  I am not an Bean Validation expert, so I convinced myself
> this was by design as you can compose constraints from other constraints.
> You could have an annotation called @GoodReturnData that validated all
> sorts of return values using other annotated constraints and put it on all
> your methods.  I tested this and BVal will happily ignore the ones that do
> not apply and enforce the ones that do.  If none of the
> ConstraintValidators match, the return value is said to be valid.
>
> Unless the return type is void, in which case an exception is throw

Re: BVAL-174 Return Parameter Validation Ignore void methods

[Romain Manni-Bucau]

Hello David,

Probably a "too late to comment" thing but why is this true
constraintsForMethod.hasConstrainedReturnValue())

Guess the code was right and either this method impl needs your diff or the
use case is invalid.

Wdyt?


Le mar. 21 mai 2019 à 22:18, David Blevins  a
écrit :

> Awesome.
>
> To critique my own PR, I probably need a test case in there :)  I was kind
> of in a rush and cut a corner I shouldn't have.
>
> Regardless, general thoughts are great.
>
>
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
>
> > On May 21, 2019, at 1:00 PM, Thomas Andraschko <
> andraschko.tho...@gmail.com> wrote:
> >
> > Hi david,
> >
> > I will review it tommorow :)
> >
> > David Blevins  schrieb am Di., 21. Mai 2019,
> 21:43:
> >
> >> Hi All!
> >>
> >> I'm personally open to any of the proposed resolutions of BVAL-175.
> More
> >> important for me would be BVAL-174 as it blocks this feature:
> >>
> >> -
> http://tomee.apache.org/tomee-8.0/examples/mp-jwt-bean-validation.html
> >>  >
> >>
> >> Any chance this PR could be reviewed?
> >>
> >> - https://github.com/apache/bval/pull/3 <
> >> https://github.com/apache/bval/pull/3>
> >>
> >>
> >> --
> >> David Blevins
> >> http://twitter.com/dblevins
> >> http://www.tomitribe.com
> >>
> >>
>
>

Re: 2.0.2 in Maven

[Romain Manni-Bucau]

Hi,

I can confirm I see it on central directly:
http://repo.maven.apache.org/maven2/org/apache/bval/bval-jsr/2.0.2/

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le lun. 20 mai 2019 à 18:24, Matt Benson  a écrit :

> I see bval-jsr 2.0.2 through the UI at https://search.maven.org .
>
> Matt
>
> On Mon, May 20, 2019 at 9:29 AM James Meen 
> wrote:
>
> > I just took a quick look in Maven to see if bval 2.0.2 is now there.
> > It is not in Central but there is an ICM repository with version
> "Unknown"
> > and date "May 2019".
> >
> > This doesn't look right, please confirm.
> >
> > Thanks
> >
>

[jira] [Commented] (BVAL-175) Regression in "Design by Contract" example

[Romain Manni-Bucau (JIRA)]

[ 
https://issues.apache.org/jira/browse/BVAL-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842049#comment-16842049
 ] 

Romain Manni-Bucau commented on BVAL-175:
-

Hi David,

AFAIK it is not a Bean Validation feature and the processing we had in the CDI 
extension is way too complex for the user benefit. The TomEE regression comes 
from the fact we only check direct method and not inheritance. Here the options 
I see if TomEE needs that feature:

1. TomEE can add the checks through a CDI extension quite easily,
2. BVal could get a toggle switched off by default
3. We can just say this is not a feature.

For reference the fix is as trivial as putting @ValidateOnExecute on the 
inherited method which is the standard activation of Bean Validation - the 
example was done before this becomes standard so didn't get it I guess.

Romain


> Regression in "Design by Contract" example
> --
>
> Key: BVAL-175
> URL: https://issues.apache.org/jira/browse/BVAL-175
> Project: BVal
>  Issue Type: Bug
>Affects Versions: 2.0.2
>Reporter: David Blevins
>Priority: Major
>
> Hi All,
> I attempted to upgrade TomEE to the latest BVal 2.0.x code and noticed one 
> potential regression that affects this example:
>  - 
> https://github.com/apache/tomee/tree/master/examples/bean-validation-design-by-contract
> I did a git bisect to pinpoint the exact BVal commit that causes the example 
> to fail:
> - 
> https://github.com/apache/bval/commit/5bca3a73ae798d0671f964448b6e590d9bae396d
> Everything before that is fine.  There and after is the issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Release Apache BVal 2.0.2

[Romain Manni-Bucau]

which makes us 4 +1 (3 bindings) and no other votes so this vote passes,
will continue the release steps ASAP

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le lun. 13 mai 2019 à 11:25, David Blevins  a
écrit :

> My +1, but also non-binding so that doesn't really help :)
>
>
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
>
> > On May 8, 2019, at 3:43 AM, Thomas Andraschko <
> andraschko.tho...@gmail.com> wrote:
> >
> > Any other possible voter? :D
> >
> > Am Di., 30. Apr. 2019 um 14:21 Uhr schrieb Romain Manni-Bucau <
> > rmannibu...@gmail.com>:
> >
> >> My own +1
> >>
> >> Romain Manni-Bucau
> >> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> >> <https://rmannibucau.metawerx.net/> | Old Blog
> >> <http://rmannibucau.wordpress.com> | Github <
> >> https://github.com/rmannibucau> |
> >> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> >> <
> >>
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >>>
> >>
> >>
> >> Le mar. 30 avr. 2019 à 14:19, Mark Struberg 
> a
> >> écrit :
> >>
> >>> sorry that this slipped through my schedule :(
> >>>
> >>> +1
> >>>
> >>> LieGrue,
> >>> strub
> >>>
> >>> Am 15.04.19 um 12:13 schrieb Romain Manni-Bucau:
> >>>> Hi guys,
> >>>>
> >>>> As mentionned on the list, here is the vote for the 2.0.2 including
> >> some
> >>>> CDI startup perf booster.
> >>>>
> >>>> Tag is there:
> >>>>
> >>>
> >>
> https://gitbox.apache.org/repos/asf/bval.git/?p=bval.git;a=tag;h=e9a61ad9ebf7ec8764028e54c7f4e046264c6d50
> >>>> Staging repo with sources is there:
> >>>> https://repository.apache.org/content/repositories/orgapachebval-1008
> >>>> My key is in https://dist.apache.org/repos/dist/release/bval/KEYS
> >> (last
> >>> one)
> >>>>
> >>>> Please vote
> >>>>
> >>>> [ ] +1, indeed
> >>>> [ ] -1 ${cause}
> >>>>
> >>>> Vote will be opened as usual for 3 days or until we get 3 +1 bindings
> >>>>
> >>>> Romain Manni-Bucau
> >>>> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> >>>> <https://rmannibucau.metawerx.net/> | Old Blog
> >>>> <http://rmannibucau.wordpress.com> | Github <
> >>> https://github.com/rmannibucau> |
> >>>> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> >>>> <
> >>>
> >>
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >>>>
> >>>>
> >>>
> >>
>
>

Re: Potential regression in 2.0.2

[Romain Manni-Bucau]

Hi David,

I guess this is because we don't browse the whole model and 100% use CDI
annotated model to detect constraints. @ValidateOnExecution on the impl
will likely solve it in the example.

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le mar. 14 mai 2019 à 09:19, David Blevins  a
écrit :

> Hi All,
>
> I attempted to upgrade TomEE to the latest BVal 2.0.x code and noticed one
> potential regression that affects this example:
>
>  -
> https://github.com/apache/tomee/tree/master/examples/bean-validation-design-by-contract
>
> I did a git bisect to pinpoint the exact BVal commit that causes the
> example to fail:
>
> -
> https://github.com/apache/bval/commit/5bca3a73ae798d0671f964448b6e590d9bae396d
>
> Everything before that is fine.  There and after is the issue.
>
> I'd roll up my sleeves and dig, but I'll unlikely have any time till later
> next week.
>
>
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
>
>

[jira] [Commented] (BVAL-172) ConcurrentModificationException during validation

[Romain Manni-Bucau (JIRA)]

[ 
https://issues.apache.org/jira/browse/BVAL-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835941#comment-16835941
 ] 

Romain Manni-Bucau commented on BVAL-172:
-

We will do after rhe 2.0.3 but this does not affect CDI/EE apps

> ConcurrentModificationException during validation
> -
>
> Key: BVAL-172
> URL: https://issues.apache.org/jira/browse/BVAL-172
> Project: BVal
>  Issue Type: Bug
>Affects Versions: 2.0.0, 2.x
> Environment: Java 10.0.3
>  
>Reporter: John Myers
>Assignee: Romain Manni-Bucau
>Priority: Major
> Fix For: 2.0.3
>
>
> The following test case fails under Java 10.0.3:
> {code:java}
> @Test
> public void testMultipleThreads()
> throws ExecutionException, InterruptedException {
> List> validationResultSuppliers = new 
> ArrayList<>();
> List validationExceptions = new ArrayList<>();
> IntStream.range(0,5).forEach(
> i -> {
> SampleEntityForValidation sampleRequestEntity = new 
> SampleEntityForValidation("name-" + i, "description-" + i);
> 
> validationResultSuppliers.add(CompletableFuture.supplyAsync(() -> {
> try {
> return validator.validate(sampleRequestEntity)
> .isEmpty();
> } catch (Exception e) {
> validationExceptions.add(e);
> e.printStackTrace();
> return false;
> }
> }));
> }
> );
> CompletableFuture.allOf(validationResultSuppliers.toArray(new 
> CompletableFuture[] {})).get();
> assertEquals(0, validationExceptions.size());
> }
> public static class SampleEntityForValidation {
> @NotNull(message = "is missing")
> @Size(min = 3, message = "must be at least 3 characters long")
> private String name;
> @NotNull(message = "is missing")
> @Size(max = 15, message = "can be at most 15 characters long")
> private String description;
> public SampleEntityForValidation (
> String name,
> String description
> ) {
> this.name = name;
> this.description = description;
> }
> }
> {code}
> throwing the following stack traces:
> {noformat}
> java.util.ConcurrentModificationException
>     at java.base/java.util.HashMap.computeIfAbsent(HashMap.java:1134)
>     at org.apache.bval.jsr.ConstraintCached.infos(ConstraintCached.java:133)
>     at 
> org.apache.bval.jsr.ConstraintCached.getConstraintValidatorInfo(ConstraintCached.java:128)
>     at 
> org.apache.bval.jsr.util.AnnotationsManager.supportedTargets(AnnotationsManager.java:406)
>     at 
> org.apache.bval.jsr.util.AnnotationsManager.validateConstraintDefinition(AnnotationsManager.java:337)
>     at 
> org.apache.bval.jsr.descriptor.MetadataReader$ForElement.lambda$getConstraints$1(MetadataReader.java:100)
>     at 
> java.base/java.util.stream.ReferencePipeline$11$1.accept(ReferencePipeline.java:441)
>     at 
> java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
>     at 
> java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
>     at 
> java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
>     at 
> java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>     at 
> java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>     at 
> java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>     at 
> java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:497)
>     at 
> java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:274)
>     at 
> java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:177)
>     at java.base/java.util.Collections$2.tryAdvance(Collections.java:4745)
>     at 
> java.base/java.util.Collections$2.forEachRemaining(Collections.java:4753)
>     at 
> java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
>     at 
> java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
>     at 
> java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913)
>     at 
> java.base/java.util.stream.Abst

Re: [VOTE] Release Apache BVal 2.0.2

[Romain Manni-Bucau]

Up^2 ;)

Le dim. 21 avr. 2019 à 15:24, Romain Manni-Bucau  a
écrit :

> Up?
>
> Le mar. 16 avr. 2019 à 17:22, Mark Struberg  a
> écrit :
>
>> will try to review it this evening!
>>
>> LieGrue,
>> strub
>>
>>
>> > Am 15.04.2019 um 12:13 schrieb Romain Manni-Bucau <
>> rmannibu...@gmail.com>:
>> >
>> > Hi guys,
>> >
>> > As mentionned on the list, here is the vote for the 2.0.2 including some
>> > CDI startup perf booster.
>> >
>> > Tag is there:
>> >
>> https://gitbox.apache.org/repos/asf/bval.git/?p=bval.git;a=tag;h=e9a61ad9ebf7ec8764028e54c7f4e046264c6d50
>> > Staging repo with sources is there:
>> > https://repository.apache.org/content/repositories/orgapachebval-1008
>> > My key is in https://dist.apache.org/repos/dist/release/bval/KEYS
>> (last one)
>> >
>> > Please vote
>> >
>> > [ ] +1, indeed
>> > [ ] -1 ${cause}
>> >
>> > Vote will be opened as usual for 3 days or until we get 3 +1 bindings
>> >
>> > Romain Manni-Bucau
>> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
>> > <https://rmannibucau.metawerx.net/> | Old Blog
>> > <http://rmannibucau.wordpress.com> | Github <
>> https://github.com/rmannibucau> |
>> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
>> > <
>> https://www.packtpub.com/application-development/java-ee-8-high-performance
>> >
>>
>>

[jira] [Commented] (BVAL-172) ConcurrentModificationException during validation

[Romain Manni-Bucau (JIRA)]

[ 
https://issues.apache.org/jira/browse/BVAL-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823435#comment-16823435
 ] 

Romain Manni-Bucau commented on BVAL-172:
-

Pushed the fix dropping LRUCache which shouldnt be needed anyway, please let me 
know any issue

> ConcurrentModificationException during validation
> -
>
> Key: BVAL-172
> URL: https://issues.apache.org/jira/browse/BVAL-172
> Project: BVal
>  Issue Type: Bug
>Affects Versions: 2.0.0, 2.x
> Environment: Java 10.0.3
>  
>Reporter: John Myers
>Assignee: Romain Manni-Bucau
>Priority: Major
> Fix For: 2.0.3
>
>
> The following test case fails under Java 10.0.3:
> {code:java}
> @Test
> public void testMultipleThreads()
> throws ExecutionException, InterruptedException {
> List> validationResultSuppliers = new 
> ArrayList<>();
> List validationExceptions = new ArrayList<>();
> IntStream.range(0,5).forEach(
> i -> {
> SampleEntityForValidation sampleRequestEntity = new 
> SampleEntityForValidation("name-" + i, "description-" + i);
> 
> validationResultSuppliers.add(CompletableFuture.supplyAsync(() -> {
> try {
> return validator.validate(sampleRequestEntity)
> .isEmpty();
> } catch (Exception e) {
> validationExceptions.add(e);
> e.printStackTrace();
> return false;
> }
> }));
> }
> );
> CompletableFuture.allOf(validationResultSuppliers.toArray(new 
> CompletableFuture[] {})).get();
> assertEquals(0, validationExceptions.size());
> }
> public static class SampleEntityForValidation {
> @NotNull(message = "is missing")
> @Size(min = 3, message = "must be at least 3 characters long")
> private String name;
> @NotNull(message = "is missing")
> @Size(max = 15, message = "can be at most 15 characters long")
> private String description;
> public SampleEntityForValidation (
> String name,
> String description
> ) {
> this.name = name;
> this.description = description;
> }
> }
> {code}
> throwing the following stack traces:
> {noformat}
> java.util.ConcurrentModificationException
>     at java.base/java.util.HashMap.computeIfAbsent(HashMap.java:1134)
>     at org.apache.bval.jsr.ConstraintCached.infos(ConstraintCached.java:133)
>     at 
> org.apache.bval.jsr.ConstraintCached.getConstraintValidatorInfo(ConstraintCached.java:128)
>     at 
> org.apache.bval.jsr.util.AnnotationsManager.supportedTargets(AnnotationsManager.java:406)
>     at 
> org.apache.bval.jsr.util.AnnotationsManager.validateConstraintDefinition(AnnotationsManager.java:337)
>     at 
> org.apache.bval.jsr.descriptor.MetadataReader$ForElement.lambda$getConstraints$1(MetadataReader.java:100)
>     at 
> java.base/java.util.stream.ReferencePipeline$11$1.accept(ReferencePipeline.java:441)
>     at 
> java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
>     at 
> java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
>     at 
> java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
>     at 
> java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>     at 
> java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>     at 
> java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>     at 
> java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:497)
>     at 
> java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:274)
>     at 
> java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:177)
>     at java.base/java.util.Collections$2.tryAdvance(Collections.java:4745)
>     at 
> java.base/java.util.Collections$2.forEachRemaining(Collections.java:4753)
>     at 
> java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
>     at 
> java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
>     at 
> java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913)
>     at 
> java.

[jira] [Commented] (BVAL-173) Unsafe double-checked locking

[Romain Manni-Bucau (JIRA)]

[ 
https://issues.apache.org/jira/browse/BVAL-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823382#comment-16823382
 ] 

Romain Manni-Bucau commented on BVAL-173:
-

Hi John, do you have an accessible code path where it wouldnt be the case? 
AFAIK this code should be safe in bval.

> Unsafe double-checked locking
> -
>
> Key: BVAL-173
> URL: https://issues.apache.org/jira/browse/BVAL-173
> Project: BVal
>  Issue Type: Bug
>Reporter: John Myers
>Priority: Major
>
> The methods org.apache.bval.util.Lazy.get() and 
> org.apache.bval.util.LazyInt.getAsInt() both use unsafe double-checked 
> locking. In both cases, the fact that init is volatile does not, under the 
> Java Memory Model, prevent an incompletely initialized value from being 
> returned from the function.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Release Apache BVal 2.0.2

[Romain Manni-Bucau]

Up?

Le mar. 16 avr. 2019 à 17:22, Mark Struberg  a
écrit :

> will try to review it this evening!
>
> LieGrue,
> strub
>
>
> > Am 15.04.2019 um 12:13 schrieb Romain Manni-Bucau  >:
> >
> > Hi guys,
> >
> > As mentionned on the list, here is the vote for the 2.0.2 including some
> > CDI startup perf booster.
> >
> > Tag is there:
> >
> https://gitbox.apache.org/repos/asf/bval.git/?p=bval.git;a=tag;h=e9a61ad9ebf7ec8764028e54c7f4e046264c6d50
> > Staging repo with sources is there:
> > https://repository.apache.org/content/repositories/orgapachebval-1008
> > My key is in https://dist.apache.org/repos/dist/release/bval/KEYS (last
> one)
> >
> > Please vote
> >
> > [ ] +1, indeed
> > [ ] -1 ${cause}
> >
> > Vote will be opened as usual for 3 days or until we get 3 +1 bindings
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > <https://rmannibucau.metawerx.net/> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>
>

[jira] [Commented] (BVAL-172) ConcurrentModificationException during validation

[Romain Manni-Bucau (JIRA)]

[ 
https://issues.apache.org/jira/browse/BVAL-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822674#comment-16822674
 ] 

Romain Manni-Bucau commented on BVAL-172:
-

[~mbenson] hey Matt, seems the HashMap impl changed enough to enforce us to 
move to a thread safe impl, i m planning to revert my last commit and move to 
concurrent hashmap but before doing so, do you want to move to another lock 
free+thread safe structure? Boost is not super significant on my bench but 
would like a second opinion before doing so.

> ConcurrentModificationException during validation
> -
>
> Key: BVAL-172
> URL: https://issues.apache.org/jira/browse/BVAL-172
> Project: BVal
>  Issue Type: Bug
>Affects Versions: 2.0.0, 2.x
> Environment: Java 10.0.3
>  
>Reporter: John Myers
>Assignee: Romain Manni-Bucau
>Priority: Major
> Fix For: 2.0.3
>
>
> The following test case fails under Java 10.0.3:
> {code:java}
> @Test
> public void testMultipleThreads()
> throws ExecutionException, InterruptedException {
> List> validationResultSuppliers = new 
> ArrayList<>();
> List validationExceptions = new ArrayList<>();
> IntStream.range(0,5).forEach(
> i -> {
> SampleEntityForValidation sampleRequestEntity = new 
> SampleEntityForValidation("name-" + i, "description-" + i);
> 
> validationResultSuppliers.add(CompletableFuture.supplyAsync(() -> {
> try {
> return validator.validate(sampleRequestEntity)
> .isEmpty();
> } catch (Exception e) {
> validationExceptions.add(e);
> e.printStackTrace();
> return false;
> }
> }));
> }
> );
> CompletableFuture.allOf(validationResultSuppliers.toArray(new 
> CompletableFuture[] {})).get();
> assertEquals(0, validationExceptions.size());
> }
> public static class SampleEntityForValidation {
> @NotNull(message = "is missing")
> @Size(min = 3, message = "must be at least 3 characters long")
> private String name;
> @NotNull(message = "is missing")
> @Size(max = 15, message = "can be at most 15 characters long")
> private String description;
> public SampleEntityForValidation (
> String name,
> String description
> ) {
> this.name = name;
> this.description = description;
> }
> }
> {code}
> throwing the following stack traces:
> {noformat}
> java.util.ConcurrentModificationException
>     at java.base/java.util.HashMap.computeIfAbsent(HashMap.java:1134)
>     at org.apache.bval.jsr.ConstraintCached.infos(ConstraintCached.java:133)
>     at 
> org.apache.bval.jsr.ConstraintCached.getConstraintValidatorInfo(ConstraintCached.java:128)
>     at 
> org.apache.bval.jsr.util.AnnotationsManager.supportedTargets(AnnotationsManager.java:406)
>     at 
> org.apache.bval.jsr.util.AnnotationsManager.validateConstraintDefinition(AnnotationsManager.java:337)
>     at 
> org.apache.bval.jsr.descriptor.MetadataReader$ForElement.lambda$getConstraints$1(MetadataReader.java:100)
>     at 
> java.base/java.util.stream.ReferencePipeline$11$1.accept(ReferencePipeline.java:441)
>     at 
> java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
>     at 
> java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
>     at 
> java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
>     at 
> java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>     at 
> java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>     at 
> java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>     at 
> java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:497)
>     at 
> java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:274)
>     at 
> java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:177)
>     at java.base/java.util.Collections$2.tryAdvance(Collections.java:4745)
>     at 
> java.base/java.util.Collections$2.forEachRemaining(Collections.java:4753)
>     at 
> java.base/java.util.stream.AbstractPipeline.copyInto(A

[jira] [Resolved] (BVAL-172) ConcurrentModificationException during validation

[Romain Manni-Bucau (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BVAL-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau resolved BVAL-172.
-
   Resolution: Fixed
 Assignee: Romain Manni-Bucau
Fix Version/s: 2.0.3

Hi [~jgmyers], fixed it on master, do you want to have another look?

> ConcurrentModificationException during validation
> -
>
> Key: BVAL-172
> URL: https://issues.apache.org/jira/browse/BVAL-172
> Project: BVal
>  Issue Type: Bug
>Affects Versions: 2.0.0, 2.x
> Environment: Java 10.0.3
>  
>Reporter: John Myers
>Assignee: Romain Manni-Bucau
>Priority: Major
> Fix For: 2.0.3
>
>
> The following test case fails under Java 10.0.3:
> {code:java}
> @Test
> public void testMultipleThreads()
> throws ExecutionException, InterruptedException {
> List> validationResultSuppliers = new 
> ArrayList<>();
> List validationExceptions = new ArrayList<>();
> IntStream.range(0,5).forEach(
> i -> {
> SampleEntityForValidation sampleRequestEntity = new 
> SampleEntityForValidation("name-" + i, "description-" + i);
> 
> validationResultSuppliers.add(CompletableFuture.supplyAsync(() -> {
> try {
> return validator.validate(sampleRequestEntity)
> .isEmpty();
> } catch (Exception e) {
> validationExceptions.add(e);
> e.printStackTrace();
> return false;
> }
> }));
> }
> );
> CompletableFuture.allOf(validationResultSuppliers.toArray(new 
> CompletableFuture[] {})).get();
> assertEquals(0, validationExceptions.size());
> }
> public static class SampleEntityForValidation {
> @NotNull(message = "is missing")
> @Size(min = 3, message = "must be at least 3 characters long")
> private String name;
> @NotNull(message = "is missing")
> @Size(max = 15, message = "can be at most 15 characters long")
> private String description;
> public SampleEntityForValidation (
> String name,
> String description
> ) {
> this.name = name;
> this.description = description;
> }
> }
> {code}
> throwing the following stack traces:
> {noformat}
> java.util.ConcurrentModificationException
>     at java.base/java.util.HashMap.computeIfAbsent(HashMap.java:1134)
>     at org.apache.bval.jsr.ConstraintCached.infos(ConstraintCached.java:133)
>     at 
> org.apache.bval.jsr.ConstraintCached.getConstraintValidatorInfo(ConstraintCached.java:128)
>     at 
> org.apache.bval.jsr.util.AnnotationsManager.supportedTargets(AnnotationsManager.java:406)
>     at 
> org.apache.bval.jsr.util.AnnotationsManager.validateConstraintDefinition(AnnotationsManager.java:337)
>     at 
> org.apache.bval.jsr.descriptor.MetadataReader$ForElement.lambda$getConstraints$1(MetadataReader.java:100)
>     at 
> java.base/java.util.stream.ReferencePipeline$11$1.accept(ReferencePipeline.java:441)
>     at 
> java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
>     at 
> java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
>     at 
> java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
>     at 
> java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>     at 
> java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>     at 
> java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>     at 
> java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:497)
>     at 
> java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:274)
>     at 
> java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:177)
>     at java.base/java.util.Collections$2.tryAdvance(Collections.java:4745)
>     at 
> java.base/java.util.Collections$2.forEachRemaining(Collections.java:4753)
>     at 
> java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
>     at 
> java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
>     at 
> java.base/java.util.stream.ReduceOps$ReduceOp.evaluateS

[VOTE] Release Apache BVal 2.0.2

[Romain Manni-Bucau]

Hi guys,

As mentionned on the list, here is the vote for the 2.0.2 including some
CDI startup perf booster.

Tag is there:
https://gitbox.apache.org/repos/asf/bval.git/?p=bval.git;a=tag;h=e9a61ad9ebf7ec8764028e54c7f4e046264c6d50
Staging repo with sources is there:
https://repository.apache.org/content/repositories/orgapachebval-1008
My key is in https://dist.apache.org/repos/dist/release/bval/KEYS (last one)

Please vote

[ ] +1, indeed
[ ] -1 ${cause}

Vote will be opened as usual for 3 days or until we get 3 +1 bindings

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>

[CANCELLED] [VOTE] Release Apache BVal 2.0.1

[Romain Manni-Bucau]

Hi guys,

As mentionned let's cancel this one and roll out a 2.0.2 tomorrow or
tuesday.

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le jeu. 11 avr. 2019 à 16:57, Thomas Andraschko 
a écrit :

> if it's not much work to cancel and re-roll, it would be great!
> the last change pushes my OWB startup in TomEE from ~12seconds to
> ~7seconds.
>
> Am Do., 11. Apr. 2019 um 16:53 Uhr schrieb Romain Manni-Bucau <
> rmannibu...@gmail.com>:
>
> > (Side note: i will probably be off-line for 3 days so end of the vote can
> > be delay to next week, i just pushed some cdi boost so if you feel it you
> > can cancel this vote and restart it if you prefer, I'm more than fine
> with
> > it - in case I miss the discussion this week-end)
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > <https://rmannibucau.metawerx.net/> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > <
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >
> >
> >
> > Le mer. 10 avr. 2019 à 17:24, Romain Manni-Bucau 
> a
> > écrit :
> >
> > > Up?
> > >
> > > Le lun. 8 avr. 2019 à 11:24, Thomas Andraschko <
> > > andraschko.tho...@gmail.com> a écrit :
> > >
> > >> +1 (nonbinding)
> > >>
> > >> Am Mo., 8. Apr. 2019 um 10:42 Uhr schrieb Romain Manni-Bucau <
> > >> rmannibu...@gmail.com>:
> > >>
> > >> > Hi guys,
> > >> >
> > >> > as mentionned on the list, here is the vote for the 2.0.1.
> > >> >
> > >> > Tag is there:
> > >> >
> > >> >
> > >>
> >
> https://gitbox.apache.org/repos/asf/bval.git/?p=bval.git;a=tag;h=1332e010be5621d2f20818598549ff58326ba3e7
> > >> > Staging repo is there:
> > >> >
> https://repository.apache.org/content/repositories/orgapachebval-1007
> > >> > Sources are there:
> > >> >
> > >> >
> > >>
> >
> https://repository.apache.org/content/repositories/orgapachebval-1007/org/apache/bval/bval-parent/2.0.1/
> > >> > My key is in https://dist.apache.org/repos/dist/release/bval/KEYS
> > (last
> > >> > one)
> > >> >
> > >> > Please vote
> > >> >
> > >> > [ ] +1, indeed
> > >> > [ ] -1 ${cause}
> > >> >
> > >> > Vote will be opened as usual for 3 days or until we get 3 +1
> bindings
> > >> >
> > >> > Romain Manni-Bucau
> > >> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > >> > <https://rmannibucau.metawerx.net/> | Old Blog
> > >> > <http://rmannibucau.wordpress.com> | Github <
> > >> > https://github.com/rmannibucau> |
> > >> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > >> > <
> > >> >
> > >>
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >> > >
> > >> >
> > >>
> > >
> >
>

Re: [VOTE] Release Apache BVal 2.0.1

[Romain Manni-Bucau]

(Side note: i will probably be off-line for 3 days so end of the vote can
be delay to next week, i just pushed some cdi boost so if you feel it you
can cancel this vote and restart it if you prefer, I'm more than fine with
it - in case I miss the discussion this week-end)

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le mer. 10 avr. 2019 à 17:24, Romain Manni-Bucau  a
écrit :

> Up?
>
> Le lun. 8 avr. 2019 à 11:24, Thomas Andraschko <
> andraschko.tho...@gmail.com> a écrit :
>
>> +1 (nonbinding)
>>
>> Am Mo., 8. Apr. 2019 um 10:42 Uhr schrieb Romain Manni-Bucau <
>> rmannibu...@gmail.com>:
>>
>> > Hi guys,
>> >
>> > as mentionned on the list, here is the vote for the 2.0.1.
>> >
>> > Tag is there:
>> >
>> >
>> https://gitbox.apache.org/repos/asf/bval.git/?p=bval.git;a=tag;h=1332e010be5621d2f20818598549ff58326ba3e7
>> > Staging repo is there:
>> > https://repository.apache.org/content/repositories/orgapachebval-1007
>> > Sources are there:
>> >
>> >
>> https://repository.apache.org/content/repositories/orgapachebval-1007/org/apache/bval/bval-parent/2.0.1/
>> > My key is in https://dist.apache.org/repos/dist/release/bval/KEYS (last
>> > one)
>> >
>> > Please vote
>> >
>> > [ ] +1, indeed
>> > [ ] -1 ${cause}
>> >
>> > Vote will be opened as usual for 3 days or until we get 3 +1 bindings
>> >
>> > Romain Manni-Bucau
>> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
>> > <https://rmannibucau.metawerx.net/> | Old Blog
>> > <http://rmannibucau.wordpress.com> | Github <
>> > https://github.com/rmannibucau> |
>> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
>> > <
>> >
>> https://www.packtpub.com/application-development/java-ee-8-high-performance
>> > >
>> >
>>
>

Re: [VOTE] Release Apache BVal 2.0.1

[Romain Manni-Bucau]

Up?

Le lun. 8 avr. 2019 à 11:24, Thomas Andraschko 
a écrit :

> +1 (nonbinding)
>
> Am Mo., 8. Apr. 2019 um 10:42 Uhr schrieb Romain Manni-Bucau <
> rmannibu...@gmail.com>:
>
> > Hi guys,
> >
> > as mentionned on the list, here is the vote for the 2.0.1.
> >
> > Tag is there:
> >
> >
> https://gitbox.apache.org/repos/asf/bval.git/?p=bval.git;a=tag;h=1332e010be5621d2f20818598549ff58326ba3e7
> > Staging repo is there:
> > https://repository.apache.org/content/repositories/orgapachebval-1007
> > Sources are there:
> >
> >
> https://repository.apache.org/content/repositories/orgapachebval-1007/org/apache/bval/bval-parent/2.0.1/
> > My key is in https://dist.apache.org/repos/dist/release/bval/KEYS (last
> > one)
> >
> > Please vote
> >
> > [ ] +1, indeed
> > [ ] -1 ${cause}
> >
> > Vote will be opened as usual for 3 days or until we get 3 +1 bindings
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > <https://rmannibucau.metawerx.net/> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > <
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >
> >
>

[VOTE] Release Apache BVal 2.0.1

[Romain Manni-Bucau]

Hi guys,

as mentionned on the list, here is the vote for the 2.0.1.

Tag is there:
https://gitbox.apache.org/repos/asf/bval.git/?p=bval.git;a=tag;h=1332e010be5621d2f20818598549ff58326ba3e7
Staging repo is there:
https://repository.apache.org/content/repositories/orgapachebval-1007
Sources are there:
https://repository.apache.org/content/repositories/orgapachebval-1007/org/apache/bval/bval-parent/2.0.1/
My key is in https://dist.apache.org/repos/dist/release/bval/KEYS (last one)

Please vote

[ ] +1, indeed
[ ] -1 ${cause}

Vote will be opened as usual for 3 days or until we get 3 +1 bindings

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>

Re: Release???

[Romain Manni-Bucau]

up? can have a slot next week if still todo

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le sam. 9 mars 2019 à 19:50, Thomas Andraschko 
a écrit :

> Any News? Matt wdyt?
>
> Romain Manni-Bucau  schrieb am Mi., 27. Feb. 2019,
> 20:56:
>
> > No blocker ticket AFAIK
> >
> > Im happy to help or drive the release but if I do it, it will wait next
> > week (i have 8 pendings releases already this week)
> >
> > Le mer. 27 févr. 2019 à 19:57, Thomas Andraschko <
> > andraschko.tho...@gmail.com> a écrit :
> >
> > > Or are there any Tickets left, that we have to fix before the Release?
> > >
> > > Daniel Cunha  schrieb am Fr., 22. Feb. 2019,
> > 18:14:
> > >
> > > > On TomEE we still are using the snapshot version.
> > > > Would be awesome to have a release for it.
> > > >
> > > > +1
> > > >
> > > > Em sex, 22 de fev de 2019 às 14:12, Thomas Andraschko <
> > > > andraschko.tho...@gmail.com> escreveu:
> > > >
> > > > > Hi,
> > > > >
> > > > > AFAIR there will be a TomEE M3 soon and currently they use a custom
> > > bval
> > > > > branch (why? @romain).
> > > > > As there are already many changes since the last release + we did
> > great
> > > > > perf enhancements, could we release a version?
> > > > >
> > > > > Thanks,
> > > > > Thomas
> > > > >
> > > >
> > > >
> > > > --
> > > > Daniel "soro" Cunha
> > > > https://twitter.com/dvlc_
> > > >
> > >
> >
>

Re: Release???

[Romain Manni-Bucau]

No blocker ticket AFAIK

Im happy to help or drive the release but if I do it, it will wait next
week (i have 8 pendings releases already this week)

Le mer. 27 févr. 2019 à 19:57, Thomas Andraschko <
andraschko.tho...@gmail.com> a écrit :

> Or are there any Tickets left, that we have to fix before the Release?
>
> Daniel Cunha  schrieb am Fr., 22. Feb. 2019, 18:14:
>
> > On TomEE we still are using the snapshot version.
> > Would be awesome to have a release for it.
> >
> > +1
> >
> > Em sex, 22 de fev de 2019 às 14:12, Thomas Andraschko <
> > andraschko.tho...@gmail.com> escreveu:
> >
> > > Hi,
> > >
> > > AFAIR there will be a TomEE M3 soon and currently they use a custom
> bval
> > > branch (why? @romain).
> > > As there are already many changes since the last release + we did great
> > > perf enhancements, could we release a version?
> > >
> > > Thanks,
> > > Thomas
> > >
> >
> >
> > --
> > Daniel "soro" Cunha
> > https://twitter.com/dvlc_
> >
>

[jira] [Commented] (BVAL-170) BVAL 2.x is very very slow

[Romain Manni-Bucau (JIRA)]

[ 
https://issues.apache.org/jira/browse/BVAL-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770358#comment-16770358
 ] 

Romain Manni-Bucau commented on BVAL-170:
-

[~tandraschko] this is because # is not needed, i dropped it and it passes

> BVAL 2.x is very very slow
> --
>
> Key: BVAL-170
> URL: https://issues.apache.org/jira/browse/BVAL-170
> Project: BVal
>  Issue Type: Bug
>  Components: jsr303
>Affects Versions: 1.1.2, 2.0.0
>Reporter: Thomas Andraschko
>Priority: Critical
> Attachments: bval1.patch, bval2.patch, bval3.patch
>
>
> Simple case:
> [https://gist.github.com/tandraschko/160195cfd35c22d8519a4304856fab65]
> With BVal it takes on my machine around 20 seconds.
> Hibernate Validator 6 takes around 1 second.
> I also checked the hibernate validator benchmark for a case and here is a 
> extract of one case with operations per seconds:
> HV 6: 874
> BV 1.1: 347
> BV 2.0: 53



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (BVAL-170) BVAL 2.x is very very slow

[Romain Manni-Bucau (JIRA)]

[ 
https://issues.apache.org/jira/browse/BVAL-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770219#comment-16770219
 ] 

Romain Manni-Bucau commented on BVAL-170:
-

Patch looks good but please note that if our interpolation is that slow we 
should rewrite it and as a side note regex are no more all useful anymore I 
think so we can drap a few matches since contains now do it.

> BVAL 2.x is very very slow
> --
>
> Key: BVAL-170
> URL: https://issues.apache.org/jira/browse/BVAL-170
> Project: BVal
>  Issue Type: Bug
>  Components: jsr303
>Affects Versions: 1.1.2, 2.0.0
>Reporter: Thomas Andraschko
>Priority: Critical
> Attachments: bval1.patch, bval2.patch, bval3.patch
>
>
> Simple case:
> [https://gist.github.com/tandraschko/160195cfd35c22d8519a4304856fab65]
> With BVal it takes on my machine around 20 seconds.
> Hibernate Validator 6 takes around 1 second.
> I also checked the hibernate validator benchmark for a case and here is a 
> extract of one case with operations per seconds:
> HV 6: 874
> BV 1.1: 347
> BV 2.0: 53



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (BVAL-167) ConstraintDeclarationException: Illegal strengthening: overridden [constraints] in inheritance hierarchy

[Romain Manni-Bucau (JIRA)]

[ 
https://issues.apache.org/jira/browse/BVAL-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678410#comment-16678410
 ] 

Romain Manni-Bucau commented on BVAL-167:
-

[~mbenson] i guess it is in the interpretation of "that method" which is the 
child method for the RI and all methods for us

> ConstraintDeclarationException: Illegal strengthening: overridden 
> [constraints] in inheritance hierarchy
> 
>
> Key: BVAL-167
> URL: https://issues.apache.org/jira/browse/BVAL-167
> Project: BVal
>  Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Francesco Chicchiriccò
>Priority: Major
> Fix For: 2.0.1
>
>
> I am trying to upgrade BVal to 2.0.0 in Syncope.
> I have changed my POMs as follows:
> * javax.validation:validation-api from 1.1.0.Final to 2.0.1.Final
> * org.apache.bval:bval-jsr from 1.1.2 to 2.0.0
> When I try to reach up some of the REST services (based on CXF 3.2), an 
> [exception|https://paste.apache.org/hxvY] is thrown; I have read about such 
> exception, but it seems to me that the mentioned methods in 
> [interface|https://github.com/apache/syncope/blob/2_1_X/common/rest-api/src/main/java/org/apache/syncope/common/rest/api/service/AnyService.java#L70]
>  and 
> [implementation|https://github.com/apache/syncope/blob/2_1_X/core/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractAnyService.java#L68]
>  should comply with hierarchy rules.
> Nevertheless, if I swap
> org.apache.bval:bval-jsr:2.0.0
> with
> org.hibernate.validator:hibernate-validator:6.0.13.Final
> all is working fine.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (BVAL-167) ConstraintDeclarationException: Illegal strengthening: overridden [constraints] in inheritance hierarchy

[Romain Manni-Bucau (JIRA)]

[ 
https://issues.apache.org/jira/browse/BVAL-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674789#comment-16674789
 ] 

Romain Manni-Bucau edited comment on BVAL-167 at 11/5/18 9:26 AM:
--

[~ilgrosso] well first "all works with the reference implementation" does not 
help since even the RI has a lot of bugs ;). Now your assumption is right if 
you have a linear inheritance which is not the case in syncope cause the 
technical abstract class breaks that and create two heads for the leaf 
implementation and here the validation rules are competing so yes you can 
bypass the @NotNull in the leaf but the abstract class likely requires it. In 
other words you have 2 supertypes so both should be aligned to not have a 
relaxed version. Once again I'm fine enhancing that impl point.

edit: FYI i sent a mail on the dev@bval list to see how we rework our impl of 
Liskov principle, feel free to join if you want to help, it would be appreciated


was (Author: romain.manni-bucau):
[~ilgrosso] well first "all works with the reference implementation" does not 
help since even the RI has a lot of bugs ;). Now your assumption is right if 
you have a linear inheritance which is not the case in syncope cause the 
technical abstract class breaks that and create two heads for the leaf 
implementation and here the validation rules are competing so yes you can 
bypass the @NotNull in the leaf but the abstract class likely requires it. In 
other words you have 2 supertypes so both should be aligned to not have a 
relaxed version. Once again I'm fine enhancing that impl point.

> ConstraintDeclarationException: Illegal strengthening: overridden 
> [constraints] in inheritance hierarchy
> 
>
> Key: BVAL-167
> URL: https://issues.apache.org/jira/browse/BVAL-167
> Project: BVal
>  Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Francesco Chicchiriccò
>Priority: Major
> Fix For: 2.0.1
>
>
> I am trying to upgrade BVal to 2.0.0 in Syncope.
> I have changed my POMs as follows:
> * javax.validation:validation-api from 1.1.0.Final to 2.0.1.Final
> * org.apache.bval:bval-jsr from 1.1.2 to 2.0.0
> When I try to reach up some of the REST services (based on CXF 3.2), an 
> [exception|https://paste.apache.org/hxvY] is thrown; I have read about such 
> exception, but it seems to me that the mentioned methods in 
> [interface|https://github.com/apache/syncope/blob/2_1_X/common/rest-api/src/main/java/org/apache/syncope/common/rest/api/service/AnyService.java#L70]
>  and 
> [implementation|https://github.com/apache/syncope/blob/2_1_X/core/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractAnyService.java#L68]
>  should comply with hierarchy rules.
> Nevertheless, if I swap
> org.apache.bval:bval-jsr:2.0.0
> with
> org.hibernate.validator:hibernate-validator:6.0.13.Final
> all is working fine.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)