[VOTE] Release apache-calcite-avatica-go-5.2.0 (release candidate 0)
Hi all, I have created a release for Apache Calcite Avatica Go 5.2.0, release candidate 0. Thanks to everyone who has contributed to this release. The release notes are available here: https://github.com/apache/calcite-avatica-go/blob/v5.2.0-rc0/site/_docs/go_history.md The commit to be voted on: https://gitbox.apache.org/repos/asf?p=calcite-avatica-go.git;a=commit;h=2b61f374115969a23a93ecbbf569e0d63c617421 The hash is 2b61f374115969a23a93ecbbf569e0d63c617421 The artifacts to be voted on are located here: https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-go-5.2.0-rc0/ The hashes of the artifacts are as follows: src.tar.gz 1879FECE 6023AA42 4574FDC9 F7B0DAE8 2812B60E DD853BF3 31C4F191 DAA6F2BB FC3F7E2E F9C97DF3 0258DED5 E7041C7F BB87A7FE 0E84D6F8 854F58FD E0A81435 Release artifacts are signed with the following key: https://people.apache.org/keys/committer/francischuang.asc Instructions for running the test suite is located here: https://github.com/apache/calcite-avatica-go/blob/v5.2.0-rc0/site/develop/avatica-go.md#testing Please vote on releasing this package as Apache Calcite Avatica Go 5.2.0. To run the tests without a Go environment, install docker and docker compose. Then, in the root of the release's directory, run: docker compose run test When the test suite completes, run "docker compose down" to remove and shutdown all the containers. The vote is open for the next 72 hours and passes if a majority of at least three +1 PMC votes are cast. [ ] +1 Release this package as Apache Calcite Avatica Go 5.2.0 [ ] 0 I don't feel strongly about it, but I'm okay with the release [ ] -1 Do not release this package because... Here is my vote: +1 (binding) Francis
[jira] [Created] (CALCITE-5325) Display errors when failing release guidelines check using docker release script
Francis Chuang created CALCITE-5325: --- Summary: Display errors when failing release guidelines check using docker release script Key: CALCITE-5325 URL: https://issues.apache.org/jira/browse/CALCITE-5325 Project: Calcite Issue Type: Bug Components: avatica-go Reporter: Francis Chuang Assignee: Francis Chuang Fix For: avatica-go-5.2.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-5324) Cancel context in tests
Francis Chuang created CALCITE-5324: --- Summary: Cancel context in tests Key: CALCITE-5324 URL: https://issues.apache.org/jira/browse/CALCITE-5324 Project: Calcite Issue Type: Improvement Components: avatica-go Reporter: Francis Chuang Assignee: Francis Chuang Fix For: avatica-go-5.2.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-5323) Do not copy lock handle in statement
Francis Chuang created CALCITE-5323: --- Summary: Do not copy lock handle in statement Key: CALCITE-5323 URL: https://issues.apache.org/jira/browse/CALCITE-5323 Project: Calcite Issue Type: Improvement Components: avatica-go Reporter: Francis Chuang Assignee: Francis Chuang Fix For: avatica-go-5.2.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-5322) Remove deprecated build tags
Francis Chuang created CALCITE-5322: --- Summary: Remove deprecated build tags Key: CALCITE-5322 URL: https://issues.apache.org/jira/browse/CALCITE-5322 Project: Calcite Issue Type: Improvement Components: avatica-go Reporter: Francis Chuang Assignee: Francis Chuang Fix For: avatica-go-5.2.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-5320) Switch from deprecated_first_frame_max_size to first_frame_max_size protobuf member for setting the first frame max size
Francis Chuang created CALCITE-5320: --- Summary: Switch from deprecated_first_frame_max_size to first_frame_max_size protobuf member for setting the first frame max size Key: CALCITE-5320 URL: https://issues.apache.org/jira/browse/CALCITE-5320 Project: Calcite Issue Type: Improvement Components: avatica-go Reporter: Francis Chuang Assignee: Francis Chuang Fix For: avatica-go-5.2.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-5321) Switch from deprecated_first_frame_max_size to first_frame_max_size protobuf member for setting the first frame max size
Francis Chuang created CALCITE-5321: --- Summary: Switch from deprecated_first_frame_max_size to first_frame_max_size protobuf member for setting the first frame max size Key: CALCITE-5321 URL: https://issues.apache.org/jira/browse/CALCITE-5321 Project: Calcite Issue Type: Improvement Components: avatica-go Reporter: Francis Chuang Assignee: Francis Chuang Fix For: avatica-go-5.2.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-5319) Remove DualStack dial option in HTTP client as it is deprecated and enabled by default
Francis Chuang created CALCITE-5319: --- Summary: Remove DualStack dial option in HTTP client as it is deprecated and enabled by default Key: CALCITE-5319 URL: https://issues.apache.org/jira/browse/CALCITE-5319 Project: Calcite Issue Type: Improvement Components: avatica-go Reporter: Francis Chuang Assignee: Francis Chuang Fix For: avatica-go-5.2.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-5318) Replace deprecated ioutil methods with io and os equivalents
Francis Chuang created CALCITE-5318: --- Summary: Replace deprecated ioutil methods with io and os equivalents Key: CALCITE-5318 URL: https://issues.apache.org/jira/browse/CALCITE-5318 Project: Calcite Issue Type: Improvement Components: avatica-go Reporter: Francis Chuang Assignee: Francis Chuang Fix For: avatica-go-5.2.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-5317) Remove redundant type declarations
Francis Chuang created CALCITE-5317: --- Summary: Remove redundant type declarations Key: CALCITE-5317 URL: https://issues.apache.org/jira/browse/CALCITE-5317 Project: Calcite Issue Type: Improvement Components: avatica-go Reporter: Francis Chuang Assignee: Francis Chuang Fix For: avatica-go-5.2.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-5316) query two same filed with order by will report an error
benwei created CALCITE-5316:
---
Summary: query two same filed with order by will report an error
Key: CALCITE-5316
URL: https://issues.apache.org/jira/browse/CALCITE-5316
Project: Calcite
Issue Type: Bug
Components: core
Affects Versions: 1.32.0
Reporter: benwei
Execute query like
{code:java}
select name,name from user order by name;
{code}
will report en error in the verification phase.
The reason is that there is a method called aliasCount() in
OrderByScope.class,this method will return each order by filed's aliasCount.
And in this method,the field in the selectList will also be considered as
alias. so, in this case, it will return 2 ,which is greater than 1.
Here is the code for getAlias in SqlValidatorUtil.class
{code:java}
public static @Nullable String getAlias(SqlNode node, int ordinal) {
switch (node.getKind()) {
case AS:
// E.g. "1 + 2 as foo" --> "foo"
return ((SqlCall) node).operand(1).toString();
case OVER:
// E.g. "bids over w" --> "bids"
return getAlias(((SqlCall) node).operand(0), ordinal);
case IDENTIFIER:
// E.g. "foo.bar" --> "bar"
return Util.last(((SqlIdentifier) node).names);
default:
if (ordinal < 0) {
return null;
} else {
return SqlUtil.deriveAliasFromOrdinal(ordinal);
}
}
} {code}
otherwise, when aliasCount() return 1, it won't rewrite orderby's field, eg:
{code:java}
original sql:
select name from user order by id;
SQL after rewriting:
select user.name from user order by user.id
original sql:
select name from user order by name;
SQL after rewriting:
select user.name from user order by name // order by's name Will not be
rewritten as user.name{code}
I think,We only need to deal with the kind of AS in orderby scope.
At last, my first language is not English, so my description may not be very
clear
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
