Re: [DISCUSS] Code quality/coverage with SonarCloud & JaCoCo

2022-12-24 Thread Stamatis Zampetakis
Since there were no objections, I just logged INFRA-24038 [1] and plan to
move this forward.

Let me know if you have questions or concerns regarding the adoption of
SonarCloud.

Best,
Stamatis

[1] https://issues.apache.org/jira/browse/INFRA-24038

On Sat, Dec 10, 2022 at 11:32 AM Benchao Li  wrote:

> Thanks Stamatis for bringing this up.
>
> I haven't used Sonar yet, but thanks for the demo[1] you provided, it looks
> really interesting. I think it's worth a try for Calcite.
>
> [1] https://github.com/zabetak/calcite/pull/9
>
> Alessandro Solimando  于2022年12月10日周六
> 02:54写道:
>
> > Hi all,
> > thanks Stamatis for the proposal and the work, I am a huge fan of Sonar
> and
> > I really miss it on Calcite, so a big +1 from me on this.
> >
> > In Hive so far we have received good feedback, so I hope it will be
> > welcomed here too.
> >
> > Best regards,
> > Alessandro
> >
> > On Fri, 9 Dec 2022 at 19:02, Stamatis Zampetakis 
> > wrote:
> >
> > > Hi all,
> > >
> > > I just logged CALCITE-5427 [1] for introducing code quality & coverage
> > > metrics in Calcite CI.
> > >
> > > I added some motivation and examples under the ticket so please have a
> > look
> > > and let me know what you think.
> > >
> > > If there are no objections, I will follow-up with INFRA to set things
> up
> > > for the official Calcite repo.
> > >
> > > The integration with SonarCloud has been inspired by HIVE-26196 [2]
> that
> > > Alessandro put in place for Hive and has been very helpful so far.
> > >
> > > Best,
> > > Stamatis
> > >
> > > [1] https://issues.apache.org/jira/browse/CALCITE-5427
> > > [2] https://issues.apache.org/jira/browse/HIVE-26196
> > >
> >
>
>
> --
>
> Best,
> Benchao Li
>


Re: Use Calcite in own codegen tool (needs to parse DB2 SQL-dialect for AS/400) ?

2022-12-24 Thread Stamatis Zampetakis
Hi Larry,

It seems that you are interested mainly in the SqlParser component of
Calcite.
You can check if it satisfies your needs by adding some tests in
SqlParserTest [1] and/or BabelParserTest [2] using the DB2 dialect.
If you encounter problems with things that are not supported log JIRA
tickets or ask for help in the dev list.

Best,
Stamatis

[1]
https://github.com/apache/calcite/blob/bc4cfa32833649f44f6f2e9455229fa0355ad81e/testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java

[2]
https://github.com/apache/calcite/blob/bc4cfa32833649f44f6f2e9455229fa0355ad81e/babel/src/test/java/org/apache/calcite/test/BabelParserTest.java


On Thu, Dec 22, 2022 at 7:28 PM Larry LeFever 
wrote:

> I'm developing a codegen tool to facilitate development of custom reports
> where I work.
>
> One step in the codegen process reads the top-level column-aliases of a
> usually very complex report-backing query (lots of subqueries, some use of
> listagg, etc.) and uses those aliases to generate a db-row POJO.
>
> I've used ANTLR's SQLLite generated parser for that, but it encounters DB2
> for AS/400 specific SQL it can't handle.
>
> I believe I've seen in some of the documentation a component of Calcite for
> the DB2 SQL-dialect.
>
> So, I'm wondering if I could incorporate Calcite into my codegen tool to
> use its SQL-parsing functionality in the db-row POJO generating part of my
> codegen tool.
>
> Any advice would be much appreciated.
>
> Larry LeFever
>


[jira] [Created] (CALCITE-5458) Label and link pull requests in Avatica repo with JIRA issues automatically

2022-12-24 Thread Stamatis Zampetakis (Jira)
Stamatis Zampetakis created CALCITE-5458:


 Summary: Label and link pull requests in Avatica repo with JIRA 
issues automatically
 Key: CALCITE-5458
 URL: https://issues.apache.org/jira/browse/CALCITE-5458
 Project: Calcite
  Issue Type: Task
  Components: avatica
Reporter: Stamatis Zampetakis
Assignee: Stamatis Zampetakis
 Fix For: avatica-1.23.0


When a pull-request is opened in the Avatica 
[repo|https://github.com/apache/calcite-avatica] add a link to the PR in the 
respective JIRA ticket and also the label "pull request available".

This behavior can be controlled by 
[.asf.yaml|https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features]
 file.

This is already in place for the Calcite HitHub repo 
(https://github.com/apache/calcite/blob/bc4cfa32833649f44f6f2e9455229fa0355ad81e/.asf.yaml
 in CALCITE-4104) and it suffices to copy the file over to Avatica.   



--
This message was sent by Atlassian Jira
(v8.20.10#820010)