date:20230126

Re: [DISCUSS] Towards Calcite 1.33.0

2023-01-26 Thread Julian Hyde

I have merged a fix for CALCITE-5489. Thanks to Tanner and TJ for their help.

There is one failure in the build, but I'm pretty sure it is
intermittent and is related to CI infrastructure, not our code.

Jess, Go ahead and make that RC.

Julian


On Thu, Jan 26, 2023 at 10:50 AM Julian Hyde  wrote:
>
> I tried your PR https://github.com/apache/calcite/pull/3048/files. It fixes 
> the bug, but the test cases you have included to not reproduce the bug. I 
> think that TIMESTAMP_DIFF(quarter, TIMESTAMP ‘…’, ’TIMESTAMP ‘…’) is the 
> problematic pattern, but you have tested TIMESTAMP_DIFF(TIMESTAMP ‘…’, 
> ’TIMESTAMP ‘…’, quarter).
>
> > On Jan 26, 2023, at 9:13 AM, Tanner Clary  
> > wrote:
> >
> > Yes I will be putting up a PR with a fix in the next hour or so. Sorry
> > about the hold up!
> >
> > Tanner
> >
> > On Thu, Jan 26, 2023 at 8:09 AM Julian Hyde  wrote:
> >
> >> I agree that this is a blocker.
> >>
> >> Sergey’s PR illustrates the problem but isn’t a great fix. The fix should
> >> look for “flag” literals in order to distinguish between the function
> >> variants. The test case should be in a Quidem test rather than
> >> RexBuikderTest.
> >>
> >> Tanner, do you have time to work on a revised PR? In any case I’ll merge a
> >> fix in the next 8 hours.
> >>
> >> Julian
> >>
> >>> On Jan 26, 2023, at 12:09 AM, Ruben Q L  wrote:
> >>>
> >>> According to our Jira dashboard [1] it seems there's still one blocker
> >>> issue for 1.33 [2] (it was categorized as blocker because it was a
> >>> regression).
> >>> I guess we should complete this ticket before starting the RC.
> >>>
> >>>
> >>> [1]
> >>>
> >> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
> >>> [2] https://issues.apache.org/jira/browse/CALCITE-5489
> >>>
>  On Thu, Jan 26, 2023 at 3:44 AM Jess Balint  wrote:
> 
>  Great, I'll start the build. Let's hold off on further commits please.
> 
> > On Wed, Jan 25, 2023 at 6:48 PM Julian Hyde  wrote:
> >
> > I have merged it:
> >
> >
> 
> >> https://github.com/apache/calcite/commit/20014b6c5b9b57d29248206f19d63ef50f7a5c0f
> >
> > On Wed, Jan 25, 2023 at 2:03 PM Jess Balint  wrote:
> >>
> >> I'll merge it and then start the rc build.
> >>
> >> On Wed, Jan 25, 2023, 13:04 Julian Hyde  wrote:
> >>
> >>> Oops, I have one more PR ready to merge [1]. If the main branch is
>  not
> >>> yet closed, let me know, Jess.
> >>>
> >>> Julian
> >>>
> >>> [1] https://issues.apache.org/jira/browse/CALCITE-5283
> >>>
> >>> On Wed, Jan 25, 2023 at 8:14 AM Julian Hyde 
> >>> wrote:
> 
>  I agree. I merged some PRs last night (before I saw this email)
>  but I
> >>> agree it’s time for an RC. I’ll stop pushing to main. Have at it,
>  Jess!
> 
>  Julian
> 
> > On Jan 24, 2023, at 2:03 PM, Stamatis Zampetakis <
> > zabe...@gmail.com>
> >>> wrote:
> >
> > Thanks for staying on top of this Jess!
> >
> > Apart from the two JIRAs marked as blockers (regressions from
> > 1.32.0) I
> > don't think we should wait much more for getting the release out.
> >
> > Best,
> > Stamatis
> >
> >> On Tue, Jan 24, 2023 at 10:59 PM Jess Balint  >
> >>> wrote:
> >>
> >> The Avatica release is out. I've done what I can on outstanding
> >>> reviews:
> >>
> >>
> >>>
> >
> 
> >> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
> >>
> >> Do we have any final requests for PRs to be merged or should I
> > create
> >>> the
> >> rc build?
> >>
> >>> On Sun, Jan 15, 2023 at 2:20 PM Julian Hyde 
> >>> wrote:
> >>>
> >>> I have created a jira case to track this release:
> >>> https://issues.apache.org/jira/browse/CALCITE-5481
> >>>
> >>> Also, I am proposing to make a quick Avatica 1.23 release. If
>  the
> >>> plans
> >>> work out, it will be ready for inclusion in Calcite 1.33 from
> >>> Thursday.
> >>>
> >>> Julian
> >>>
> >>>
> >>> On 2023/01/05 20:21:03 Julian Hyde wrote:
>  Good idea. I have started reviewing those two cases.
> 
>  Reviewers are still needed for the other cases.
> 
>  Julian
> 
> 
> 
> > On Jan 5, 2023, at 3:39 AM, Dmitry Sysolyatin <
> >> dm.sysolya...@gmail.com>
> >>> wrote:
> >
> > It will be also good to review and include to release
> > https://issues.apache.org/jira/browse/CALCITE-5405 and
> > https://issues.apache.org/jira/browse/CALCITE-5407. I am not
> >> familiar
> >>> with
> > mongodb adapter
> >
>

Re: [DISCUSS] Towards Calcite 1.33.0

2023-01-26 Thread Tanner Clary

I added two tests. One for BigQuery's TIMESTAMP_DIFF(timestamp, timestamp,
unit) and one for the standard TIMESTAMPDIFF(unit, timestamp, timestamp).
This verifies that flag literals work for both functions.
TIMESTAMP_DIFF(quarter, timestamp, timestamp) is an incorrect pattern
whether it is a flag literal or not because for BigQuery the time unit
should always be the third argument. I moved the test for the standard
TIMESTAMPDIFF from SqlOperatorTest to misc.iq. Let me know if you have any
questions!

Tanner

On Thu, Jan 26, 2023 at 10:51 AM Julian Hyde  wrote:

> I tried your PR https://github.com/apache/calcite/pull/3048/files. It
> fixes the bug, but the test cases you have included to not reproduce the
> bug. I think that TIMESTAMP_DIFF(quarter, TIMESTAMP ‘…’, ’TIMESTAMP ‘…’) is
> the problematic pattern, but you have tested TIMESTAMP_DIFF(TIMESTAMP ‘…’,
> ’TIMESTAMP ‘…’, quarter).
>
> > On Jan 26, 2023, at 9:13 AM, Tanner Clary 
> wrote:
> >
> > Yes I will be putting up a PR with a fix in the next hour or so. Sorry
> > about the hold up!
> >
> > Tanner
> >
> > On Thu, Jan 26, 2023 at 8:09 AM Julian Hyde 
> wrote:
> >
> >> I agree that this is a blocker.
> >>
> >> Sergey’s PR illustrates the problem but isn’t a great fix. The fix
> should
> >> look for “flag” literals in order to distinguish between the function
> >> variants. The test case should be in a Quidem test rather than
> >> RexBuikderTest.
> >>
> >> Tanner, do you have time to work on a revised PR? In any case I’ll
> merge a
> >> fix in the next 8 hours.
> >>
> >> Julian
> >>
> >>> On Jan 26, 2023, at 12:09 AM, Ruben Q L  wrote:
> >>>
> >>> According to our Jira dashboard [1] it seems there's still one blocker
> >>> issue for 1.33 [2] (it was categorized as blocker because it was a
> >>> regression).
> >>> I guess we should complete this ticket before starting the RC.
> >>>
> >>>
> >>> [1]
> >>>
> >>
> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
> >>> [2] https://issues.apache.org/jira/browse/CALCITE-5489
> >>>
>  On Thu, Jan 26, 2023 at 3:44 AM Jess Balint 
> wrote:
> 
>  Great, I'll start the build. Let's hold off on further commits please.
> 
> > On Wed, Jan 25, 2023 at 6:48 PM Julian Hyde 
> wrote:
> >
> > I have merged it:
> >
> >
> 
> >>
> https://github.com/apache/calcite/commit/20014b6c5b9b57d29248206f19d63ef50f7a5c0f
> >
> > On Wed, Jan 25, 2023 at 2:03 PM Jess Balint 
> wrote:
> >>
> >> I'll merge it and then start the rc build.
> >>
> >> On Wed, Jan 25, 2023, 13:04 Julian Hyde  wrote:
> >>
> >>> Oops, I have one more PR ready to merge [1]. If the main branch is
>  not
> >>> yet closed, let me know, Jess.
> >>>
> >>> Julian
> >>>
> >>> [1] https://issues.apache.org/jira/browse/CALCITE-5283
> >>>
> >>> On Wed, Jan 25, 2023 at 8:14 AM Julian Hyde <
> jhyde.apa...@gmail.com>
> >>> wrote:
> 
>  I agree. I merged some PRs last night (before I saw this email)
>  but I
> >>> agree it’s time for an RC. I’ll stop pushing to main. Have at it,
>  Jess!
> 
>  Julian
> 
> > On Jan 24, 2023, at 2:03 PM, Stamatis Zampetakis <
> > zabe...@gmail.com>
> >>> wrote:
> >
> > Thanks for staying on top of this Jess!
> >
> > Apart from the two JIRAs marked as blockers (regressions from
> > 1.32.0) I
> > don't think we should wait much more for getting the release out.
> >
> > Best,
> > Stamatis
> >
> >> On Tue, Jan 24, 2023 at 10:59 PM Jess Balint  >
> >>> wrote:
> >>
> >> The Avatica release is out. I've done what I can on outstanding
> >>> reviews:
> >>
> >>
> >>>
> >
> 
> >>
> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
> >>
> >> Do we have any final requests for PRs to be merged or should I
> > create
> >>> the
> >> rc build?
> >>
> >>> On Sun, Jan 15, 2023 at 2:20 PM Julian Hyde 
> >>> wrote:
> >>>
> >>> I have created a jira case to track this release:
> >>> https://issues.apache.org/jira/browse/CALCITE-5481
> >>>
> >>> Also, I am proposing to make a quick Avatica 1.23 release. If
>  the
> >>> plans
> >>> work out, it will be ready for inclusion in Calcite 1.33 from
> >>> Thursday.
> >>>
> >>> Julian
> >>>
> >>>
> >>> On 2023/01/05 20:21:03 Julian Hyde wrote:
>  Good idea. I have started reviewing those two cases.
> 
>  Reviewers are still needed for the other cases.
> 
>  Julian
> 
> 
> 
> > On Jan 5, 2023, at 3:39 AM, Dmitry Sysolyatin <
> >> dm.sysolya...@gmail.com>
> >>> wrote:
> >
>

Re: [DISCUSS] Towards Calcite 1.33.0

2023-01-26 Thread Julian Hyde

I tried your PR https://github.com/apache/calcite/pull/3048/files. It fixes the 
bug, but the test cases you have included to not reproduce the bug. I think 
that TIMESTAMP_DIFF(quarter, TIMESTAMP ‘…’, ’TIMESTAMP ‘…’) is the problematic 
pattern, but you have tested TIMESTAMP_DIFF(TIMESTAMP ‘…’, ’TIMESTAMP ‘…’, 
quarter).

> On Jan 26, 2023, at 9:13 AM, Tanner Clary  
> wrote:
> 
> Yes I will be putting up a PR with a fix in the next hour or so. Sorry
> about the hold up!
> 
> Tanner
> 
> On Thu, Jan 26, 2023 at 8:09 AM Julian Hyde  wrote:
> 
>> I agree that this is a blocker.
>> 
>> Sergey’s PR illustrates the problem but isn’t a great fix. The fix should
>> look for “flag” literals in order to distinguish between the function
>> variants. The test case should be in a Quidem test rather than
>> RexBuikderTest.
>> 
>> Tanner, do you have time to work on a revised PR? In any case I’ll merge a
>> fix in the next 8 hours.
>> 
>> Julian
>> 
>>> On Jan 26, 2023, at 12:09 AM, Ruben Q L  wrote:
>>> 
>>> According to our Jira dashboard [1] it seems there's still one blocker
>>> issue for 1.33 [2] (it was categorized as blocker because it was a
>>> regression).
>>> I guess we should complete this ticket before starting the RC.
>>> 
>>> 
>>> [1]
>>> 
>> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
>>> [2] https://issues.apache.org/jira/browse/CALCITE-5489
>>> 
 On Thu, Jan 26, 2023 at 3:44 AM Jess Balint  wrote:
 
 Great, I'll start the build. Let's hold off on further commits please.
 
> On Wed, Jan 25, 2023 at 6:48 PM Julian Hyde  wrote:
> 
> I have merged it:
> 
> 
 
>> https://github.com/apache/calcite/commit/20014b6c5b9b57d29248206f19d63ef50f7a5c0f
> 
> On Wed, Jan 25, 2023 at 2:03 PM Jess Balint  wrote:
>> 
>> I'll merge it and then start the rc build.
>> 
>> On Wed, Jan 25, 2023, 13:04 Julian Hyde  wrote:
>> 
>>> Oops, I have one more PR ready to merge [1]. If the main branch is
 not
>>> yet closed, let me know, Jess.
>>> 
>>> Julian
>>> 
>>> [1] https://issues.apache.org/jira/browse/CALCITE-5283
>>> 
>>> On Wed, Jan 25, 2023 at 8:14 AM Julian Hyde 
>>> wrote:
 
 I agree. I merged some PRs last night (before I saw this email)
 but I
>>> agree it’s time for an RC. I’ll stop pushing to main. Have at it,
 Jess!
 
 Julian
 
> On Jan 24, 2023, at 2:03 PM, Stamatis Zampetakis <
> zabe...@gmail.com>
>>> wrote:
> 
> Thanks for staying on top of this Jess!
> 
> Apart from the two JIRAs marked as blockers (regressions from
> 1.32.0) I
> don't think we should wait much more for getting the release out.
> 
> Best,
> Stamatis
> 
>> On Tue, Jan 24, 2023 at 10:59 PM Jess Balint  
>>> wrote:
>> 
>> The Avatica release is out. I've done what I can on outstanding
>>> reviews:
>> 
>> 
>>> 
> 
 
>> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
>> 
>> Do we have any final requests for PRs to be merged or should I
> create
>>> the
>> rc build?
>> 
>>> On Sun, Jan 15, 2023 at 2:20 PM Julian Hyde 
>>> wrote:
>>> 
>>> I have created a jira case to track this release:
>>> https://issues.apache.org/jira/browse/CALCITE-5481
>>> 
>>> Also, I am proposing to make a quick Avatica 1.23 release. If
 the
>>> plans
>>> work out, it will be ready for inclusion in Calcite 1.33 from
>>> Thursday.
>>> 
>>> Julian
>>> 
>>> 
>>> On 2023/01/05 20:21:03 Julian Hyde wrote:
 Good idea. I have started reviewing those two cases.
 
 Reviewers are still needed for the other cases.
 
 Julian
 
 
 
> On Jan 5, 2023, at 3:39 AM, Dmitry Sysolyatin <
>> dm.sysolya...@gmail.com>
>>> wrote:
> 
> It will be also good to review and include to release
> https://issues.apache.org/jira/browse/CALCITE-5405 and
> https://issues.apache.org/jira/browse/CALCITE-5407. I am not
>> familiar
>>> with
> mongodb adapter
> 
> On Thu, Jan 5, 2023 at 12:24 PM Stamatis Zampetakis <
>> zabe...@gmail.com
 
> wrote:
> 
>> I added https://issues.apache.org/jira/browse/CALCITE-2884
> to the
>>> list. I
>> am finalizing the patch right now and will get this in a few
>>> hours.
>> I removed the fixVersion from
>> https://issues.apache.org/jira/browse/CALCITE-5427 (I am
> working
>>> on
>>> it)
>> since there is no

Re: [DISCUSS] Towards Calcite 1.33.0

2023-01-26 Thread Tanner Clary

Yes I will be putting up a PR with a fix in the next hour or so. Sorry
about the hold up!

Tanner

On Thu, Jan 26, 2023 at 8:09 AM Julian Hyde  wrote:

> I agree that this is a blocker.
>
> Sergey’s PR illustrates the problem but isn’t a great fix. The fix should
> look for “flag” literals in order to distinguish between the function
> variants. The test case should be in a Quidem test rather than
> RexBuikderTest.
>
> Tanner, do you have time to work on a revised PR? In any case I’ll merge a
> fix in the next 8 hours.
>
> Julian
>
> > On Jan 26, 2023, at 12:09 AM, Ruben Q L  wrote:
> >
> > According to our Jira dashboard [1] it seems there's still one blocker
> > issue for 1.33 [2] (it was categorized as blocker because it was a
> > regression).
> > I guess we should complete this ticket before starting the RC.
> >
> >
> > [1]
> >
> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
> > [2] https://issues.apache.org/jira/browse/CALCITE-5489
> >
> >> On Thu, Jan 26, 2023 at 3:44 AM Jess Balint  wrote:
> >>
> >> Great, I'll start the build. Let's hold off on further commits please.
> >>
> >>> On Wed, Jan 25, 2023 at 6:48 PM Julian Hyde  wrote:
> >>>
> >>> I have merged it:
> >>>
> >>>
> >>
> https://github.com/apache/calcite/commit/20014b6c5b9b57d29248206f19d63ef50f7a5c0f
> >>>
> >>> On Wed, Jan 25, 2023 at 2:03 PM Jess Balint  wrote:
> 
>  I'll merge it and then start the rc build.
> 
>  On Wed, Jan 25, 2023, 13:04 Julian Hyde  wrote:
> 
> > Oops, I have one more PR ready to merge [1]. If the main branch is
> >> not
> > yet closed, let me know, Jess.
> >
> > Julian
> >
> > [1] https://issues.apache.org/jira/browse/CALCITE-5283
> >
> > On Wed, Jan 25, 2023 at 8:14 AM Julian Hyde 
> > wrote:
> >>
> >> I agree. I merged some PRs last night (before I saw this email)
> >> but I
> > agree it’s time for an RC. I’ll stop pushing to main. Have at it,
> >> Jess!
> >>
> >> Julian
> >>
> >>> On Jan 24, 2023, at 2:03 PM, Stamatis Zampetakis <
> >>> zabe...@gmail.com>
> > wrote:
> >>>
> >>> Thanks for staying on top of this Jess!
> >>>
> >>> Apart from the two JIRAs marked as blockers (regressions from
> >>> 1.32.0) I
> >>> don't think we should wait much more for getting the release out.
> >>>
> >>> Best,
> >>> Stamatis
> >>>
>  On Tue, Jan 24, 2023 at 10:59 PM Jess Balint  >>>
> > wrote:
> 
>  The Avatica release is out. I've done what I can on outstanding
> > reviews:
> 
> 
> >
> >>>
> >>
> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
> 
>  Do we have any final requests for PRs to be merged or should I
> >>> create
> > the
>  rc build?
> 
> > On Sun, Jan 15, 2023 at 2:20 PM Julian Hyde 
> > wrote:
> >
> > I have created a jira case to track this release:
> > https://issues.apache.org/jira/browse/CALCITE-5481
> >
> > Also, I am proposing to make a quick Avatica 1.23 release. If
> >> the
> > plans
> > work out, it will be ready for inclusion in Calcite 1.33 from
> > Thursday.
> >
> > Julian
> >
> >
> > On 2023/01/05 20:21:03 Julian Hyde wrote:
> >> Good idea. I have started reviewing those two cases.
> >>
> >> Reviewers are still needed for the other cases.
> >>
> >> Julian
> >>
> >>
> >>
> >>> On Jan 5, 2023, at 3:39 AM, Dmitry Sysolyatin <
>  dm.sysolya...@gmail.com>
> > wrote:
> >>>
> >>> It will be also good to review and include to release
> >>> https://issues.apache.org/jira/browse/CALCITE-5405 and
> >>> https://issues.apache.org/jira/browse/CALCITE-5407. I am not
>  familiar
> > with
> >>> mongodb adapter
> >>>
> >>> On Thu, Jan 5, 2023 at 12:24 PM Stamatis Zampetakis <
>  zabe...@gmail.com
> >>
> >>> wrote:
> >>>
>  I added https://issues.apache.org/jira/browse/CALCITE-2884
> >>> to the
> > list. I
>  am finalizing the patch right now and will get this in a few
> > hours.
>  I removed the fixVersion from
>  https://issues.apache.org/jira/browse/CALCITE-5427 (I am
> >>> working
> > on
> > it)
>  since there is no rush to get it in 1.33.0.
>  Unfortunately, I don't have time to review other things
> >> today.
> 
>  Best,
>  Stamatis
> 
>  On Wed, Jan 4, 2023 at 9:19 PM Julian Hyde <
> > jhyde.apa...@gmail.com>
> > wrote:
> 
> > According to the dashboard [
> >
> 
> >
> 
> >
> >>>
> >>
>

Re: [ANNOUNCE] New committer: Istvan Toth

2023-01-26 Thread Istvan Toth

Thanks for the warm welcome to everyone!

A few words about myself:

I am from Hungary, and I work for Cloudera.
My focus is Apache Phoenix, and its sub-projects, but I also contribute to
HBase and other projects at times.

As many of you know, one of the Phoenix sub-projects is Phoenix Query
Server (PQS), which is
an essential part of the Phoenix ecosystem for many users.

While working on PQS issues I quickly realized that PQS is just a very thin
glue layer, and all the heavy lifting is in fact performed by Avatica,
which led to me becoming active on the project and contributing to it.

I am grateful to everyone in the community who helped with advice and
reviews, especially to one of the project's founders Josh Elser.
I was lucky to have him as a colleague, and have access to his thorough
knowledge of Avatica.

best regards
Istvan

On Thu, Jan 26, 2023 at 3:54 PM Michael Mior  wrote:

> Welcome Istvan!
>
> --
> Michael Mior
> mm...@apache.org
>
>
> On Tue, Jan 24, 2023 at 4:58 PM Stamatis Zampetakis 
> wrote:
>
> > Apache Calcite's Project Management Committee (PMC) has invited Istvan
> > Toth to become a committer, and we are pleased to announce that he
> > has accepted.
> >
> > Istvan began contributing to Avatica in 2019 and has since made notable
> > contributions,
> > particularly in the areas of authentication and connection handling. His
> > efforts have
> > helped improve the project's stability and security.
> >
> > Istvan, welcome, thank you for your contributions, and we look forward
> > to your further interactions with the community! If you wish, feel free
> to
> > tell us more about yourself and what you are working on.
> >
> > As your first commit, please add yourself to the contributors list [1]
> > and the community page will re-generate [2].
> >
> > Stamatis (on behalf of the Apache Calcite PMC)
> >
> > [1]
> > https://github.com/apache/calcite/blob/main/site/_data/contributors.yml
> >
> > [2] https://calcite.apache.org/community/#project-members
> >
>

-- 
*István Tóth* | Sr. Staff Software Engineer
*Email*: st...@cloudera.com
cloudera.com 
[image: Cloudera] 
[image: Cloudera on Twitter]  [image:
Cloudera on Facebook]  [image: Cloudera
on LinkedIn] 
--
--

Re: [DISCUSS] Towards Calcite 1.33.0

2023-01-26 Thread Julian Hyde

I agree that this is a blocker.

Sergey’s PR illustrates the problem but isn’t a great fix. The fix should look 
for “flag” literals in order to distinguish between the function variants. The 
test case should be in a Quidem test rather than RexBuikderTest. 

Tanner, do you have time to work on a revised PR? In any case I’ll merge a fix 
in the next 8 hours. 

Julian

> On Jan 26, 2023, at 12:09 AM, Ruben Q L  wrote:
> 
> According to our Jira dashboard [1] it seems there's still one blocker
> issue for 1.33 [2] (it was categorized as blocker because it was a
> regression).
> I guess we should complete this ticket before starting the RC.
> 
> 
> [1]
> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
> [2] https://issues.apache.org/jira/browse/CALCITE-5489
> 
>> On Thu, Jan 26, 2023 at 3:44 AM Jess Balint  wrote:
>> 
>> Great, I'll start the build. Let's hold off on further commits please.
>> 
>>> On Wed, Jan 25, 2023 at 6:48 PM Julian Hyde  wrote:
>>> 
>>> I have merged it:
>>> 
>>> 
>> https://github.com/apache/calcite/commit/20014b6c5b9b57d29248206f19d63ef50f7a5c0f
>>> 
>>> On Wed, Jan 25, 2023 at 2:03 PM Jess Balint  wrote:
 
 I'll merge it and then start the rc build.
 
 On Wed, Jan 25, 2023, 13:04 Julian Hyde  wrote:
 
> Oops, I have one more PR ready to merge [1]. If the main branch is
>> not
> yet closed, let me know, Jess.
> 
> Julian
> 
> [1] https://issues.apache.org/jira/browse/CALCITE-5283
> 
> On Wed, Jan 25, 2023 at 8:14 AM Julian Hyde 
> wrote:
>> 
>> I agree. I merged some PRs last night (before I saw this email)
>> but I
> agree it’s time for an RC. I’ll stop pushing to main. Have at it,
>> Jess!
>> 
>> Julian
>> 
>>> On Jan 24, 2023, at 2:03 PM, Stamatis Zampetakis <
>>> zabe...@gmail.com>
> wrote:
>>> 
>>> Thanks for staying on top of this Jess!
>>> 
>>> Apart from the two JIRAs marked as blockers (regressions from
>>> 1.32.0) I
>>> don't think we should wait much more for getting the release out.
>>> 
>>> Best,
>>> Stamatis
>>> 
 On Tue, Jan 24, 2023 at 10:59 PM Jess Balint >> 
> wrote:
 
 The Avatica release is out. I've done what I can on outstanding
> reviews:
 
 
> 
>>> 
>> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
 
 Do we have any final requests for PRs to be merged or should I
>>> create
> the
 rc build?
 
> On Sun, Jan 15, 2023 at 2:20 PM Julian Hyde 
> wrote:
> 
> I have created a jira case to track this release:
> https://issues.apache.org/jira/browse/CALCITE-5481
> 
> Also, I am proposing to make a quick Avatica 1.23 release. If
>> the
> plans
> work out, it will be ready for inclusion in Calcite 1.33 from
> Thursday.
> 
> Julian
> 
> 
> On 2023/01/05 20:21:03 Julian Hyde wrote:
>> Good idea. I have started reviewing those two cases.
>> 
>> Reviewers are still needed for the other cases.
>> 
>> Julian
>> 
>> 
>> 
>>> On Jan 5, 2023, at 3:39 AM, Dmitry Sysolyatin <
 dm.sysolya...@gmail.com>
> wrote:
>>> 
>>> It will be also good to review and include to release
>>> https://issues.apache.org/jira/browse/CALCITE-5405 and
>>> https://issues.apache.org/jira/browse/CALCITE-5407. I am not
 familiar
> with
>>> mongodb adapter
>>> 
>>> On Thu, Jan 5, 2023 at 12:24 PM Stamatis Zampetakis <
 zabe...@gmail.com
>> 
>>> wrote:
>>> 
 I added https://issues.apache.org/jira/browse/CALCITE-2884
>>> to the
> list. I
 am finalizing the patch right now and will get this in a few
> hours.
 I removed the fixVersion from
 https://issues.apache.org/jira/browse/CALCITE-5427 (I am
>>> working
> on
> it)
 since there is no rush to get it in 1.33.0.
 Unfortunately, I don't have time to review other things
>> today.
 
 Best,
 Stamatis
 
 On Wed, Jan 4, 2023 at 9:19 PM Julian Hyde <
> jhyde.apa...@gmail.com>
> wrote:
 
> According to the dashboard [
> 
 
> 
 
> 
>>> 
>> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
> <
> 
 
> 
 
> 
>>> 
>> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
> 
> ] there are 6 open issues, all of which have pull requests.
> 
> Can we have volunteers to review/merge these in the next 24
> hours?
 As

Re: [ANNOUNCE] New committer: Istvan Toth

2023-01-26 Thread Michael Mior

Welcome Istvan!

--
Michael Mior
mm...@apache.org


On Tue, Jan 24, 2023 at 4:58 PM Stamatis Zampetakis 
wrote:

> Apache Calcite's Project Management Committee (PMC) has invited Istvan
> Toth to become a committer, and we are pleased to announce that he
> has accepted.
>
> Istvan began contributing to Avatica in 2019 and has since made notable
> contributions,
> particularly in the areas of authentication and connection handling. His
> efforts have
> helped improve the project's stability and security.
>
> Istvan, welcome, thank you for your contributions, and we look forward
> to your further interactions with the community! If you wish, feel free to
> tell us more about yourself and what you are working on.
>
> As your first commit, please add yourself to the contributors list [1]
> and the community page will re-generate [2].
>
> Stamatis (on behalf of the Apache Calcite PMC)
>
> [1]
> https://github.com/apache/calcite/blob/main/site/_data/contributors.yml
>
> [2] https://calcite.apache.org/community/#project-members
>

[jira] [Created] (CALCITE-5502) RelToSql converter generates where clause with window expression

2023-01-26 Thread Leonid Chistov (Jira)

Leonid Chistov created CALCITE-5502:
---

 Summary: RelToSql converter generates where clause with window 
expression
 Key: CALCITE-5502
 URL: https://issues.apache.org/jira/browse/CALCITE-5502
 Project: Calcite
  Issue Type: Bug
  Components: jdbc-adapter
Affects Versions: 1.32.0
Reporter: Leonid Chistov


Wrong SQL code is generated when Filter (or Calc) node contains window 
expression.

Example can be demonstrated by adding following code to 
RelToSqlConverterTest.java:
{code:java}
@Test void testWindowedFilter() {
  final RelBuilder builder = relBuilder();
  final RelNode root = builder
  .scan("DEPT")
  .filter(
  builder.lessThan(
builder.aggregateCall(SqlStdOperatorTable.MAX, 
builder.field("DEPTNO"))
.over()
.partitionBy(builder.field("DNAME"))
.toRex(),
  builder.literal(1)
  )
  )
  .build();
  final String expectedSql = "?";
  assertThat(toSql(root), isLinux(expectedSql));
} {code}
Generated SQL code will look like:
{code:java}
SELECT *
FROM \"scott\".\"DEPT\"
WHERE (MAX(\"DEPTNO\") OVER (PARTITION BY \"DNAME\" RANGE BETWEEN UNBOUNDED 
PRECEDING AND UNBOUNDED FOLLOWING)) < 1 {code}
This is incorrect - window expressions are not required in WHERE clause by SQL 
standard and Calcite itself would produce following error message if this SQL 
code would passed as input: 
{code:java}
Windowed aggregate expression is illegal in WHERE clause {code}
 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (CALCITE-5501) SqlToRelConverterTest.checkActualAndReferenceFiles fails intermittently in Jenkins CI

2023-01-26 Thread Stamatis Zampetakis (Jira)

Stamatis Zampetakis created CALCITE-5501:


 Summary: SqlToRelConverterTest.checkActualAndReferenceFiles fails 
intermittently in Jenkins CI
 Key: CALCITE-5501
 URL: https://issues.apache.org/jira/browse/CALCITE-5501
 Project: Calcite
  Issue Type: Bug
  Components: tests
Affects Versions: 1.32.0
Reporter: Stamatis Zampetakis


Sample runs that failed due to 
SqlToRelConverterTest.checkActualAndReferenceFiles:
* https://ci-builds.apache.org/job/Calcite/job/Calcite-sonar/job/main/15/console
* https://ci-builds.apache.org/job/Calcite/job/Calcite-sonar/job/main/18/console

 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [ANNOUNCE] New committer: Istvan Toth

2023-01-26 Thread Bertil Chapuis

Congrats and welcome Istvan!

> On 26 Jan 2023, at 02:16, Benchao Li  wrote:
> 
> Congrats Istvan!
> 
> Alessandro Solimando  于2023年1月25日周三 14:56写道：
> 
>> Congrats Ivan!
>> 
>> On Tue 24 Jan 2023, 22:59 Francis Chuang, 
>> wrote:
>> 
>>> Congrats, Istvan!
>>> 
>>> On 25/01/2023 8:58 am, Stamatis Zampetakis wrote:
 Apache Calcite's Project Management Committee (PMC) has invited Istvan
 Toth to become a committer, and we are pleased to announce that he
 has accepted.
 
 Istvan began contributing to Avatica in 2019 and has since made notable
 contributions,
 particularly in the areas of authentication and connection handling.
>> His
 efforts have
 helped improve the project's stability and security.
 
 Istvan, welcome, thank you for your contributions, and we look forward
 to your further interactions with the community! If you wish, feel free
>>> to
 tell us more about yourself and what you are working on.
 
 As your first commit, please add yourself to the contributors list [1]
 and the community page will re-generate [2].
 
 Stamatis (on behalf of the Apache Calcite PMC)
 
 [1]
>>> https://github.com/apache/calcite/blob/main/site/_data/contributors.yml
 
 [2] https://calcite.apache.org/community/#project-members
 
>>> 
>> 
> 
> 
> -- 
> 
> Best,
> Benchao Li

Re: [DISCUSS] Towards Calcite 1.33.0

2023-01-26 Thread Ruben Q L

According to our Jira dashboard [1] it seems there's still one blocker
issue for 1.33 [2] (it was categorized as blocker because it was a
regression).
I guess we should complete this ticket before starting the RC.


[1]
https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
[2] https://issues.apache.org/jira/browse/CALCITE-5489

On Thu, Jan 26, 2023 at 3:44 AM Jess Balint  wrote:

> Great, I'll start the build. Let's hold off on further commits please.
>
> On Wed, Jan 25, 2023 at 6:48 PM Julian Hyde  wrote:
>
> > I have merged it:
> >
> >
> https://github.com/apache/calcite/commit/20014b6c5b9b57d29248206f19d63ef50f7a5c0f
> >
> > On Wed, Jan 25, 2023 at 2:03 PM Jess Balint  wrote:
> > >
> > > I'll merge it and then start the rc build.
> > >
> > > On Wed, Jan 25, 2023, 13:04 Julian Hyde  wrote:
> > >
> > > > Oops, I have one more PR ready to merge [1]. If the main branch is
> not
> > > > yet closed, let me know, Jess.
> > > >
> > > > Julian
> > > >
> > > > [1] https://issues.apache.org/jira/browse/CALCITE-5283
> > > >
> > > > On Wed, Jan 25, 2023 at 8:14 AM Julian Hyde 
> > > > wrote:
> > > > >
> > > > > I agree. I merged some PRs last night (before I saw this email)
> but I
> > > > agree it’s time for an RC. I’ll stop pushing to main. Have at it,
> Jess!
> > > > >
> > > > > Julian
> > > > >
> > > > > > On Jan 24, 2023, at 2:03 PM, Stamatis Zampetakis <
> > zabe...@gmail.com>
> > > > wrote:
> > > > > >
> > > > > > Thanks for staying on top of this Jess!
> > > > > >
> > > > > > Apart from the two JIRAs marked as blockers (regressions from
> > 1.32.0) I
> > > > > > don't think we should wait much more for getting the release out.
> > > > > >
> > > > > > Best,
> > > > > > Stamatis
> > > > > >
> > > > > >> On Tue, Jan 24, 2023 at 10:59 PM Jess Balint  >
> > > > wrote:
> > > > > >>
> > > > > >> The Avatica release is out. I've done what I can on outstanding
> > > > reviews:
> > > > > >>
> > > > > >>
> > > >
> >
> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
> > > > > >>
> > > > > >> Do we have any final requests for PRs to be merged or should I
> > create
> > > > the
> > > > > >> rc build?
> > > > > >>
> > > > > >>> On Sun, Jan 15, 2023 at 2:20 PM Julian Hyde 
> > > > wrote:
> > > > > >>>
> > > > > >>> I have created a jira case to track this release:
> > > > > >>> https://issues.apache.org/jira/browse/CALCITE-5481
> > > > > >>>
> > > > > >>> Also, I am proposing to make a quick Avatica 1.23 release. If
> the
> > > > plans
> > > > > >>> work out, it will be ready for inclusion in Calcite 1.33 from
> > > > Thursday.
> > > > > >>>
> > > > > >>> Julian
> > > > > >>>
> > > > > >>>
> > > > > >>> On 2023/01/05 20:21:03 Julian Hyde wrote:
> > > > >  Good idea. I have started reviewing those two cases.
> > > > > 
> > > > >  Reviewers are still needed for the other cases.
> > > > > 
> > > > >  Julian
> > > > > 
> > > > > 
> > > > > 
> > > > > > On Jan 5, 2023, at 3:39 AM, Dmitry Sysolyatin <
> > > > > >> dm.sysolya...@gmail.com>
> > > > > >>> wrote:
> > > > > >
> > > > > > It will be also good to review and include to release
> > > > > > https://issues.apache.org/jira/browse/CALCITE-5405 and
> > > > > > https://issues.apache.org/jira/browse/CALCITE-5407. I am not
> > > > > >> familiar
> > > > > >>> with
> > > > > > mongodb adapter
> > > > > >
> > > > > > On Thu, Jan 5, 2023 at 12:24 PM Stamatis Zampetakis <
> > > > > >> zabe...@gmail.com
> > > > > 
> > > > > > wrote:
> > > > > >
> > > > > >> I added https://issues.apache.org/jira/browse/CALCITE-2884
> > to the
> > > > > >>> list. I
> > > > > >> am finalizing the patch right now and will get this in a few
> > > > hours.
> > > > > >> I removed the fixVersion from
> > > > > >> https://issues.apache.org/jira/browse/CALCITE-5427 (I am
> > working
> > > > on
> > > > > >>> it)
> > > > > >> since there is no rush to get it in 1.33.0.
> > > > > >> Unfortunately, I don't have time to review other things
> today.
> > > > > >>
> > > > > >> Best,
> > > > > >> Stamatis
> > > > > >>
> > > > > >> On Wed, Jan 4, 2023 at 9:19 PM Julian Hyde <
> > > > jhyde.apa...@gmail.com>
> > > > > >>> wrote:
> > > > > >>
> > > > > >>> According to the dashboard [
> > > > > >>>
> > > > > >>
> > > > > >>>
> > > > > >>
> > > >
> >
> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
> > > > > >>> <
> > > > > >>>
> > > > > >>
> > > > > >>>
> > > > > >>
> > > >
> >
> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
> > > > > >>>
> > > > > >>> ] there are 6 open issues, all of which have pull requests.
> > > > > >>>
> > > > > >>> Can we have volunteers to review/merge these in the next 24
> > > > hours?
> > > > > >> As
> > > > > >> last
> > > > > >>> time, I’ll match: if 2 people take 2 issues each, I’ll take
> > the
> > > > > >> last
> > >

Re: [DISCUSS] Towards Calcite 1.33.0

Re: [DISCUSS] Towards Calcite 1.33.0

Re: [DISCUSS] Towards Calcite 1.33.0

Re: [DISCUSS] Towards Calcite 1.33.0

Re: [ANNOUNCE] New committer: Istvan Toth

Re: [DISCUSS] Towards Calcite 1.33.0

Re: [ANNOUNCE] New committer: Istvan Toth

[jira] [Created] (CALCITE-5502) RelToSql converter generates where clause with window expression

[jira] [Created] (CALCITE-5501) SqlToRelConverterTest.checkActualAndReferenceFiles fails intermittently in Jenkins CI

Re: [ANNOUNCE] New committer: Istvan Toth

Re: [DISCUSS] Towards Calcite 1.33.0

11 matches

Site Navigation

Mail list logo

Footer information