Please make a review pr 3211

2023-06-15 Thread stanilovsky evgeny 

There is ones more change touching null literals in SUBSTRING func.
Can someone make a review plz?

https://issues.apache.org/jira/browse/CALCITE-5708

https://github.com/apache/calcite/pull/3211

PR 3258 Review Request

2023-06-15 Thread Zhe Hu 
Hi, community.
I’ve submitted a PR for applying two different NULL semantics for CONCAT 
function, because this function now returns NULL when any of the arguments is 
NULL, however Postgresql and MSSQL have different behavior(they treat NULL as 
empty string).
BTW, CONCAT enabled in Oracle(we call it CONCAT2 in Calcite) has been resolved 
in CALCITE-5745, if anyone needs to refer to.


https://github.com/apache/calcite/pull/3258


Best,
ZheHu

[jira] [Created] (CALCITE-5784) Generate the same correlationId for the same query

2023-06-15 Thread Aitozi (Jira) 
Aitozi created CALCITE-5784:
---

 Summary: Generate the same correlationId for the same query
 Key: CALCITE-5784
 URL: https://issues.apache.org/jira/browse/CALCITE-5784
 Project: Calcite
  Issue Type: Improvement
  Components: core
Reporter: Aitozi


Currently, the CTE query block will be sql2rel multiple times if be referenced 
multiple times. If it contains a lateral join, it will generate different 
correlation id. See below:


{code:java}
String sql = "WITH a AS (SELECT ename, job, empno, r FROM emp, LATERAL 
TABLE (ramp(empno)) as T(r))"
+ " SELECT * from a a1, a a2 WHERE a1.r = a2.empno";
sql(sql).ok();
{code}


{code:java}
LogicalProject(ENAME=[$0], JOB=[$1], EMPNO=[$2], R=[$3], ENAME0=[$4], 
JOB0=[$5], EMPNO0=[$6], R0=[$7])
  LogicalJoin(condition=[=($3, $6)], joinType=[inner])
LogicalProject(ENAME=[$1], JOB=[$2], EMPNO=[$0], R=[$9])
  LogicalCorrelate(correlation=[$cor0], joinType=[inner], 
requiredColumns=[{0}])
LogicalTableScan(table=[[CATALOG, SALES, EMP]])
LogicalTableFunctionScan(invocation=[RAMP($cor0.EMPNO)], 
rowType=[RecordType(INTEGER I)])
LogicalProject(ENAME=[$1], JOB=[$2], EMPNO=[$0], R=[$9])
  LogicalCorrelate(correlation=[$cor1], joinType=[inner], 
requiredColumns=[{0}])
LogicalTableScan(table=[[CATALOG, SALES, EMP]])
LogicalTableFunctionScan(invocation=[RAMP($cor1.EMPNO)], 
rowType=[RecordType(INTEGER I)])

{code}

It will generate two correlation id. In flink there is a subplan reuse based on 
the digest, it will break this functionality




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [ANNOUNCE] New committer: Oliver Lee

2023-06-15 Thread Sergey Nuyanzin 
Congratulations, Oliver!

On Thu, Jun 15, 2023 at 9:43 AM Alessandro Solimando <
alessandro.solima...@gmail.com> wrote:

> Very well deserved, congratulations, Oliver!
>
> On Thu, 15 Jun 2023 at 03:40, Jiajun Xie 
> wrote:
>
> > Congratulations and welcome Oliver!
> >
>


-- 
Best regards,
Sergey

Re: [ANNOUNCE] New committer: Oliver Lee

2023-06-15 Thread Alessandro Solimando 
Very well deserved, congratulations, Oliver!

On Thu, 15 Jun 2023 at 03:40, Jiajun Xie  wrote:

> Congratulations and welcome Oliver!
>

[jira] [Created] (CALCITE-5783) Make table function scan hintable

2023-06-15 Thread Aitozi (Jira) 
Aitozi created CALCITE-5783:
---

 Summary: Make table function scan hintable 
 Key: CALCITE-5783
 URL: https://issues.apache.org/jira/browse/CALCITE-5783
 Project: Calcite
  Issue Type: Improvement
  Components: core
Reporter: Aitozi


This ticket is meant to make the table function scan RelNode hintable, so that 
we can apply some hint on the target table function.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)