Re: [DISCUSS] Github PR link to JIRA issue

[Michael Mior]

Autolinks are listed as an "upcoming feature." I don't believe they can be
currently controlled via .asf.yaml.

--
Michael Mior
mm...@apache.org


Le sam. 2 avr. 2022 à 01:19, Julian Hyde  a écrit :

> The present hyperlinking was enabled by Stamatis:
> https://issues.apache.org/jira/browse/CALCITE-4104 <
> https://issues.apache.org/jira/browse/CALCITE-4104>
>
> I’m not exactly sure how the .asf.yaml file accomplishes this. Maybe it
> instructs some ASF robot to modify the GitHub project settings on our
> behalf.
>
> More info on the .asf.yaml file:
> https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features
> <
> https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features>
>
>
> Julian
>
>
> > On Apr 1, 2022, at 9:18 PM, Haisheng Yuan  wrote:
> >
> > Yes, that is what I meant.
> >
> > I was expecting to see the link to JIRA in PR's commit page:
> > https://github.com/apache/calcite/pull/2752/commits
> >
> > I am lazy to navigate to JIRA manually. :)
> >
> > Haisheng
> >
> > On 2022/04/01 01:04:19 Julian Hyde wrote:
> >> Ah, I see. In the page for a commit (e.g. [1]) the text
> “[CALCITE-5064]” appears as a blue hyperlink whereas the page for the
> corresponding pull request (e.g. [2]) the “[CALCITE-5064]” text is not a
> hyperlink.
> >>
> >> Is that what you meant, Haisheng?
> >>
> >> Julian
> >>
> >>
> >> [1]
> https://github.com/apache/calcite/commit/d85b2a602a547290bd5be0bba68092b702400731
> <
> https://github.com/apache/calcite/commit/d85b2a602a547290bd5be0bba68092b702400731
> >
> >>
> >> [2] https://github.com/apache/calcite/pull/2752 <
> https://github.com/apache/calcite/pull/2752>
> >>
> >>> On Mar 31, 2022, at 11:05 AM, Michael Mior  wrote:
> >>>
> >>> Stamatis,
> >>>
> >>> Unless I'm misunderstanding, Haisheng was referring to links in the
> >>> opposite direction. That is, linking to JIRA issues from GitHub. The
> >>> setting you reference is for creating a link from JIRA to GitHub.
> >>>
> >>> --
> >>> Michael Mior
> >>> mm...@apache.org
> >>>
> >>>
> >>> Le jeu. 31 mars 2022 à 13:53, Stamatis Zampetakis 
> a
> >>> écrit :
> >>>
>  It's already done via .asf.yaml [1].
> 
>  Best,
>  Stamatis
> 
>  [1]
> 
> 
> https://github.com/apache/calcite/blob/88cc385f98c551c1aca7ffab101934f1c34fdffd/.asf.yaml#L35
> 
>  On Thu, Mar 31, 2022 at 7:19 PM Michael Mior 
> wrote:
> 
> > Not sure what might have changed, but here's the GitHub
> documentation on
> > the feature. If this isn't working as expected, I would contact
> INFRA to
> > make sure things are correctly configured. (Apparently in the future,
>  this
> > may be done via .asf.yaml)
> >
> >
> >
> 
> https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/configuring-autolinks-to-reference-external-resources
> >
> >
> > --
> > Michael Mior
> > mm...@apache.org
> >
> >
> > Le mer. 30 mars 2022 à 13:46, Haisheng Yuan  a
> écrit :
> >
> >> Hi all,
> >>
> >> Previously, the JIRA issue e.g. [CALCITE-6789] in Calcite github PR
> and
> >> commit message will be automatically linked to the JIRA site. Now
> there
> > is
> >> no link anymore.
> >>
> >> Does anyone know what happened? What can we do to add the link back?
> >>
> >> Thanks,
> >> Haisheng Yuan
> >>
> >
> 
> >>
> >>
>
>

Re: [DISCUSS] Github PR link to JIRA issue

[Julian Hyde]

The present hyperlinking was enabled by Stamatis: 
https://issues.apache.org/jira/browse/CALCITE-4104 
 

I’m not exactly sure how the .asf.yaml file accomplishes this. Maybe it 
instructs some ASF robot to modify the GitHub project settings on our behalf.

More info on the .asf.yaml file: 
https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features 
 

Julian


> On Apr 1, 2022, at 9:18 PM, Haisheng Yuan  wrote:
> 
> Yes, that is what I meant.
> 
> I was expecting to see the link to JIRA in PR's commit page:
> https://github.com/apache/calcite/pull/2752/commits
> 
> I am lazy to navigate to JIRA manually. :)
> 
> Haisheng
> 
> On 2022/04/01 01:04:19 Julian Hyde wrote:
>> Ah, I see. In the page for a commit (e.g. [1]) the text “[CALCITE-5064]” 
>> appears as a blue hyperlink whereas the page for the corresponding pull 
>> request (e.g. [2]) the “[CALCITE-5064]” text is not a hyperlink.
>> 
>> Is that what you meant, Haisheng?
>> 
>> Julian
>> 
>> 
>> [1] 
>> https://github.com/apache/calcite/commit/d85b2a602a547290bd5be0bba68092b702400731
>>  
>> 
>> 
>> [2] https://github.com/apache/calcite/pull/2752 
>>  
>> 
>>> On Mar 31, 2022, at 11:05 AM, Michael Mior  wrote:
>>> 
>>> Stamatis,
>>> 
>>> Unless I'm misunderstanding, Haisheng was referring to links in the
>>> opposite direction. That is, linking to JIRA issues from GitHub. The
>>> setting you reference is for creating a link from JIRA to GitHub.
>>> 
>>> --
>>> Michael Mior
>>> mm...@apache.org
>>> 
>>> 
>>> Le jeu. 31 mars 2022 à 13:53, Stamatis Zampetakis  a
>>> écrit :
>>> 
 It's already done via .asf.yaml [1].
 
 Best,
 Stamatis
 
 [1]
 
 https://github.com/apache/calcite/blob/88cc385f98c551c1aca7ffab101934f1c34fdffd/.asf.yaml#L35
 
 On Thu, Mar 31, 2022 at 7:19 PM Michael Mior  wrote:
 
> Not sure what might have changed, but here's the GitHub documentation on
> the feature. If this isn't working as expected, I would contact INFRA to
> make sure things are correctly configured. (Apparently in the future,
 this
> may be done via .asf.yaml)
> 
> 
> 
 https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/configuring-autolinks-to-reference-external-resources
> 
> 
> --
> Michael Mior
> mm...@apache.org
> 
> 
> Le mer. 30 mars 2022 à 13:46, Haisheng Yuan  a écrit :
> 
>> Hi all,
>> 
>> Previously, the JIRA issue e.g. [CALCITE-6789] in Calcite github PR and
>> commit message will be automatically linked to the JIRA site. Now there
> is
>> no link anymore.
>> 
>> Does anyone know what happened? What can we do to add the link back?
>> 
>> Thanks,
>> Haisheng Yuan
>> 
> 
 
>> 
>> 

Re: [DISCUSS] Github PR link to JIRA issue

[Haisheng Yuan]

Yes, that is what I meant.

I was expecting to see the link to JIRA in PR's commit page:
https://github.com/apache/calcite/pull/2752/commits

I am lazy to navigate to JIRA manually. :)

Haisheng

On 2022/04/01 01:04:19 Julian Hyde wrote:
> Ah, I see. In the page for a commit (e.g. [1]) the text “[CALCITE-5064]” 
> appears as a blue hyperlink whereas the page for the corresponding pull 
> request (e.g. [2]) the “[CALCITE-5064]” text is not a hyperlink.
> 
> Is that what you meant, Haisheng?
> 
> Julian
> 
> 
> [1] 
> https://github.com/apache/calcite/commit/d85b2a602a547290bd5be0bba68092b702400731
>  
> 
> 
> [2] https://github.com/apache/calcite/pull/2752 
>  
> 
> > On Mar 31, 2022, at 11:05 AM, Michael Mior  wrote:
> > 
> > Stamatis,
> > 
> > Unless I'm misunderstanding, Haisheng was referring to links in the
> > opposite direction. That is, linking to JIRA issues from GitHub. The
> > setting you reference is for creating a link from JIRA to GitHub.
> > 
> > --
> > Michael Mior
> > mm...@apache.org
> > 
> > 
> > Le jeu. 31 mars 2022 à 13:53, Stamatis Zampetakis  a
> > écrit :
> > 
> >> It's already done via .asf.yaml [1].
> >> 
> >> Best,
> >> Stamatis
> >> 
> >> [1]
> >> 
> >> https://github.com/apache/calcite/blob/88cc385f98c551c1aca7ffab101934f1c34fdffd/.asf.yaml#L35
> >> 
> >> On Thu, Mar 31, 2022 at 7:19 PM Michael Mior  wrote:
> >> 
> >>> Not sure what might have changed, but here's the GitHub documentation on
> >>> the feature. If this isn't working as expected, I would contact INFRA to
> >>> make sure things are correctly configured. (Apparently in the future,
> >> this
> >>> may be done via .asf.yaml)
> >>> 
> >>> 
> >>> 
> >> https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/configuring-autolinks-to-reference-external-resources
> >>> 
> >>> 
> >>> --
> >>> Michael Mior
> >>> mm...@apache.org
> >>> 
> >>> 
> >>> Le mer. 30 mars 2022 à 13:46, Haisheng Yuan  a écrit :
> >>> 
>  Hi all,
>  
>  Previously, the JIRA issue e.g. [CALCITE-6789] in Calcite github PR and
>  commit message will be automatically linked to the JIRA site. Now there
> >>> is
>  no link anymore.
>  
>  Does anyone know what happened? What can we do to add the link back?
>  
>  Thanks,
>  Haisheng Yuan
>  
> >>> 
> >> 
> 
> 

Re: [DISCUSS] Github PR link to JIRA issue

[Julian Hyde]

Ah, I see. In the page for a commit (e.g. [1]) the text “[CALCITE-5064]” 
appears as a blue hyperlink whereas the page for the corresponding pull request 
(e.g. [2]) the “[CALCITE-5064]” text is not a hyperlink.

Is that what you meant, Haisheng?

Julian


[1] 
https://github.com/apache/calcite/commit/d85b2a602a547290bd5be0bba68092b702400731
 


[2] https://github.com/apache/calcite/pull/2752 
 

> On Mar 31, 2022, at 11:05 AM, Michael Mior  wrote:
> 
> Stamatis,
> 
> Unless I'm misunderstanding, Haisheng was referring to links in the
> opposite direction. That is, linking to JIRA issues from GitHub. The
> setting you reference is for creating a link from JIRA to GitHub.
> 
> --
> Michael Mior
> mm...@apache.org
> 
> 
> Le jeu. 31 mars 2022 à 13:53, Stamatis Zampetakis  a
> écrit :
> 
>> It's already done via .asf.yaml [1].
>> 
>> Best,
>> Stamatis
>> 
>> [1]
>> 
>> https://github.com/apache/calcite/blob/88cc385f98c551c1aca7ffab101934f1c34fdffd/.asf.yaml#L35
>> 
>> On Thu, Mar 31, 2022 at 7:19 PM Michael Mior  wrote:
>> 
>>> Not sure what might have changed, but here's the GitHub documentation on
>>> the feature. If this isn't working as expected, I would contact INFRA to
>>> make sure things are correctly configured. (Apparently in the future,
>> this
>>> may be done via .asf.yaml)
>>> 
>>> 
>>> 
>> https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/configuring-autolinks-to-reference-external-resources
>>> 
>>> 
>>> --
>>> Michael Mior
>>> mm...@apache.org
>>> 
>>> 
>>> Le mer. 30 mars 2022 à 13:46, Haisheng Yuan  a écrit :
>>> 
 Hi all,
 
 Previously, the JIRA issue e.g. [CALCITE-6789] in Calcite github PR and
 commit message will be automatically linked to the JIRA site. Now there
>>> is
 no link anymore.
 
 Does anyone know what happened? What can we do to add the link back?
 
 Thanks,
 Haisheng Yuan
 
>>> 
>> 

Re: [DISCUSS] Github PR link to JIRA issue

[Michael Mior]

Stamatis,

Unless I'm misunderstanding, Haisheng was referring to links in the
opposite direction. That is, linking to JIRA issues from GitHub. The
setting you reference is for creating a link from JIRA to GitHub.

--
Michael Mior
mm...@apache.org


Le jeu. 31 mars 2022 à 13:53, Stamatis Zampetakis  a
écrit :

> It's already done via .asf.yaml [1].
>
> Best,
> Stamatis
>
> [1]
>
> https://github.com/apache/calcite/blob/88cc385f98c551c1aca7ffab101934f1c34fdffd/.asf.yaml#L35
>
> On Thu, Mar 31, 2022 at 7:19 PM Michael Mior  wrote:
>
> > Not sure what might have changed, but here's the GitHub documentation on
> > the feature. If this isn't working as expected, I would contact INFRA to
> > make sure things are correctly configured. (Apparently in the future,
> this
> > may be done via .asf.yaml)
> >
> >
> >
> https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/configuring-autolinks-to-reference-external-resources
> >
> >
> > --
> > Michael Mior
> > mm...@apache.org
> >
> >
> > Le mer. 30 mars 2022 à 13:46, Haisheng Yuan  a écrit :
> >
> > > Hi all,
> > >
> > > Previously, the JIRA issue e.g. [CALCITE-6789] in Calcite github PR and
> > > commit message will be automatically linked to the JIRA site. Now there
> > is
> > > no link anymore.
> > >
> > > Does anyone know what happened? What can we do to add the link back?
> > >
> > > Thanks,
> > > Haisheng Yuan
> > >
> >
>

Re: [DISCUSS] Github PR link to JIRA issue

[Stamatis Zampetakis]

It's already done via .asf.yaml [1].

Best,
Stamatis

[1]
https://github.com/apache/calcite/blob/88cc385f98c551c1aca7ffab101934f1c34fdffd/.asf.yaml#L35

On Thu, Mar 31, 2022 at 7:19 PM Michael Mior  wrote:

> Not sure what might have changed, but here's the GitHub documentation on
> the feature. If this isn't working as expected, I would contact INFRA to
> make sure things are correctly configured. (Apparently in the future, this
> may be done via .asf.yaml)
>
>
> https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/configuring-autolinks-to-reference-external-resources
>
>
> --
> Michael Mior
> mm...@apache.org
>
>
> Le mer. 30 mars 2022 à 13:46, Haisheng Yuan  a écrit :
>
> > Hi all,
> >
> > Previously, the JIRA issue e.g. [CALCITE-6789] in Calcite github PR and
> > commit message will be automatically linked to the JIRA site. Now there
> is
> > no link anymore.
> >
> > Does anyone know what happened? What can we do to add the link back?
> >
> > Thanks,
> > Haisheng Yuan
> >
>

Re: [DISCUSS] Github PR link to JIRA issue

[Michael Mior]

Not sure what might have changed, but here's the GitHub documentation on
the feature. If this isn't working as expected, I would contact INFRA to
make sure things are correctly configured. (Apparently in the future, this
may be done via .asf.yaml)

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/configuring-autolinks-to-reference-external-resources


--
Michael Mior
mm...@apache.org


Le mer. 30 mars 2022 à 13:46, Haisheng Yuan  a écrit :

> Hi all,
>
> Previously, the JIRA issue e.g. [CALCITE-6789] in Calcite github PR and
> commit message will be automatically linked to the JIRA site. Now there is
> no link anymore.
>
> Does anyone know what happened? What can we do to add the link back?
>
> Thanks,
> Haisheng Yuan
>

Re: [DISCUSS] Github PR link to JIRA issue

[Haisheng Yuan]

Hi Thomas,

I didn't make myself clear. 6789 is just a random number, should be 
[CALCITE-], as Julian mentioned.

The problem happens on github PR. e.g. 
in https://github.com/apache/calcite/pull/2757, the commit message title is
[CALCITE-4401] SqlJoin toString throws RuntimeException

Previously "[CALCITE-4401]" was linked to Caclite JIRA website automatically. 
Now it is not linked anymore.
I have to manually visit the JIRA website.
 
Anyway, hope it is just a sporadic issue.

On 2022/03/30 18:04:00 Thomas Rebele wrote:
> When I visit https://issues.apache.org/jira/browse/CALCITE-6789, I get an
> error message:
> 
> You can't view this issue
> It may have been deleted or you don't have permission to view it.
> 
> I can view other tickets, though (e.g.,
> https://issues.apache.org/jira/browse/CALCITE-5008).
> Maybe the link has been removed because the ticket is not available?
> 
> Cordialement / Best Regards,
> *Thomas Rebele, PhD* | R&D Developer | Germany | www.tibco.com
> 
> 
> On Wed, Mar 30, 2022 at 7:57 PM Julian Hyde  wrote:
> 
> > It seems to happen sporadically. Maybe the commit message of the PR needs
> > to start with exactly “[CALCITE-]”.
> >
> > > On Mar 30, 2022, at 10:45 AM, Haisheng Yuan  wrote:
> > >
> > > Hi all,
> > >
> > > Previously, the JIRA issue e.g. [CALCITE-6789] in Calcite github PR and
> > > commit message will be automatically linked to the JIRA site. Now there
> > is
> > > no link anymore.
> > >
> > > Does anyone know what happened? What can we do to add the link back?
> > >
> > > Thanks,
> > > Haisheng Yuan
> >
> >
> 

Re: [DISCUSS] Github PR link to JIRA issue

[Thomas Rebele]

When I visit https://issues.apache.org/jira/browse/CALCITE-6789, I get an
error message:

You can't view this issue
It may have been deleted or you don't have permission to view it.

I can view other tickets, though (e.g.,
https://issues.apache.org/jira/browse/CALCITE-5008).
Maybe the link has been removed because the ticket is not available?

Cordialement / Best Regards,
*Thomas Rebele, PhD* | R&D Developer | Germany | www.tibco.com


On Wed, Mar 30, 2022 at 7:57 PM Julian Hyde  wrote:

> It seems to happen sporadically. Maybe the commit message of the PR needs
> to start with exactly “[CALCITE-]”.
>
> > On Mar 30, 2022, at 10:45 AM, Haisheng Yuan  wrote:
> >
> > Hi all,
> >
> > Previously, the JIRA issue e.g. [CALCITE-6789] in Calcite github PR and
> > commit message will be automatically linked to the JIRA site. Now there
> is
> > no link anymore.
> >
> > Does anyone know what happened? What can we do to add the link back?
> >
> > Thanks,
> > Haisheng Yuan
>
>

Re: [DISCUSS] Github PR link to JIRA issue

[Julian Hyde]

It seems to happen sporadically. Maybe the commit message of the PR needs to 
start with exactly “[CALCITE-]”.

> On Mar 30, 2022, at 10:45 AM, Haisheng Yuan  wrote:
> 
> Hi all,
> 
> Previously, the JIRA issue e.g. [CALCITE-6789] in Calcite github PR and
> commit message will be automatically linked to the JIRA site. Now there is
> no link anymore.
> 
> Does anyone know what happened? What can we do to add the link back?
> 
> Thanks,
> Haisheng Yuan

[DISCUSS] Github PR link to JIRA issue

[Haisheng Yuan]

Hi all,

Previously, the JIRA issue e.g. [CALCITE-6789] in Calcite github PR and
commit message will be automatically linked to the JIRA site. Now there is
no link anymore.

Does anyone know what happened? What can we do to add the link back?

Thanks,
Haisheng Yuan