[GitHub] siddharthteotia commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds
siddharthteotia commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds URL: https://github.com/apache/calcite/pull/1034#issuecomment-468449888 @vlsi ... we use this initially only to get some random ordering (not possibly the best ordering) to convert multi-join to join nodes.. There is probably no other way in Calcite to do that so added this unoptimized instance where we just return after getting the first ordering. So the test case also aims to verify if the result is the ordering by considering first join factor as the first factor. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] siddharthteotia commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds
siddharthteotia commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds URL: https://github.com/apache/calcite/pull/1034#issuecomment-468035971 > @siddharthteotia , this PR adds extremely specific feature, and I don't see how the behavior is tested. Do you have a test that validates "only one"? > > I think we could go with: "generate at most N permutations" or "spend no more than X milliseconds" rule parameters. > > What do you think? @vlsi , let me revisit the unit test and see if it can be changed/improved. I am a little confused with "generate at most N permutation" part. Are you referring to some piece of code that I can leverage to test this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] siddharthteotia commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds
siddharthteotia commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds URL: https://github.com/apache/calcite/pull/1034#issuecomment-468028636 ping? cc @laurentgo , @vladimirdolzhenko This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
