[VOTE] Release Apache Calcite Avatica 1.25.0 (release candidate 0)
Hi all, I have created a build for Apache Calcite Avatica 1.25.0, release candidate 0. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite-avatica/blob/avatica-1.25.0-rc0/site/_docs/history.md The commit to be voted upon: https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=62b0fdd3f4e0173d8492eb0e203056f0938dd6f5 Its hash is 62b0fdd3f4e0173d8492eb0e203056f0938dd6f5 Tag: https://github.com/apache/calcite-avatica/tree/avatica-1.25.0-rc0 The artifacts to be voted on are located here: https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.25.0-rc0 RAT report: https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/rat/rat-report.txt Site preview is here: https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/ JavaDoc API preview is here: https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/api The hashes of the artifacts are as follows: 0daa1da33ca0712cb3a4918260081e707c336e06eaacee87962a8ff914f377e8ad21d5fd24490612dbca7d56b83e9d062c39b5cd51701564cf8cba7840ed4806 *apache-calcite-avatica-1.25.0-src.tar.gz A staged Maven repository is available for review at: https://repository.apache.org/content/repositories/orgapachecalcite-1223/org/apache/calcite/ Release artifacts are signed with the following key: https://people.apache.org/keys/committer/francischuang.asc https://www.apache.org/dist/calcite/KEYS To create the jars and test Apache Calcite Avatica: "gradle build -Prelease -PskipSign". If you do not have a Java/Gradle environment available, you can run the tests using docker. To do so, install docker and docker-compose, then run "docker compose run test" from the root of the directory. Please vote on releasing this package as Apache Calcite Avatica 1.25.0. The vote is open for the next 72 hours and passes if a majority of at least three +1 PMC votes are cast. [ ] +1 Release this package as Apache Calcite Avatica 1.25.0 [ ] 0 I don't feel strongly about it, but I'm okay with the release [ ] -1 Do not release this package because... Here is my vote: +1 (binding) Francis
Re: [VOTE] Release Apache Calcite Avatica 1.25.0 (release candidate 0)
+1 (binding) - checked signature and checksum [OK] - checked copyright year in notice [OK] - downloaded src, make sure no unexpected files [OK] - compiled and tested from source [OK] - reviewed release note [OK] - checked a few files in Nexus for signature and checksum [OK] - downloaded javadoc jar, make sure it's in English [OK] One minor comment is that those gitbox urls seem not valid. Francis Chuang 于2024年4月2日周二 11:40写道: > > Hi all, > > I have created a build for Apache Calcite Avatica 1.25.0, release > candidate 0. > > Thanks to everyone who has contributed to this release. > > You can read the release notes here: > https://github.com/apache/calcite-avatica/blob/avatica-1.25.0-rc0/site/_docs/history.md > > The commit to be voted upon: > https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=62b0fdd3f4e0173d8492eb0e203056f0938dd6f5 > > Its hash is 62b0fdd3f4e0173d8492eb0e203056f0938dd6f5 > > Tag: > https://github.com/apache/calcite-avatica/tree/avatica-1.25.0-rc0 > > The artifacts to be voted on are located here: > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.25.0-rc0 > > RAT report: > https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/rat/rat-report.txt > > Site preview is here: > https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/ > > JavaDoc API preview is here: > https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/api > > The hashes of the artifacts are as follows: > 0daa1da33ca0712cb3a4918260081e707c336e06eaacee87962a8ff914f377e8ad21d5fd24490612dbca7d56b83e9d062c39b5cd51701564cf8cba7840ed4806 > *apache-calcite-avatica-1.25.0-src.tar.gz > > A staged Maven repository is available for review at: > https://repository.apache.org/content/repositories/orgapachecalcite-1223/org/apache/calcite/ > > Release artifacts are signed with the following key: > https://people.apache.org/keys/committer/francischuang.asc > https://www.apache.org/dist/calcite/KEYS > > To create the jars and test Apache Calcite Avatica: "gradle build > -Prelease -PskipSign". > > If you do not have a Java/Gradle environment available, you can run the > tests using docker. To do so, install docker and docker-compose, then > run "docker compose run test" from the root of the directory. > > Please vote on releasing this package as Apache Calcite Avatica 1.25.0. > > The vote is open for the next 72 hours and passes if a majority of at > least three +1 PMC votes are cast. > > [ ] +1 Release this package as Apache Calcite Avatica 1.25.0 > [ ] 0 I don't feel strongly about it, but I'm okay with the release > [ ] -1 Do not release this package because... > > > Here is my vote: > > +1 (binding) > > Francis -- Best, Benchao Li
Re: [VOTE] Release Apache Calcite Avatica 1.25.0 (release candidate 0)
Opps, good catch! Please ignore the links to the calcite-avatica-site-preview repo. Those are generated by the asf-release plugin, but we don't use any preview repos for Calcite. On 3/04/2024 9:41 pm, Benchao Li wrote: +1 (binding) - checked signature and checksum [OK] - checked copyright year in notice [OK] - downloaded src, make sure no unexpected files [OK] - compiled and tested from source [OK] - reviewed release note [OK] - checked a few files in Nexus for signature and checksum [OK] - downloaded javadoc jar, make sure it's in English [OK] One minor comment is that those gitbox urls seem not valid. Francis Chuang 于2024年4月2日周二 11:40写道: Hi all, I have created a build for Apache Calcite Avatica 1.25.0, release candidate 0. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite-avatica/blob/avatica-1.25.0-rc0/site/_docs/history.md The commit to be voted upon: https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=62b0fdd3f4e0173d8492eb0e203056f0938dd6f5 Its hash is 62b0fdd3f4e0173d8492eb0e203056f0938dd6f5 Tag: https://github.com/apache/calcite-avatica/tree/avatica-1.25.0-rc0 The artifacts to be voted on are located here: https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.25.0-rc0 RAT report: https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/rat/rat-report.txt Site preview is here: https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/ JavaDoc API preview is here: https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/api The hashes of the artifacts are as follows: 0daa1da33ca0712cb3a4918260081e707c336e06eaacee87962a8ff914f377e8ad21d5fd24490612dbca7d56b83e9d062c39b5cd51701564cf8cba7840ed4806 *apache-calcite-avatica-1.25.0-src.tar.gz A staged Maven repository is available for review at: https://repository.apache.org/content/repositories/orgapachecalcite-1223/org/apache/calcite/ Release artifacts are signed with the following key: https://people.apache.org/keys/committer/francischuang.asc https://www.apache.org/dist/calcite/KEYS To create the jars and test Apache Calcite Avatica: "gradle build -Prelease -PskipSign". If you do not have a Java/Gradle environment available, you can run the tests using docker. To do so, install docker and docker-compose, then run "docker compose run test" from the root of the directory. Please vote on releasing this package as Apache Calcite Avatica 1.25.0. The vote is open for the next 72 hours and passes if a majority of at least three +1 PMC votes are cast. [ ] +1 Release this package as Apache Calcite Avatica 1.25.0 [ ] 0 I don't feel strongly about it, but I'm okay with the release [ ] -1 Do not release this package because... Here is my vote: +1 (binding) Francis
Re: [VOTE] Release Apache Calcite Avatica 1.25.0 (release candidate 0)
Ubuntu 20.04.6 LTS, jdk1.8.0_261, Gradle wrapper, Gradle 8.1.1 * Checked signatures and checksums OK * Checked diff between repo and artifacts OK * Went over release note OK (It mentions two Gradle versions 8.4 and 8.5) * Checked README, NOTICE, LICENSE OK (minor fixes in LICENSE from Calcite should be ported to Avatica) * All source files have ASF headers OK (grep -RiL "Licensed to the Apache Software Foundation") * No unexpected binary files OK (find . -type f -exec file {} \; | grep -v text) * Checked LICENSE, NOTICE, signature, and checksum for avatica-core-1.25.0.jar in nexus OK * Built from git tag and run tests (./gradlew build) OK * Built from source artifacts and run tests (gradle build) OK +1 (binding) Best, Stamatis On Wed, Apr 3, 2024 at 11:36 PM Francis Chuang wrote: > > Opps, good catch! Please ignore the links to the > calcite-avatica-site-preview repo. Those are generated by the > asf-release plugin, but we don't use any preview repos for Calcite. > > On 3/04/2024 9:41 pm, Benchao Li wrote: > > +1 (binding) > > > > - checked signature and checksum [OK] > > - checked copyright year in notice [OK] > > - downloaded src, make sure no unexpected files [OK] > > - compiled and tested from source [OK] > > - reviewed release note [OK] > > - checked a few files in Nexus for signature and checksum [OK] > > - downloaded javadoc jar, make sure it's in English [OK] > > > > One minor comment is that those gitbox urls seem not valid. > > > > Francis Chuang 于2024年4月2日周二 11:40写道: > >> > >> Hi all, > >> > >> I have created a build for Apache Calcite Avatica 1.25.0, release > >> candidate 0. > >> > >> Thanks to everyone who has contributed to this release. > >> > >> You can read the release notes here: > >> https://github.com/apache/calcite-avatica/blob/avatica-1.25.0-rc0/site/_docs/history.md > >> > >> The commit to be voted upon: > >> https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=62b0fdd3f4e0173d8492eb0e203056f0938dd6f5 > >> > >> Its hash is 62b0fdd3f4e0173d8492eb0e203056f0938dd6f5 > >> > >> Tag: > >> https://github.com/apache/calcite-avatica/tree/avatica-1.25.0-rc0 > >> > >> The artifacts to be voted on are located here: > >> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.25.0-rc0 > >> > >> RAT report: > >> https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/rat/rat-report.txt > >> > >> Site preview is here: > >> https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/ > >> > >> JavaDoc API preview is here: > >> https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/api > >> > >> The hashes of the artifacts are as follows: > >> 0daa1da33ca0712cb3a4918260081e707c336e06eaacee87962a8ff914f377e8ad21d5fd24490612dbca7d56b83e9d062c39b5cd51701564cf8cba7840ed4806 > >> *apache-calcite-avatica-1.25.0-src.tar.gz > >> > >> A staged Maven repository is available for review at: > >> https://repository.apache.org/content/repositories/orgapachecalcite-1223/org/apache/calcite/ > >> > >> Release artifacts are signed with the following key: > >> https://people.apache.org/keys/committer/francischuang.asc > >> https://www.apache.org/dist/calcite/KEYS > >> > >> To create the jars and test Apache Calcite Avatica: "gradle build > >> -Prelease -PskipSign". > >> > >> If you do not have a Java/Gradle environment available, you can run the > >> tests using docker. To do so, install docker and docker-compose, then > >> run "docker compose run test" from the root of the directory. > >> > >> Please vote on releasing this package as Apache Calcite Avatica 1.25.0. > >> > >> The vote is open for the next 72 hours and passes if a majority of at > >> least three +1 PMC votes are cast. > >> > >> [ ] +1 Release this package as Apache Calcite Avatica 1.25.0 > >> [ ] 0 I don't feel strongly about it, but I'm okay with the release > >> [ ] -1 Do not release this package because... > >> > >> > >> Here is my vote: > >> > >> +1 (binding) > >> > >> Francis > > > > > >
Re: [VOTE] Release Apache Calcite Avatica 1.25.0 (release candidate 0)
+1 (non-binding) after verifying as follows: - verified gpg signature: OK $ curl "https://downloads.apache.org/calcite/KEYS"; | gpg --import $ gpg --verify apache-calcite-avatica-1.25.0-src.tar.gz.asc apache-calcite-avatica-1.25.0-src.tar.gz - verified package checksum: OK $ diff <(cat apache-calcite-avatica-1.25.0-src.tar.gz.sha512) <(shasum -a 512 apache-calcite-avatica-1.25.0-src.tar.gz) - verified gradle build from sources: OK $ cp ~/git-apache/calcite-avatica/gradlew . $ cp -r ~/git-apache/calcite-avatica/gradle/wrapper gradle $ ./gradlew build -Prelease -PskipSign $ docker-compose run test - building commit and running tests: OK $ ./gradlew build -Prelease -PskipSign $ docker-compose run test (checked CI on github for the commit) - checked release notes: OK - checked few modules in Nexus: OK - checking difference in folder: OK $ diff -qr . ~/git-apache/calcite-avatica | grep -v gradle | grep -v idea (nothing worth mentioning) -- Environment used: $ sw_vers ProductName: macOS ProductVersion: 12.6.2 BuildVersion: 21G320 $ ./gradlew -version Gradle 8.5 Build time: 2023-11-29 14:08:57 UTC Revision: 28aca86a7180baa17117e0e5ba01d8ea9feca598 Kotlin: 1.9.20 Groovy: 3.0.17 Ant: Apache Ant(TM) version 1.10.13 compiled on January 4 2023 JVM: 1.8.0_352 (Azul Systems, Inc. 25.352-b08) OS: Mac OS X 12.6.2 aarch64 $ java -version openjdk version "1.8.0_352" OpenJDK Runtime Environment (Zulu 8.66.0.15-CA-macos-aarch64) (build 1.8.0_352-b08) OpenJDK 64-Bit Server VM (Zulu 8.66.0.15-CA-macos-aarch64) (build 25.352-b08, mixed mode) Best regards, Alessandro On Thu, 4 Apr 2024 at 09:25, Stamatis Zampetakis wrote: > Ubuntu 20.04.6 LTS, jdk1.8.0_261, Gradle wrapper, Gradle 8.1.1 > > * Checked signatures and checksums OK > * Checked diff between repo and artifacts OK > * Went over release note OK (It mentions two Gradle versions 8.4 and 8.5) > * Checked README, NOTICE, LICENSE OK (minor fixes in LICENSE from > Calcite should be ported to Avatica) > * All source files have ASF headers OK (grep -RiL "Licensed to the > Apache Software Foundation") > * No unexpected binary files OK (find . -type f -exec file {} \; | > grep -v text) > * Checked LICENSE, NOTICE, signature, and checksum for > avatica-core-1.25.0.jar in nexus OK > * Built from git tag and run tests (./gradlew build) OK > * Built from source artifacts and run tests (gradle build) OK > > +1 (binding) > > Best, > Stamatis > > > On Wed, Apr 3, 2024 at 11:36 PM Francis Chuang > wrote: > > > > Opps, good catch! Please ignore the links to the > > calcite-avatica-site-preview repo. Those are generated by the > > asf-release plugin, but we don't use any preview repos for Calcite. > > > > On 3/04/2024 9:41 pm, Benchao Li wrote: > > > +1 (binding) > > > > > > - checked signature and checksum [OK] > > > - checked copyright year in notice [OK] > > > - downloaded src, make sure no unexpected files [OK] > > > - compiled and tested from source [OK] > > > - reviewed release note [OK] > > > - checked a few files in Nexus for signature and checksum [OK] > > > - downloaded javadoc jar, make sure it's in English [OK] > > > > > > One minor comment is that those gitbox urls seem not valid. > > > > > > Francis Chuang 于2024年4月2日周二 11:40写道: > > >> > > >> Hi all, > > >> > > >> I have created a build for Apache Calcite Avatica 1.25.0, release > > >> candidate 0. > > >> > > >> Thanks to everyone who has contributed to this release. > > >> > > >> You can read the release notes here: > > >> > https://github.com/apache/calcite-avatica/blob/avatica-1.25.0-rc0/site/_docs/history.md > > >> > > >> The commit to be voted upon: > > >> > https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=62b0fdd3f4e0173d8492eb0e203056f0938dd6f5 > > >> > > >> Its hash is 62b0fdd3f4e0173d8492eb0e203056f0938dd6f5 > > >> > > >> Tag: > > >> https://github.com/apache/calcite-avatica/tree/avatica-1.25.0-rc0 > > >> > > >> The artifacts to be voted on are located here: > > >> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.25.0-rc0 > > >> > > >> RAT report: > > >> > https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/rat/rat-report.txt > > >> > > >> Site preview is here: > > >> > https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/ > > >> > > >> JavaDoc API preview is here: > > >> > https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/api > > >> > > >> The hashes of the artifacts are as follows: > > >> > 0daa1da33ca0712cb3a4918260081e707c336e06eaacee87962a8ff914f377e8ad21d5fd24490612dbca7d56b83e9d062c39b5cd51701564cf8cba7840ed4806 > > >> *apache-calcite-avatica-1.25.0-src.tar.gz > > >> > > >> A staged Maven repository is available for review at: > > >> > https://repository.apache.org/content/re
Re: [VOTE] Release Apache Calcite Avatica 1.25.0 (release candidate 0)
- Checksum: ok - Signature: ok - Diff source release and git repository: ok - Build + tests: ok - Release notes: ok; one minor issue: the list item "CALCITE-6137" mentions the upgrade to "Gradle 8.4", but both the Jira title and the initial description of the RN say "8.5" +1 (binding) Best, Ruben On Thu, Apr 4, 2024 at 1:53 PM Alessandro Solimando < alessandro.solima...@gmail.com> wrote: > +1 (non-binding) after verifying as follows: > > - verified gpg signature: OK > > $ curl "https://downloads.apache.org/calcite/KEYS"; | gpg --import > > $ gpg --verify apache-calcite-avatica-1.25.0-src.tar.gz.asc > apache-calcite-avatica-1.25.0-src.tar.gz > > - verified package checksum: OK > > $ diff <(cat apache-calcite-avatica-1.25.0-src.tar.gz.sha512) <(shasum -a > 512 apache-calcite-avatica-1.25.0-src.tar.gz) > > - verified gradle build from sources: OK > > $ cp ~/git-apache/calcite-avatica/gradlew . > > $ cp -r ~/git-apache/calcite-avatica/gradle/wrapper gradle > > $ ./gradlew build -Prelease -PskipSign > > $ docker-compose run test > > - building commit and running tests: OK > > $ ./gradlew build -Prelease -PskipSign > > $ docker-compose run test > > (checked CI on github for the commit) > > - checked release notes: OK > > - checked few modules in Nexus: OK > > - checking difference in folder: OK > > $ diff -qr . ~/git-apache/calcite-avatica | grep -v gradle | grep -v idea > > (nothing worth mentioning) > > -- Environment used: > > $ sw_vers > > ProductName: macOS > > ProductVersion: 12.6.2 > > BuildVersion: 21G320 > > $ ./gradlew -version > > > > Gradle 8.5 > > > > Build time: 2023-11-29 14:08:57 UTC > > Revision: 28aca86a7180baa17117e0e5ba01d8ea9feca598 > > Kotlin: 1.9.20 > > Groovy: 3.0.17 > > Ant: Apache Ant(TM) version 1.10.13 compiled on January 4 2023 > > JVM: 1.8.0_352 (Azul Systems, Inc. 25.352-b08) > > OS: Mac OS X 12.6.2 aarch64 > > $ java -version > > openjdk version "1.8.0_352" > > OpenJDK Runtime Environment (Zulu 8.66.0.15-CA-macos-aarch64) (build > 1.8.0_352-b08) > > OpenJDK 64-Bit Server VM (Zulu 8.66.0.15-CA-macos-aarch64) (build > 25.352-b08, mixed mode) > > Best regards, > > Alessandro > > On Thu, 4 Apr 2024 at 09:25, Stamatis Zampetakis > wrote: > > > Ubuntu 20.04.6 LTS, jdk1.8.0_261, Gradle wrapper, Gradle 8.1.1 > > > > * Checked signatures and checksums OK > > * Checked diff between repo and artifacts OK > > * Went over release note OK (It mentions two Gradle versions 8.4 and > 8.5) > > * Checked README, NOTICE, LICENSE OK (minor fixes in LICENSE from > > Calcite should be ported to Avatica) > > * All source files have ASF headers OK (grep -RiL "Licensed to the > > Apache Software Foundation") > > * No unexpected binary files OK (find . -type f -exec file {} \; | > > grep -v text) > > * Checked LICENSE, NOTICE, signature, and checksum for > > avatica-core-1.25.0.jar in nexus OK > > * Built from git tag and run tests (./gradlew build) OK > > * Built from source artifacts and run tests (gradle build) OK > > > > +1 (binding) > > > > Best, > > Stamatis > > > > > > On Wed, Apr 3, 2024 at 11:36 PM Francis Chuang > > > wrote: > > > > > > Opps, good catch! Please ignore the links to the > > > calcite-avatica-site-preview repo. Those are generated by the > > > asf-release plugin, but we don't use any preview repos for Calcite. > > > > > > On 3/04/2024 9:41 pm, Benchao Li wrote: > > > > +1 (binding) > > > > > > > > - checked signature and checksum [OK] > > > > - checked copyright year in notice [OK] > > > > - downloaded src, make sure no unexpected files [OK] > > > > - compiled and tested from source [OK] > > > > - reviewed release note [OK] > > > > - checked a few files in Nexus for signature and checksum [OK] > > > > - downloaded javadoc jar, make sure it's in English [OK] > > > > > > > > One minor comment is that those gitbox urls seem not valid. > > > > > > > > Francis Chuang 于2024年4月2日周二 11:40写道: > > > >> > > > >> Hi all, > > > >> > > > >> I have created a build for Apache Calcite Avatica 1.25.0, release > > > >> candidate 0. > > > >> > > > >> Thanks to everyone who has contributed to this release. > > > >> > > > >> You can read the release notes here: > > > >> > > > https://github.com/apache/calcite-avatica/blob/avatica-1.25.0-rc0/site/_docs/history.md > > > >> > > > >> The commit to be voted upon: > > > >> > > > https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=62b0fdd3f4e0173d8492eb0e203056f0938dd6f5 > > > >> > > > >> Its hash is 62b0fdd3f4e0173d8492eb0e203056f0938dd6f5 > > > >> > > > >> Tag: > > > >> https://github.com/apache/calcite-avatica/tree/avatica-1.25.0-rc0 > > > >> > > > >> The artifacts to be voted on are located here: > > > >> > > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.25.0-rc0 > > > >> > > > >> RAT report: > > > >> > > > https://gitbox.apache.org
Re: [VOTE] Release Apache Calcite Avatica 1.25.0 (release candidate 0)
Francis, +1 (checked signature and hash, ran tests) I can't recall if this is expected, but the gradle wrapper is missing from the release. This means that running tests via docker compose doesn't work. -- Michael Mior mm...@apache.org On Mon, Apr 1, 2024 at 11:40 PM Francis Chuang wrote: > Hi all, > > I have created a build for Apache Calcite Avatica 1.25.0, release > candidate 0. > > Thanks to everyone who has contributed to this release. > > You can read the release notes here: > > https://github.com/apache/calcite-avatica/blob/avatica-1.25.0-rc0/site/_docs/history.md > > The commit to be voted upon: > > https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=62b0fdd3f4e0173d8492eb0e203056f0938dd6f5 > > Its hash is 62b0fdd3f4e0173d8492eb0e203056f0938dd6f5 > > Tag: > https://github.com/apache/calcite-avatica/tree/avatica-1.25.0-rc0 > > The artifacts to be voted on are located here: > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.25.0-rc0 > > RAT report: > > https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/rat/rat-report.txt > > Site preview is here: > > https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/ > > JavaDoc API preview is here: > > https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/api > > The hashes of the artifacts are as follows: > > 0daa1da33ca0712cb3a4918260081e707c336e06eaacee87962a8ff914f377e8ad21d5fd24490612dbca7d56b83e9d062c39b5cd51701564cf8cba7840ed4806 > *apache-calcite-avatica-1.25.0-src.tar.gz > > A staged Maven repository is available for review at: > > https://repository.apache.org/content/repositories/orgapachecalcite-1223/org/apache/calcite/ > > Release artifacts are signed with the following key: > https://people.apache.org/keys/committer/francischuang.asc > https://www.apache.org/dist/calcite/KEYS > > To create the jars and test Apache Calcite Avatica: "gradle build > -Prelease -PskipSign". > > If you do not have a Java/Gradle environment available, you can run the > tests using docker. To do so, install docker and docker-compose, then > run "docker compose run test" from the root of the directory. > > Please vote on releasing this package as Apache Calcite Avatica 1.25.0. > > The vote is open for the next 72 hours and passes if a majority of at > least three +1 PMC votes are cast. > > [ ] +1 Release this package as Apache Calcite Avatica 1.25.0 > [ ] 0 I don't feel strongly about it, but I'm okay with the release > [ ] -1 Do not release this package because... > > > Here is my vote: > > +1 (binding) > > Francis >
Re: [VOTE] Release Apache Calcite Avatica 1.25.0 (release candidate 0)
Good catch, Ruben and Michael! I will fix the release notes to say Gradle 8.5 instead of Gradle after release. The gradle wrapper was removed in CALCITE-4575[1] to comply with ASF guidelines. For running tests in docker using docker-compose for releases, I've filed CALCITE-6354 to directly use the gradle container to run tests. Francis [1] https://issues.apache.org/jira/browse/CALCITE-4575 [2] https://issues.apache.org/jira/browse/CALCITE-6354 On 5/04/2024 3:51 am, Michael Mior wrote: Francis, +1 (checked signature and hash, ran tests) I can't recall if this is expected, but the gradle wrapper is missing from the release. This means that running tests via docker compose doesn't work. -- Michael Mior mm...@apache.org On Mon, Apr 1, 2024 at 11:40 PM Francis Chuang wrote: Hi all, I have created a build for Apache Calcite Avatica 1.25.0, release candidate 0. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite-avatica/blob/avatica-1.25.0-rc0/site/_docs/history.md The commit to be voted upon: https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=62b0fdd3f4e0173d8492eb0e203056f0938dd6f5 Its hash is 62b0fdd3f4e0173d8492eb0e203056f0938dd6f5 Tag: https://github.com/apache/calcite-avatica/tree/avatica-1.25.0-rc0 The artifacts to be voted on are located here: https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.25.0-rc0 RAT report: https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/rat/rat-report.txt Site preview is here: https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/ JavaDoc API preview is here: https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/api The hashes of the artifacts are as follows: 0daa1da33ca0712cb3a4918260081e707c336e06eaacee87962a8ff914f377e8ad21d5fd24490612dbca7d56b83e9d062c39b5cd51701564cf8cba7840ed4806 *apache-calcite-avatica-1.25.0-src.tar.gz A staged Maven repository is available for review at: https://repository.apache.org/content/repositories/orgapachecalcite-1223/org/apache/calcite/ Release artifacts are signed with the following key: https://people.apache.org/keys/committer/francischuang.asc https://www.apache.org/dist/calcite/KEYS To create the jars and test Apache Calcite Avatica: "gradle build -Prelease -PskipSign". If you do not have a Java/Gradle environment available, you can run the tests using docker. To do so, install docker and docker-compose, then run "docker compose run test" from the root of the directory. Please vote on releasing this package as Apache Calcite Avatica 1.25.0. The vote is open for the next 72 hours and passes if a majority of at least three +1 PMC votes are cast. [ ] +1 Release this package as Apache Calcite Avatica 1.25.0 [ ] 0 I don't feel strongly about it, but I'm okay with the release [ ] -1 Do not release this package because... Here is my vote: +1 (binding) Francis
Re: [VOTE] Release Apache Calcite Avatica 1.25.0 (release candidate 0)
- checked signatures and checksums - verified hashes - downloaded sources, compiled and tested +1 (binding) On Thu, Apr 4, 2024 at 11:15 PM Francis Chuang wrote: > Good catch, Ruben and Michael! > > I will fix the release notes to say Gradle 8.5 instead of Gradle after > release. > > The gradle wrapper was removed in CALCITE-4575[1] to comply with ASF > guidelines. > > For running tests in docker using docker-compose for releases, I've > filed CALCITE-6354 to directly use the gradle container to run tests. > > Francis > > [1] https://issues.apache.org/jira/browse/CALCITE-4575 > [2] https://issues.apache.org/jira/browse/CALCITE-6354 > > On 5/04/2024 3:51 am, Michael Mior wrote: > > Francis, > > > > +1 (checked signature and hash, ran tests) > > > > I can't recall if this is expected, but the gradle wrapper is missing > from > > the release. This means that running tests via docker compose doesn't > work. > > > > -- > > Michael Mior > > mm...@apache.org > > > > > > On Mon, Apr 1, 2024 at 11:40 PM Francis Chuang > > > wrote: > > > >> Hi all, > >> > >> I have created a build for Apache Calcite Avatica 1.25.0, release > >> candidate 0. > >> > >> Thanks to everyone who has contributed to this release. > >> > >> You can read the release notes here: > >> > >> > https://github.com/apache/calcite-avatica/blob/avatica-1.25.0-rc0/site/_docs/history.md > >> > >> The commit to be voted upon: > >> > >> > https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=62b0fdd3f4e0173d8492eb0e203056f0938dd6f5 > >> > >> Its hash is 62b0fdd3f4e0173d8492eb0e203056f0938dd6f5 > >> > >> Tag: > >> https://github.com/apache/calcite-avatica/tree/avatica-1.25.0-rc0 > >> > >> The artifacts to be voted on are located here: > >> > >> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.25.0-rc0 > >> > >> RAT report: > >> > >> > https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/rat/rat-report.txt > >> > >> Site preview is here: > >> > >> > https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/ > >> > >> JavaDoc API preview is here: > >> > >> > https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/api > >> > >> The hashes of the artifacts are as follows: > >> > >> > 0daa1da33ca0712cb3a4918260081e707c336e06eaacee87962a8ff914f377e8ad21d5fd24490612dbca7d56b83e9d062c39b5cd51701564cf8cba7840ed4806 > >> *apache-calcite-avatica-1.25.0-src.tar.gz > >> > >> A staged Maven repository is available for review at: > >> > >> > https://repository.apache.org/content/repositories/orgapachecalcite-1223/org/apache/calcite/ > >> > >> Release artifacts are signed with the following key: > >> https://people.apache.org/keys/committer/francischuang.asc > >> https://www.apache.org/dist/calcite/KEYS > >> > >> To create the jars and test Apache Calcite Avatica: "gradle build > >> -Prelease -PskipSign". > >> > >> If you do not have a Java/Gradle environment available, you can run the > >> tests using docker. To do so, install docker and docker-compose, then > >> run "docker compose run test" from the root of the directory. > >> > >> Please vote on releasing this package as Apache Calcite Avatica 1.25.0. > >> > >> The vote is open for the next 72 hours and passes if a majority of at > >> least three +1 PMC votes are cast. > >> > >> [ ] +1 Release this package as Apache Calcite Avatica 1.25.0 > >> [ ] 0 I don't feel strongly about it, but I'm okay with the release > >> [ ] -1 Do not release this package because... > >> > >> > >> Here is my vote: > >> > >> +1 (binding) > >> > >> Francis > >> > > > -- Best regards, Sergey
[RESULT] [VOTE] Release Apache Calcite Avatica 1.25.0 (release candidate 0)
Thanks to everyone who have tested the release candidate and given their comments and votes. The tally is as follows. 6 binding +1s: Benchao Li Francis Chuang Michael Mior Ruben Quesada Lopez Sergey Nuyanzin Stamatis Zampetakis 1 non-binding +1s: Alessandro Solimando No 0s or -1s. Therefore, I am delighted to announce that the proposal to release Apache Calcite Avatica 1.25.0 has passed. Thanks everyone. We’ll now roll the release out to the mirrors. Francis