[RESULT] [VOTE] Release apache-calcite-avatica-1.16.0 (release candidate 1)
Thanks to everyone who has tested the release candidate and given their comments and votes. The tally is as follows. 4 binding +1s: Danny Chan Francis Chuang Kevin Risden Stamatis Zampetakis 1 non-binding +1s: Rui Wang No 0s or -1s. Therefore, I am delighted to announce that the proposal to release Apache Calcite Avatica 1.16.0 has passed. Thanks everyone. We’ll now roll the release out to the mirrors. There was some discussion regarding producing zip source archive for Windows. As Gradle fails on Windows when using source files with LF line endings, we should reach some consensus as to whether we need to produce a zip archive targeted towards Windows for the next Avatica and Calcite releases. Francis
Re: [VOTE] Release apache-calcite-avatica-1.16.0 (release candidate 1)
Given the discussion on [1] the problem of building .tar.gz on Windows was anticipated so I am not changing my vote. Nevertheless it might be a bit annoying for Windows users so we have to see how we can improve on this aspect. [1] https://lists.apache.org/thread.html/280c02113c31e7ae2186ee42c1ac1e1010c7390863e791d5778f1578%40%3Cdev.calcite.apache.org%3E On Tue, Dec 17, 2019 at 10:58 AM Danny Chan wrote: > MacOS 10.14, JDK 1.8.0_161, Gradle 6.0.1 > * Checked signatures and checksums OK > * Went over release note OK > * Run build and tests (./gradlew clean build) on git repo OK > * Run build and Calcite tests on Calcite current master (./gradlew clean > build) with Avatica 1.16.0 OK > * Run diff between staged sources and git commit (diff -qr > ~/workspace/avatica-dev ~/Desktop/apache-calcite-avatica-1.16.0-src) ? > > Files /Users/chenyuzhao/workspace/avatica-dev/LICENSE and > /Users/chenyuzhao/Desktop/apache-calcite-avatica-1.16.0-src/LICENSE differ > Only in /Users/chenyuzhao/Desktop/apache-calcite-avatica-1.16.0-src: > licenses > > There are quite a few commits that does not have a JIRA issue to trace, > which is hard to understand, > instead of list the commit message, maybe we should give a broad summary > of them. > > +1 (binding) > > Best, > Danny Chan > 在 2019年12月12日 +0800 AM6:20，Francis Chuang ，写道： > > Hi all, > > > > I have created a build for Apache Calcite Avatica 1.16.0, release > > candidate 1. > > > > Thanks to everyone who has contributed to this release. > > > > You can read the release notes here: > > > https://github.com/apache/calcite-avatica/blob/512bbee4aa24ef9fb8106d0286d1243679dce2d0/site/_docs/history.md > > > > The commit to be voted upon: > > > https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=512bbee4aa24ef9fb8106d0286d1243679dce2d0 > > > > Its hash is 512bbee4aa24ef9fb8106d0286d1243679dce2d0 > > > > Tag: > > > https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=tag;h=refs/tags/avatica-1.16.0-rc1 > > > > The artifacts to be voted on are located here: > > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.16.0-rc1 > > (revision 37181) > > > > The hashes of the artifacts are as follows: > > > 102d3ab0e90dd1db5e012a966d265bdfa8a0f24f9016a4187a6e5f0135a14770da124493dd2c7a18c9d8d8b9af5ecf4f5aceb90d48421251f38bc6ce6f5be697 > > *apache-calcite-avatica-1.16.0-src.tar.gz > > > > A staged Maven repository is available for review at: > > > https://repository.apache.org/content/repositories/orgapachecalcite-1071/org/apache/calcite/ > > > > Release artifacts are signed with the following key: > > https://people.apache.org/keys/committer/francischuang.asc > > https://www.apache.org/dist/calcite/KEYS > > > > N.B. > > To create the jars and test Apache Calcite Avatica: "./gradlew build > > -PskipSigning". > > > > If you do not have a Java environment available, you can run the tests > > using docker. To do so, install docker and docker-compose, then run > > "docker-compose run test" from the root of the directory. > > > > Please vote on releasing this package as Apache Calcite Avatica 1.16.0. > > > > The vote is open for the next 72 hours and passes if a majority of at > > least three +1 PMC votes are cast. > > > > [ ] +1 Release this package as Apache Calcite 1.16.0 > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > [ ] -1 Do not release this package because... > > > > > > Here is my vote: > > > > +1 (binding) > > > > Francis >
Re: [VOTE] Release apache-calcite-avatica-1.16.0 (release candidate 1)
MacOS 10.14, JDK 1.8.0_161, Gradle 6.0.1 * Checked signatures and checksums OK * Went over release note OK * Run build and tests (./gradlew clean build) on git repo OK * Run build and Calcite tests on Calcite current master (./gradlew clean build) with Avatica 1.16.0 OK * Run diff between staged sources and git commit (diff -qr ~/workspace/avatica-dev ~/Desktop/apache-calcite-avatica-1.16.0-src) ? Files /Users/chenyuzhao/workspace/avatica-dev/LICENSE and /Users/chenyuzhao/Desktop/apache-calcite-avatica-1.16.0-src/LICENSE differ Only in /Users/chenyuzhao/Desktop/apache-calcite-avatica-1.16.0-src: licenses There are quite a few commits that does not have a JIRA issue to trace, which is hard to understand, instead of list the commit message, maybe we should give a broad summary of them. +1 (binding) Best, Danny Chan 在 2019年12月12日 +0800 AM6:20，Francis Chuang ，写道： > Hi all, > > I have created a build for Apache Calcite Avatica 1.16.0, release > candidate 1. > > Thanks to everyone who has contributed to this release. > > You can read the release notes here: > https://github.com/apache/calcite-avatica/blob/512bbee4aa24ef9fb8106d0286d1243679dce2d0/site/_docs/history.md > > The commit to be voted upon: > https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=512bbee4aa24ef9fb8106d0286d1243679dce2d0 > > Its hash is 512bbee4aa24ef9fb8106d0286d1243679dce2d0 > > Tag: > https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=tag;h=refs/tags/avatica-1.16.0-rc1 > > The artifacts to be voted on are located here: > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.16.0-rc1 > (revision 37181) > > The hashes of the artifacts are as follows: > 102d3ab0e90dd1db5e012a966d265bdfa8a0f24f9016a4187a6e5f0135a14770da124493dd2c7a18c9d8d8b9af5ecf4f5aceb90d48421251f38bc6ce6f5be697 > *apache-calcite-avatica-1.16.0-src.tar.gz > > A staged Maven repository is available for review at: > https://repository.apache.org/content/repositories/orgapachecalcite-1071/org/apache/calcite/ > > Release artifacts are signed with the following key: > https://people.apache.org/keys/committer/francischuang.asc > https://www.apache.org/dist/calcite/KEYS > > N.B. > To create the jars and test Apache Calcite Avatica: "./gradlew build > -PskipSigning". > > If you do not have a Java environment available, you can run the tests > using docker. To do so, install docker and docker-compose, then run > "docker-compose run test" from the root of the directory. > > Please vote on releasing this package as Apache Calcite Avatica 1.16.0. > > The vote is open for the next 72 hours and passes if a majority of at > least three +1 PMC votes are cast. > > [ ] +1 Release this package as Apache Calcite 1.16.0 > [ ] 0 I don't feel strongly about it, but I'm okay with the release > [ ] -1 Do not release this package because... > > > Here is my vote: > > +1 (binding) > > Francis
Re: [VOTE] Release apache-calcite-avatica-1.16.0 (release candidate 1)
Contributors and Committers who have voted, please review this issue and
let me know if this changes your vote.
On 17/12/2019 8:07 pm, Vladimir Sitnikov wrote:
https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.16.0-rc1/apache-calcite-avatica-1.16.0-src.tar.gz
does not build if Windows with default settings is used.
The error messages for "./gradlew build" are as follows:
-// dependency on it during compilation\n
-apiv("com.beust:jcommander")\n
... (116 more lines that didn't fit)
Run 'gradlew spotlessApply' to fix these violations.
It means \n files are not expected for Windows.
I'll leave the decision on the severity of that to the RM.
Vladimir
Re: [VOTE] Release apache-calcite-avatica-1.16.0 (release candidate 1)
https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.16.0-rc1/apache-calcite-avatica-1.16.0-src.tar.gz
does not build if Windows with default settings is used.
The error messages for "./gradlew build" are as follows:
-// dependency on it during compilation\n
-apiv("com.beust:jcommander")\n
... (116 more lines that didn't fit)
Run 'gradlew spotlessApply' to fix these violations.
It means \n files are not expected for Windows.
I'll leave the decision on the severity of that to the RM.
Vladimir
Re: [VOTE] Release apache-calcite-avatica-1.16.0 (release candidate 1)
Mac OS 10.15.2, jdk 1.8.0_181, Gradle 6.0.1 - checked that the git tag has the right commit. - run "./gradlew build -PskipSigning" in git repo successfully. - run "./gradlew clean build" in staged sources successfully. - verified the sha512 hash of apache-calcite-avatica-1.16.0-src.tar.gz by running "shasum -a512 apache-calcite-avatica-1.16.0-src.tar.gz" - checked staged Maven repository which looks good. - found the diff related to LICENSE and licenses/ and it's discussed above. Release notes contain more commits without Jira links compared to past several releases. Read those commits and seems like they are related to gradle migration/style fixes. +1 (non-binding) -Rui On Wed, Dec 11, 2019 at 2:20 PM Francis Chuang wrote: > Hi all, > > I have created a build for Apache Calcite Avatica 1.16.0, release > candidate 1. > > Thanks to everyone who has contributed to this release. > > You can read the release notes here: > > https://github.com/apache/calcite-avatica/blob/512bbee4aa24ef9fb8106d0286d1243679dce2d0/site/_docs/history.md > > The commit to be voted upon: > > https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=512bbee4aa24ef9fb8106d0286d1243679dce2d0 > > Its hash is 512bbee4aa24ef9fb8106d0286d1243679dce2d0 > > Tag: > > https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=tag;h=refs/tags/avatica-1.16.0-rc1 > > The artifacts to be voted on are located here: > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.16.0-rc1 > (revision 37181) > > The hashes of the artifacts are as follows: > > 102d3ab0e90dd1db5e012a966d265bdfa8a0f24f9016a4187a6e5f0135a14770da124493dd2c7a18c9d8d8b9af5ecf4f5aceb90d48421251f38bc6ce6f5be697 > *apache-calcite-avatica-1.16.0-src.tar.gz > > A staged Maven repository is available for review at: > > https://repository.apache.org/content/repositories/orgapachecalcite-1071/org/apache/calcite/ > > Release artifacts are signed with the following key: > https://people.apache.org/keys/committer/francischuang.asc > https://www.apache.org/dist/calcite/KEYS > > N.B. > To create the jars and test Apache Calcite Avatica: "./gradlew build > -PskipSigning". > > If you do not have a Java environment available, you can run the tests > using docker. To do so, install docker and docker-compose, then run > "docker-compose run test" from the root of the directory. > > Please vote on releasing this package as Apache Calcite Avatica 1.16.0. > > The vote is open for the next 72 hours and passes if a majority of at > least three +1 PMC votes are cast. > > [ ] +1 Release this package as Apache Calcite 1.16.0 > [ ] 0 I don't feel strongly about it, but I'm okay with the release > [ ] -1 Do not release this package because... > > > Here is my vote: > > +1 (binding) > > Francis >
Re: [VOTE] Release apache-calcite-avatica-1.16.0 (release candidate 1)
+1 (binding) * Check signatures and hashes * Checked src matches git hash - same comment about licenses as Stamtis * Checked build ran for git hash and src tar.gz * Checked Maven repo looks complete * Same comment as Stamatis about release notes being a bit rough to follow w/ all the commits. Kevin Risden On Mon, Dec 16, 2019 at 4:07 PM Francis Chuang wrote: > Hey everyone, > > Just a quick reminder that the vote for Avatica 1.16.0 rc1 is still open. > > Francis > > On 12/12/2019 9:20 am, Francis Chuang wrote: > > Hi all, > > > > I have created a build for Apache Calcite Avatica 1.16.0, release > > candidate 1. > > > > Thanks to everyone who has contributed to this release. > > > > You can read the release notes here: > > > https://github.com/apache/calcite-avatica/blob/512bbee4aa24ef9fb8106d0286d1243679dce2d0/site/_docs/history.md > > > > > > The commit to be voted upon: > > > https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=512bbee4aa24ef9fb8106d0286d1243679dce2d0 > > > > > > Its hash is 512bbee4aa24ef9fb8106d0286d1243679dce2d0 > > > > Tag: > > > https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=tag;h=refs/tags/avatica-1.16.0-rc1 > > > > > > The artifacts to be voted on are located here: > > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.16.0-rc1 > > > > (revision 37181) > > > > The hashes of the artifacts are as follows: > > > 102d3ab0e90dd1db5e012a966d265bdfa8a0f24f9016a4187a6e5f0135a14770da124493dd2c7a18c9d8d8b9af5ecf4f5aceb90d48421251f38bc6ce6f5be697 > > > > > *apache-calcite-avatica-1.16.0-src.tar.gz > > > > A staged Maven repository is available for review at: > > > https://repository.apache.org/content/repositories/orgapachecalcite-1071/org/apache/calcite/ > > > > > > Release artifacts are signed with the following key: > > https://people.apache.org/keys/committer/francischuang.asc > > https://www.apache.org/dist/calcite/KEYS > > > > N.B. > > To create the jars and test Apache Calcite Avatica: "./gradlew build > > -PskipSigning". > > > > If you do not have a Java environment available, you can run the tests > > using docker. To do so, install docker and docker-compose, then run > > "docker-compose run test" from the root of the directory. > > > > Please vote on releasing this package as Apache Calcite Avatica 1.16.0. > > > > The vote is open for the next 72 hours and passes if a majority of at > > least three +1 PMC votes are cast. > > > > [ ] +1 Release this package as Apache Calcite 1.16.0 > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > [ ] -1 Do not release this package because... > > > > > > Here is my vote: > > > > +1 (binding) > > > > Francis >
Re: [VOTE] Release apache-calcite-avatica-1.16.0 (release candidate 1)
Hey everyone, Just a quick reminder that the vote for Avatica 1.16.0 rc1 is still open. Francis On 12/12/2019 9:20 am, Francis Chuang wrote: Hi all, I have created a build for Apache Calcite Avatica 1.16.0, release candidate 1. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite-avatica/blob/512bbee4aa24ef9fb8106d0286d1243679dce2d0/site/_docs/history.md The commit to be voted upon: https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=512bbee4aa24ef9fb8106d0286d1243679dce2d0 Its hash is 512bbee4aa24ef9fb8106d0286d1243679dce2d0 Tag: https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=tag;h=refs/tags/avatica-1.16.0-rc1 The artifacts to be voted on are located here: https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.16.0-rc1 (revision 37181) The hashes of the artifacts are as follows: 102d3ab0e90dd1db5e012a966d265bdfa8a0f24f9016a4187a6e5f0135a14770da124493dd2c7a18c9d8d8b9af5ecf4f5aceb90d48421251f38bc6ce6f5be697 *apache-calcite-avatica-1.16.0-src.tar.gz A staged Maven repository is available for review at: https://repository.apache.org/content/repositories/orgapachecalcite-1071/org/apache/calcite/ Release artifacts are signed with the following key: https://people.apache.org/keys/committer/francischuang.asc https://www.apache.org/dist/calcite/KEYS N.B. To create the jars and test Apache Calcite Avatica: "./gradlew build -PskipSigning". If you do not have a Java environment available, you can run the tests using docker. To do so, install docker and docker-compose, then run "docker-compose run test" from the root of the directory. Please vote on releasing this package as Apache Calcite Avatica 1.16.0. The vote is open for the next 72 hours and passes if a majority of at least three +1 PMC votes are cast. [ ] +1 Release this package as Apache Calcite 1.16.0 [ ] 0 I don't feel strongly about it, but I'm okay with the release [ ] -1 Do not release this package because... Here is my vote: +1 (binding) Francis
Re: [VOTE] Release apache-calcite-avatica-1.16.0 (release candidate 1)
Ubuntu 18.04.3 LTS, jdk1.8.0_202, Gradle 6.0.1 * Checked signatures and checksums OK * Went over release note OK * Run build and tests (./gradlew clean build) on git repo OK * Run build and tests (./gradlew clean build) on staged sources OK * Run build and Calcite tests on Calcite current master (./gradlew clean build) with Avatica 1.16.0 OK * Run diff between staged sources and git commit (diff -qr apache-calcite-avatica-1.16.0-src ~/git/Apache/Avatica) ? Files apache-calcite-avatica-1.16.0-src/LICENSE and /home/zabetak/git/Apache/Avatica/LICENSE differ Only in apache-calcite-avatica-1.16.0-src: licenses Minor remarks: There seems to be some differences regarding the licenses between the git repo and the staged sources. It seems that this is intended but I though it is worth mentioning. The release note has the full history of commits as usual but there are quite a few messages who are not self-contained and easy to understand. In general, maybe it would be better if we removed these commits from the release notes. +1 (binding) On Wed, Dec 11, 2019 at 11:20 PM Francis Chuang wrote: > Hi all, > > I have created a build for Apache Calcite Avatica 1.16.0, release > candidate 1. > > Thanks to everyone who has contributed to this release. > > You can read the release notes here: > > https://github.com/apache/calcite-avatica/blob/512bbee4aa24ef9fb8106d0286d1243679dce2d0/site/_docs/history.md > > The commit to be voted upon: > > https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=512bbee4aa24ef9fb8106d0286d1243679dce2d0 > > Its hash is 512bbee4aa24ef9fb8106d0286d1243679dce2d0 > > Tag: > > https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=tag;h=refs/tags/avatica-1.16.0-rc1 > > The artifacts to be voted on are located here: > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.16.0-rc1 > (revision 37181) > > The hashes of the artifacts are as follows: > > 102d3ab0e90dd1db5e012a966d265bdfa8a0f24f9016a4187a6e5f0135a14770da124493dd2c7a18c9d8d8b9af5ecf4f5aceb90d48421251f38bc6ce6f5be697 > *apache-calcite-avatica-1.16.0-src.tar.gz > > A staged Maven repository is available for review at: > > https://repository.apache.org/content/repositories/orgapachecalcite-1071/org/apache/calcite/ > > Release artifacts are signed with the following key: > https://people.apache.org/keys/committer/francischuang.asc > https://www.apache.org/dist/calcite/KEYS > > N.B. > To create the jars and test Apache Calcite Avatica: "./gradlew build > -PskipSigning". > > If you do not have a Java environment available, you can run the tests > using docker. To do so, install docker and docker-compose, then run > "docker-compose run test" from the root of the directory. > > Please vote on releasing this package as Apache Calcite Avatica 1.16.0. > > The vote is open for the next 72 hours and passes if a majority of at > least three +1 PMC votes are cast. > > [ ] +1 Release this package as Apache Calcite 1.16.0 > [ ] 0 I don't feel strongly about it, but I'm okay with the release > [ ] -1 Do not release this package because... > > > Here is my vote: > > +1 (binding) > > Francis >
[VOTE] Release apache-calcite-avatica-1.16.0 (release candidate 1)
Hi all, I have created a build for Apache Calcite Avatica 1.16.0, release candidate 1. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite-avatica/blob/512bbee4aa24ef9fb8106d0286d1243679dce2d0/site/_docs/history.md The commit to be voted upon: https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=512bbee4aa24ef9fb8106d0286d1243679dce2d0 Its hash is 512bbee4aa24ef9fb8106d0286d1243679dce2d0 Tag: https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=tag;h=refs/tags/avatica-1.16.0-rc1 The artifacts to be voted on are located here: https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.16.0-rc1 (revision 37181) The hashes of the artifacts are as follows: 102d3ab0e90dd1db5e012a966d265bdfa8a0f24f9016a4187a6e5f0135a14770da124493dd2c7a18c9d8d8b9af5ecf4f5aceb90d48421251f38bc6ce6f5be697 *apache-calcite-avatica-1.16.0-src.tar.gz A staged Maven repository is available for review at: https://repository.apache.org/content/repositories/orgapachecalcite-1071/org/apache/calcite/ Release artifacts are signed with the following key: https://people.apache.org/keys/committer/francischuang.asc https://www.apache.org/dist/calcite/KEYS N.B. To create the jars and test Apache Calcite Avatica: "./gradlew build -PskipSigning". If you do not have a Java environment available, you can run the tests using docker. To do so, install docker and docker-compose, then run "docker-compose run test" from the root of the directory. Please vote on releasing this package as Apache Calcite Avatica 1.16.0. The vote is open for the next 72 hours and passes if a majority of at least three +1 PMC votes are cast. [ ] +1 Release this package as Apache Calcite 1.16.0 [ ] 0 I don't feel strongly about it, but I'm okay with the release [ ] -1 Do not release this package because... Here is my vote: +1 (binding) Francis
