Re: Performance degradation during query planning (vs Calcite 1.25)

2021-02-25 Thread JiaTao Tao
Well done, thanks Lgor.


Regards!

Aron Tao


Chunwei Lei  于2021年2月22日周一 上午11:15写道:

> Thank you for your work, Lgor.
>
> Would love to review the PR.
>
>
> Best,
> Chunwei
>
>
> On Fri, Feb 12, 2021 at 1:49 AM Igor Lozynskyi 
> wrote:
>
> > Hi Calcite community!
> >
> > Before the upcoming 1.27 release, in a downstream project, my team
> started
> > the migration procedure. We had to accommodate our code for SARGs
> changes,
> > but other than that, everything looks great. Out test suites are green,
> and
> > everything works like a charm. However, when compared with 1.25, Calcite
> > optimizes queries slower, especially queries with many Rels, especially
> > with many JOINs.
> >
> > Here, I described the essence of the issue:
> > https://issues.apache.org/jira/browse/CALCITE-4494.
> >
> > Fortunately, the potential fix is trivial:
> > https://github.com/apache/calcite/pull/2347.
> >
> > I am ready to assign the issue to myself. And it would be great if the PR
> > is reviewed and accepted (if no objections) before the 1.27 release.
> >
> > Thanks!
> >
>


Re: Performance degradation during query planning (vs Calcite 1.25)

2021-02-21 Thread Chunwei Lei
Thank you for your work, Lgor.

Would love to review the PR.


Best,
Chunwei


On Fri, Feb 12, 2021 at 1:49 AM Igor Lozynskyi 
wrote:

> Hi Calcite community!
>
> Before the upcoming 1.27 release, in a downstream project, my team started
> the migration procedure. We had to accommodate our code for SARGs changes,
> but other than that, everything looks great. Out test suites are green, and
> everything works like a charm. However, when compared with 1.25, Calcite
> optimizes queries slower, especially queries with many Rels, especially
> with many JOINs.
>
> Here, I described the essence of the issue:
> https://issues.apache.org/jira/browse/CALCITE-4494.
>
> Fortunately, the potential fix is trivial:
> https://github.com/apache/calcite/pull/2347.
>
> I am ready to assign the issue to myself. And it would be great if the PR
> is reviewed and accepted (if no objections) before the 1.27 release.
>
> Thanks!
>