Re: Would appreciate help with first PR
FYI, ServerTest.testTruncateTable() is a known unstable test[1]. [1] https://issues.apache.org/jira/browse/CALCITE-6048 Tanner Clary 于2023年11月2日周四 07:49写道: > > Hi Paul, > > Thanks for opening your first PR! I took a look and I think it might have > been a flaky failure, I believe that has happened to me in the past. I > approved the workflow run so we will see what happens with CI, I will try > to give the PR a review in the meantime :) Thanks again! > > Best, > Tanner > > On Wed, Nov 1, 2023 at 4:09 PM Paul Jackson > wrote: > > > I just created https://github.com/apache/calcite/pull/3495 for > > https://issues.apache.org/jira/browse/CALCITE-6044. It's my first PR. I'm > > getting what appears to be a code quality error or a test failure > > in ServerTest.testTruncateTable(), which passes when I run it locally. Any > > tips for where to look next? > > Thanks,-Paul -- Best, Benchao Li
Re: Would appreciate help with first PR
Hi Paul, Thanks for opening your first PR! I took a look and I think it might have been a flaky failure, I believe that has happened to me in the past. I approved the workflow run so we will see what happens with CI, I will try to give the PR a review in the meantime :) Thanks again! Best, Tanner On Wed, Nov 1, 2023 at 4:09 PM Paul Jackson wrote: > I just created https://github.com/apache/calcite/pull/3495 for > https://issues.apache.org/jira/browse/CALCITE-6044. It's my first PR. I'm > getting what appears to be a code quality error or a test failure > in ServerTest.testTruncateTable(), which passes when I run it locally. Any > tips for where to look next? > Thanks,-Paul
Would appreciate help with first PR
I just created https://github.com/apache/calcite/pull/3495 for https://issues.apache.org/jira/browse/CALCITE-6044. It's my first PR. I'm getting what appears to be a code quality error or a test failure in ServerTest.testTruncateTable(), which passes when I run it locally. Any tips for where to look next? Thanks,-Paul