Re: [heads-up] Re: camel-spring.xsd gets updated and new tag fails during start up
Hi Onder，
Can you share more detail information of the problem that you found?
Maybe we can help you review the design at the first place :)
Willem Jiang
Twitter: willemjiang
Weibo: 姜宁willem
On Thu, Jun 14, 2018 at 2:36 AM, Onder SEZGIN wrote:
> Hi Guys,
>
> Just a heads up.
> I found problems with the implementation so before moving ahead with XML
> DSL i reverted the changes.
> I will try to revisit.
> Four you information.
>
> Thanks.
>
> On Tue, Jun 12, 2018 at 9:53 AM Onder SEZGIN wrote:
>
> > Thanks Guys,
> >
> > @ Alex, I suspect the schema is wrong but as you and Willem mentioned
> jaxb
> > annotation definition may matter.
> >
> > @ Willem, i thought not putting required="true" makes it optional, maybe
> > making it optional as you mentioned and what i presumably did changes the
> > output of autogenerated xsd file and then it affects the xml dsl.
> >
> > I will try to go into deep.
> >
> >
> > On Tue, Jun 12, 2018 at 6:57 AM Willem Jiang
> > wrote:
> >
> >> I just have a quick look at the code, the schema is updated, but there
> are
> >> something wrong with the xml file.
> >> As the ThrottleDefinition is extends from ExpressionNode, but the first
> >> element of ExpressionNode is a reference of expression element, not
> >> the correlationExpression
> >> that you want.
> >> So you keep getting the complain message.
> >>
> >> Once I put the correlationExpression as the last element of throttle, I
> >> don't get the error message anymore. (but the test is freeze ).
> >>
> >>
> >>
> >>
> >> max
> >>
> >>
> >>
> >> 2
> >>
> >>
> >>
> >>
> >> We need to address the element order first to fix this issue.
> >>
> >> BTW, I also find an issue in the ThrottleDefinition, to support to old
> XML
> >> which has no correlationExpression, we need to specify the element as an
> >> optional one.
> >> Just like this :
> >>
> >> @XmlElements({
> >> @XmlElement(name = "correlationExpression", type =
> >> ExpressionSubElementDefinition.class)}
> >> )
> >> private ExpressionSubElementDefinition correlationExpression;
> >>
> >>
> >>
> >>
> >> Willem Jiang
> >>
> >> Twitter: willemjiang
> >> Weibo: 姜宁willem
> >>
> >> On Tue, Jun 12, 2018 at 5:23 AM, Alex Dettinger
> >> wrote:
> >>
> >> > Hi,
> >> >
> >> > I had a quick look and forced the resolution of the schema like
> this:
> >> > http://camel.apache.org/schema/spring
> >> > /home/aldettinger/.m2/repository/org/apache/camel/
> >> > camel-spring/2.22.0-SNAPSHOT/camel-spring-2.22.0-SNAPSHOT.xsd
> >> >
> >> > And hit the same issue then you. So I think that the last version of
> >> the
> >> > schema is loaded, but the schema would be wrong then.
> >> >
> >> > Hope this help,
> >> > Alex
> >> >
> >> > On Mon, Jun 11, 2018 at 5:12 PM, Onder SEZGIN
> >> > wrote:
> >> >
> >> > > Hi,
> >> > >
> >> > > please see the branch in this link.
> >> > > https://github.com/apache/camel/pull/2366#issuecomment-396193135
> >> > >
> >> > > or this one.
> >> > >
> >> > >
> >> https://github.com/onderson/camel/commit/ae63d64f627ec921c574059aadd1cf
> >> > > 894f5f3e2e
> >> > >
> >> > >
> >> > > On Mon, Jun 11, 2018 at 5:32 PM Willem Jiang <
> willem.ji...@gmail.com>
> >> > > wrote:
> >> > >
> >> > > > Where is your unit test?
> >> > > > Can you check if you are using the latest built camel-spring jar.
> >> > > > There is a schema definition in the camel-spring[1], please make
> >> sure
> >> > > the
> >> > > > new generated camel-spring.xsd is wrap into the camel-spring.jar
> >> > > >
> >> > > > [1]
> >> > > >
> >> > > > https://github.com/apache/camel/blob/master/components/
> >> > > camel-spring/src/main/resources/META-INF/spring.schemas
> >> > > >
> >> > > >
> >> > > > Willem Jiang
> >> > > >
> >> > > > Twitter: willemjiang
> >> > > > Weibo: 姜宁willem
> >> > > >
> >> > > > On Mon, Jun 11, 2018 at 9:11 PM, Onder SEZGIN
> >> > wrote:
> >> > > >
> >> > > > > i did try full build. it did not help in my case :/
> >> > > > >
> >> > > > > On Mon, Jun 11, 2018 at 12:23 PM Onder SEZGIN <
> >> ondersez...@gmail.com
> >> > >
> >> > > > > wrote:
> >> > > > >
> >> > > > > > no. because it may take very long on my pc.
> >> > > > > > I will try to check.
> >> > > > > >
> >> > > > > > On Mon, Jun 11, 2018 at 12:17 PM Andrea Cosentino
> >> > > > > > wrote:
> >> > > > > >
> >> > > > > >> Did you try a full rebuild?
> >> > > > > >>
> >> > > > > >> --
> >> > > > > >> Andrea Cosentino
> >> > > > > >> --
> >> > > > > >> Apache Camel PMC Chair
> >> > > > > >> Apache Karaf Committer
> >> > > > > >> Apache Servicemix PMC Member
> >> > > > > >> Email: ancosen1...@yahoo.com
> >> > > > > >> Twitter: @oscerd2
> >> > > > > >> Github: oscerd
> >> > > > > >>
> >> > > > > >>
> >> > > > > >>
> >> > > > > >>
> >> > > > > >>
> >> > > > > >>
> >> > > > > >> On Monday, June 11, 2018, 11:15:17 AM GMT+2, Onder SEZGIN <
> >> > > > > >> ond...@apache.org> wrote:
> >> > > > > >>
> >> > > > > >>
> >> > > > > >>
> >> > > > > >>
> >> > > > >
[heads-up] Re: camel-spring.xsd gets updated and new tag fails during start up
Hi Guys,
Just a heads up.
I found problems with the implementation so before moving ahead with XML
DSL i reverted the changes.
I will try to revisit.
Four you information.
Thanks.
On Tue, Jun 12, 2018 at 9:53 AM Onder SEZGIN wrote:
> Thanks Guys,
>
> @ Alex, I suspect the schema is wrong but as you and Willem mentioned jaxb
> annotation definition may matter.
>
> @ Willem, i thought not putting required="true" makes it optional, maybe
> making it optional as you mentioned and what i presumably did changes the
> output of autogenerated xsd file and then it affects the xml dsl.
>
> I will try to go into deep.
>
>
> On Tue, Jun 12, 2018 at 6:57 AM Willem Jiang
> wrote:
>
>> I just have a quick look at the code, the schema is updated, but there are
>> something wrong with the xml file.
>> As the ThrottleDefinition is extends from ExpressionNode, but the first
>> element of ExpressionNode is a reference of expression element, not
>> the correlationExpression
>> that you want.
>> So you keep getting the complain message.
>>
>> Once I put the correlationExpression as the last element of throttle, I
>> don't get the error message anymore. (but the test is freeze ).
>>
>>
>>
>>
>> max
>>
>>
>>
>> 2
>>
>>
>>
>>
>> We need to address the element order first to fix this issue.
>>
>> BTW, I also find an issue in the ThrottleDefinition, to support to old XML
>> which has no correlationExpression, we need to specify the element as an
>> optional one.
>> Just like this :
>>
>> @XmlElements({
>> @XmlElement(name = "correlationExpression", type =
>> ExpressionSubElementDefinition.class)}
>> )
>> private ExpressionSubElementDefinition correlationExpression;
>>
>>
>>
>>
>> Willem Jiang
>>
>> Twitter: willemjiang
>> Weibo: 姜宁willem
>>
>> On Tue, Jun 12, 2018 at 5:23 AM, Alex Dettinger
>> wrote:
>>
>> > Hi,
>> >
>> > I had a quick look and forced the resolution of the schema like this:
>> > http://camel.apache.org/schema/spring
>> > /home/aldettinger/.m2/repository/org/apache/camel/
>> > camel-spring/2.22.0-SNAPSHOT/camel-spring-2.22.0-SNAPSHOT.xsd
>> >
>> > And hit the same issue then you. So I think that the last version of
>> the
>> > schema is loaded, but the schema would be wrong then.
>> >
>> > Hope this help,
>> > Alex
>> >
>> > On Mon, Jun 11, 2018 at 5:12 PM, Onder SEZGIN
>> > wrote:
>> >
>> > > Hi,
>> > >
>> > > please see the branch in this link.
>> > > https://github.com/apache/camel/pull/2366#issuecomment-396193135
>> > >
>> > > or this one.
>> > >
>> > >
>> https://github.com/onderson/camel/commit/ae63d64f627ec921c574059aadd1cf
>> > > 894f5f3e2e
>> > >
>> > >
>> > > On Mon, Jun 11, 2018 at 5:32 PM Willem Jiang
>> > > wrote:
>> > >
>> > > > Where is your unit test?
>> > > > Can you check if you are using the latest built camel-spring jar.
>> > > > There is a schema definition in the camel-spring[1], please make
>> sure
>> > > the
>> > > > new generated camel-spring.xsd is wrap into the camel-spring.jar
>> > > >
>> > > > [1]
>> > > >
>> > > > https://github.com/apache/camel/blob/master/components/
>> > > camel-spring/src/main/resources/META-INF/spring.schemas
>> > > >
>> > > >
>> > > > Willem Jiang
>> > > >
>> > > > Twitter: willemjiang
>> > > > Weibo: 姜宁willem
>> > > >
>> > > > On Mon, Jun 11, 2018 at 9:11 PM, Onder SEZGIN
>> > wrote:
>> > > >
>> > > > > i did try full build. it did not help in my case :/
>> > > > >
>> > > > > On Mon, Jun 11, 2018 at 12:23 PM Onder SEZGIN <
>> ondersez...@gmail.com
>> > >
>> > > > > wrote:
>> > > > >
>> > > > > > no. because it may take very long on my pc.
>> > > > > > I will try to check.
>> > > > > >
>> > > > > > On Mon, Jun 11, 2018 at 12:17 PM Andrea Cosentino
>> > > > > > wrote:
>> > > > > >
>> > > > > >> Did you try a full rebuild?
>> > > > > >>
>> > > > > >> --
>> > > > > >> Andrea Cosentino
>> > > > > >> --
>> > > > > >> Apache Camel PMC Chair
>> > > > > >> Apache Karaf Committer
>> > > > > >> Apache Servicemix PMC Member
>> > > > > >> Email: ancosen1...@yahoo.com
>> > > > > >> Twitter: @oscerd2
>> > > > > >> Github: oscerd
>> > > > > >>
>> > > > > >>
>> > > > > >>
>> > > > > >>
>> > > > > >>
>> > > > > >>
>> > > > > >> On Monday, June 11, 2018, 11:15:17 AM GMT+2, Onder SEZGIN <
>> > > > > >> ond...@apache.org> wrote:
>> > > > > >>
>> > > > > >>
>> > > > > >>
>> > > > > >>
>> > > > > >>
>> > > > > >> Hi Guys,
>> > > > > >>
>> > > > > >> I've recently implemented CAMEL-6840 and new xml element is
>> > > introduced
>> > > > > as
>> > > > > >> a
>> > > > > >> result of it.
>> > > > > >> I am trying to create a unit test for it under camel-spring to
>> see
>> > > if
>> > > > > the
>> > > > > >> new element is fine in XML DSL.
>> > > > > >> and i have this simple xml route.
>> > > > > >>
>> > > > > >> http://camel.apache.org/schema/spring;>
>> > > > > >> > > > > > >> type="DeadLetterChannel"/>
>> > > > > >>
>> > > > > >>
>> > > > > >>
>> > > > > >>
>> >
Re: [PROPOSAL] Setting up an official ASF swag store
Hello, I'm a committer and a PMC member of Apache Camel project. I've made a handful of Apache Camel branded T-shirts that I gave to my colleagues and I'll also give away some tomorrow at EU Roadshow. Having been contacted by a community member wishing to purchase these and never intending to become a t-shirt vendor prompted me to approach Mark and Rich at EU Roadshow and they pointed me to this this discussion. I saw the page listing existing vendors that offer ASF branded goods[1], and I would like to collaborate with someone to get some Camel branded swag into an official ASF store. How would I go about doing that? thanks :) zoran [1] https://www.apache.org/foundation/buy_stuff.html On 2018/03/04 20:19:59, Mark Thomas wrote: > Hi, > > I'd like to propose setting up an official ASF swag store. I recently > came across RedBubble [1] who produce stuff through geographically > distributed agents so the post costs remain reasonable world-wide. > > My thinking is to do this with the logos for as many ASF projects as > possible and for as many of the products that RedBubble offer as possible. > > These are the prices[2], excluding shipping and mark-up. The standard > mark-up is 20% which I propose we use with all of this being passed to > the ASF. > > The plan, assuming there is general support, would be: > > - Set up the account and figure out all the admin side of things > - Pick a project to start with to test things out > - Email all PMCs to > - inform them of the store > - ask them to add a link to it on their web-sites > - ask them to provide logo(s) in suitable resolutions > - Upload logos for those PMCs that provide them > - Work through the logos for the PMCs that don't in slower time > > I need to run this past a few other folks as well. My intention is to > point them to this thread and ask for feedback. > > I don't intend this to replace any stores committers, PMCs, community > members etc. are currently running. I view it more as a way of providing > a default selection of swag for as many projects as possible. > > Thoughts? Feedback? > > Cheers, > > Mark > > > > [1] https://www.redbubble.com/ > []2 https://help.redbubble.com/hc/en-us/articles/206409096 > -- Zoran Regvart
[GitHub] camel pull request #2373: Updates to latest zipkin, eliminating SpanCollecto...
GitHub user adriancole opened a pull request: https://github.com/apache/camel/pull/2373 Updates to latest zipkin, eliminating SpanCollector dependency This reduces the effort of renovating the zipkin component by reducing the apis used to send data to Zipkin. You can merge this pull request into a Git repository by running: $ git pull https://github.com/adriancole/camel zipkin-latest Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/2373.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2373 commit 1960b97429f2794bf8f46de4620383f2bf7c8b77 Author: Adrian Cole Date: 2018-06-13T08:27:54Z Updates to latest zipkin, eliminating SpanCollector dependency This reduces the effort of renovating the zipkin component by reducing the apis used to send data to Zipkin. ---
[GitHub] camel pull request #1996: CAMEL-11879: Upgraded lucene version to 7.0.0
Github user oscerd closed the pull request at: https://github.com/apache/camel/pull/1996 ---
[GitHub] camel pull request #2372: CAMEL-12573: Fixing class cast exception
Github user oscerd closed the pull request at: https://github.com/apache/camel/pull/2372 ---
