Re: Fwd: Apache Camel branded Swag!
Wow, that was fast. Thanks On Thu, 14 Jun 2018 at 19:59, Zoran Regvart wrote: > Hi Andrea, > I wanted to make the t-shirt as simple as possible and I didn't want > to take too much of Marks time, I'm sure that Mark is open to > arranging the making the other design available as well :) > > zoran > > On Thu, Jun 14, 2018 at 2:32 PM, Andrea Cosentino > wrote: > > Thanks a lot for this nice work Zoran and Mark! :-) > > > > I'm not sure but maybe we can also the t-shirt I created a while ago, it > is using the other kind of logo > > > > -- > > Andrea Cosentino > > -- > > Apache Camel PMC Chair > > Apache Karaf Committer > > Apache Servicemix PMC Member > > Email: ancosen1...@yahoo.com > > Twitter: @oscerd2 > > Github: oscerd > > > > > > > > > > > > > > On Thursday, June 14, 2018, 2:29:37 PM GMT+2, Zoran Regvart < > zo...@regvart.com> wrote: > > > > > > > > > > > > Hi Mark, > > thank you for taking the time to make this happen, I hope for that > > Camel duvet keeps a lot of people warm and comfortable ;) > > > > zoran > > > > -- Forwarded message -- > > From: Zoran Regvart > > Date: Thu, Jun 14, 2018 at 2:26 PM > > Subject: Apache Camel branded Swag! > > To: us...@camel.apache.org, dev@camel.apache.org > > > > > > Hi Cameleers, > > with great joy I'm happy to announce that Camel branded swag: > > T-Shirts, Cases, Posters, Mugs, Notebooks and a whole lot more, is > > available at the official Apache Software Foundation store at > > Redbubble. > > > > Peruse it here: > > > > > https://www.redbubble.com/people/comdev/works/32232604-apache-camel?asc=u > > > > From any purchases you make a percentage goes as a donation to the ASF. > > > > zoran > > -- > > Zoran Regvart > > > > > > -- > > Zoran Regvart > > > > -- > Zoran Regvart >
[GitHub] camel pull request #2376: CAMEL-6840 - add grouped throttling feature, XML D...
GitHub user onderson opened a pull request: https://github.com/apache/camel/pull/2376 CAMEL-6840 - add grouped throttling feature, XML DSL is not working p⦠â¦roperly so it is WIP for and now checking it in as Ignored test case For now unit test in camel-spring is ignored. I think i need help with it. fyi. @davsclaus , @WillemJiang , @oscerd and @aldettinger You can merge this pull request into a Git repository by running: $ git pull https://github.com/onderson/camel CAMEL-6840_jdsl Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/2376.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2376 commit 31ecb1702d24d182c45e56ee72a4cfd2ba29b07c Author: Sezgin Date: 2018-06-14T17:26:59Z CAMEL-6840 - add grouped throttling feature, XML DSL is not working properly so it is WIP for and now checking it in as Ignored test case ---
Re: Fwd: Apache Camel branded Swag!
Hi Andrea, I wanted to make the t-shirt as simple as possible and I didn't want to take too much of Marks time, I'm sure that Mark is open to arranging the making the other design available as well :) zoran On Thu, Jun 14, 2018 at 2:32 PM, Andrea Cosentino wrote: > Thanks a lot for this nice work Zoran and Mark! :-) > > I'm not sure but maybe we can also the t-shirt I created a while ago, it is > using the other kind of logo > > -- > Andrea Cosentino > -- > Apache Camel PMC Chair > Apache Karaf Committer > Apache Servicemix PMC Member > Email: ancosen1...@yahoo.com > Twitter: @oscerd2 > Github: oscerd > > > > > > > On Thursday, June 14, 2018, 2:29:37 PM GMT+2, Zoran Regvart > wrote: > > > > > > Hi Mark, > thank you for taking the time to make this happen, I hope for that > Camel duvet keeps a lot of people warm and comfortable ;) > > zoran > > -- Forwarded message -- > From: Zoran Regvart > Date: Thu, Jun 14, 2018 at 2:26 PM > Subject: Apache Camel branded Swag! > To: us...@camel.apache.org, dev@camel.apache.org > > > Hi Cameleers, > with great joy I'm happy to announce that Camel branded swag: > T-Shirts, Cases, Posters, Mugs, Notebooks and a whole lot more, is > available at the official Apache Software Foundation store at > Redbubble. > > Peruse it here: > > https://www.redbubble.com/people/comdev/works/32232604-apache-camel?asc=u > > From any purchases you make a percentage goes as a donation to the ASF. > > zoran > -- > Zoran Regvart > > > -- > Zoran Regvart -- Zoran Regvart
Re: Fwd: Apache Camel branded Swag!
Thanks a lot for this nice work Zoran and Mark! :-) I'm not sure but maybe we can also the t-shirt I created a while ago, it is using the other kind of logo -- Andrea Cosentino -- Apache Camel PMC Chair Apache Karaf Committer Apache Servicemix PMC Member Email: ancosen1...@yahoo.com Twitter: @oscerd2 Github: oscerd On Thursday, June 14, 2018, 2:29:37 PM GMT+2, Zoran Regvart wrote: Hi Mark, thank you for taking the time to make this happen, I hope for that Camel duvet keeps a lot of people warm and comfortable ;) zoran -- Forwarded message -- From: Zoran Regvart Date: Thu, Jun 14, 2018 at 2:26 PM Subject: Apache Camel branded Swag! To: us...@camel.apache.org, dev@camel.apache.org Hi Cameleers, with great joy I'm happy to announce that Camel branded swag: T-Shirts, Cases, Posters, Mugs, Notebooks and a whole lot more, is available at the official Apache Software Foundation store at Redbubble. Peruse it here: https://www.redbubble.com/people/comdev/works/32232604-apache-camel?asc=u >From any purchases you make a percentage goes as a donation to the ASF. zoran -- Zoran Regvart -- Zoran Regvart
Fwd: Apache Camel branded Swag!
Hi Mark, thank you for taking the time to make this happen, I hope for that Camel duvet keeps a lot of people warm and comfortable ;) zoran -- Forwarded message -- From: Zoran Regvart Date: Thu, Jun 14, 2018 at 2:26 PM Subject: Apache Camel branded Swag! To: us...@camel.apache.org, dev@camel.apache.org Hi Cameleers, with great joy I'm happy to announce that Camel branded swag: T-Shirts, Cases, Posters, Mugs, Notebooks and a whole lot more, is available at the official Apache Software Foundation store at Redbubble. Peruse it here: https://www.redbubble.com/people/comdev/works/32232604-apache-camel?asc=u >From any purchases you make a percentage goes as a donation to the ASF. zoran -- Zoran Regvart -- Zoran Regvart
Apache Camel branded Swag!
Hi Cameleers, with great joy I'm happy to announce that Camel branded swag: T-Shirts, Cases, Posters, Mugs, Notebooks and a whole lot more, is available at the official Apache Software Foundation store at Redbubble. Peruse it here: https://www.redbubble.com/people/comdev/works/32232604-apache-camel?asc=u >From any purchases you make a percentage goes as a donation to the ASF. zoran -- Zoran Regvart
[GitHub] camel pull request #2375: CAMEL-6840- New PR for grouped throttling - Java D...
Github user onderson closed the pull request at: https://github.com/apache/camel/pull/2375 ---
[GitHub] camel pull request #2375: CAMEL-6840- New PR for grouped throttling - Java D...
GitHub user onderson opened a pull request: https://github.com/apache/camel/pull/2375 CAMEL-6840- New PR for grouped throttling - Java DSL, XML DSL is WIP. For now unit test in camel-spring is ignored. I think i need help with it. fyi. @davsclaus , @WillemJiang , @oscerd and @aldettinger You can merge this pull request into a Git repository by running: $ git pull https://github.com/onderson/camel CAMEL-6840_javadsl Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/2375.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2375 commit e76026194766f344796e67b3db1372b6822aed30 Author: onders86 Date: 2018-06-09T22:31:45Z CAMEL-6840- New PR for grouped throttling - Java DSL, XML DSL is WIP commit 9af7aa167972b54e6bae3cee36d15e640b048749 Author: Sezgin Date: 2018-06-14T11:30:13Z CAMEL-6840 ignore xml dsl test WIP ---
[GitHub] camel pull request #2374: CAMEL-12577: Re-apply CAMEL-12104 Unintuitive defa...
GitHub user ppalaga opened a pull request: https://github.com/apache/camel/pull/2374 CAMEL-12577: Re-apply CAMEL-12104 Unintuitive default cxf timeout behavior You can merge this pull request into a Git repository by running: $ git pull https://github.com/ppalaga/camel CAMEL-12577 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/2374.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2374 commit ebbf89550078b4f99f30804c89296a0e56612c57 Author: Peter Palaga Date: 2018-06-14T09:32:16Z CAMEL-12577: Re-apply CAMEL-12104 Unintuitive default cxf timeout behavior ---
Re: [heads-up] Re: camel-spring.xsd gets updated and new tag fails during start up
Hi,
Sure no problem.
As there was no grouping of Delay queues and there was only one single
DelayQueue in Throttler implementation.
My initial thought was simple to group them in ConcurrentHashMap or
LRUCache according to the expression provided in an expression with this
way.
from("myendpoint")
.throttle(groupIdExpression, maxRequestPerPeriodExpression)
GroupId expression is what i called correlationExpression which has similar
naming aggregate pattern. (You know naming is hard.)
So afterwards, in the implementation i replaced single queue with Map of
Queues to retreieve from or place the items in it considering the grouping
expression.
(PS: In the code i checked and i found a problem that the order of
parameters are placed wrongly in ProcessorDefinition[1][2] to create an
instance of ThrottlerDefinition. This was making single
correlationExpression which works ok as already(before reverting) in unit
tests but after i reliazed and fixed that problem to provide right order
and correlationExpression started to be varing in values as intented and
unit tests failed and then i realised there was an initial design mistake i
was caught up.. Thanks to unit testing :) )
So as i mentioned in the side note, if we have map of delay queues and if
that map has only one delay queue, we don't know the result of what i have
done.
if correlationExpresssion varies then the problem arises, and there was
another mistake, i did, which was to see throttleRate[3] was single
volatile member of Throttler and dependent on Delay Queue. And i also need
to make it as map. (which was not existing in implementation i checked-in.
So as you can guess, at some point after realizing what i have done, i felt
like what i checked-in was rubbish so i reverted to rethink on it.)
So let's say i did make throttleRate into throttleRatesMap to save
DelayQueue's rates(for now we can assume all delay queues throttleRate is
the same as we don't have such throttleRatesMap), there is another issue
which is the initialization of delay queue. (in my case it will be queues
becuase you know i was thinking of having group of queues stored in map)
Originally Queues are initialized with permits depending on the initial
throttle rate. This is not an issue if you have a single queue. but if you
want to have multiple queues stored and grouped in a map (as i tried to
do), considering the existing implementation approach all the queues needs
to initialised in the same way. However, it is not very hard to do so
throttleRatesMap will serve for that. (I had figured it out while writing..)
I will open the PR soon so you can review.
Any feedback is welcome.
[1]
https://github.com/onderson/camel/blob/CAMEL-6840/camel-core/src/main/java/org/apache/camel/model/ProcessorDefinition.java#L2304
[2]
https://github.com/onderson/camel/blob/CAMEL-6840/camel-core/src/main/java/org/apache/camel/model/ProcessorDefinition.java#L2325
[3]
https://github.com/onderson/camel/blob/CAMEL-6840/camel-core/src/main/java/org/apache/camel/processor/Throttler.java#L83
On Thu, Jun 14, 2018 at 1:51 AM Willem Jiang wrote:
> Hi Onder，
>
> Can you share more detail information of the problem that you found?
> Maybe we can help you review the design at the first place :)
>
>
> Willem Jiang
>
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Thu, Jun 14, 2018 at 2:36 AM, Onder SEZGIN wrote:
>
> > Hi Guys,
> >
> > Just a heads up.
> > I found problems with the implementation so before moving ahead with XML
> > DSL i reverted the changes.
> > I will try to revisit.
> > Four you information.
> >
> > Thanks.
> >
> > On Tue, Jun 12, 2018 at 9:53 AM Onder SEZGIN wrote:
> >
> > > Thanks Guys,
> > >
> > > @ Alex, I suspect the schema is wrong but as you and Willem mentioned
> > jaxb
> > > annotation definition may matter.
> > >
> > > @ Willem, i thought not putting required="true" makes it optional,
> maybe
> > > making it optional as you mentioned and what i presumably did changes
> the
> > > output of autogenerated xsd file and then it affects the xml dsl.
> > >
> > > I will try to go into deep.
> > >
> > >
> > > On Tue, Jun 12, 2018 at 6:57 AM Willem Jiang
> > > wrote:
> > >
> > >> I just have a quick look at the code, the schema is updated, but there
> > are
> > >> something wrong with the xml file.
> > >> As the ThrottleDefinition is extends from ExpressionNode, but the
> first
> > >> element of ExpressionNode is a reference of expression element, not
> > >> the correlationExpression
> > >> that you want.
> > >> So you keep getting the complain message.
> > >>
> > >> Once I put the correlationExpression as the last element of throttle,
> I
> > >> don't get the error message anymore. (but the test is freeze ).
> > >>
> > >>
> > >>
> > >>
> > >> max
> > >>
> > >>
> > >>
> > >> 2
> > >>
> > >>
> > >>
> > >>
> > >> We need to address the element order first to fix this issue.
> > >>
> > >> BTW, I also find an issue in the ThrottleDefinition, to
