[GitHub] [camel-quarkus] oscerd merged pull request #200: improve the paho integration test
oscerd merged pull request #200: improve the paho integration test URL: https://github.com/apache/camel-quarkus/pull/200 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #200: improve the paho integration test
asf-ci commented on issue #200: improve the paho integration test URL: https://github.com/apache/camel-quarkus/pull/200#issuecomment-530642232 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/154/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] zhfeng commented on issue #200: improve the paho integration test
zhfeng commented on issue #200: improve the paho integration test URL: https://github.com/apache/camel-quarkus/pull/200#issuecomment-530629972 @ppalaga I make some changes to improve the paho test to check the message after publishing to the queue. Can you take a look ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] zhfeng opened a new pull request #200: improve the paho integration test
zhfeng opened a new pull request #200: improve the paho integration test URL: https://github.com/apache/camel-quarkus/pull/200 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #199: Camel jira
asf-ci commented on issue #199: Camel jira URL: https://github.com/apache/camel-quarkus/pull/199#issuecomment-530603827 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/153/Build result: FAILURE[...truncated 685.14 KB...]at java.lang.reflect.Method.invoke (Method.java:498)at hudson.maven.Maven3Builder.call (Maven3Builder.java:139)at hudson.maven.Maven3Builder.call (Maven3Builder.java:70)at hudson.remoting.UserRequest.perform (UserRequest.java:212)at hudson.remoting.UserRequest.perform (UserRequest.java:54)at hudson.remoting.Request$2.run (Request.java:369)at hudson.remoting.InterceptingExecutorService$1.call (InterceptingExecutorService.java:72)at java.util.concurrent.FutureTask.run (FutureTask.java:266)at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1149)at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:624)at java.lang.Thread.run (Thread.java:748)[ERROR] [ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn -rf :camel-quarkus-integration-test-jirachannel stoppedAdding one-line test results to commit status...Setting status of e196cc4966863e5cba0c46c3af59df74ed9bffe3 to FAILURE with url https://builds.apache.org/job/camel-quarkus-pr/153/ and message: 'FAILURE 73 tests run, 2 skipped, 0 failed.'Using context: default This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ffang opened a new pull request #199: Camel jira
ffang opened a new pull request #199: Camel jira URL: https://github.com/apache/camel-quarkus/pull/199 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli opened a new issue #198: Remove support for RuntimeValue from registry
lburgazzoli opened a new issue #198: Remove support for RuntimeValue from registry URL: https://github.com/apache/camel-quarkus/issues/198 It does not seem we do store instances wrapped by a RuntimeValue in the registry any more so it may be possible to thing to simplify the registry and leverage the "bean repository" concept we have in Camel, something like: repository = new ArCBeanRepository(); registry = new DefaultRegistry(repository); This would reduce the maintenance costs as i.e. https://issues.apache.org/jira/projects/CAMEL/issues/CAMEL-13948 would not need to be implemented in bot Camel and Camel Quarkus. //cc @gnodet This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] weimeilin79 opened a new issue #933: Error after cluster restart
weimeilin79 opened a new issue #933: Error after cluster restart URL: https://github.com/apache/camel-k/issues/933 Error appears when cluster restarts. CRD missing.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] oscerd merged pull request #139: yaml-loader: support route definition
oscerd merged pull request #139: yaml-loader: support route definition URL: https://github.com/apache/camel-k-runtime/pull/139 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] oscerd merged pull request #140: fix(catalog): Declare the webhook component as an HTTP component
oscerd merged pull request #140: fix(catalog): Declare the webhook component as an HTTP component URL: https://github.com/apache/camel-k-runtime/pull/140 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] astefanutti opened a new pull request #140: fix(catalog): Declare the webhook component as an HTTP component
astefanutti opened a new pull request #140: fix(catalog): Declare the webhook component as an HTTP component URL: https://github.com/apache/camel-k-runtime/pull/140 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #189: Make xml and jaxb disabled by default and opt-in when depending on camel
asf-ci commented on issue #189: Make xml and jaxb disabled by default and opt-in when depending on camel URL: https://github.com/apache/camel-quarkus/pull/189#issuecomment-530440360 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/152/Build result: FAILURE[...truncated 1.04 MB...]at java.lang.reflect.Method.invoke (Method.java:498)at hudson.maven.Maven3Builder.call (Maven3Builder.java:139)at hudson.maven.Maven3Builder.call (Maven3Builder.java:70)at hudson.remoting.UserRequest.perform (UserRequest.java:212)at hudson.remoting.UserRequest.perform (UserRequest.java:54)at hudson.remoting.Request$2.run (Request.java:369)at hudson.remoting.InterceptingExecutorService$1.call (InterceptingExecutorService.java:72)at java.util.concurrent.FutureTask.run (FutureTask.java:266)at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1149)at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:624)at java.lang.Thread.run (Thread.java:748)[ERROR] [ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn -rf :camel-quarkus-integration-test-corechannel stoppedAdding one-line test results to commit status...Setting status of bb9540e938b826ded46fdf7213b19752f0f19615 to FAILURE with url https://builds.apache.org/job/camel-quarkus-pr/152/ and message: 'FAILURE 39 tests run, 1 skipped, 0 failed.'Using context: default This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] lburgazzoli commented on issue #138: #137 Add the error log when setting component property failed
lburgazzoli commented on issue #138: #137 Add the error log when setting component property failed URL: https://github.com/apache/camel-k-runtime/pull/138#issuecomment-530423380 thinking a little bit more about this we may throw something like new PropertyBindingException(this.component, name, "") as the Missing*Exception have some special meaning so they are not propagated This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #189: Make xml and jaxb disabled by default and opt-in when depending on camel
asf-ci commented on issue #189: Make xml and jaxb disabled by default and opt-in when depending on camel URL: https://github.com/apache/camel-quarkus/pull/189#issuecomment-530421254 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/151/Build result: FAILURE[...truncated 1009.17 KB...]at java.lang.reflect.Method.invoke (Method.java:498)at hudson.maven.Maven3Builder.call (Maven3Builder.java:139)at hudson.maven.Maven3Builder.call (Maven3Builder.java:70)at hudson.remoting.UserRequest.perform (UserRequest.java:212)at hudson.remoting.UserRequest.perform (UserRequest.java:54)at hudson.remoting.Request$2.run (Request.java:369)at hudson.remoting.InterceptingExecutorService$1.call (InterceptingExecutorService.java:72)at java.util.concurrent.FutureTask.run (FutureTask.java:266)at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1149)at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:624)at java.lang.Thread.run (Thread.java:748)[ERROR] [ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn -rf :camel-quarkus-integration-test-corechannel stoppedAdding one-line test results to commit status...Setting status of ac650a1f106c2aa8caec66528c0bbd6f2a039eb7 to FAILURE with url https://builds.apache.org/job/camel-quarkus-pr/151/ and message: 'FAILURE 38 tests run, 1 skipped, 0 failed.'Using context: default This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #189: Make xml and jaxb disabled by default and opt-in when depending on camel
lburgazzoli commented on a change in pull request #189: Make xml and jaxb
disabled by default and opt-in when depending on camel
URL: https://github.com/apache/camel-quarkus/pull/189#discussion_r323281846
##
File path:
extensions/core/runtime/src/main/java/org/apache/camel/quarkus/core/runtime/support/FastModel.java
##
@@ -46,6 +47,16 @@ public FastModel(CamelContext camelContext) {
super(camelContext);
}
+@Override
+public void addRouteDefinitions(InputStream is) throws Exception {
+throw new UnsupportedOperationException();
+}
+
+@Override
+public void addRestDefinitions(InputStream is, boolean addToRoutes) throws
Exception {
+throw new UnsupportedOperationException();
+}
Review comment:
Maybe we can remove those two methods from Model's interface in RC2 and
re-factorize them as helpers ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #189: Make xml and jaxb disabled by default and opt-in when depending on camel
lburgazzoli commented on a change in pull request #189: Make xml and jaxb
disabled by default and opt-in when depending on camel
URL: https://github.com/apache/camel-quarkus/pull/189#discussion_r323278960
##
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java
##
@@ -70,10 +73,17 @@
CamelRuntimeBuildItem create(
CamelRecorder recorder,
List registryItems,
+List contexts,
BuildProducer runtimeBeans) {
+Supplier contextSupplier;
+if (contexts.size() == 0) {
+contextSupplier = new FastCamelContextSupplier();
+} else {
+contextSupplier = contexts.get(0).getContext();
+}
Review comment:
As the list is used as a "feature toggle", we may need to throw an exception
in case of contexts > 1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #189: Make xml and jaxb disabled by default and opt-in when depending on camel
lburgazzoli commented on a change in pull request #189: Make xml and jaxb
disabled by default and opt-in when depending on camel
URL: https://github.com/apache/camel-quarkus/pull/189#discussion_r323278960
##
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java
##
@@ -70,10 +73,17 @@
CamelRuntimeBuildItem create(
CamelRecorder recorder,
List registryItems,
+List contexts,
BuildProducer runtimeBeans) {
+Supplier contextSupplier;
+if (contexts.size() == 0) {
+contextSupplier = new FastCamelContextSupplier();
+} else {
+contextSupplier = contexts.get(0).getContext();
+}
Review comment:
We may need to throw an exception in case of contexts > 1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] oscerd merged pull request #86: CAMEL-13916: add 'Camel 3 Migration Guide' to navigation
oscerd merged pull request #86: CAMEL-13916: add 'Camel 3 Migration Guide' to navigation URL: https://github.com/apache/camel-website/pull/86 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] WillemJiang commented on issue #138: #137 Add the error log when setting component property failed
WillemJiang commented on issue #138: #137 Add the error log when setting component property failed URL: https://github.com/apache/camel-k-runtime/pull/138#issuecomment-530386826 @lburgazzoli Could you merge the code? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-website] alexkieling opened a new pull request #86: CAMEL-13916: add 'Camel 3 Migration Guide' to navigation
alexkieling opened a new pull request #86: CAMEL-13916: add 'Camel 3 Migration Guide' to navigation URL: https://github.com/apache/camel-website/pull/86 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] asifdxtreme commented on issue #923: Camel-K build fails with error: open /workspace/builder-656588331/package/context/Dockerfile: no such file or directory
asifdxtreme commented on issue #923: Camel-K build fails with error: open /workspace/builder-656588331/package/context/Dockerfile: no such file or directory URL: https://github.com/apache/camel-k/issues/923#issuecomment-530351441 Even I am facing the same issue when running multiple integrations parallely with similar set of dependencies. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] emmanuelbernard commented on issue #190: Be listed in code.quarkus.io
emmanuelbernard commented on issue #190: Be listed in code.quarkus.io URL: https://github.com/apache/camel-quarkus/issues/190#issuecomment-530338841 Note that there are a few sources today unfortunately: - the extensions.json list that is consumed by the CLI - the extension and category file that is hosted in code.q.io that also need to be updated - the bom file which needs to reference the Camel extensions So it's not jsut a code.quarkus.io change unfortunately This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] asifdxtreme commented on a change in pull request #922: fix: Add option to disable Kaniko cache warming
asifdxtreme commented on a change in pull request #922: fix: Add option to
disable Kaniko cache warming
URL: https://github.com/apache/camel-k/pull/922#discussion_r323183498
##
File path: pkg/controller/integrationplatform/initialize.go
##
@@ -137,7 +137,7 @@ func (action *initializeAction) Handle(ctx
context.Context, platform *v1alpha1.I
}
// Check if the operator is running in the same namespace
before starting the cache warmer
- if platform.Namespace == platformutil.GetOperatorNamespace() {
+ if platform.Namespace == platformutil.GetOperatorNamespace() &&
platform.Spec.Build.KanikoBuildCache {
Review comment:
@astefanutti based on your input I thought to reverse the way we are dealing
with this new variable, so now the `kamel` cli tool will take the value of
`skip-kaniko-build-cache` whose value will be by default `false`. Now in the
intialize we skip the cache warmer only if this value has been explicitly
update as `true` (`if platform.Namespace == platformutil.GetOperatorNamespace()
&& !platform.Spec.Build.SkipKanikoBuildCache {`). Hope this will cover most of
the scenarios of installation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] asifdxtreme commented on a change in pull request #922: fix: Add option to disable Kaniko cache warming
asifdxtreme commented on a change in pull request #922: fix: Add option to
disable Kaniko cache warming
URL: https://github.com/apache/camel-k/pull/922#discussion_r323183498
##
File path: pkg/controller/integrationplatform/initialize.go
##
@@ -137,7 +137,7 @@ func (action *initializeAction) Handle(ctx
context.Context, platform *v1alpha1.I
}
// Check if the operator is running in the same namespace
before starting the cache warmer
- if platform.Namespace == platformutil.GetOperatorNamespace() {
+ if platform.Namespace == platformutil.GetOperatorNamespace() &&
platform.Spec.Build.KanikoBuildCache {
Review comment:
@astefanutti based on your input I though to reverse the way we are dealing
with this new variable, so now the `kamel` cli tool we take the value of
`skip-kaniko-build-cache` whose value will be by default `false`. Now in the
intialize we check for cache warmer intializer only if this value has been
explicitly update as `true` (`if platform.Namespace ==
platformutil.GetOperatorNamespace() &&
!platform.Spec.Build.SkipKanikoBuildCache {`). Hope this will cover most of the
scenarios of installation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ia3andy edited a comment on issue #190: Be listed in code.quarkus.io
ia3andy edited a comment on issue #190: Be listed in code.quarkus.io URL: https://github.com/apache/camel-quarkus/issues/190#issuecomment-530304141 @lburgazzoli ok, I just got up to speed with the soon coming Quarkus Platform, sorry about that. The platform is not out there yet, so the idea is to temporary add your extension to the list (in the Quarkus repo). I am currently creating an issue for you in there. Once that done, I'll update you, but you'll be really close to have your extension listed in code.quarkus.io :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ia3andy commented on issue #190: Be listed in code.quarkus.io
ia3andy commented on issue #190: Be listed in code.quarkus.io URL: https://github.com/apache/camel-quarkus/issues/190#issuecomment-530304141 @lburgazzoli ok, I just got up to speed with the soon coming Quarkus Platform, sorry about that. The platform is not out there yet, so the idea is to temporary add your extension to the list (in the Quarkus repo). I am currently creating an issue for you in there. Once that done, I'll update you, but you'll be really close to have your extension listed in code.quarkus.io :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #190: Be listed in code.quarkus.io
lburgazzoli commented on issue #190: Be listed in code.quarkus.io URL: https://github.com/apache/camel-quarkus/issues/190#issuecomment-530293752 @ia3andy you are talking about being part of the quarkus platform right ? the camel quarkus extension won't join the quarkus repo, in fact we moved out quite recently :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] zhfeng commented on a change in pull request #197: Add the camel-paho extension to support the MQTT
zhfeng commented on a change in pull request #197: Add the camel-paho extension
to support the MQTT
URL: https://github.com/apache/camel-quarkus/pull/197#discussion_r323135839
##
File path:
integration-tests/paho/src/test/java/org/apache/camel/quarkus/component/paho/it/PahoTest.java
##
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.paho.it;
+
+import java.util.UUID;
+
+import io.quarkus.test.common.QuarkusTestResource;
+import io.quarkus.test.junit.QuarkusTest;
+import io.restassured.RestAssured;
+import io.restassured.http.ContentType;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+@QuarkusTest
+@QuarkusTestResource(ActiveMQTestResource.class)
+class PahoTest {
+
+@Test
+public void test() {
+final String msg = UUID.randomUUID().toString().replace("-", "");
+RestAssured.given() //
+.contentType(ContentType.TEXT).body(msg).post("/paho/publish") //
+.then().statusCode(200);
Review comment:
OK, I get your idea and will improve the test. Thanks @ppalaga
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ia3andy commented on issue #190: Be listed in code.quarkus.io
ia3andy commented on issue #190: Be listed in code.quarkus.io URL: https://github.com/apache/camel-quarkus/issues/190#issuecomment-530291247 We are currently creating the process to have a new extension listed in Code Quarkus. A good first step would be to have it accepted on the Quarkus repo. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #190: Be listed in code.quarkus.io
lburgazzoli commented on issue #190: Be listed in code.quarkus.io URL: https://github.com/apache/camel-quarkus/issues/190#issuecomment-530287088 @ppalaga @gnodet, @ia3andy can help on this This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] gnodet commented on issue #183: Generate documentation to be included in quarkus
gnodet commented on issue #183: Generate documentation to be included in quarkus URL: https://github.com/apache/camel-quarkus/issues/183#issuecomment-530285887 https://github.com/quarkusio/code.quarkus.io#update-the-extensions-list This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli edited a comment on issue #183: Generate documentation to be included in quarkus
lburgazzoli edited a comment on issue #183: Generate documentation to be included in quarkus URL: https://github.com/apache/camel-quarkus/issues/183#issuecomment-530283939 Something similar to guides available here: https://github.com/quarkusio/quarkus/tree/master/docs/src/main/asciidoc We need something generic that do not change very often to put there and point to camel-quarkus micro site for more details This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #183: Generate documentation to be included in quarkus
lburgazzoli commented on issue #183: Generate documentation to be included in quarkus URL: https://github.com/apache/camel-quarkus/issues/183#issuecomment-530283939 Something similar to guides available here: https://github.com/quarkusio/quarkus/tree/master/docs/src/main/asciidoc This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #197: Add the camel-paho extension to support the MQTT
ppalaga commented on a change in pull request #197: Add the camel-paho
extension to support the MQTT
URL: https://github.com/apache/camel-quarkus/pull/197#discussion_r323120298
##
File path:
integration-tests/paho/src/test/java/org/apache/camel/quarkus/component/paho/it/PahoTest.java
##
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.paho.it;
+
+import java.util.UUID;
+
+import io.quarkus.test.common.QuarkusTestResource;
+import io.quarkus.test.junit.QuarkusTest;
+import io.restassured.RestAssured;
+import io.restassured.http.ContentType;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+@QuarkusTest
+@QuarkusTestResource(ActiveMQTestResource.class)
+class PahoTest {
+
+@Test
+public void test() {
+final String msg = UUID.randomUUID().toString().replace("-", "");
+RestAssured.given() //
+.contentType(ContentType.TEXT).body(msg).post("/paho/publish") //
+.then().statusCode(200);
Review comment:
I do not find this test sufficient. I think there should be an assertion
that the message really passed the queue. You could e.g. add another REST
endpoint that would forward the messages from the queue using a
ConsumerTemplate, something like we have here:
https://github.com/apache/camel-quarkus/blob/master/integration-tests/twitter/src/main/java/org/apache/camel/quarkus/component/twitter/CamelResource.java#L58
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #143: Create a Camel AMQP extension
lburgazzoli commented on issue #143: Create a Camel AMQP extension URL: https://github.com/apache/camel-quarkus/issues/143#issuecomment-530273421 please go ahead This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
