[GitHub] [camel-k-runtime] WillemJiang commented on issue #138: #137 Add the error log when setting component property failed
WillemJiang commented on issue #138: #137 Add the error log when setting component property failed URL: https://github.com/apache/camel-k-runtime/pull/138#issuecomment-534047838 @lburgazzoli please review the new updated the code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] WillemJiang commented on issue #138: #137 Add the error log when setting component property failed
WillemJiang commented on issue #138: #137 Add the error log when setting component property failed URL: https://github.com/apache/camel-k-runtime/pull/138#issuecomment-532718712 @lburgazzoli Could you take a look at my recent change? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] WillemJiang commented on issue #138: #137 Add the error log when setting component property failed
WillemJiang commented on issue #138: #137 Add the error log when setting component property failed URL: https://github.com/apache/camel-k-runtime/pull/138#issuecomment-531560406 > The code you have linked relates to MissingPropertyException, not PropertyBindingException Sorry, it's a typo, the right name is MissingPropertyException. BTW, I just add two unit tests with a fix by throwing the exception to the runtime. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] WillemJiang commented on issue #138: #137 Add the error log when setting component property failed
WillemJiang commented on issue #138: #137 Add the error log when setting component property failed URL: https://github.com/apache/camel-k-runtime/pull/138#issuecomment-531442837 > thinking a little bit more about this we may throw something like > > ``` > new PropertyBindingException(this.component, name, "") > ``` > > as the Missing*Exception have some special meaning so they are not propagated @lburgazzoli I checked the code of [PropertyBindingException](http://docs.groovy-lang.org/latest/html/api/groovy/lang/MissingPropertyException.html) code, the default getMessage implementation (which has the location text) is much better than the String message that I can feed in. So I prefer to use new PropertyBindingException(this.component, name) one. What do you think about it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] WillemJiang commented on issue #138: #137 Add the error log when setting component property failed
WillemJiang commented on issue #138: #137 Add the error log when setting component property failed URL: https://github.com/apache/camel-k-runtime/pull/138#issuecomment-530386826 @lburgazzoli Could you merge the code? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k-runtime] WillemJiang commented on issue #138: #137 Add the error log when setting component property failed
WillemJiang commented on issue #138: #137 Add the error log when setting component property failed URL: https://github.com/apache/camel-k-runtime/pull/138#issuecomment-529271213 @lburgazzoli The log is updated, could you review it? BTW, it is strange for me to see the exception which is thrown from the "propertyMissing" doesn't break the running process of camel-k-runtime. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
