[GitHub] [camel-spring-boot] JiriOndrusek commented on a change in pull request #2: CAMEL-14159 camel-elytron - Security component

2020-01-20 Thread GitBox
JiriOndrusek commented on a change in pull request #2: CAMEL-14159 
camel-elytron - Security component
URL: https://github.com/apache/camel-spring-boot/pull/2#discussion_r368841206
 
 

 ##
 File path: 
examples/camel-example-spring-boot-elytron/src/main/java/sample/camel/SampleCamelApplication.java
 ##
 @@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package sample.camel;
 
 Review comment:
   @oscerd I see. I have copied it from other examples. E.g. - 
https://github.com/apache/camel-spring-boot/blob/master/examples/camel-example-spring-boot-amqp/src/main/java/sample/camel/SampleAmqApplication.java#L17
   
   I'll refactor it to org/apache/camel/example/springboot/
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [camel-spring-boot] JiriOndrusek commented on a change in pull request #2: CAMEL-14159 camel-elytron - Security component

2020-01-20 Thread GitBox
JiriOndrusek commented on a change in pull request #2: CAMEL-14159 
camel-elytron - Security component
URL: https://github.com/apache/camel-spring-boot/pull/2#discussion_r368840215
 
 

 ##
 File path: components-starter/camel-elytron-starter/pom.xml
 ##
 @@ -0,0 +1,67 @@
+
+
+http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd";>
+  4.0.0
+  
+org.apache.camel.springboot
+components-starter
+3.1.0-SNAPSHOT
 
 Review comment:
   In that case, there was probably something wrong on my side


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services