Re: camel-core - Checkstyle issues on trunk
Hi Claus, great. That helps a lot. How about running it always? Christian Am 28.08.2011 08:11, schrieb Claus Ibsen: On Sat, Aug 27, 2011 at 6:39 PM, Christian Schneider wrote: Ok will check on Monday. Can the issues be seen somewhere on the web or only in eclipse? The issues is reported on the command line using mvn compile -Psourcecheck Its a maven plugin, so there could be some maven reporting web tooling being able to display them. However its just much easier to run the cmd from the command line once in a while. Christian Am 27.08.2011 18:29, schrieb Claus Ibsen: Hi There is a fair number of checkstyle issues on trunk on camel-core. I suspect its due some of the latest refactorings. -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: camel-core - Checkstyle issues on trunk
In CXF the build fails when there are checkstyle errors. I think that is a good idea. Of course this can only be done when we are at 0 errors for a moment. But we could aim to do that for 2.9 or 3.0. Christian Am 28.08.2011 04:09, schrieb Johan Edstrom: Would a tag+IDE cleanup be something acceptable? I have camel check style profiles I use, I've noticed they can differ a tiny bit from the eclipse one and still pass, but do we simply need one strict enforcement and then we stay more critical to the issue? Just a wild IDEa… :) /je On Aug 27, 2011, at 10:29 AM, Claus Ibsen wrote: Hi There is a fair number of checkstyle issues on trunk on camel-core. I suspect its due some of the latest refactorings. -- Claus Ibsen - FuseSource Email: cib...@fusesource.com Web: http://fusesource.com Twitter: davsclaus, fusenews Blog: http://davsclaus.blogspot.com/ Author of Camel in Action: http://www.manning.com/ibsen/ -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: camel-core - Checkstyle issues on trunk
On Sat, Aug 27, 2011 at 6:39 PM, Christian Schneider wrote: > Ok will check on Monday. > Can the issues be seen somewhere on the web or only in eclipse? > The issues is reported on the command line using mvn compile -Psourcecheck Its a maven plugin, so there could be some maven reporting web tooling being able to display them. However its just much easier to run the cmd from the command line once in a while. > Christian > > > Am 27.08.2011 18:29, schrieb Claus Ibsen: >> >> Hi >> >> There is a fair number of checkstyle issues on trunk on camel-core. I >> suspect its due some of the latest refactorings. >> >> > > -- > Christian Schneider > http://www.liquid-reality.de > > Open Source Architect > http://www.talend.com > > -- Claus Ibsen - FuseSource Email: cib...@fusesource.com Web: http://fusesource.com Twitter: davsclaus, fusenews Blog: http://davsclaus.blogspot.com/ Author of Camel in Action: http://www.manning.com/ibsen/
Re: camel-core - Checkstyle issues on trunk
Would a tag+IDE cleanup be something acceptable? I have camel check style profiles I use, I've noticed they can differ a tiny bit from the eclipse one and still pass, but do we simply need one strict enforcement and then we stay more critical to the issue? Just a wild IDEa… :) /je On Aug 27, 2011, at 10:29 AM, Claus Ibsen wrote: > Hi > > There is a fair number of checkstyle issues on trunk on camel-core. I > suspect its due some of the latest refactorings. > > > -- > Claus Ibsen > - > FuseSource > Email: cib...@fusesource.com > Web: http://fusesource.com > Twitter: davsclaus, fusenews > Blog: http://davsclaus.blogspot.com/ > Author of Camel in Action: http://www.manning.com/ibsen/
Re: camel-core - Checkstyle issues on trunk
sonar @ asf ? https://analysis.apache.org/dashboard/index/37401 2011/8/27 Christian Schneider : > Ok will check on Monday. > Can the issues be seen somewhere on the web or only in eclipse? > > Christian > > > Am 27.08.2011 18:29, schrieb Claus Ibsen: >> >> Hi >> >> There is a fair number of checkstyle issues on trunk on camel-core. I >> suspect its due some of the latest refactorings. >> >> > > -- > Christian Schneider > http://www.liquid-reality.de > > Open Source Architect > http://www.talend.com > > -- Olivier Lamy Talend : http://talend.com http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: camel-core - Checkstyle issues on trunk
Ok will check on Monday. Can the issues be seen somewhere on the web or only in eclipse? Christian Am 27.08.2011 18:29, schrieb Claus Ibsen: Hi There is a fair number of checkstyle issues on trunk on camel-core. I suspect its due some of the latest refactorings. -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
camel-core - Checkstyle issues on trunk
Hi There is a fair number of checkstyle issues on trunk on camel-core. I suspect its due some of the latest refactorings. -- Claus Ibsen - FuseSource Email: cib...@fusesource.com Web: http://fusesource.com Twitter: davsclaus, fusenews Blog: http://davsclaus.blogspot.com/ Author of Camel in Action: http://www.manning.com/ibsen/
