Re: [DISCUSSION] Support Map type for complex type columns

2018-08-20 Thread Indhumathi
Hi Sujith,

Thanks for your review. Please find my comments inline.

a)Can we use map data type columns as partition key columns?

** No. It has been already mentioned in Impacted Feature Analysis. **

b) It will be clear if you can mention all the data types which is
supported, like do we support all primitive types especially timestanp
since its one of the important type of key for map data type
e.g. you can store the events corresponding to a time periods.

** Supported DataTypes for Map has been updated in Design Document. Please
check **

c) Any restrictions in the level of nesting?
eg 50 or 100 

** Similar to Array and Struct, Map will also have n - level nesting
supported through SDK.
Without SDK, 2-level nesting will be supported **

Please find the updated Design document for Map-DataType.
MAP_DATA-TYPE_SUPPORT.pdf

   



--
Sent from: 
http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/


Re: [DISCUSSION] Support Map type for complex type columns

2018-08-20 Thread sujith chacko
Hi Indumathi,
Design document covers all aspects of the implementation which is good
except few minor points are missing i think like,
It will be better if we can list down the constraints in our
implementations if any, like
a)Can we use map data type columns as partition key columns?
b) It will be clear if you can mention all the data types which is
supported, like do we support all primitive types especially timestanp
since its one of the important type of key for map data type
e.g. you can store the events corresponding to a time periods.
c) Any restrictions in the level of nesting?
eg 50 or 100

Thanks,
Sujith

On Mon, 20 Aug 2018 at 4:24 PM, Indhumathi  wrote:

> Hi all,
>
> Please find the Attached MAP-DataType support Design document. Please let
> me
> know for any further clarification on design document.
> Any further suggestions/improvements are welcomed.
>
> MAP_DATA-TYPE_SUPPORT.pdf
> <
> http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/file/t341/MAP_DATA-TYPE_SUPPORT.pdf>
>
>
> Please find the link for design document.
>
> https://docs.google.com/document/d/1HHe2fdkIh3Jyz1y3494_2kGRSc4muTWuilAmwg5lpVw/edit?usp=sharing
> <
> https://docs.google.com/document/d/1HHe2fdkIh3Jyz1y3494_2kGRSc4muTWuilAmwg5lpVw/edit?usp=sharing>
>
>
> Regards
> Indhumathi M
>
>
>
> --
> Sent from:
> http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/
>


Re: Change the 'comment' content for column when execute command 'desc formatted table_name'

2018-08-20 Thread Jacky Li
Hi ZZC,

Can you create a JIRA ticket and upload the design doc, in mail list we can not 
get the attachment

Regards,
Jacky

> 在 2018年8月20日,上午11:20,xm_zzc <441586...@qq.com> 写道:
> 
> Hi dev:
>  Now I am working on this, the new format is shown in attachment, please
> give me some feedback.
>  There is one question: if user uses CTAS to create table, do we need to
> show the 'select sql' in the result of 'desc formatted table'? If yes, how
> to get 'select sql'? now I just can get a non-formatted sql from
> 'CarbonSparkSqlParser.scala' (Jacky mentioned), for example:
> 
> *CREATE TABLE IF NOT EXISTS test_table
> STORED BY 'carbondata'
> TBLPROPERTIES(
> 'streaming'='false', 'sort_columns'='id,city', 'dictionary_include'='name')
> AS SELECT * from source_test ;*
> 
> The non-formatted sql I get is :
> *SELECT*fromsource_test*
> 
> desc_formatted.txt
> 
>   
> desc_formatted_external.txt
> 
>   
> 
> 
> 
> 
> 
> 
> --
> Sent from: 
> http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/
> 





Re: [DISCUSSION] Support Map type for complex type columns

2018-08-20 Thread Indhumathi
Hi all,

Please find the Attached MAP-DataType support Design document. Please let me
know for any further clarification on design document.
Any further suggestions/improvements are welcomed.

MAP_DATA-TYPE_SUPPORT.pdf

  

Please find the link for design document.
https://docs.google.com/document/d/1HHe2fdkIh3Jyz1y3494_2kGRSc4muTWuilAmwg5lpVw/edit?usp=sharing

  

Regards
Indhumathi M



--
Sent from: 
http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/