Re: [ANNOUNCE] Chuanyin Xu as new PMC for Apache CarbonData

2019-01-06 Thread xubo245
Congratulations!! 



--
Sent from: 
http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/


Re: [DISCUSS] Move to gitbox as per ASF infra team mail

2019-01-06 Thread David CaiQiang
+1



-
Best Regards
David Cai
--
Sent from: 
http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/


Re: [DISCUSS] Move to gitbox as per ASF infra team mail

2019-01-06 Thread Bhavya Aggarwal
+1

On Mon, Jan 7, 2019 at 8:08 AM David CaiQiang  wrote:

> +1
>
>
>
> -
> Best Regards
> David Cai
> --
> Sent from:
> http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/
>


-- 
*Bhavya Aggarwal*
CTO & Partner
Knoldus Inc. 
+91-9910483067
Canada - USA - India - Singapore
 
 


Re: [DISCUSS] Move to gitbox as per ASF infra team mail

2019-01-06 Thread manishgupta88
+1

Regards
Manish Gupta



--
Sent from: 
http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/


Re: [Discussion] Refactor dynamic configuration

2019-01-06 Thread ravipesala
Hi,

Please check my views on it.

Basic design should be there is a clear separation between modules. Like
Spark based configurations are no means to presto, So every module can have
there owned conf and constant classes. 
1. No need for CarbonProperties and  CarbonCommonConstants.
2. Should have CarbonStaticConf and CarbonRuntimeConf classes to
differentiate between static and runtime configurations.
3. Don't add description as string to it as it consumes lot of memory,
adding as comment should be enough.
4. Create CarbonCoreConstants for keeping all core level constants to it. 
5. Every integration layer should have its own constants classes like Spark,
presto and Hive.
6. Even configurations also should be different for each integration layer.
That means spark should have CarbonSparkConf which can extends or wrap
CarbonStaticConf. And same for presto and hive as well.



--
Sent from: 
http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/