[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox


CarbonDataQA2 commented on pull request #4120:
URL: https://github.com/apache/carbondata/pull/4120#issuecomment-823025676


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5214/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Indhumathi27 commented on pull request #4115: [CARBONDATA-4163] Support adding of single-level complex columns(array/struct)

2021-04-19 Thread GitBox


Indhumathi27 commented on pull request #4115:
URL: https://github.com/apache/carbondata/pull/4115#issuecomment-822986620


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] akashrn5 commented on pull request #4115: [CARBONDATA-4163] Support adding of single-level complex columns(array/struct)

2021-04-19 Thread GitBox


akashrn5 commented on pull request #4115:
URL: https://github.com/apache/carbondata/pull/4115#issuecomment-822983721


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] ydvpankaj99 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox


ydvpankaj99 commented on pull request #4120:
URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822982313


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox


CarbonDataQA2 commented on pull request #4120:
URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822968465


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3465/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox


CarbonDataQA2 commented on pull request #4120:
URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822966299


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5213/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] ydvpankaj99 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox


ydvpankaj99 commented on pull request #4120:
URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822935849


   retest this please 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox


CarbonDataQA2 commented on pull request #4120:
URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822674554


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3464/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox


CarbonDataQA2 commented on pull request #4120:
URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822671455


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5212/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] ydvpankaj99 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox


ydvpankaj99 commented on pull request #4120:
URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822612384


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4118: [CARBONDATA-4167][CARBONDATA-4168] Fix case sensitive issues and input validation for Geo values.

2021-04-19 Thread GitBox


CarbonDataQA2 commented on pull request #4118:
URL: https://github.com/apache/carbondata/pull/4118#issuecomment-822579372


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3463/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4118: [CARBONDATA-4167][CARBONDATA-4168] Fix case sensitive issues and input validation for Geo values.

2021-04-19 Thread GitBox


CarbonDataQA2 commented on pull request #4118:
URL: https://github.com/apache/carbondata/pull/4118#issuecomment-822578777


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5211/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] asfgit closed pull request #4113: [CARBONDATA-4161] Describe complex columns

2021-04-19 Thread GitBox


asfgit closed pull request #4113:
URL: https://github.com/apache/carbondata/pull/4113


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox


CarbonDataQA2 commented on pull request #4120:
URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822517283


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3462/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] akkio-97 commented on a change in pull request #4115: [CARBONDATA-4163] Support adding of single-level complex columns(array/struct)

2021-04-19 Thread GitBox


akkio-97 commented on a change in pull request #4115:
URL: https://github.com/apache/carbondata/pull/4115#discussion_r615904251



##
File path: 
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/alterTable/TestAlterTableAddColumns.scala
##
@@ -136,14 +139,274 @@ class TestAlterTableAddColumns extends QueryTest with 
BeforeAndAfterAll {
 sql(s"""DROP TABLE IF EXISTS ${ tableName }""")
   }
 
+  def addedColumnsInSchemaEvolutionEntry(tableName: String): Int = {
+val carbonTable = CarbonEnv.getCarbonTable(None, 
tableName)(sqlContext.sparkSession)
+val schemaEvolutionList = carbonTable.getTableInfo
+  .getFactTable
+  .getSchemaEvolution()
+  .getSchemaEvolutionEntryList()
+var addedColumns = 0
+for (i <- 0 until schemaEvolutionList.size()) {
+  addedColumns += schemaEvolutionList.get(i).getAdded.size()
+}
+addedColumns
+  }
+
+  test("Test adding of array of all primitive datatypes") {
+sql("DROP TABLE IF EXISTS alter_com")
+sql("CREATE TABLE alter_com(intfield int) STORED AS carbondata")
+sql(
+  "ALTER TABLE alter_com ADD COLUMNS(arr1 array, arr2 array, 
arr3 " +
+  "array, arr4 array, arr5 array, arr6 
array, arr7 " +
+  "array, arr8 array, arr9 array, arr10 
array, arr11 " +
+  "array )")
+val columns = sql("desc table alter_com").collect()
+assert(columns.size.equals(12))
+sql(
+  "insert into alter_com 
values(1,array(1,5),array(1,2),array(1,2,3),array(1.2d,2.3d),array" +
+  
"(4.5,6.7),array('hello','world'),array('a','bcd'),array('abcd','efg'),array(true,false),"
 +
+  "array('2017-02-01','2018-09-11'),array('2017-02-01 
00:01:00','2018-02-01 02:21:00') )")
+checkAnswer(sql(
+  "select * from alter_com"),
+  Seq(Row(1,
+make(Array(1, 5)),
+make(Array(1, 2)),
+make(Array(1, 2, 3)),
+make(Array(1.2, 2.3)),
+make(Array(java.math.BigDecimal.valueOf(4.5).setScale(2),
+  java.math.BigDecimal.valueOf(6.7).setScale(2))),
+make(Array("hello", "world")),
+make(Array("a", "bcd")),
+make(Array("abcd", "efg")),
+make(Array(true, false)),
+make(Array(Date.valueOf("2017-02-01"),
+  Date.valueOf("2018-09-11"))),
+make(Array(Timestamp.valueOf("2017-02-01 00:01:00"),
+  Timestamp.valueOf("2018-02-01 02:21:00")))
+  )))
+
+val addedColumns = addedColumnsInSchemaEvolutionEntry("alter_com")
+assert(addedColumns == 11)

Review comment:
   Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




Re: [DISCUSSION] Support JOIN query with spatial index

2021-04-19 Thread Ajantha Bhat
Hi,
I think now the latest document has addressed my previous comments and
questions.

polygon list query and polyline list query design looks ok.

But the design of polygon query with join, I have performance concern.
In this approach, we are using union polygon filter on spatial_table to
prune till blocklet.
It may identify all the rows in blocklet in the worst case and with this
output (N) we will perform join with the polygon table output(M).
which will again check IN_POLYGON condition during join (N*M) times. I too
don't have any different solution at the moment.

But we can optimize the current solution further by below points:
a) Here for the polygon table output you can reduce making quadtree for N*M
times to M times and use the quadtree output as range filter/UDF for join.
b) Also later if we need more improvement, maybe we can try row-level
filtering on the spatial table.

Thanks,
Ajantha



On Thu, Apr 15, 2021 at 9:37 PM Indhumathi  wrote:

> Hello all,
>
> Please find the design document link attached in JIRA,  CARBONDATA-4166
> 
> Any inputs/suggestions from the community is most welcomed.
>
> Regards,
> Indhumathi
>
>
>
> --
> Sent from:
> http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/
>


[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox


CarbonDataQA2 commented on pull request #4120:
URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822504281


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5210/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4113: [CARBONDATA-4161] Describe complex columns

2021-04-19 Thread GitBox


CarbonDataQA2 commented on pull request #4113:
URL: https://github.com/apache/carbondata/pull/4113#issuecomment-822484996


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5209/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4113: [CARBONDATA-4161] Describe complex columns

2021-04-19 Thread GitBox


CarbonDataQA2 commented on pull request #4113:
URL: https://github.com/apache/carbondata/pull/4113#issuecomment-822482372


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3461/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4115: [CARBONDATA-4163] Support adding of single-level complex columns(array/struct)

2021-04-19 Thread GitBox


CarbonDataQA2 commented on pull request #4115:
URL: https://github.com/apache/carbondata/pull/4115#issuecomment-822476499


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5208/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4115: [CARBONDATA-4163] Support adding of single-level complex columns(array/struct)

2021-04-19 Thread GitBox


CarbonDataQA2 commented on pull request #4115:
URL: https://github.com/apache/carbondata/pull/4115#issuecomment-822476020


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3460/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] ydvpankaj99 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox


ydvpankaj99 commented on pull request #4120:
URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822439792


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Indhumathi27 commented on pull request #4113: [CARBONDATA-4161] Describe complex columns

2021-04-19 Thread GitBox


Indhumathi27 commented on pull request #4113:
URL: https://github.com/apache/carbondata/pull/4113#issuecomment-822421143


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox


CarbonDataQA2 commented on pull request #4120:
URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822366877


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3459/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox


CarbonDataQA2 commented on pull request #4120:
URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822360744


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5207/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4115: [CARBONDATA-4163] Support adding of single-level complex columns(array/struct)

2021-04-19 Thread GitBox


CarbonDataQA2 commented on pull request #4115:
URL: https://github.com/apache/carbondata/pull/4115#issuecomment-822355050


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3457/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] akashrn5 commented on a change in pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2021-04-19 Thread GitBox


akashrn5 commented on a change in pull request #3988:
URL: https://github.com/apache/carbondata/pull/3988#discussion_r615721648



##
File path: 
integration/spark/src/main/scala/org/apache/spark/sql/events/MergeIndexEventListener.scala
##
@@ -140,19 +141,47 @@ class MergeIndexEventListener extends 
OperationEventListener with Logging {
   .get
   .filterNot(streamingSegment.contains(_))
   }
+validSegments.foreach { segment =>
+  if (segmentsToMerge.contains(segment.getSegmentNo)) {

Review comment:
   move this if check as `.filter` before ` foreach`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2021-04-19 Thread GitBox


CarbonDataQA2 commented on pull request #3988:
URL: https://github.com/apache/carbondata/pull/3988#issuecomment-822354240


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3458/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




Re: query on string type return error

2021-04-19 Thread Yahui Liu
I encounter the same error in later carbon version. Have you find the root
cause and solution for this error?



--
Sent from: 
http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/


[GitHub] [carbondata] akashrn5 commented on a change in pull request #4115: [CARBONDATA-4163] Support adding of single-level complex columns(array/struct)

2021-04-19 Thread GitBox


akashrn5 commented on a change in pull request #4115:
URL: https://github.com/apache/carbondata/pull/4115#discussion_r615698795



##
File path: 
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/alterTable/TestAlterTableAddColumns.scala
##
@@ -136,14 +139,274 @@ class TestAlterTableAddColumns extends QueryTest with 
BeforeAndAfterAll {
 sql(s"""DROP TABLE IF EXISTS ${ tableName }""")
   }
 
+  def addedColumnsInSchemaEvolutionEntry(tableName: String): Int = {
+val carbonTable = CarbonEnv.getCarbonTable(None, 
tableName)(sqlContext.sparkSession)
+val schemaEvolutionList = carbonTable.getTableInfo
+  .getFactTable
+  .getSchemaEvolution()
+  .getSchemaEvolutionEntryList()
+var addedColumns = 0
+for (i <- 0 until schemaEvolutionList.size()) {
+  addedColumns += schemaEvolutionList.get(i).getAdded.size()
+}
+addedColumns
+  }
+
+  test("Test adding of array of all primitive datatypes") {
+sql("DROP TABLE IF EXISTS alter_com")
+sql("CREATE TABLE alter_com(intfield int) STORED AS carbondata")
+sql(
+  "ALTER TABLE alter_com ADD COLUMNS(arr1 array, arr2 array, 
arr3 " +
+  "array, arr4 array, arr5 array, arr6 
array, arr7 " +
+  "array, arr8 array, arr9 array, arr10 
array, arr11 " +
+  "array )")
+val columns = sql("desc table alter_com").collect()
+assert(columns.size.equals(12))
+sql(
+  "insert into alter_com 
values(1,array(1,5),array(1,2),array(1,2,3),array(1.2d,2.3d),array" +
+  
"(4.5,6.7),array('hello','world'),array('a','bcd'),array('abcd','efg'),array(true,false),"
 +
+  "array('2017-02-01','2018-09-11'),array('2017-02-01 
00:01:00','2018-02-01 02:21:00') )")
+checkAnswer(sql(
+  "select * from alter_com"),
+  Seq(Row(1,
+make(Array(1, 5)),
+make(Array(1, 2)),
+make(Array(1, 2, 3)),
+make(Array(1.2, 2.3)),
+make(Array(java.math.BigDecimal.valueOf(4.5).setScale(2),
+  java.math.BigDecimal.valueOf(6.7).setScale(2))),
+make(Array("hello", "world")),
+make(Array("a", "bcd")),
+make(Array("abcd", "efg")),
+make(Array(true, false)),
+make(Array(Date.valueOf("2017-02-01"),
+  Date.valueOf("2018-09-11"))),
+make(Array(Timestamp.valueOf("2017-02-01 00:01:00"),
+  Timestamp.valueOf("2018-02-01 02:21:00")))
+  )))
+
+val addedColumns = addedColumnsInSchemaEvolutionEntry("alter_com")
+assert(addedColumns == 11)

Review comment:
   also add an assert of added column names and datatypes in a test case




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2021-04-19 Thread GitBox


CarbonDataQA2 commented on pull request #3988:
URL: https://github.com/apache/carbondata/pull/3988#issuecomment-822328365


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5205/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Indhumathi27 commented on pull request #4115: [CARBONDATA-4163] Support adding of single-level complex columns(array/struct)

2021-04-19 Thread GitBox


Indhumathi27 commented on pull request #4115:
URL: https://github.com/apache/carbondata/pull/4115#issuecomment-822311739


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #1390: [CARBONDATA-1360] fix for update table failures for struct data type

2021-04-19 Thread GitBox


CarbonDataQA2 commented on pull request #1390:
URL: https://github.com/apache/carbondata/pull/1390#issuecomment-822291842


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5206/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox


CarbonDataQA2 commented on pull request #4120:
URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822267379


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5204/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox


CarbonDataQA2 commented on pull request #4120:
URL: https://github.com/apache/carbondata/pull/4120#issuecomment-822267153


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3452/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] ydvpankaj99 opened a new pull request #4120: ci test random issue or not

2021-04-19 Thread GitBox


ydvpankaj99 opened a new pull request #4120:
URL: https://github.com/apache/carbondata/pull/4120


### Why is this PR needed?


### What changes were proposed in this PR?
   
   
### Does this PR introduce any user interface change?
- No
- Yes. (please explain the change and update document)
   
### Is any new testcase added?
- No
- Yes
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4115: [CARBONDATA-4163] Support adding of single-level complex columns(array/struct)

2021-04-19 Thread GitBox


CarbonDataQA2 commented on pull request #4115:
URL: https://github.com/apache/carbondata/pull/4115#issuecomment-822256718


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3451/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4115: [CARBONDATA-4163] Support adding of single-level complex columns(array/struct)

2021-04-19 Thread GitBox


CarbonDataQA2 commented on pull request #4115:
URL: https://github.com/apache/carbondata/pull/4115#issuecomment-822254971


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5203/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org