[GitHub] [carbondata] ydvpankaj99 commented on pull request #4246: [WIP] Fix clean files removing wrong delta files

2022-01-04 Thread GitBox


ydvpankaj99 commented on pull request #4246:
URL: https://github.com/apache/carbondata/pull/4246#issuecomment-1005417486


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4246: [WIP] Fix clean files removing wrong delta files

2022-01-04 Thread GitBox


CarbonDataQA2 commented on pull request #4246:
URL: https://github.com/apache/carbondata/pull/4246#issuecomment-1005004640


   Build Failed  with Spark 3.1, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/585/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4246: [WIP] Fix clean files removing wrong delta files

2022-01-04 Thread GitBox


CarbonDataQA2 commented on pull request #4246:
URL: https://github.com/apache/carbondata/pull/4246#issuecomment-1004982034


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4450/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4246: [WIP] Fix clean files removing wrong delta files

2022-01-04 Thread GitBox


CarbonDataQA2 commented on pull request #4246:
URL: https://github.com/apache/carbondata/pull/4246#issuecomment-1004969731


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/6194/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4246: [WIP] Fix clean files removing wrong delta files

2022-01-04 Thread GitBox


CarbonDataQA2 commented on pull request #4246:
URL: https://github.com/apache/carbondata/pull/4246#issuecomment-1004846649


   Build Failed  with Spark 3.1, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/584/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4246: [WIP] Fix clean files removing wrong delta files

2022-01-04 Thread GitBox


CarbonDataQA2 commented on pull request #4246:
URL: https://github.com/apache/carbondata/pull/4246#issuecomment-1004797152


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/6193/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4238: Carbon CI Test

2022-01-04 Thread GitBox


CarbonDataQA2 commented on pull request #4238:
URL: https://github.com/apache/carbondata/pull/4238#issuecomment-1004746218


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4448/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4238: Carbon CI Test

2022-01-04 Thread GitBox


CarbonDataQA2 commented on pull request #4238:
URL: https://github.com/apache/carbondata/pull/4238#issuecomment-1004737529


   Build Success with Spark 3.1, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/583/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4238: Carbon CI Test

2022-01-04 Thread GitBox


CarbonDataQA2 commented on pull request #4238:
URL: https://github.com/apache/carbondata/pull/4238#issuecomment-1004736626


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/6192/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4246: [WIP] Fix clean files removing wrong delta files

2022-01-04 Thread GitBox


CarbonDataQA2 commented on pull request #4246:
URL: https://github.com/apache/carbondata/pull/4246#issuecomment-1004735850


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4449/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] vikramahuja1001 opened a new pull request #4246: [WIP] Fix clean files removing wrong delta files

2022-01-04 Thread GitBox


vikramahuja1001 opened a new pull request #4246:
URL: https://github.com/apache/carbondata/pull/4246


### Why is this PR needed?
In the case where there are multiple delete delta files in a partition in a 
partition table, some delta files were being ignored and deleted, thus changing 
the value during the query

### What changes were proposed in this PR?
   Fixed the logic which checks which delta file to delete. Now checking the 
deltaStartTime and comparing it with deltaEndTime to check consider all the 
delta files during clean files.
   
### Does this PR introduce any user interface change?
- No
   
### Is any new testcase added?
- Yes, one test case has been added.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] ydvpankaj99 commented on pull request #4238: Carbon CI Test

2022-01-04 Thread GitBox


ydvpankaj99 commented on pull request #4238:
URL: https://github.com/apache/carbondata/pull/4238#issuecomment-1004653163


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org