[GitHub] incubator-carbondata pull request #281: [CARBONDATA-362]Optimize the Paramet...
Github user lion-x closed the pull request at: https://github.com/apache/incubator-carbondata/pull/281 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #281: [CARBONDATA-362]Optimize the Paramet...
Github user Hexiaoqiao commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/281#discussion_r86279989
--- Diff:
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
@@ -65,7 +65,7 @@ object CarbonDataRDDFactory extends Logging {
sqlContext: SQLContext,
carbonLoadModel: CarbonLoadModel,
storeLocation: String,
- hdfsStoreLocation: String,
+ StoreLocation: String,
--- End diff --
pls follow the code style and use lowercase character of variable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #281: [CARBONDATA-362]Optimize the Paramet...
GitHub user lion-x opened a pull request: https://github.com/apache/incubator-carbondata/pull/281 [CARBONDATA-362]Optimize the Parameters Name in CarbonDataRDDFactory.scala # Why raise this PR? changes the name of "hdfsStoreLocation" to "storePath", because not only support hdfs path. # How to test? Pass all test cases. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lion-x/incubator-carbondata optimizeParametersName Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-carbondata/pull/281.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #281 commit ef50982ee53929d67b3e58d57d7a05a46a8a2ba8 Author: lion-x Date: 2016-11-03T01:02:31Z optimizeParametersName --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
