Review request : CASSANDRA-13547

[Krishna Koneru]

Would anyone be interested in reviewing a patch related to Materialized Views? 

https://issues.apache.org/jira/browse/CASSANDRA-13547 
 - Filtered materialized 
views missing data

Patch for 3.11 : 
https://github.com/apache/cassandra/compare/cassandra-3.11...krishna-koneru:cassandra-3.11-13547
 



Some background :

In ViewUpdateGenerator.java, computeTimestampForEntryDeletion()  method takes 
the biggest timestamp of all the columns (including non-pk) in the row and uses 
it in Deletion info when deleting. But, when inserting/updating, 
computeLivenessInfoForEntry() uses the biggest timestamp of the primary keys 
for liveliness info.This causes non-pk columns to be treated incorrectly (in 
some cases) as deleted because view tombstones can have higher timestamp than 
live cell from base row.

Fix makes computeLivenessInfoForEntry() to use the highest timestamp of all the 
columns (instead of just PK columns) for liveliness info .

Another problem fixed in the patch is updates to non-pk columns are not 
propagated to view if they are not denormalized in the view and have a filter 
specified on them.This is implemented as CQL syntax restriction which forces 
denormalisation of a non-pk column in view if it has a filter on it.(support 
for allowing filters on non-pk columns was added in CASSANDRA-10368 )


Thanks !

Re: [VOTE] Release Apache Cassandra 2.1.18

[Jason Brown]

+1

On Wed, Jun 21, 2017 at 17:52 Brandon Williams  wrote:

> +1
>
> On Wed, Jun 21, 2017 at 3:18 PM, Michael Shuler 
> wrote:
>
> > I propose the following artifacts for release as 2.1.18.
> >
> > sha1: 9369db1dfd92d4eb76284cfb68b1ffb9d22c9b06
> > Git:
> > http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=
> > shortlog;h=refs/tags/2.1.18-tentative
> > Artifacts:
> > https://repository.apache.org/content/repositories/
> > orgapachecassandra-1146/org/apache/cassandra/apache-cassandra/2.1.18/
> > Staging repository:
> > https://repository.apache.org/content/repositories/
> > orgapachecassandra-1146/
> >
> > The Debian and RPM packages are available here:
> > http://people.apache.org/~mshuler/
> >
> > The vote will be open for 72 hours (longer if needed).
> >
> > [1]: (CHANGES.txt) https://goo.gl/MG5EUZ
> > [2]: (NEWS.txt) https://goo.gl/7bi7K1
> >
> >
>

Re: [VOTE] Release Apache Cassandra 2.1.18

[Brandon Williams]

+1

On Wed, Jun 21, 2017 at 3:18 PM, Michael Shuler 
wrote:

> I propose the following artifacts for release as 2.1.18.
>
> sha1: 9369db1dfd92d4eb76284cfb68b1ffb9d22c9b06
> Git:
> http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=
> shortlog;h=refs/tags/2.1.18-tentative
> Artifacts:
> https://repository.apache.org/content/repositories/
> orgapachecassandra-1146/org/apache/cassandra/apache-cassandra/2.1.18/
> Staging repository:
> https://repository.apache.org/content/repositories/
> orgapachecassandra-1146/
>
> The Debian and RPM packages are available here:
> http://people.apache.org/~mshuler/
>
> The vote will be open for 72 hours (longer if needed).
>
> [1]: (CHANGES.txt) https://goo.gl/MG5EUZ
> [2]: (NEWS.txt) https://goo.gl/7bi7K1
>
>

Re: [VOTE] Release Apache Cassandra 2.2.10

[Brandon Williams]

+1

On Wed, Jun 21, 2017 at 3:20 PM, Michael Shuler 
wrote:

> I propose the following artifacts for release as 2.2.10.
>
> sha1: 83f28ce3c4eeff75ce70855a56b6155047ce8e9a
> Git:
> http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=
> shortlog;h=refs/tags/2.2.10-tentative
> Artifacts:
> https://repository.apache.org/content/repositories/
> orgapachecassandra-1147/org/apache/cassandra/apache-cassandra/2.2.10/
> Staging repository:
> https://repository.apache.org/content/repositories/
> orgapachecassandra-1147/
>
> The Debian and RPM packages are available here:
> http://people.apache.org/~mshuler/
>
> The vote will be open for 72 hours (longer if needed).
>
> [1]: (CHANGES.txt) https://goo.gl/N2ZEkF
> [2]: (NEWS.txt) https://goo.gl/FAv57Z
>
>

Re: [VOTE] Release Apache Cassandra 2.2.10

[Nate McCall]

+1

On Thu, Jun 22, 2017 at 8:20 AM, Michael Shuler  wrote:
> I propose the following artifacts for release as 2.2.10.
>
> sha1: 83f28ce3c4eeff75ce70855a56b6155047ce8e9a
> Git:
> http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=shortlog;h=refs/tags/2.2.10-tentative
> Artifacts:
> https://repository.apache.org/content/repositories/orgapachecassandra-1147/org/apache/cassandra/apache-cassandra/2.2.10/
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachecassandra-1147/
>
> The Debian and RPM packages are available here:
> http://people.apache.org/~mshuler/
>
> The vote will be open for 72 hours (longer if needed).
>
> [1]: (CHANGES.txt) https://goo.gl/N2ZEkF
> [2]: (NEWS.txt) https://goo.gl/FAv57Z
>

-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org

Re: AutoBoxing overhead in lambda expressions

[Nate McCall]

Hi Ameya,
Did you end up creating any issues for your findings?

On Mon, Jun 12, 2017 at 6:44 PM, Jeff Jirsa  wrote:
> Generally speaking,
>
> Patches that decrease boxing/unboxing overhead are great, and we've made a
> point of committing some of those in the past ( such as in CASSANDRA-12199
> and CASSANDRA-8019 ) , though there are also some examples where we've
> decided not to apply boxing changes to critical code paths that didn't have
> a meaningful performance impact.
>
> I would expect that if you refactor it in chunks - that is, break it down
> into a handful of patches, where each patch is contained to a specific
> subsystem (compaction, commitlog, repair, messaging, etc) so it could be
> reasonably reviewed - such refactoring would likely be appreciated,
> especially if it came with quantifiable performance increase (using
> something like cstar https://github.com/datastax/cstar_perf or stress runs
> or microbenchmarks or similar).
>
> - Jeff
>
>
> On Fri, Jun 9, 2017 at 10:50 AM, Ameya Sanjay Sanjay Ketkar <
> ketk...@oregonstate.edu> wrote:
>
>> Hello,
>>
>> I am  graduate researcher at Oregon State University, currently studying
>> lambda expressions in java open source project.
>> Using a generic Functional interface when a specialized primitive
>> functional interface can be used, is one the lambda smells I am focussing
>> on.
>> for instance  Function could be IntUnaryOperator.
>>
>> https://github.com/apache/cassandra/pull/116 > cassandra/pull/116>
>>
>> Is an instance of refactoring, of such lambda smell.
>> I would love to contribute to this project, by refactoring such lambda
>> smells.
>>
>> I am developing a tool to detect such opportunities.
>> But all the refactoring done are manual and all instances are checked and
>> verified by me manually, before creating a pull request.
>>
>> Regards,
>> Ameya Ketkar
>>
>> Graduate Research Assistant
>> Oregon State University

-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org

Re: [VOTE] Release Apache Cassandra 2.2.10

[Jason Brown]

+1

On Wed, Jun 21, 2017 at 16:52 Jeff Jirsa  wrote:

> +1
>
> On Wed, Jun 21, 2017 at 1:20 PM, Michael Shuler 
> wrote:
>
> > I propose the following artifacts for release as 2.2.10.
> >
> > sha1: 83f28ce3c4eeff75ce70855a56b6155047ce8e9a
> > Git:
> > http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=
> > shortlog;h=refs/tags/2.2.10-tentative
> > Artifacts:
> > https://repository.apache.org/content/repositories/
> > orgapachecassandra-1147/org/apache/cassandra/apache-cassandra/2.2.10/
> > Staging repository:
> > https://repository.apache.org/content/repositories/
> > orgapachecassandra-1147/
> >
> > The Debian and RPM packages are available here:
> > http://people.apache.org/~mshuler/
> >
> > The vote will be open for 72 hours (longer if needed).
> >
> > [1]: (CHANGES.txt) https://goo.gl/N2ZEkF
> > [2]: (NEWS.txt) https://goo.gl/FAv57Z
> >
> >
>

Re: [VOTE] Release Apache Cassandra 2.2.10

[Jeff Jirsa]

+1

On Wed, Jun 21, 2017 at 1:20 PM, Michael Shuler 
wrote:

> I propose the following artifacts for release as 2.2.10.
>
> sha1: 83f28ce3c4eeff75ce70855a56b6155047ce8e9a
> Git:
> http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=
> shortlog;h=refs/tags/2.2.10-tentative
> Artifacts:
> https://repository.apache.org/content/repositories/
> orgapachecassandra-1147/org/apache/cassandra/apache-cassandra/2.2.10/
> Staging repository:
> https://repository.apache.org/content/repositories/
> orgapachecassandra-1147/
>
> The Debian and RPM packages are available here:
> http://people.apache.org/~mshuler/
>
> The vote will be open for 72 hours (longer if needed).
>
> [1]: (CHANGES.txt) https://goo.gl/N2ZEkF
> [2]: (NEWS.txt) https://goo.gl/FAv57Z
>
>

[VOTE] Release Apache Cassandra 2.2.10

[Michael Shuler]

I propose the following artifacts for release as 2.2.10.

sha1: 83f28ce3c4eeff75ce70855a56b6155047ce8e9a
Git:
http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=shortlog;h=refs/tags/2.2.10-tentative
Artifacts:
https://repository.apache.org/content/repositories/orgapachecassandra-1147/org/apache/cassandra/apache-cassandra/2.2.10/
Staging repository:
https://repository.apache.org/content/repositories/orgapachecassandra-1147/

The Debian and RPM packages are available here:
http://people.apache.org/~mshuler/

The vote will be open for 72 hours (longer if needed).

[1]: (CHANGES.txt) https://goo.gl/N2ZEkF
[2]: (NEWS.txt) https://goo.gl/FAv57Z



signature.asc
Description: OpenPGP digital signature

[VOTE] Release Apache Cassandra 2.1.18

[Michael Shuler]

I propose the following artifacts for release as 2.1.18.

sha1: 9369db1dfd92d4eb76284cfb68b1ffb9d22c9b06
Git:
http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=shortlog;h=refs/tags/2.1.18-tentative
Artifacts:
https://repository.apache.org/content/repositories/orgapachecassandra-1146/org/apache/cassandra/apache-cassandra/2.1.18/
Staging repository:
https://repository.apache.org/content/repositories/orgapachecassandra-1146/

The Debian and RPM packages are available here:
http://people.apache.org/~mshuler/

The vote will be open for 72 hours (longer if needed).

[1]: (CHANGES.txt) https://goo.gl/MG5EUZ
[2]: (NEWS.txt) https://goo.gl/7bi7K1



signature.asc
Description: OpenPGP digital signature

Re: [DISCUSS] Should we do a 2.2 release?

[Michael Shuler]

Yeah, the number of users running 2.1 was part of my concern, and if
we're happy to maintain 4 actively supported branches, along with trunk,
I think that's fine.

A 2.1.18 release with the few fixes committed in cassandra-2.1 will at
least be an opportunity to get RPMs rolled up for users in all branches.

I appreciate the feedback.

-- 
Michael

On 06/21/2017 12:01 AM, Jeff Jirsa wrote:
> Site says: 
> 
>   * Apache Cassandra 2.1 is supported until 4.0 release (date
> TBD) with critical fixes only.
> 
> Since we don't know when 4.0 goes out, we shouldn't be in a hurry to do
> a final 2.1.18 cut. There's not much in that branch (a few 2i fixes,
> some build fixes, a cqlsh fix, and a logging fix), so no reason to cut
> it now, and certainly no reason to cut a "final" release now. Leave it
> open, there's no real cost to having it open, and if a real critical bug
> pops up between now and 4.0, the hundreds/thousands of people running
> 2.1 in prod will appreciate a fix.
> 
> - Jeff
> 
> 
> 
> On Tue, Jun 20, 2017 at 8:20 PM, Michael Shuler  > wrote:
> 
> Sounds good to me - I'll work up a 2.2.10 artifact set tomorrow.
> 
> Looking at our current branches and the EOL TBD dates on the download
> page, I believe the 4.0 references for sunsetting branches was prior to
> considering a 3.11.0 release with ongoing support for the branch.
> 
> Should we also do a 2.1.18 release as a final cut and end commits to the
> cassandra-2.1 branch? I'm sorry I hadn't thought about this sooner.
> 
> Michael
> 
> On 06/20/2017 09:11 PM, Nate McCall wrote:
> > Since we have the others going out and we do have some bugfixes there.
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
> 
> For additional commands, e-mail: dev-h...@cassandra.apache.org
> 
> 
> 


-
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org

Re: [DISCUSS] Should we do a 2.2 release?

[kurt greaves]

+1 what Jeff said.